)]}'
{"id":"openstack%2Fdevstack~75486","triplet_id":"openstack%2Fdevstack~master~I16e37214726c227fa0b7372b2b868c052c2aa23b","project":"openstack/devstack","branch":"master","topic":"master","hashtags":[],"change_id":"I16e37214726c227fa0b7372b2b868c052c2aa23b","subject":"Ensure die is called if git fetch/checkout fails","status":"ABANDONED","created":"2014-02-21 19:20:54.000000000","updated":"2014-02-26 20:49:12.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cb6a6851751435034d639c55a77f15316d96cd26","_number":75486,"virtual_id_number":75486,"owner":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-02-21 20:17:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"disliked":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-02-21 20:51:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"date":"2014-02-21 20:52:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-02-21 22:47:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":1,"date":"2014-02-22 23:25:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":-1,"date":"2014-02-24 02:00:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":-1,"date":"2014-02-23 22:38:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"date":"2014-02-21 20:46:19.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"date":"2014-02-24 02:00:26.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"date":"2014-02-21 23:16:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-21 20:17:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-02-21 20:46:19.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-02-21 20:51:09.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2014-02-21 23:16:44.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2014-02-22 23:25:39.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2014-02-24 02:00:26.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"}],"messages":[{"id":"c574d7a4f65d8a03e108018b753ccd6874735aaa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 19:20:55.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d083c753e42526d6b24d101fb800e9bae92607ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 20:17:03.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/86/75486/1/check/gate-devstack-bash8/08eebdf : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/86/75486/1/check/check-devstack-dsvm-cells/30e738f : SUCCESS in 10m 36s\n- check-tempest-dsvm-full http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-full/13defd8 : SUCCESS in 44m 10s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-postgres-full/52028fa : SUCCESS in 39m 56s\n- check-tempest-dsvm-neutron http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-neutron/eba5a6a : SUCCESS in 36m 34s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-neutron-full/62e4311 : SUCCESS in 43m 49s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/86/75486/1/check/gate-tempest-dsvm-large-ops/eccdb48 : SUCCESS in 11m 26s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/86/75486/1/check/gate-tempest-dsvm-neutron-large-ops/4a5384d : SUCCESS in 13m 40s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-neutron-heat-slow/2764ca5 : FAILURE in 24m 52s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-cells-full/c268233 : FAILURE in 26m 37s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/86/75486/1/check/check-grenade-dsvm/80878a3 : SUCCESS in 33m 07s\n- check-swift-dsvm-functional http://logs.openstack.org/86/75486/1/check/check-swift-dsvm-functional/9c1f954 : SUCCESS in 12m 00s\n- check-devstack-dsvm-neutron http://logs.openstack.org/86/75486/1/check/check-devstack-dsvm-neutron/ec1973c : FAILURE in 14m 04s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-ironic-nv/106b86f : SUCCESS in 23m 28s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-ironic-postgres-nv/66d1433 : SUCCESS in 24m 30s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-savanna-full-nv/c115b11 : SUCCESS in 40m 33s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-savanna-postgres-nv/2ab0e60 : SUCCESS in 16m 55s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/86/75486/1/check/check-tempest-dsvm-savanna-neutron-nv/f5caaa5 : SUCCESS in 27m 40s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"246e436363027917bb7a563ec56e1a2858cccb20","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2014-02-21 20:51:09.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d175d95be75400243f7602187f70b1f31d498e50","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-02-21 20:52:11.000000000","message":"Patch Set 1:\n\nAaron, have a look at https://review.openstack.org/#/c/74910/.  Ian is dong more than just aborting after failed git operation, but I think it covers what you are looking for in this review.","accounts_in_message":[],"_revision_number":1},{"id":"d4d04de0f2498a3b71faf99b0de8b4f9b1432de4","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2014-02-21 22:47:07.000000000","message":"Patch Set 1:\n\nHi Dean,\n\nNot quite, his patch adds logic for the case where git times out and locks for even. In the case i\u0027m fixing git does not timeout but instead returns a failure status. We could combine the two patches if you want though.\n\nAaron","accounts_in_message":[],"_revision_number":1},{"id":"65d861678788a3706cf41a54be50edc45f4aa8a0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-02-21 22:54:09.000000000","message":"Patch Set 1:\n\nYou\u0027re right, not quite...it would try 3 times before die();  if [[ ! $? \u003d 124  ]] it should die immediately.\n\nLet\u0027s add this to Ian\u0027s review.","accounts_in_message":[],"_revision_number":1},{"id":"0715b744954261b8892623dcd48abdb7c8a31345","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-02-22 20:11:39.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2.\n* Logs: http://ca.downloads.xensource.com/OpenStack/xenserver-ci/refs/changes/86/75486/1/\n\nXenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":1},{"id":"3732427c896b7c0d4a3083283093ebb4141a657d","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2014-02-22 23:25:39.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"c7229b18b04c39a21ee0fa839451b1266a48fe70","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2014-02-23 22:06:24.000000000","message":"Patch Set 1:\n\n@Dean, \n\nI think we should merge this as some of the 3rd party neutron CI is falsely passing because of this.","accounts_in_message":[],"_revision_number":1},{"id":"5ba3ab2119ce84e6100f43ab846cf0ac83bc3509","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-23 22:38:11.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI think this is now covered by version #4 of [1]?\n\nThanks\n\n[1] https://review.openstack.org/#/c/74910/","accounts_in_message":[],"_revision_number":1},{"id":"35ac489cf9d5844d1ac68a14d02a9d4ce33e9996","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-02-24 02:00:26.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nso I think the actual fix here is to get us running cleanly under -o errexit instead, then we stop right away. Trying to get that working over here - https://review.openstack.org/#/c/71996/ - debug assistance there would be appreciated.","accounts_in_message":[],"_revision_number":1},{"id":"4e239546bce287b885993aade15a7fd5928ffaa3","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2014-02-26 20:49:12.000000000","message":"Patch Set 1: Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"54cff2a6beee706f0f715651bb75ec9b6e719ac7","revisions":{"54cff2a6beee706f0f715651bb75ec9b6e719ac7":{"kind":"REWORK","_number":1,"created":"2014-02-21 19:20:54.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/86/75486/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/86/75486/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/75486/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/75486/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/86/75486/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/86/75486/1"}}},"commit":{"parents":[{"commit":"5d920e02e30f375253ff9a5f6fef010c95c2fb4b","subject":"Merge \"add heat to the default devstack service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5d920e02e30f375253ff9a5f6fef010c95c2fb4b"}]}],"author":{"name":"Aaron Rosen","email":"aaronorosen@gmail.com","date":"2014-02-21 19:12:44.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2014-02-21 19:15:49.000000000","tz":-480},"subject":"Ensure die is called if git fetch/checkout fails","message":"Ensure die is called if git fetch/checkout fails\n\nThis patch ensures that if git fetch or checkout fails that devstack\nstops running and prevents it from continuing on so it is ensured the\nintended code is running.\n\nCloses-bug: #1283173\nChange-Id: I16e37214726c227fa0b7372b2b868c052c2aa23b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/54cff2a6beee706f0f715651bb75ec9b6e719ac7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/54cff2a6beee706f0f715651bb75ec9b6e719ac7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}