)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"87f0f85b4c0da523bb8af0c503ab582482d0d94e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"91fa9862_13bbc650","updated":"2025-03-15 21:33:35.000000000","message":"@dalvarez@redhat.com hello, I think we can continue working for this changes (problem is there), may be you restore this MR?","commit_id":"5ce6a9032fc5f97ca3c7c887a9763320f78ead38"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"79756b831df36318a8d771f368d19b3ea9cab058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"43137e67_c927d6ad","updated":"2021-11-23 09:56:10.000000000","message":"any updates on this?","commit_id":"5ce6a9032fc5f97ca3c7c887a9763320f78ead38"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"62a17941056bbb30ce6861fbd657b7f401014e08","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            install_package iptables-services"},{"line_number":133,"context_line":"            sudo systemctl enable iptables"},{"line_number":134,"context_line":"            sudo systemctl stop firewalld"},{"line_number":135,"context_line":"            sudo systemctl start iptables"},{"line_number":136,"context_line":"        fi"},{"line_number":137,"context_line":"    fi"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f560f44_e7d37736","side":"PARENT","line":135,"updated":"2020-10-01 15:23:14.000000000","message":"I wonder whether we should remove everything like this or just remove the problematic rule on from /etc/sysconfig/iptables if it exists (with sed or something).\n\nI need to investigate why this code was added in first place.","commit_id":"29efb7282296c183d5036bc64451a9469a053056"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"eff01040eb32e35fe8075a17f47d88d1caace5f3","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            install_package iptables-services"},{"line_number":133,"context_line":"            sudo systemctl enable iptables"},{"line_number":134,"context_line":"            sudo systemctl stop firewalld"},{"line_number":135,"context_line":"            sudo systemctl start iptables"},{"line_number":136,"context_line":"        fi"},{"line_number":137,"context_line":"    fi"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f560f44_e7bc17dd","side":"PARENT","line":135,"in_reply_to":"9f560f44_e7d37736","updated":"2020-10-01 15:24:34.000000000","message":"Also let\u0027s wait and see what the gate says bout it.","commit_id":"29efb7282296c183d5036bc64451a9469a053056"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7a5a2f699d725493479f8b0b1a71ba97a30860df","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        # [2] https://bugs.launchpad.net/neutron/+bug/1455303"},{"line_number":126,"context_line":"        # [3] https://github.com/redhat-openstack/openstack-puppet-modules/blob/master/firewall/manifests/linux/redhat.pp"},{"line_number":127,"context_line":"        # [4] https://docs.openstack.org/devstack/latest/guides/neutron.html"},{"line_number":128,"context_line":"        if is_package_installed firewalld; then"},{"line_number":129,"context_line":"            sudo systemctl disable firewalld"},{"line_number":130,"context_line":"        fi"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9f560f44_f16dde2f","line":128,"updated":"2020-10-02 19:36:23.000000000","message":"As an addendum to my previous comment about switching to firewalld, I\u0027m not the firewalld expert, but it seems like we could enable firewalld and then set up a \u0027devstack\u0027 zone and add an interface to it and then just accept all traffic on that particular devstack interface.\n\n sudo firewall-cmd --permanent --new-zone\u003ddevstack\n sudo firewall-cmd --zone\u003ddevstack --change-interface\u003d${INTERFACE_OF_HOSTIP}\n sudo firewall-cmd --permanent --zone\u003ddevstack --set-target\u003dACCEPT\n\nwith a \n\n sudo firewall-cmd --reload\n\nprobably thrown in there somewhere. Or just move the interface the existing \u0027trusted\u0027 zone.\n\nWe don\u0027t currently do anything with interface names, so maybe that\u0027d be a pain. Could probably just add a rich rule based on \"destination address\u003d$HOST_IP\" as well.\n\nBut functionally on a single nic devstack system that would be equivalent to the current patch which just disables firewalld. Which I\u0027m not really against, it\u0027s devstack and like Daniel said ubuntu doesn\u0027t block anything by default. It would just give people the option of specifying a public/private interface with different rules, and if we ever wanted to having the zone would make it easy to add rules for individual services if we ever went crazy and did that. :p","commit_id":"5ce6a9032fc5f97ca3c7c887a9763320f78ead38"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b5b17ddcfb236fe2676364b0b5ece1974f211f19","unresolved":true,"context_lines":[{"line_number":126,"context_line":"        # [3] https://github.com/redhat-openstack/openstack-puppet-modules/blob/master/firewall/manifests/linux/redhat.pp"},{"line_number":127,"context_line":"        # [4] https://docs.openstack.org/devstack/latest/guides/neutron.html"},{"line_number":128,"context_line":"        if is_package_installed firewalld; then"},{"line_number":129,"context_line":"            sudo systemctl disable firewalld"},{"line_number":130,"context_line":"        fi"},{"line_number":131,"context_line":"    fi"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"9fa8fe32_4cff1c82","line":129,"range":{"start_line":129,"start_character":12,"end_line":129,"end_character":44},"updated":"2021-05-11 14:35:42.000000000","message":"it does not make sense to leave this but not \"stop\"","commit_id":"5ce6a9032fc5f97ca3c7c887a9763320f78ead38"}]}