)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c6cd2dcdf2f43f4ba3d7880ac317b793b4f59cf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Rosmaita \u003crosmaita.fossdev@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-28 08:54:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable optimized cinder backend for glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When Glance is configured with a cinder glance_store, Cinder can be"},{"line_number":10,"context_line":"configured to allow cloning of image data directly in the backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f621f24_2ba0f28f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2020-11-15 13:00:09.000000000","message":"more like: \"Allow to enable\"","commit_id":"7d7501e8c5c6ce445fd58bfd4a3b948414910a34"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4f2c394f3ce7e163f9d478583d5817c5053f57da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Rosmaita \u003crosmaita.fossdev@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-10-28 08:54:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable optimized cinder backend for glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When Glance is configured with a cinder glance_store, Cinder can be"},{"line_number":10,"context_line":"configured to allow cloning of image data directly in the backend"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5258c512_261d501c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"1f621f24_2ba0f28f","updated":"2020-12-02 19:58:20.000000000","message":"Good point!","commit_id":"7d7501e8c5c6ce445fd58bfd4a3b948414910a34"}],"lib/cinder":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ad726a56c1a620b9bfb9fc543cc78ec464a2ab9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# transferring data from volume to volume.  Value is a comma separated list of"},{"line_number":93,"context_line":"# schemes (currently only \u0027file\u0027 and \u0027cinder\u0027 are supported).  The default"},{"line_number":94,"context_line":"# configuration in Cinder is empty (that is, do not use this feature).  NOTE:"},{"line_number":95,"context_line":"# to use this feature you must also enable GLANCE_SHOW_DIRECT_URL and/or"},{"line_number":96,"context_line":"# GLANCE_SHOW_MULTIPLE_LOCATIONS for glance-api.conf."},{"line_number":97,"context_line":"CINDER_ALLOWED_DIRECT_URL_SCHEMES\u003d${CINDER_ALLOWED_DIRECT_URL_SCHEMES:-}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_3e48fbca","line":96,"range":{"start_line":95,"start_character":2,"end_line":96,"end_character":53},"updated":"2020-10-14 14:27:12.000000000","message":"FWIW, I prefer when we fail if someone tries to turn on one half of a feature. It\u0027s pretty frustrating to turn on the thing you think you want, run an hour of devstack, then poke at it for a while wondering why it doesn\u0027t work, only to find a comment like this buried in the code once you go looking for a bug. It\u0027d be better, IMHO, to fail early during configure_cinder() if one or both of the required glance features isn\u0027t enabled.","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"853c299bcc979e6366d9b43fc53a65f906bb3e29","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# transferring data from volume to volume.  Value is a comma separated list of"},{"line_number":93,"context_line":"# schemes (currently only \u0027file\u0027 and \u0027cinder\u0027 are supported).  The default"},{"line_number":94,"context_line":"# configuration in Cinder is empty (that is, do not use this feature).  NOTE:"},{"line_number":95,"context_line":"# to use this feature you must also enable GLANCE_SHOW_DIRECT_URL and/or"},{"line_number":96,"context_line":"# GLANCE_SHOW_MULTIPLE_LOCATIONS for glance-api.conf."},{"line_number":97,"context_line":"CINDER_ALLOWED_DIRECT_URL_SCHEMES\u003d${CINDER_ALLOWED_DIRECT_URL_SCHEMES:-}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_97647fbb","line":96,"range":{"start_line":95,"start_character":2,"end_line":96,"end_character":53},"in_reply_to":"7f6b1bfe_3e48fbca","updated":"2020-10-15 13:39:10.000000000","message":"Good point, I can make that change.","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b66472f430339dac1f45d1787b2aaa9c3bab21f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"# GLANCE_SHOW_MULTIPLE_LOCATIONS for glance-api.conf."},{"line_number":97,"context_line":"CINDER_ALLOWED_DIRECT_URL_SCHEMES\u003d${CINDER_ALLOWED_DIRECT_URL_SCHEMES:-}"},{"line_number":98,"context_line":"if [[ -n \"$CINDER_ALLOWED_DIRECT_URL_SCHEMES\" ]]; then"},{"line_number":99,"context_line":"    if [[ \"${GLANCE_SHOW_DIRECT_URL:-False}\" !\u003d \"True\""},{"line_number":100,"context_line":"          \u0026\u0026 \"${GLANCE_SHOW_MULTIPLE_LOCATIONS:-False}\" !\u003d \"True\" ]]; then"},{"line_number":101,"context_line":"        warn $LINENO \"CINDER_ALLOWED_DIRECT_URL_SCHEMES is set, but neither \\"},{"line_number":102,"context_line":"GLANCE_SHOW_DIRECT_URL nor GLANCE_SHOW_MULTIPLE_LOCATIONS is True\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f65232a_f5a2dd99","line":99,"updated":"2020-10-28 03:52:27.000000000","message":"bashate: E011 Then keyword is not on same line as if or elif keyword","commit_id":"d4e5661c6c0dcf33937229f3026c072bdf19b926"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0b66472f430339dac1f45d1787b2aaa9c3bab21f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"CINDER_ALLOWED_DIRECT_URL_SCHEMES\u003d${CINDER_ALLOWED_DIRECT_URL_SCHEMES:-}"},{"line_number":98,"context_line":"if [[ -n \"$CINDER_ALLOWED_DIRECT_URL_SCHEMES\" ]]; then"},{"line_number":99,"context_line":"    if [[ \"${GLANCE_SHOW_DIRECT_URL:-False}\" !\u003d \"True\""},{"line_number":100,"context_line":"          \u0026\u0026 \"${GLANCE_SHOW_MULTIPLE_LOCATIONS:-False}\" !\u003d \"True\" ]]; then"},{"line_number":101,"context_line":"        warn $LINENO \"CINDER_ALLOWED_DIRECT_URL_SCHEMES is set, but neither \\"},{"line_number":102,"context_line":"GLANCE_SHOW_DIRECT_URL nor GLANCE_SHOW_MULTIPLE_LOCATIONS is True\""},{"line_number":103,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3f65232a_d59d2158","line":100,"updated":"2020-10-28 03:52:27.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"d4e5661c6c0dcf33937229f3026c072bdf19b926"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5cdc6204ee98ead9045b1aae2e41941039953b2a","unresolved":true,"context_lines":[{"line_number":115,"context_line":"if [[ -n \"$CINDER_ALLOWED_DIRECT_URL_SCHEMES\" ]]; then"},{"line_number":116,"context_line":"    if [[ \"${GLANCE_SHOW_DIRECT_URL:-False}\" !\u003d \"True\" \\"},{"line_number":117,"context_line":"            \u0026\u0026 \"${GLANCE_SHOW_MULTIPLE_LOCATIONS:-False}\" !\u003d \"True\" ]]; then"},{"line_number":118,"context_line":"        warn $LINENO \"CINDER_ALLOWED_DIRECT_URL_SCHEMES is set, but neither \\"},{"line_number":119,"context_line":"GLANCE_SHOW_DIRECT_URL nor GLANCE_SHOW_MULTIPLE_LOCATIONS is True\""},{"line_number":120,"context_line":"    fi"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# For backward compatibility"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"04042871_9c568724","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":0},"updated":"2021-05-18 14:41:46.000000000","message":"is it never useful without glance?","commit_id":"6e9f7c25704afb5bcc33c6f17a01f62068664e40"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c3d620943cf573710c1c3142c9b602003806430b","unresolved":true,"context_lines":[{"line_number":115,"context_line":"if [[ -n \"$CINDER_ALLOWED_DIRECT_URL_SCHEMES\" ]]; then"},{"line_number":116,"context_line":"    if [[ \"${GLANCE_SHOW_DIRECT_URL:-False}\" !\u003d \"True\" \\"},{"line_number":117,"context_line":"            \u0026\u0026 \"${GLANCE_SHOW_MULTIPLE_LOCATIONS:-False}\" !\u003d \"True\" ]]; then"},{"line_number":118,"context_line":"        warn $LINENO \"CINDER_ALLOWED_DIRECT_URL_SCHEMES is set, but neither \\"},{"line_number":119,"context_line":"GLANCE_SHOW_DIRECT_URL nor GLANCE_SHOW_MULTIPLE_LOCATIONS is True\""},{"line_number":120,"context_line":"    fi"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# For backward compatibility"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9c668eea_81bd3825","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":0},"in_reply_to":"04042871_9c568724","updated":"2021-08-11 16:27:44.000000000","message":"That\u0027s right, you can only use this with Glance, and even worse, it requires that Glance must be configured a certain way, or you can\u0027t use it.  (It doesn\u0027t cause an error, the optimization that we want to test just doesn\u0027t happen.)","commit_id":"6e9f7c25704afb5bcc33c6f17a01f62068664e40"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"02445d2cf7dce21cc809c77601c28d4e90c17d7a","unresolved":true,"context_lines":[{"line_number":115,"context_line":"if [[ -n \"$CINDER_ALLOWED_DIRECT_URL_SCHEMES\" ]]; then"},{"line_number":116,"context_line":"    if [[ \"${GLANCE_SHOW_DIRECT_URL:-False}\" !\u003d \"True\" \\"},{"line_number":117,"context_line":"            \u0026\u0026 \"${GLANCE_SHOW_MULTIPLE_LOCATIONS:-False}\" !\u003d \"True\" ]]; then"},{"line_number":118,"context_line":"        warn $LINENO \"CINDER_ALLOWED_DIRECT_URL_SCHEMES is set, but neither \\"},{"line_number":119,"context_line":"GLANCE_SHOW_DIRECT_URL nor GLANCE_SHOW_MULTIPLE_LOCATIONS is True\""},{"line_number":120,"context_line":"    fi"},{"line_number":121,"context_line":"fi"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# For backward compatibility"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"2ea110be_04135da7","line":120,"range":{"start_line":118,"start_character":0,"end_line":120,"end_character":0},"in_reply_to":"9c668eea_81bd3825","updated":"2021-08-12 13:08:19.000000000","message":"The answer makes my QA side sad but able to approve this patch.","commit_id":"6e9f7c25704afb5bcc33c6f17a01f62068664e40"}],"lib/glance":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ad726a56c1a620b9bfb9fc543cc78ec464a2ab9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# GLANCE_SHOW_DIRECT_URL and/or GLANCE_SHOW_MULTIPLE_LOCATIONS for Glance.  The"},{"line_number":59,"context_line":"# default value for both of these is False, because for some backends they"},{"line_number":60,"context_line":"# present a grave security risk (though not for Cinder, because all that\u0027s"},{"line_number":61,"context_line":"# exposed is the volume_id where the image data is stored.)  See OSSN-0065 for"},{"line_number":62,"context_line":"# more information."},{"line_number":63,"context_line":"GLANCE_SHOW_DIRECT_URL\u003d$(trueorfalse False GLANCE_SHOW_DIRECT_URL)"},{"line_number":64,"context_line":"GLANCE_SHOW_MULTIPLE_LOCATIONS\u003d$(trueorfalse False GLANCE_SHOW_MULTIPLE_LOCATIONS)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_3eac7b8b","line":61,"range":{"start_line":61,"start_character":65,"end_line":61,"end_character":74},"updated":"2020-10-14 14:27:12.000000000","message":"How about a link?\n\n https://wiki.openstack.org/wiki/OSSN/OSSN-0065","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"853c299bcc979e6366d9b43fc53a65f906bb3e29","unresolved":false,"context_lines":[{"line_number":58,"context_line":"# GLANCE_SHOW_DIRECT_URL and/or GLANCE_SHOW_MULTIPLE_LOCATIONS for Glance.  The"},{"line_number":59,"context_line":"# default value for both of these is False, because for some backends they"},{"line_number":60,"context_line":"# present a grave security risk (though not for Cinder, because all that\u0027s"},{"line_number":61,"context_line":"# exposed is the volume_id where the image data is stored.)  See OSSN-0065 for"},{"line_number":62,"context_line":"# more information."},{"line_number":63,"context_line":"GLANCE_SHOW_DIRECT_URL\u003d$(trueorfalse False GLANCE_SHOW_DIRECT_URL)"},{"line_number":64,"context_line":"GLANCE_SHOW_MULTIPLE_LOCATIONS\u003d$(trueorfalse False GLANCE_SHOW_MULTIPLE_LOCATIONS)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_17706f72","line":61,"range":{"start_line":61,"start_character":65,"end_line":61,"end_character":74},"in_reply_to":"7f6b1bfe_3eac7b8b","updated":"2020-10-15 13:39:10.000000000","message":"I\u0027ll add it.","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ad726a56c1a620b9bfb9fc543cc78ec464a2ab9","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    if [ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ] \u0026\u0026 [ \"$LIBVIRT_TYPE\" \u003d \u0027parallels\u0027 ]; then"},{"line_number":299,"context_line":"        iniset $GLANCE_API_CONF DEFAULT disk_formats \"ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso,ploop\""},{"line_number":300,"context_line":"    fi"},{"line_number":301,"context_line":"    # Only use these if you know what you are doing!  See OSSN-0065"},{"line_number":302,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_image_direct_url $GLANCE_SHOW_DIRECT_URL"},{"line_number":303,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_multiple_locations $GLANCE_SHOW_MULTIPLE_LOCATIONS"},{"line_number":304,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_3ec59b3d","line":301,"updated":"2020-10-14 14:27:12.000000000","message":"This is minor, but I think it\u0027s pointless. You\u0027re documenting the risk above, which is where the knob is. There\u0027s really nothing to do or not do on this specific line of code, so might as well remove it and rely on the above warning.","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"853c299bcc979e6366d9b43fc53a65f906bb3e29","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    if [ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ] \u0026\u0026 [ \"$LIBVIRT_TYPE\" \u003d \u0027parallels\u0027 ]; then"},{"line_number":299,"context_line":"        iniset $GLANCE_API_CONF DEFAULT disk_formats \"ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso,ploop\""},{"line_number":300,"context_line":"    fi"},{"line_number":301,"context_line":"    # Only use these if you know what you are doing!  See OSSN-0065"},{"line_number":302,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_image_direct_url $GLANCE_SHOW_DIRECT_URL"},{"line_number":303,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_multiple_locations $GLANCE_SHOW_MULTIPLE_LOCATIONS"},{"line_number":304,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7f6b1bfe_37e64b18","line":301,"in_reply_to":"7f6b1bfe_3ec59b3d","updated":"2020-10-15 13:39:10.000000000","message":"I will leave this, because I don\u0027t want these settings mentioned anywhere without the security warning also being present.","commit_id":"4513e6ec5b3c002ed4edcd1b99d7809c8051e885"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ecb6728f7d8f9e6b56446109dc9e7b20ddccdd2f","unresolved":true,"context_lines":[{"line_number":296,"context_line":"        iniset $GLANCE_API_CONF DEFAULT disk_formats \"ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso,ploop\""},{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":"    # Only use these if you know what you are doing!  See OSSN-0065"},{"line_number":299,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_image_direct_url $GLANCE_SHOW_DIRECT_URL"},{"line_number":300,"context_line":"    iniset $GLANCE_API_CONF DEFAULT show_multiple_locations $GLANCE_SHOW_MULTIPLE_LOCATIONS"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    # Configure glance_store"},{"line_number":303,"context_line":"    configure_glance_store $USE_CINDER_FOR_GLANCE $GLANCE_ENABLE_MULTIPLE_STORES"},{"line_number":304,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0bb49b34_260b8785","line":301,"range":{"start_line":299,"start_character":0,"end_line":301,"end_character":0},"updated":"2021-06-03 22:58:19.000000000","message":"these both config in glance are false so this is not chaining anything until set explicitly.","commit_id":"6e9f7c25704afb5bcc33c6f17a01f62068664e40"}]}