)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05205dd518f3bd74a676c1d40b257fc2ba007dce","unresolved":true,"context_lines":[{"line_number":17,"context_line":"Currently there is no available package for uwsgi-plugin-python3 and ovn, so that"},{"line_number":18,"context_line":"openEuler needs manually install them from source."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Website: https://openeuler.org/en/"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I169a0017998054604a63ac6c177d0f43f8a32ba6"},{"line_number":23,"context_line":"Co-Authored-By: wangxiyuan \u003cwangxiyuan1007@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"abd87830_85d283f3","line":20,"updated":"2021-12-21 10:43:04.000000000","message":"This redirects to the chinese site for me. https://www.openeuler.org/en/ seems to work better instead.","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"776e1042ccd9eb4b3898070912ca0e0b12ef376a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Currently there is no available package for uwsgi-plugin-python3 and ovn, so that"},{"line_number":18,"context_line":"openEuler needs manually install them from source."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Website: https://openeuler.org/en/"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I169a0017998054604a63ac6c177d0f43f8a32ba6"},{"line_number":23,"context_line":"Co-Authored-By: wangxiyuan \u003cwangxiyuan1007@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":36,"id":"f46a56c4_2b0ef957","line":20,"in_reply_to":"abd87830_85d283f3","updated":"2021-12-21 13:46:42.000000000","message":"Ack","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"2f8fffa31245e77bdf2a38abcb824334764ca8fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"4c64c000_a9be91ee","updated":"2021-10-18 03:06:00.000000000","message":"\u003e Patch Set 8: Code-Review-1\n\u003e \n\u003e It seems there is a lot of duplication of existing code in these files. In general, it would look better if it simply made ``is_fedora`` return true for openEuler as well and then only fixed paths that would need fixing (if any). Also, let\u0027s not restore cap-pip again.\n\nMake openEuler ``is_fedora`` +1, as package naming refers Fedora a lot.","commit_id":"b7a19bd683179f0158b58e30fda1f3f01318c837"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"1133e31aaac5007fdc57f42b35acf62acdd29eae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4e6a4ad4_5609053a","updated":"2021-10-26 03:34:32.000000000","message":"Some comments.","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"664b210f55bcc259a833898f3972ac9619c5290d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"48454749_67ebf4d0","updated":"2021-11-17 14:20:06.000000000","message":"I still think it would be good to accompany this patch with a platform job that actually exercises the code. Seems like getting https://review.opendev.org/c/openstack/diskimage-builder/+/784550/2 into shape would be the next step.\n\nAlternatively, can you describe in more detail how you did your manual testing? Is there a cloudimage that one could download and run?","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c884c7c79f2ee80e2000ba5ea16698645efb4201","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f95f742e_7634b6f7","updated":"2021-10-27 02:06:06.000000000","message":"Tested with PS19 on a local openEuler 20.03 LTS SP2 ARM64 VM. success installed devstack with the local.conf:\n\n```\n[[local|localrc]]\nDATABASE_PASSWORD\u003droot\nRABBIT_PASSWORD\u003droot\nSERVICE_PASSWORD\u003droot\nADMIN_PASSWORD\u003droot\nOVN_BUILD_FROM_SOURCE\u003dTrue\n\n[[post-config|$NOVA_CONF]]\n[libvirt]\ncpu_mode\u003dcustom\ncpu_model\u003dcortex-a72\n```","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"e8977859a165de523711124edcdf9e096f717f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"86541650_66021a3b","updated":"2021-10-27 08:16:47.000000000","message":"Thanks wangxiyuan:-)","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4b7a8f2a5a1da684d3ae193199fc32b2092f8651","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"267ebfcc_7880ba4a","updated":"2021-11-16 10:44:23.000000000","message":"any devstack core reviewer could take a look at this patch? Big thanks!","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"3fada197c149e3c6512e4bc6d0a0a3b78cb4e704","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"fd68dd62_ce080dfc","in_reply_to":"48454749_67ebf4d0","updated":"2021-11-18 02:46:24.000000000","message":"CI usually runs jobs on VMs created via minimal image. The openEuler-minimal image support is already landed[1]. To add a platform job, maybe next step is to add openEuler nodeset first.\n\n[1]: https://review.opendev.org/c/openstack/diskimage-builder/+/784363","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"0a8f71933a0f068b3b1a4a4659dfe87d9a984a29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"60f312b1_86b1b5f6","in_reply_to":"e30efe50_a6ff77fd","updated":"2021-11-24 01:00:32.000000000","message":"https://review.opendev.org/c/openstack/project-config/+/818723  This Patch adds openEuler node in OpenStack CI system. Once it\u0027s merged, the new nodeset and CI job can be added in devstack.","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b30f7c083af210f1484be1d015ce7170815500e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e30efe50_a6ff77fd","in_reply_to":"fd68dd62_ce080dfc","updated":"2021-11-18 02:58:15.000000000","message":"Yeah, my origin plan is to add the openEuler nodeset and CI job after this Patch is merged.\n\nCloud image is here:\nhttps://repo.openeuler.org/openEuler-20.03-LTS-SP2/virtual_machine_img/aarch64/openEuler-20.03-LTS-SP2-aarch64.qcow2.xz\n\nmirror list is here:\nhttps://www.openeuler.org/en/mirror/list/\n\nIf you want to test this Patch locally, you should add the below yum repo as well(This repo has been added to)\n\n```\n[openstack]\nname\u003dopenstack\nbaseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/aarch64/\nenabled\u003d1\ngpgcheck\u003d0\n```","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7b2e2c976958e6d2bd2081c1e5441639f8bd60af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"e963e4f9_657ec85b","updated":"2021-12-09 01:35:56.000000000","message":"Fixed merge conflict and drop python2 support for uwsgi","commit_id":"11fff599f7a27eee460eabaf2c6171ce660ca6ec"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"0a5a22d4ea25cc2cc1f7fb8fea0ee7e93e13f91b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"a086e5a1_ac4a5109","updated":"2021-12-14 11:14:38.000000000","message":"recheck","commit_id":"edc9a5a6b68e6e0ffcabd8256c27cd904a0c980f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8f6a1d333c7fab4bdd54ad31dfd23f7e88d16459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f0886e47_aa44a220","updated":"2021-12-15 00:48:11.000000000","message":"recheck","commit_id":"edc9a5a6b68e6e0ffcabd8256c27cd904a0c980f"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4f02e29a84c8c7b0933e8df80ca47d8502088b91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"9d5f049a_d4684f03","updated":"2021-12-17 06:02:10.000000000","message":"recheck","commit_id":"cac20b04808b68f7c9c79c8e73951b60fd491089"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5cd903087d9badf3d6df0a1f13f41aae14fb666b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"858a13cb_85153551","updated":"2021-12-17 07:33:14.000000000","message":"Let\u0027s only test the new job for now until we can get it passing.","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ee2e0b0a5238d83644110ba05896a5546f852bfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"f9b399b0_f9849711","updated":"2021-12-17 11:03:21.000000000","message":"recheck new images should be ready","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"5fc1c7bd7fe9d2acaf9fbf8a240321082a6e4fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"901d0a60_8ebe1501","in_reply_to":"858a13cb_85153551","updated":"2021-12-17 08:02:04.000000000","message":"OK, I\u0027ll comment out other jobs in next PS for testing.","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"eae110256ff1e19e9e4f3e71e0d6742fd2204f99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"48cdbccb_ae4da7c0","in_reply_to":"901d0a60_8ebe1501","updated":"2021-12-17 08:05:18.000000000","message":"Just added the missing element\nhttps://review.opendev.org/c/openstack/project-config/+/822T073\n\nIt\u0027ll spend hours to generate the new image and node. Let\u0027s wait more.","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"df98fb2b0fa990f11b46f63673bccae7364ed56f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e88bb617_dd46c305","updated":"2021-12-18 10:06:21.000000000","message":"I was distracted by the wrong error message, this seems to be the relevant one:\n\nnova-novncproxy[133662]: Can not find html/js files at /usr/share/novnc.","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9aef91a7a1dbac3a813931564910e72fdc01e5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"94488ed6_78b96b46","updated":"2021-12-18 10:25:43.000000000","message":"I wonder why this isn\u0027t a fatal error immediately, would make the issue quite more obvious:\n\n2021-12-17 17:18:21.872630 | controller | + functions-common:sudo_with_proxies:2370  :   sudo http_proxy\u003d https_proxy\u003d no_proxy\u003d dnf install -y novnc\n2021-12-17 17:18:22.451737 | controller | Last metadata expiration check: 0:10:29 ago on Fri 17 Dec 2021 05:07:53 PM UTC.\n2021-12-17 17:18:23.238489 | controller | Error:\n2021-12-17 17:18:23.238539 | controller |  Problem: conflicting requests\n2021-12-17 17:18:23.238554 | controller |   - nothing provides python3-websockify needed by novnc-1.2.0-1.oe1.noarch\n2021-12-17 17:18:23.238567 | controller | (try to add \u0027--skip-broken\u0027 to skip uninstallable packages or \u0027--nobest\u0027 to use not only best candidate packages)","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"aa80381b721e5541a63bf5a7e6801b0a9ddde440","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"2ecabf68_3d7a161b","updated":"2021-12-17 16:46:31.000000000","message":"recheck holding a node since there are too little logs collected","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"1e7a378fcf8c7da8e34608817da1da1d411e1540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"57ec8b1d_cf119ae0","in_reply_to":"2112905c_82b7a331","updated":"2021-12-20 00:50:59.000000000","message":"After some  investigation, I think this is a bug in openEuler.\n\nThe spec file is here:\nhttps://gitee.com/src-openeuler/python-websockify/blob/openEuler-20.03-LTS-SP2/python-websockify.spec\n\nI\u0027m sure this package exist before. Not sure why it\u0027s disappeared in openEuler official yum repo now. I\u0027ll ask openEuler community for this problem.\n\nAnd I assume the `devstack-platform` job disabled novnc by default. So the CI didn\u0027t hit this error?","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"6a1c56983aba819f9d98e1fe8b55ec83b50cebfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"e470d1fd_850444a1","in_reply_to":"57ec8b1d_cf119ae0","updated":"2021-12-20 01:24:04.000000000","message":"Sorry, I just noticed your new Patch Set in last two days. I understand the problem now.\n\nAnd I asked openEuler community, the python3-websockify package will be added in this week. I\u0027ll let you know once it\u0027s fixed.","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"2b6ef2bd1c66e6be2b03a7e3e27c2093283d3542","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"2112905c_82b7a331","in_reply_to":"94488ed6_78b96b46","updated":"2021-12-20 00:40:21.000000000","message":"Where is this error log file? I\u0027d like to take a look deeply. I didn\u0027t hit this error when test locally.","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"55b1b970dca636b3fe835e1b92834656ceeddaae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"4a17bf65_03973bad","in_reply_to":"e470d1fd_850444a1","updated":"2021-12-20 07:51:44.000000000","message":"python3-websockify is back now. Please see the newest CI result(with novnc enabled).\n\nI\u0027d like to add other jobs back if this Patch looks good.","commit_id":"29af200bf75cb83767534b7d8148182ae6d67525"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"31d330b68418ba448e475cab98c92a05f2fd401e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"29f4dac3_8eaace7b","updated":"2021-12-20 06:08:05.000000000","message":"recheck","commit_id":"ddf0c7039f9828bbd7fc76e235593258d5c63f3c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05205dd518f3bd74a676c1d40b257fc2ba007dce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"b00c147a_9f7dc942","updated":"2021-12-21 10:43:04.000000000","message":"Great to see this finally working, just some minor questions remaining.","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"0af3271e1666729155f016bae8a55fd0d84c823d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"76e0a6b1_71592206","updated":"2021-12-22 09:34:10.000000000","message":"Many thanks wangxiyuan to make openEuler test on upstream happen :-)","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2f4f6a7f7519f772d9662c5dd83f105001b1202d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"e869e37f_497a15e3","updated":"2021-12-30 10:38:39.000000000","message":"please fix in a followup","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4b966aa3c03508603a6fcb03b8e4766a550c20a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"4294adbc_a39b7689","in_reply_to":"e869e37f_497a15e3","updated":"2021-12-31 01:04:24.000000000","message":"Thanks for the review, I\u0027ll fix the nit later","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"}],"files/rpms/general":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"76fda8dd8e27721a11cc93da39c042bb0b134657","unresolved":true,"context_lines":[{"line_number":7,"context_line":"gettext  # used for compiling message catalogs"},{"line_number":8,"context_line":"git-core"},{"line_number":9,"context_line":"graphviz # needed only for docs"},{"line_number":10,"context_line":"hostname # dist: openEuler-20.03-LTS-SP2"},{"line_number":11,"context_line":"httpd"},{"line_number":12,"context_line":"httpd-devel"},{"line_number":13,"context_line":"iptables-services"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"83586b9d_23af40ca","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":32},"updated":"2021-10-26 07:10:58.000000000","message":"If rhel family and federa distros contain this package we can not limit to openEuler. These packages are so basic one we can install for rhel family and federa distos as well, I think.\n\nSame for other added packages, please check as well.\n\nWhat if disto is openEuler-20.03-LTS-SP3, SP4, etc? adding too much openEuler distros version here  looks not good here.","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"gettext  # used for compiling message catalogs"},{"line_number":8,"context_line":"git-core"},{"line_number":9,"context_line":"graphviz # needed only for docs"},{"line_number":10,"context_line":"hostname # dist: openEuler-20.03-LTS-SP2"},{"line_number":11,"context_line":"httpd"},{"line_number":12,"context_line":"httpd-devel"},{"line_number":13,"context_line":"iptables-services"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"bbf6f715_3a4f7ac2","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":32},"in_reply_to":"1b818d72_f0f41b45","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"bda3a378a3f91298f1ca31e52ef4d66957adef50","unresolved":true,"context_lines":[{"line_number":7,"context_line":"gettext  # used for compiling message catalogs"},{"line_number":8,"context_line":"git-core"},{"line_number":9,"context_line":"graphviz # needed only for docs"},{"line_number":10,"context_line":"hostname # dist: openEuler-20.03-LTS-SP2"},{"line_number":11,"context_line":"httpd"},{"line_number":12,"context_line":"httpd-devel"},{"line_number":13,"context_line":"iptables-services"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"da087cbc_d910efb2","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":32},"in_reply_to":"83586b9d_23af40ca","updated":"2021-10-26 07:38:16.000000000","message":"I\u0027m not sure if fedora need hostname, make or systemd-devel. So I add openEuler here. The `# dist` can be removed if these packages are common.","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"554896d4d71c7f76e66e2f45572a3e1063d860c0","unresolved":true,"context_lines":[{"line_number":7,"context_line":"gettext  # used for compiling message catalogs"},{"line_number":8,"context_line":"git-core"},{"line_number":9,"context_line":"graphviz # needed only for docs"},{"line_number":10,"context_line":"hostname # dist: openEuler-20.03-LTS-SP2"},{"line_number":11,"context_line":"httpd"},{"line_number":12,"context_line":"httpd-devel"},{"line_number":13,"context_line":"iptables-services"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"1b818d72_f0f41b45","line":10,"range":{"start_line":10,"start_character":27,"end_line":10,"end_character":32},"in_reply_to":"da087cbc_d910efb2","updated":"2021-10-26 07:48:56.000000000","message":"And I assume that openEuler will be like ubuntu, debian or centos. i.e. there will not be much supportted version. Once newer version of openEuler is added, the old one may be removed perhaps.","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"}],"functions-common":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        sudo dnf install -y redhat-lsb-core"},{"line_number":337,"context_line":"        if [ $? -eq 1 ]; then"},{"line_number":338,"context_line":"            sudo dnf install -y openeuler-lsb"},{"line_number":339,"context_line":"\tfi"},{"line_number":340,"context_line":"    else"},{"line_number":341,"context_line":"        die $LINENO \"Unable to find or auto-install lsb_release\""},{"line_number":342,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_415cd37d","line":339,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E002 Tab indents","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        sudo dnf install -y redhat-lsb-core"},{"line_number":337,"context_line":"        if [ $? -eq 1 ]; then"},{"line_number":338,"context_line":"            sudo dnf install -y openeuler-lsb"},{"line_number":339,"context_line":"\tfi"},{"line_number":340,"context_line":"    else"},{"line_number":341,"context_line":"        die $LINENO \"Unable to find or auto-install lsb_release\""},{"line_number":342,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_2161d737","line":339,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":504,"context_line":"}"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"function is_openeuler {"},{"line_number":507,"context_line":"     if [[ -z \"$os_PACKAGE\" ]]; then"},{"line_number":508,"context_line":"        GetOSVersion"},{"line_number":509,"context_line":"    fi"},{"line_number":510,"context_line":"    [ \"$os_PACKAGE\" \u003d \"rpm\" ]"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_81554b53","line":507,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9b3aa60f467ce3e32788fad78fac3b78321ca198","unresolved":true,"context_lines":[{"line_number":458,"context_line":"        [ \"$os_VENDOR\" \u003d \"RedHatEnterpriseServer\" ] || \\"},{"line_number":459,"context_line":"        [ \"$os_VENDOR\" \u003d \"RedHatEnterprise\" ] || \\"},{"line_number":460,"context_line":"        [ \"$os_VENDOR\" \u003d \"CentOS\" ] || [ \"$os_VENDOR\" \u003d \"OracleServer\" ] || \\"},{"line_number":461,"context_line":"        [ \"$os_VENDOR\" \u003d \"Virtuozzo\" ]"},{"line_number":462,"context_line":"}"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d55d47ce_99f1e4cd","line":461,"updated":"2021-04-10 11:00:28.000000000","message":"Seeing in how many locations you have to write \"is_fedora || is_openeuler\",\nI\u0027m thinking that it would be easier to add it here (which won\u0027t be wrong, as it in fact is yet another rpm-based distro) and just special case the instances where a different behaviour is needed..","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        [ \"$os_VENDOR\" \u003d \"RedHatEnterpriseServer\" ] || \\"},{"line_number":459,"context_line":"        [ \"$os_VENDOR\" \u003d \"RedHatEnterprise\" ] || \\"},{"line_number":460,"context_line":"        [ \"$os_VENDOR\" \u003d \"CentOS\" ] || [ \"$os_VENDOR\" \u003d \"OracleServer\" ] || \\"},{"line_number":461,"context_line":"        [ \"$os_VENDOR\" \u003d \"Virtuozzo\" ]"},{"line_number":462,"context_line":"}"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8bcbd1c4_5171f5c7","line":461,"in_reply_to":"d55d47ce_99f1e4cd","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9b3aa60f467ce3e32788fad78fac3b78321ca198","unresolved":true,"context_lines":[{"line_number":507,"context_line":"    if [[ -z \"$os_PACKAGE\" ]]; then"},{"line_number":508,"context_line":"        GetOSVersion"},{"line_number":509,"context_line":"    fi"},{"line_number":510,"context_line":"    [ \"$os_PACKAGE\" \u003d \"rpm\" ]"},{"line_number":511,"context_line":"}"},{"line_number":512,"context_line":"# Git Functions"},{"line_number":513,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8e6442e5_249bce8c","line":510,"updated":"2021-04-10 11:00:28.000000000","message":"This definitively is too generic.","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":507,"context_line":"    if [[ -z \"$os_PACKAGE\" ]]; then"},{"line_number":508,"context_line":"        GetOSVersion"},{"line_number":509,"context_line":"    fi"},{"line_number":510,"context_line":"    [ \"$os_PACKAGE\" \u003d \"rpm\" ]"},{"line_number":511,"context_line":"}"},{"line_number":512,"context_line":"# Git Functions"},{"line_number":513,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"778166bf_c6f410a1","line":510,"in_reply_to":"8e6442e5_249bce8c","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"1133e31aaac5007fdc57f42b35acf62acdd29eae","unresolved":true,"context_lines":[{"line_number":337,"context_line":"        sudo dnf install -y redhat-lsb-core 2\u003e/dev/null || is_os_redhat\u003d0"},{"line_number":338,"context_line":"        if [ $? -eq 0 ]; then"},{"line_number":339,"context_line":"            sudo dnf install -y openeuler-lsb"},{"line_number":340,"context_line":"    fi"},{"line_number":341,"context_line":"    else"},{"line_number":342,"context_line":"        die $LINENO \"Unable to find or auto-install lsb_release\""},{"line_number":343,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"8a53a043_8089f0cd","line":340,"range":{"start_line":340,"start_character":4,"end_line":340,"end_character":6},"updated":"2021-10-26 03:34:32.000000000","message":"Why put errors into /dev/null here?\nHow about:\nsudo dnf install -y redhat-lsb-core ||\nsudo dnf install -y openeuler-lsb","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":337,"context_line":"        sudo dnf install -y redhat-lsb-core 2\u003e/dev/null || is_os_redhat\u003d0"},{"line_number":338,"context_line":"        if [ $? -eq 0 ]; then"},{"line_number":339,"context_line":"            sudo dnf install -y openeuler-lsb"},{"line_number":340,"context_line":"    fi"},{"line_number":341,"context_line":"    else"},{"line_number":342,"context_line":"        die $LINENO \"Unable to find or auto-install lsb_release\""},{"line_number":343,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ea01a1ea_8074e665","line":340,"range":{"start_line":340,"start_character":4,"end_line":340,"end_character":6},"in_reply_to":"8a53a043_8089f0cd","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"1133e31aaac5007fdc57f42b35acf62acdd29eae","unresolved":true,"context_lines":[{"line_number":402,"context_line":"        # XXX re-evaluate when we get RHEL10"},{"line_number":403,"context_line":"        DISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":404,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openEuler) ]]; then"},{"line_number":405,"context_line":"        DISTRO\u003d\"openEuler-$os_RELEASE\""},{"line_number":406,"context_line":"    else"},{"line_number":407,"context_line":"        # We can\u0027t make a good choice here.  Setting a sensible DISTRO"},{"line_number":408,"context_line":"        # is part of the problem, but not the major issue -- we really"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"a9300aee_2d08b78c","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":8},"updated":"2021-10-26 03:34:32.000000000","message":"Use lower case to be consistent with other distros?\nopeneuler-$os_RELEASE","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        # XXX re-evaluate when we get RHEL10"},{"line_number":403,"context_line":"        DISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":404,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openEuler) ]]; then"},{"line_number":405,"context_line":"        DISTRO\u003d\"openEuler-$os_RELEASE\""},{"line_number":406,"context_line":"    else"},{"line_number":407,"context_line":"        # We can\u0027t make a good choice here.  Setting a sensible DISTRO"},{"line_number":408,"context_line":"        # is part of the problem, but not the major issue -- we really"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ff28c964_eb7c8e92","line":405,"range":{"start_line":405,"start_character":0,"end_line":405,"end_character":8},"in_reply_to":"a9300aee_2d08b78c","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"1133e31aaac5007fdc57f42b35acf62acdd29eae","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"    if is_ubuntu; then"},{"line_number":1070,"context_line":"        pkg_dir\u003d$base_dir/debs"},{"line_number":1071,"context_line":"    elif is_openeuler; then"},{"line_number":1072,"context_line":"        pkg_dir\u003d$base_dir/rpms-openeuler"},{"line_number":1073,"context_line":"    elif is_fedora; then"},{"line_number":1074,"context_line":"        pkg_dir\u003d$base_dir/rpms"},{"line_number":1075,"context_line":"    elif is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1b8b9c54_02cee930","line":1072,"range":{"start_line":1072,"start_character":0,"end_line":1072,"end_character":8},"updated":"2021-10-26 03:34:32.000000000","message":"Can remove $base_dir/rpms-openeuler directory here? Still a lot of duplication with $base_dir/rpms directory.\nTo do so, we might need to extent function \"_parse_package_files\" to support different distros in the same family, if they have some different packages to install.","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"    if is_ubuntu; then"},{"line_number":1070,"context_line":"        pkg_dir\u003d$base_dir/debs"},{"line_number":1071,"context_line":"    elif is_openeuler; then"},{"line_number":1072,"context_line":"        pkg_dir\u003d$base_dir/rpms-openeuler"},{"line_number":1073,"context_line":"    elif is_fedora; then"},{"line_number":1074,"context_line":"        pkg_dir\u003d$base_dir/rpms"},{"line_number":1075,"context_line":"    elif is_suse; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"d828ecb3_7200f5bf","line":1072,"range":{"start_line":1072,"start_character":0,"end_line":1072,"end_character":8},"in_reply_to":"1b8b9c54_02cee930","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"efbede686df0075767be8ee6a9f98956fd7c8a73"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d20c0bea700e25d026e48f1fdc7609c01b919e0c","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        # XXX re-evaluate when we get RHEL10"},{"line_number":461,"context_line":"        DISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":462,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openEuler) ]]; then"},{"line_number":463,"context_line":"        # The DISTRO here is `openEuler-20.03`. While, actually only openEuler"},{"line_number":464,"context_line":"        # 20.03 LTS SP2 is fully tested. Other SP version maybe have bugs."},{"line_number":465,"context_line":"        DISTRO\u003d\"openEuler-$os_RELEASE\""},{"line_number":466,"context_line":"    else"},{"line_number":467,"context_line":"        # We can\u0027t make a good choice here.  Setting a sensible DISTRO"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"6bfbc7ec_aee51d4d","line":464,"range":{"start_line":463,"start_character":8,"end_line":464,"end_character":74},"updated":"2021-12-22 02:00:34.000000000","message":"Maybe moving this part comment to SUPPORTED_DISTROS definition location is better.","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"53124679cdeab7dd9e5e46d6decf1d59e772db53","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        # XXX re-evaluate when we get RHEL10"},{"line_number":461,"context_line":"        DISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":462,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openEuler) ]]; then"},{"line_number":463,"context_line":"        # The DISTRO here is `openEuler-20.03`. While, actually only openEuler"},{"line_number":464,"context_line":"        # 20.03 LTS SP2 is fully tested. Other SP version maybe have bugs."},{"line_number":465,"context_line":"        DISTRO\u003d\"openEuler-$os_RELEASE\""},{"line_number":466,"context_line":"    else"},{"line_number":467,"context_line":"        # We can\u0027t make a good choice here.  Setting a sensible DISTRO"}],"source_content_type":"application/x-shellscript","patch_set":36,"id":"4493391d_5f05fe5b","line":464,"range":{"start_line":463,"start_character":8,"end_line":464,"end_character":74},"in_reply_to":"6bfbc7ec_aee51d4d","updated":"2021-12-22 14:47:31.000000000","message":"Done","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2f4f6a7f7519f772d9662c5dd83f105001b1202d","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        # XXX re-evaluate when we get RHEL10"},{"line_number":461,"context_line":"        DISTRO\u003d\"rhel${os_RELEASE::1}\""},{"line_number":462,"context_line":"    elif [[ \"$os_VENDOR\" \u003d~ (openEuler) ]]; then"},{"line_number":463,"context_line":"        # The DISTRO here is `openEuler-20.03`. While, actually only openEuler"},{"line_number":464,"context_line":"        # 20.03 LTS SP2 is fully tested. Other SP version maybe have bugs."},{"line_number":465,"context_line":"        DISTRO\u003d\"openEuler-$os_RELEASE\""},{"line_number":466,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"c502550d_68de2313","line":463,"range":{"start_line":463,"start_character":48,"end_line":463,"end_character":63},"updated":"2021-12-30 10:38:39.000000000","message":"nit: these words only complicate the comment, better be removed","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2f4f6a7f7519f772d9662c5dd83f105001b1202d","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        GetOSVersion"},{"line_number":569,"context_line":"    fi"},{"line_number":570,"context_line":"    [ \"$os_VENDOR\" \u003d \"openEuler\" ]"},{"line_number":571,"context_line":"}"},{"line_number":572,"context_line":"# Git Functions"},{"line_number":573,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":574,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":41,"id":"a7418397_7640282a","line":571,"updated":"2021-12-30 10:38:39.000000000","message":"nit: missing empty line","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"}],"lib/apache":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"664b210f55bcc259a833898f3972ac9619c5290d","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        popd"},{"line_number":123,"context_line":"        # delete the temp directory"},{"line_number":124,"context_line":"        sudo rm -rf $dir"},{"line_number":125,"context_line":"        UWSGI_PYTHON_PLUGIN\u003dpython3"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_ubuntu || is_suse ; then"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"bbee922d_dc511237","line":125,"updated":"2021-11-17 14:20:06.000000000","message":"This is the default being set above. If we can really just use python3 everywhere, we could drop this variable completely and hardcode the value below.","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        popd"},{"line_number":123,"context_line":"        # delete the temp directory"},{"line_number":124,"context_line":"        sudo rm -rf $dir"},{"line_number":125,"context_line":"        UWSGI_PYTHON_PLUGIN\u003dpython3"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_ubuntu || is_suse ; then"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"d7157bb6_610b4eb6","line":125,"in_reply_to":"6276024f_87d1ac27","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7fab8ac907cc67b812728779c1a309978b82f699","unresolved":true,"context_lines":[{"line_number":122,"context_line":"        popd"},{"line_number":123,"context_line":"        # delete the temp directory"},{"line_number":124,"context_line":"        sudo rm -rf $dir"},{"line_number":125,"context_line":"        UWSGI_PYTHON_PLUGIN\u003dpython3"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    if is_ubuntu || is_suse ; then"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"6276024f_87d1ac27","line":125,"in_reply_to":"bbee922d_dc511237","updated":"2021-12-09 01:27:41.000000000","message":"++\npython2 support could be dropped here","commit_id":"1d6b187169bdd8698432dcfff5375fc4fc69d1f7"}],"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            install_package edk2-aarch64"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpip_uninstall libvirt-python"},{"line_number":98,"context_line":"\tpip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_6152af69","line":97,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E002 Tab indents","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            install_package edk2-aarch64"},{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpip_uninstall libvirt-python"},{"line_number":98,"context_line":"\tpip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_c14f43bb","line":97,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpip_uninstall libvirt-python"},{"line_number":98,"context_line":"\tpip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if [[ $DEBUG_LIBVIRT_COREDUMPS \u003d\u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_a14cc7c7","line":98,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E002 Tab indents","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f34e37bed990acba584afefb1eec5048628f8fda","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpip_uninstall libvirt-python"},{"line_number":98,"context_line":"\tpip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if [[ $DEBUG_LIBVIRT_COREDUMPS \u003d\u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f621f24_01c77b14","line":98,"updated":"2020-11-02 11:03:48.000000000","message":"bashate: E003 Indent not multiple of 4","commit_id":"d28703420c6a228fd6427c31376aad3c03fba9aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9b3aa60f467ce3e32788fad78fac3b78321ca198","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    pip_uninstall libvirt-python"},{"line_number":98,"context_line":"    pip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if [[ $DEBUG_LIBVIRT_COREDUMPS \u003d\u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9b841555_41252620","line":98,"updated":"2021-04-10 11:00:28.000000000","message":"Missing indent","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    pip_uninstall libvirt-python"},{"line_number":98,"context_line":"    pip_install_gr libvirt-python"},{"line_number":99,"context_line":"    fi"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    if [[ $DEBUG_LIBVIRT_COREDUMPS \u003d\u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9c56c0a3_26df5177","line":98,"in_reply_to":"9b841555_41252620","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"e5bb0a051c2eddcbc19140a608b3f7b6ca3f1a97"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"76fda8dd8e27721a11cc93da39c042bb0b134657","unresolved":true,"context_lines":[{"line_number":74,"context_line":"            install_package qemu-efi"},{"line_number":75,"context_line":"        fi"},{"line_number":76,"context_line":"        #pip_install_gr \u003cthere-si-no-guestfs-in-pypi\u003e"},{"line_number":77,"context_line":"    elif is_openeuler; then"},{"line_number":78,"context_line":"        install_package qemu-kvm"},{"line_number":79,"context_line":"        install_package libvirt libvirt-devel python3-libvirt"},{"line_number":80,"context_line":"        if is_arch \"aarch64\"; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3e8d7110_9c4f97a3","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":9},"updated":"2021-10-26 07:10:58.000000000","message":"This part move into part \"elif is_fedora\"?","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"bda3a378a3f91298f1ca31e52ef4d66957adef50","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            install_package qemu-efi"},{"line_number":75,"context_line":"        fi"},{"line_number":76,"context_line":"        #pip_install_gr \u003cthere-si-no-guestfs-in-pypi\u003e"},{"line_number":77,"context_line":"    elif is_openeuler; then"},{"line_number":78,"context_line":"        install_package qemu-kvm"},{"line_number":79,"context_line":"        install_package libvirt libvirt-devel python3-libvirt"},{"line_number":80,"context_line":"        if is_arch \"aarch64\"; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3f6ad1c7_3b26afec","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":9},"in_reply_to":"3e8d7110_9c4f97a3","updated":"2021-10-26 07:38:16.000000000","message":"Ack","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"9d49de405dc5b7b82d27072f7b10bf097c74769d","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            install_package libvirt libvirt-devel python3-libvirt"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            if is_arch \"aarch64\"; then"},{"line_number":99,"context_line":"                install_package edk2.git-aarch64"},{"line_number":100,"context_line":"            fi"},{"line_number":101,"context_line":"        fi"},{"line_number":102,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"b8037b4b_be431747","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":48},"updated":"2021-10-26 09:22:23.000000000","message":"I don\u0027t think we have this package. Please change to edk2-aarch64 and remove \"if is_openeuler\" part.\n\n[root@5812d64ada86 /]# dnf install edk2.git-aarch64\nLast metadata expiration check: 0:03:50 ago on Tue Oct 26 09:13:54 2021.\nNo match for argument: edk2.git-aarch64\nError: Unable to find a match: edk2.git-aarch64\n[root@5812d64ada86 /]# cat /etc/redhat-release\nFedora release 34 (Thirty Four)\n[root@5812d64ada86 /]#\n\nEven not found in virt-preview repo:\nhttps://download.copr.fedorainfracloud.org/results/@virtmaint-sig/virt-preview/fedora-35-aarch64/02876943-edk2/","commit_id":"175880087607c80cec4c232b3599dea7527bfc7b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            install_package libvirt libvirt-devel python3-libvirt"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            if is_arch \"aarch64\"; then"},{"line_number":99,"context_line":"                install_package edk2.git-aarch64"},{"line_number":100,"context_line":"            fi"},{"line_number":101,"context_line":"        fi"},{"line_number":102,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"0ab2f6b2_c1ea7a6d","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":48},"in_reply_to":"ad0c8d18_5fd5a239","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"175880087607c80cec4c232b3599dea7527bfc7b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"d2953fdeb33d6591fbb3f5eab6f912a0adc78878","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            install_package libvirt libvirt-devel python3-libvirt"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"            if is_arch \"aarch64\"; then"},{"line_number":99,"context_line":"                install_package edk2.git-aarch64"},{"line_number":100,"context_line":"            fi"},{"line_number":101,"context_line":"        fi"},{"line_number":102,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"ad0c8d18_5fd5a239","line":99,"range":{"start_line":99,"start_character":41,"end_line":99,"end_character":48},"in_reply_to":"b8037b4b_be431747","updated":"2021-10-27 00:57:12.000000000","message":"I\u0027m not familiar with the history of this code. But it seems that only https://www.kraxel.org/repos/jenkins/edk2/ names edk2.git-aarch64\n\nI tried centos 8, it\u0027s edk2-aarch64 as well.","commit_id":"175880087607c80cec4c232b3599dea7527bfc7b"}],"playbooks/openeuler/pre.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b77127bdbd4db5ed1b928dee0af5e2edad0ac6ee","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Generate openstack ci yum repo"},{"line_number":4,"context_line":"      copy:"},{"line_number":5,"context_line":"        dest: \"/etc/yum.repos.d/openstack-master.repo\""},{"line_number":6,"context_line":"        content: |"},{"line_number":7,"context_line":"          [openstack-ci]"},{"line_number":8,"context_line":"          name\u003dopenstack"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"fd941d9d_9afee8de","line":5,"updated":"2021-12-17 14:19:34.000000000","message":"Seems this needs a \"become: true\"\n\n\"msg\": \"Destination /etc/yum.repos.d not writable\"","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"53124679cdeab7dd9e5e46d6decf1d59e772db53","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  tasks:"},{"line_number":3,"context_line":"    - name: Generate openstack ci yum repo"},{"line_number":4,"context_line":"      copy:"},{"line_number":5,"context_line":"        dest: \"/etc/yum.repos.d/openstack-master.repo\""},{"line_number":6,"context_line":"        content: |"},{"line_number":7,"context_line":"          [openstack-ci]"},{"line_number":8,"context_line":"          name\u003dopenstack"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"7ce0c852_8080c6b1","line":5,"in_reply_to":"fd941d9d_9afee8de","updated":"2021-12-22 14:47:31.000000000","message":"Done","commit_id":"961d0e747f5c7cf9d2f90e07d3e9a7af161f3fa8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05205dd518f3bd74a676c1d40b257fc2ba007dce","unresolved":true,"context_lines":[{"line_number":7,"context_line":"        content: |"},{"line_number":8,"context_line":"          [openstack-ci]"},{"line_number":9,"context_line":"          name\u003dopenstack"},{"line_number":10,"context_line":"          baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/x86_64/"},{"line_number":11,"context_line":"          enabled\u003d1"},{"line_number":12,"context_line":"          gpgcheck\u003d0"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"14f16667_19ea349f","line":10,"updated":"2021-12-21 10:43:04.000000000","message":"Is there a specific reason you need this as a pre-playbook?\n\nThe usual procedure would be to add needed repos or other distro-specific setup in tools/fixup_stuff.sh","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"776e1042ccd9eb4b3898070912ca0e0b12ef376a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"        content: |"},{"line_number":8,"context_line":"          [openstack-ci]"},{"line_number":9,"context_line":"          name\u003dopenstack"},{"line_number":10,"context_line":"          baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/x86_64/"},{"line_number":11,"context_line":"          enabled\u003d1"},{"line_number":12,"context_line":"          gpgcheck\u003d0"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"4661ff68_16684b67","line":10,"in_reply_to":"14f16667_19ea349f","updated":"2021-12-21 13:46:42.000000000","message":"There are some problems in openEuler 20.03 LTS SP2 official RPM repo:\n1. The version of Libvirt, Qemu and edk2 is too old which doesn\u0027t satisfy nova\u0027s requirement.\n2. mod_wsgi and novnc are missing.\n\nSo We(openEuler OpenStack SIG[1]) maintained a third-part repo to fix the problem.\n\nThe openEuler issue is here[2], we\u0027ll fix them then.\n\n[1]: https://gitee.com/openeuler/openstack/blob/master/README.en.md\n[2]: https://gitee.com/openeuler/openstack/issues/I4NJX4\n\n\nSorry that I\u0027m not very familiar with devstack code structure. I\u0027ll move the hack code to fixup_stuff.sh in next PS.","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"53124679cdeab7dd9e5e46d6decf1d59e772db53","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        content: |"},{"line_number":8,"context_line":"          [openstack-ci]"},{"line_number":9,"context_line":"          name\u003dopenstack"},{"line_number":10,"context_line":"          baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/x86_64/"},{"line_number":11,"context_line":"          enabled\u003d1"},{"line_number":12,"context_line":"          gpgcheck\u003d0"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"55510ef5_3f0198a0","line":10,"in_reply_to":"4661ff68_16684b67","updated":"2021-12-22 14:47:31.000000000","message":"Done","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"}],"stack.sh":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"76fda8dd8e27721a11cc93da39c042bb0b134657","unresolved":true,"context_lines":[{"line_number":278,"context_line":"sudo chown root:root $TEMPFILE"},{"line_number":279,"context_line":"sudo mv $TEMPFILE /etc/sudoers.d/50_stack_sh"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03-LTS-SP2\" ]]; then"},{"line_number":282,"context_line":"    install_package hostname"},{"line_number":283,"context_line":"fi"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"711e8e58_1a49cfe0","line":281,"updated":"2021-10-26 07:10:58.000000000","message":"Put packages installation into files/rpm/, in this case is files/rpms/general.","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"bda3a378a3f91298f1ca31e52ef4d66957adef50","unresolved":true,"context_lines":[{"line_number":278,"context_line":"sudo chown root:root $TEMPFILE"},{"line_number":279,"context_line":"sudo mv $TEMPFILE /etc/sudoers.d/50_stack_sh"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03-LTS-SP2\" ]]; then"},{"line_number":282,"context_line":"    install_package hostname"},{"line_number":283,"context_line":"fi"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"bf95e905_077b1afa","line":281,"in_reply_to":"711e8e58_1a49cfe0","updated":"2021-10-26 07:38:16.000000000","message":"hostname is called before files/rpm action. So we must install it first. We can remove hostname in files/rpm instead.","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"61bf0ba29a5f2516847d78a68765ece5fdab23f3","unresolved":false,"context_lines":[{"line_number":278,"context_line":"sudo chown root:root $TEMPFILE"},{"line_number":279,"context_line":"sudo mv $TEMPFILE /etc/sudoers.d/50_stack_sh"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03-LTS-SP2\" ]]; then"},{"line_number":282,"context_line":"    install_package hostname"},{"line_number":283,"context_line":"fi"},{"line_number":284,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"c2336b56_4bfc6a9a","line":281,"in_reply_to":"bf95e905_077b1afa","updated":"2021-12-09 01:39:59.000000000","message":"Done","commit_id":"50fcda9748a76029dcdfb14e40675be679f51280"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"05205dd518f3bd74a676c1d40b257fc2ba007dce","unresolved":true,"context_lines":[{"line_number":283,"context_line":"# in the future."},{"line_number":284,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03\" ]]; then"},{"line_number":285,"context_line":"    install_package hostname"},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# Configure Distro Repositories"},{"line_number":289,"context_line":"# -----------------------------"}],"source_content_type":"text/x-sh","patch_set":36,"id":"7b1a294b_f33d745d","line":286,"updated":"2021-12-21 10:43:04.000000000","message":"The location of this is a bit weird, could it also be moved to fixup_stuff.sh? Also, do you have a bug against openEuler that could be used to track this issue?","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"752d3054f93cbaa12eec1551b56230b9e937e234","unresolved":true,"context_lines":[{"line_number":283,"context_line":"# in the future."},{"line_number":284,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03\" ]]; then"},{"line_number":285,"context_line":"    install_package hostname"},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# Configure Distro Repositories"},{"line_number":289,"context_line":"# -----------------------------"}],"source_content_type":"text/x-sh","patch_set":36,"id":"7def98fb_c0ceced1","line":286,"in_reply_to":"00f17426_dd495197","updated":"2021-12-22 01:51:21.000000000","message":"Maybe this part can be removed, hostname pkg should be installed in openeuler-minimal image already. Hostname cmd is a so basic cmd most local test environment will have it and we can install hostname easily.","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"776e1042ccd9eb4b3898070912ca0e0b12ef376a","unresolved":true,"context_lines":[{"line_number":283,"context_line":"# in the future."},{"line_number":284,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03\" ]]; then"},{"line_number":285,"context_line":"    install_package hostname"},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# Configure Distro Repositories"},{"line_number":289,"context_line":"# -----------------------------"}],"source_content_type":"text/x-sh","patch_set":36,"id":"d588e28e_869e2934","line":286,"in_reply_to":"7b1a294b_f33d745d","updated":"2021-12-21 13:46:42.000000000","message":"ditto","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"53124679cdeab7dd9e5e46d6decf1d59e772db53","unresolved":false,"context_lines":[{"line_number":283,"context_line":"# in the future."},{"line_number":284,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03\" ]]; then"},{"line_number":285,"context_line":"    install_package hostname"},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# Configure Distro Repositories"},{"line_number":289,"context_line":"# -----------------------------"}],"source_content_type":"text/x-sh","patch_set":36,"id":"5330dfec_4efe6a54","line":286,"in_reply_to":"7def98fb_c0ceced1","updated":"2021-12-22 14:47:31.000000000","message":"Done","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"4cee9493732732904d48948b4ba7a39f3028ecd3","unresolved":true,"context_lines":[{"line_number":283,"context_line":"# in the future."},{"line_number":284,"context_line":"if [[ $DISTRO \u003d\u003d \"openEuler-20.03\" ]]; then"},{"line_number":285,"context_line":"    install_package hostname"},{"line_number":286,"context_line":"fi"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"# Configure Distro Repositories"},{"line_number":289,"context_line":"# -----------------------------"}],"source_content_type":"text/x-sh","patch_set":36,"id":"00f17426_dd495197","line":286,"in_reply_to":"d588e28e_869e2934","updated":"2021-12-22 01:33:14.000000000","message":"hostname is called before fixup, so it can\u0027t be moved to fixup_stuff\n\nhttps://opendev.org/openstack/devstack/src/branch/master/stack.sh#L594","commit_id":"0e31dd9ba72e7d9031da27e1b7dd2d82634e442a"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"d8cee5139c233c6e2916f15ffcbb0b674378ff4b","unresolved":true,"context_lines":[{"line_number":162,"context_line":"    # Some packages\u0027 version in openEuler are too old, use the newer ones we"},{"line_number":163,"context_line":"    # provide in oepkg. (oepkg is an openEuler third part yum repo which is"},{"line_number":164,"context_line":"    # endorsed by openEuler community)"},{"line_number":165,"context_line":"    (echo \u0027[openstack-ci]\u0027"},{"line_number":166,"context_line":"    echo \u0027name\u003dopenstack\u0027"},{"line_number":167,"context_line":"    echo \u0027baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/\u0027$arch\u0027/\u0027"},{"line_number":168,"context_line":"    echo \u0027enabled\u003d1\u0027"},{"line_number":169,"context_line":"    echo \u0027gpgcheck\u003d0\u0027) | sudo tee -a /etc/yum.repos.d/openstack-master.repo \u003e /dev/null"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    yum_install liberasurecode-devel"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"90bef0df_3ab660f3","line":169,"range":{"start_line":165,"start_character":4,"end_line":169,"end_character":87},"updated":"2021-12-22 08:48:20.000000000","message":"How about:\ncat \u003e/etc/yum.repos.d/openstack-master.repo\u003c\u003cEOF\nXXX\nEOF","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"cce6441aaad05f8d7e6d1bb1b575a1467bb952b8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    # Some packages\u0027 version in openEuler are too old, use the newer ones we"},{"line_number":163,"context_line":"    # provide in oepkg. (oepkg is an openEuler third part yum repo which is"},{"line_number":164,"context_line":"    # endorsed by openEuler community)"},{"line_number":165,"context_line":"    (echo \u0027[openstack-ci]\u0027"},{"line_number":166,"context_line":"    echo \u0027name\u003dopenstack\u0027"},{"line_number":167,"context_line":"    echo \u0027baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/\u0027$arch\u0027/\u0027"},{"line_number":168,"context_line":"    echo \u0027enabled\u003d1\u0027"},{"line_number":169,"context_line":"    echo \u0027gpgcheck\u003d0\u0027) | sudo tee -a /etc/yum.repos.d/openstack-master.repo \u003e /dev/null"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    yum_install liberasurecode-devel"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"16950c3d_ba567a6a","line":169,"range":{"start_line":165,"start_character":4,"end_line":169,"end_character":87},"in_reply_to":"2fe8a3e9_de1a97dd","updated":"2021-12-22 09:26:10.000000000","message":"OK, fine too for me.","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c27a871351349ef46ad02e4ec58a068b27a4626e","unresolved":true,"context_lines":[{"line_number":162,"context_line":"    # Some packages\u0027 version in openEuler are too old, use the newer ones we"},{"line_number":163,"context_line":"    # provide in oepkg. (oepkg is an openEuler third part yum repo which is"},{"line_number":164,"context_line":"    # endorsed by openEuler community)"},{"line_number":165,"context_line":"    (echo \u0027[openstack-ci]\u0027"},{"line_number":166,"context_line":"    echo \u0027name\u003dopenstack\u0027"},{"line_number":167,"context_line":"    echo \u0027baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/\u0027$arch\u0027/\u0027"},{"line_number":168,"context_line":"    echo \u0027enabled\u003d1\u0027"},{"line_number":169,"context_line":"    echo \u0027gpgcheck\u003d0\u0027) | sudo tee -a /etc/yum.repos.d/openstack-master.repo \u003e /dev/null"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    yum_install liberasurecode-devel"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"e00ef6e7_ac7c4216","line":169,"range":{"start_line":165,"start_character":4,"end_line":169,"end_character":87},"in_reply_to":"90bef0df_3ab660f3","updated":"2021-12-22 09:08:31.000000000","message":"it\u0027ll raise permision error. Please see the log in PS39\n\nhttps://zuul.opendev.org/t/openstack/build/426fe9fd14fd4ad5b0ed6e99d9ab5850","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a4aa87df0d5d5a640fb69893809b82f64c085347","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    # Some packages\u0027 version in openEuler are too old, use the newer ones we"},{"line_number":163,"context_line":"    # provide in oepkg. (oepkg is an openEuler third part yum repo which is"},{"line_number":164,"context_line":"    # endorsed by openEuler community)"},{"line_number":165,"context_line":"    (echo \u0027[openstack-ci]\u0027"},{"line_number":166,"context_line":"    echo \u0027name\u003dopenstack\u0027"},{"line_number":167,"context_line":"    echo \u0027baseurl\u003dhttps://repo.oepkgs.net/openEuler/rpm/openEuler-20.03-LTS-SP2/budding-openeuler/openstack-master-ci/\u0027$arch\u0027/\u0027"},{"line_number":168,"context_line":"    echo \u0027enabled\u003d1\u0027"},{"line_number":169,"context_line":"    echo \u0027gpgcheck\u003d0\u0027) | sudo tee -a /etc/yum.repos.d/openstack-master.repo \u003e /dev/null"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    yum_install liberasurecode-devel"},{"line_number":172,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":41,"id":"2fe8a3e9_de1a97dd","line":169,"range":{"start_line":165,"start_character":4,"end_line":169,"end_character":87},"in_reply_to":"e00ef6e7_ac7c4216","updated":"2021-12-22 09:18:22.000000000","message":"Well, you could do\n\ncat \u003c\u003c EOF | sudo tee\n\nbut I think this variant is fine as well.","commit_id":"7880ba665e2d594b2eabb0533e6dca52e042ca50"}]}