)]}'
{"functions":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"69241bea0bf52f817f08707924bb1ed2738f5387","unresolved":true,"context_lines":[{"line_number":771,"context_line":"    fi"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    # Clear any stale fstab entries for this image"},{"line_number":774,"context_line":"    sudo sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    # Create an empty file of the correct size (and ensure the"},{"line_number":777,"context_line":"    # directory structure up to that path exists)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"16a5231b_0892c1f9","line":774,"updated":"2020-11-26 09:45:24.000000000","message":"Why not simply call destroy_disk() instead of repeating all this code?","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"293df2e4fab6a63cb123be2007bd4385d62a3c6a","unresolved":true,"context_lines":[{"line_number":771,"context_line":"    fi"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    # Clear any stale fstab entries for this image"},{"line_number":774,"context_line":"    sudo sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    # Create an empty file of the correct size (and ensure the"},{"line_number":777,"context_line":"    # directory structure up to that path exists)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"410ebe1c_b84c6101","line":774,"in_reply_to":"16a5231b_0892c1f9","updated":"2020-12-03 12:20:08.000000000","message":"Good catch. Also, the destroy_disk is missing sudo with sed, and force with rm (commented below).","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3405952a3d5bc4d81333026b671873cc0dbfe5f1","unresolved":true,"context_lines":[{"line_number":771,"context_line":"    fi"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"    # Clear any stale fstab entries for this image"},{"line_number":774,"context_line":"    sudo sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"    # Create an empty file of the correct size (and ensure the"},{"line_number":777,"context_line":"    # directory structure up to that path exists)"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9ffef8f1_49b965af","line":774,"in_reply_to":"410ebe1c_b84c6101","updated":"2021-01-05 17:59:25.000000000","message":"Probably because I never spend more than five minutes on this every month or so :)\n\nMy apologies.","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"293df2e4fab6a63cb123be2007bd4385d62a3c6a","unresolved":true,"context_lines":[{"line_number":802,"context_line":"    fi"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    # Clear any fstab rules"},{"line_number":805,"context_line":"    sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    # Delete the file"},{"line_number":808,"context_line":"    sudo rm $disk_image"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff58e914_88714839","line":805,"range":{"start_line":805,"start_character":4,"end_line":805,"end_character":5},"updated":"2020-12-03 12:20:08.000000000","message":"missing sudo","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3405952a3d5bc4d81333026b671873cc0dbfe5f1","unresolved":true,"context_lines":[{"line_number":802,"context_line":"    fi"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"    # Clear any fstab rules"},{"line_number":805,"context_line":"    sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    # Delete the file"},{"line_number":808,"context_line":"    sudo rm $disk_image"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"67bdff8e_3e7ea2bf","line":805,"range":{"start_line":805,"start_character":4,"end_line":805,"end_character":5},"in_reply_to":"ff58e914_88714839","updated":"2021-01-05 17:59:25.000000000","message":"Also missing definition of $key","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"293df2e4fab6a63cb123be2007bd4385d62a3c6a","unresolved":true,"context_lines":[{"line_number":805,"context_line":"    sed -i \u0027/.*comment\u003d$key.*/ d\u0027 /etc/fstab"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    # Delete the file"},{"line_number":808,"context_line":"    sudo rm $disk_image"},{"line_number":809,"context_line":"}"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fc616e84_ef486373","line":808,"range":{"start_line":808,"start_character":11,"end_line":808,"end_character":12},"updated":"2020-12-03 12:20:08.000000000","message":"missing -f","commit_id":"73634a5acb53091f8b934dfa663227af6c14ce19"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"995007859f0910ce78abfe4cac834ec4403d3882","unresolved":true,"context_lines":[{"line_number":786,"context_line":"function destroy_disk {"},{"line_number":787,"context_line":"    local disk_image\u003d$1"},{"line_number":788,"context_line":"    local storage_data_dir\u003d$2"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"    key\u003d$(echo $disk_image | sed \u0027s#/.##\u0027)"},{"line_number":791,"context_line":"    key\u003d\"devstack-$key\""},{"line_number":792,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"2aa5bb96_95eae591","line":789,"updated":"2021-01-07 18:24:49.000000000","message":"Add \"local key\" here","commit_id":"f0135bbb46c8fef778e94f74c80993277d9bebbd"}]}