)]}'
{"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"83e89606b70f1c4bbb5bdb34a907bba00ac5280c","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            pushd $ovs_repo_dir"},{"line_number":144,"context_line":"            git checkout $OVS_BRANCH"},{"line_number":145,"context_line":"            popd"},{"line_number":146,"context_line":"        else"},{"line_number":147,"context_line":"            clone_repository $OVS_REPO $ovs_repo_dir $OVS_BRANCH"},{"line_number":148,"context_line":"        fi"},{"line_number":149,"context_line":"        # Check the split commit exists in the current branch"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"83535a29_59cbe8b0","line":146,"updated":"2020-11-24 09:21:52.000000000","message":"This change was needed because OVS_BRANCH can be a specific commit and the \"clone_repository ...\" syntax was failing to clone and checkout to a specific commit if the repository didn\u0027t exist. It works if the repository is already there tho.\n\nThe \"ovs\" devstack module in Neutron does something similar: https://github.com/openstack/neutron/blob/master/devstack/lib/ovs#L45-L55","commit_id":"a99e1c06c18ee3d338b7e40517d2cce0ff8bef1d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7756d08558336eeeffdb645c0a14a7f40a6d21e2","unresolved":true,"context_lines":[{"line_number":738,"context_line":"function stop_ovn {"},{"line_number":739,"context_line":"    if is_service_enabled q-ovn-metadata-agent; then"},{"line_number":740,"context_line":"        sudo pkill -9 -f haproxy || :"},{"line_number":741,"context_line":"        _stop_process \"devstack@q-ovn-metadata-agent.service\""},{"line_number":742,"context_line":"    fi"},{"line_number":743,"context_line":"    if is_service_enabled ovn-controller-vtep ; then"},{"line_number":744,"context_line":"        _stop_process \"$OVN_CONTROLLER_VTEP_SERVICE\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"59e08199_7fce3025","line":741,"updated":"2020-12-03 13:21:37.000000000","message":"is this related to the patch?","commit_id":"7eb96f9e9d126462dcd42cd2fca0129f99ac6d33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ec85a59c38f4e9e0a9840cf69145f765d2dfe3da","unresolved":true,"context_lines":[{"line_number":738,"context_line":"function stop_ovn {"},{"line_number":739,"context_line":"    if is_service_enabled q-ovn-metadata-agent; then"},{"line_number":740,"context_line":"        sudo pkill -9 -f haproxy || :"},{"line_number":741,"context_line":"        _stop_process \"devstack@q-ovn-metadata-agent.service\""},{"line_number":742,"context_line":"    fi"},{"line_number":743,"context_line":"    if is_service_enabled ovn-controller-vtep ; then"},{"line_number":744,"context_line":"        _stop_process \"$OVN_CONTROLLER_VTEP_SERVICE\""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"ece7c15f_d0caa372","line":741,"in_reply_to":"59e08199_7fce3025","updated":"2020-12-03 13:26:04.000000000","message":"Well, maybe not 100% but this is an existing problem, the name of this process is devstack@q-ovn-metadata-agent.service (see L660 for example).\n\nThe previous name (neutron-ovn-metadata-agent) was wrong and the service wasn\u0027t stopped when I ran ./unstack.sh so, I just fixed it here. I could put it in a separated patch if u think it makes more sense.","commit_id":"7eb96f9e9d126462dcd42cd2fca0129f99ac6d33"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"cd463eec85522694e3e281a733aa99852178b1ad","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    local count\u003d0"},{"line_number":158,"context_line":"    while [ ! -S $1 ]; do"},{"line_number":159,"context_line":"        sleep 1"},{"line_number":160,"context_line":"        ((count+\u003d1))"},{"line_number":161,"context_line":"        if [ \"$count\" -gt 5 ]; then"},{"line_number":162,"context_line":"            die $LINENO \"File $1 not found\""},{"line_number":163,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"58b22b7e_89d7fc77","line":160,"in_reply_to":"a1d68a37_3f42de2d","updated":"2020-12-09 15:17:34.000000000","message":"\u003e bashate: E043 Arithmetic compound has inconsistent return semantics\n\n\"   The return value of ((expr)) is 1 if \"expr\" evalues to zero,\n        otherwise 0.  Combined with \"set -e\", this can be quite\n        confusing when something like ((counter++)) evaluates to zero,\n        making the arithmetic evaluation return 1 and triggering the\n        an error failure.  It is therefore best to use assignment with\n        the $(( operator.   \"\"\",\u0027default\u0027: \u0027W\u0027,\"\n\nhttps://github.com/openstack/bashate/blob/master/bashate/messages.py#L179\n\nI think this wants:\ncount\u003d$((count+1))","commit_id":"42e37ad6682301f2cddacf429c82f47937be5df5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":157,"context_line":"    local count\u003d0"},{"line_number":158,"context_line":"    while [ ! -S $1 ]; do"},{"line_number":159,"context_line":"        sleep 1"},{"line_number":160,"context_line":"        count\u003d$((count+\u003d1))"},{"line_number":161,"context_line":"        if [ \"$count\" -gt 5 ]; then"},{"line_number":162,"context_line":"            die $LINENO \"File $1 not found\""},{"line_number":163,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"0e087ea3_ee72ac01","line":160,"range":{"start_line":160,"start_character":17,"end_line":160,"end_character":25},"updated":"2020-12-14 11:47:19.000000000","message":"This should be just \"count+1\", no need to do two assignments one overriding the other","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    local count\u003d0"},{"line_number":158,"context_line":"    while [ ! -S $1 ]; do"},{"line_number":159,"context_line":"        sleep 1"},{"line_number":160,"context_line":"        count\u003d$((count+\u003d1))"},{"line_number":161,"context_line":"        if [ \"$count\" -gt 5 ]; then"},{"line_number":162,"context_line":"            die $LINENO \"File $1 not found\""},{"line_number":163,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"f6d2e79d_0acd64eb","line":160,"range":{"start_line":160,"start_character":17,"end_line":160,"end_character":25},"in_reply_to":"0e087ea3_ee72ac01","updated":"2020-12-17 16:18:29.000000000","message":"Done","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        sleep 1"},{"line_number":160,"context_line":"        count\u003d$((count+\u003d1))"},{"line_number":161,"context_line":"        if [ \"$count\" -gt 5 ]; then"},{"line_number":162,"context_line":"            die $LINENO \"File $1 not found\""},{"line_number":163,"context_line":"        fi"},{"line_number":164,"context_line":"    done"},{"line_number":165,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"876e5d07_40131b98","line":162,"updated":"2020-12-14 11:47:19.000000000","message":"This message is a bit vague I\u0027d say, it could happen that the file exist but isn\u0027t socket. Maybe s/File/Socket/ ?","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        sleep 1"},{"line_number":160,"context_line":"        count\u003d$((count+\u003d1))"},{"line_number":161,"context_line":"        if [ \"$count\" -gt 5 ]; then"},{"line_number":162,"context_line":"            die $LINENO \"File $1 not found\""},{"line_number":163,"context_line":"        fi"},{"line_number":164,"context_line":"    done"},{"line_number":165,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"523dd270_ecef544c","line":162,"in_reply_to":"876e5d07_40131b98","updated":"2020-12-17 16:18:29.000000000","message":"Done","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    # NOTE(lucasagomes): To keep things simpler, let\u0027s reuse the same"},{"line_number":384,"context_line":"    # RUNDIR for both OVS and OVN. This way we avoid having to specify the"},{"line_number":385,"context_line":"    # --db option in the ovn-{n,s}bctl commands while playing with DevStack"},{"line_number":386,"context_line":"    sudo ln -s $OVS_RUNDIR $OVN_RUNDIR"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if [[ \"$OVN_BUILD_FROM_SOURCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":389,"context_line":"        # If OVS is already installed, remove it, because we\u0027re about to"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"badf74b7_e93e00cb","line":386,"updated":"2020-12-14 11:47:19.000000000","message":"Wouldn\u0027t it be better to set OVS_RUNDIR and OVN_RUNDIR to the same path?","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f67946d8e05dabf80d655ae9cb9ea05c4d885ed7","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    # NOTE(lucasagomes): To keep things simpler, let\u0027s reuse the same"},{"line_number":384,"context_line":"    # RUNDIR for both OVS and OVN. This way we avoid having to specify the"},{"line_number":385,"context_line":"    # --db option in the ovn-{n,s}bctl commands while playing with DevStack"},{"line_number":386,"context_line":"    sudo ln -s $OVS_RUNDIR $OVN_RUNDIR"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if [[ \"$OVN_BUILD_FROM_SOURCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":389,"context_line":"        # If OVS is already installed, remove it, because we\u0027re about to"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"37e39e90_1e219abf","line":386,"in_reply_to":"b2562209_5cc3173f","updated":"2020-12-19 17:52:15.000000000","message":"After some tests it seems that we need to have this link. IMO it\u0027s like that because ovn installed from package will use /var/run/ovn as RUNDIR so it should be there.","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":true,"context_lines":[{"line_number":383,"context_line":"    # NOTE(lucasagomes): To keep things simpler, let\u0027s reuse the same"},{"line_number":384,"context_line":"    # RUNDIR for both OVS and OVN. This way we avoid having to specify the"},{"line_number":385,"context_line":"    # --db option in the ovn-{n,s}bctl commands while playing with DevStack"},{"line_number":386,"context_line":"    sudo ln -s $OVS_RUNDIR $OVN_RUNDIR"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    if [[ \"$OVN_BUILD_FROM_SOURCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":389,"context_line":"        # If OVS is already installed, remove it, because we\u0027re about to"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"b2562209_5cc3173f","line":386,"in_reply_to":"badf74b7_e93e00cb","updated":"2020-12-17 16:18:29.000000000","message":"Lets try :)","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":404,"context_line":"    else"},{"line_number":405,"context_line":"        if [[ $os_VENDOR \u003d\u003d \"CentOS\" ]]; then"},{"line_number":406,"context_line":"            # OVN packages are part of this release for CentOS"},{"line_number":407,"context_line":"            yum_install centos-release-openstack-victoria"},{"line_number":408,"context_line":"        fi"},{"line_number":409,"context_line":"        install_package $(get_packages openvswitch)"},{"line_number":410,"context_line":"        install_package $(get_packages ovn)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"212d748f_0e150b07","line":407,"updated":"2020-12-14 11:47:19.000000000","message":"Since I\u0027m assuming that this may affect other services installing pkgs like qemu and libvirt, I\u0027d rather do this globally in tools/fixup_stuff.sh to make it visible.","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":false,"context_lines":[{"line_number":404,"context_line":"    else"},{"line_number":405,"context_line":"        if [[ $os_VENDOR \u003d\u003d \"CentOS\" ]]; then"},{"line_number":406,"context_line":"            # OVN packages are part of this release for CentOS"},{"line_number":407,"context_line":"            yum_install centos-release-openstack-victoria"},{"line_number":408,"context_line":"        fi"},{"line_number":409,"context_line":"        install_package $(get_packages openvswitch)"},{"line_number":410,"context_line":"        install_package $(get_packages ovn)"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"7c278421_7de2f60f","line":407,"in_reply_to":"212d748f_0e150b07","updated":"2020-12-17 16:18:29.000000000","message":"Done","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":411,"context_line":"    fi"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    # Ensure that the OVS commands are accessible in the PATH"},{"line_number":414,"context_line":"    OVS_BINDIR\u003d${OVS_BINDIR:-/usr/local/bin}"},{"line_number":415,"context_line":"    export PATH\u003d$OVS_BINDIR:$PATH"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"1b17ac0d_d27d05c8","line":414,"updated":"2020-12-14 11:47:19.000000000","message":"This seems no longer necessary when OVS_BINDIR is already always defined in the header.","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":false,"context_lines":[{"line_number":411,"context_line":"    fi"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    # Ensure that the OVS commands are accessible in the PATH"},{"line_number":414,"context_line":"    OVS_BINDIR\u003d${OVS_BINDIR:-/usr/local/bin}"},{"line_number":415,"context_line":"    export PATH\u003d$OVS_BINDIR:$PATH"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"b6b63925_b0994ec5","line":414,"in_reply_to":"1b17ac0d_d27d05c8","updated":"2020-12-17 16:18:29.000000000","message":"Done","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"cbba162b564fb19913b1f54510a4376a64c6bf79","unresolved":true,"context_lines":[{"line_number":414,"context_line":"    OVS_BINDIR\u003d${OVS_BINDIR:-/usr/local/bin}"},{"line_number":415,"context_line":"    export PATH\u003d$OVS_BINDIR:$PATH"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/openvswitch"},{"line_number":418,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/openvswitch"},{"line_number":419,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/ovn"},{"line_number":420,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/ovn"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    # Archive log files and create new"},{"line_number":423,"context_line":"    local log_archive_dir\u003d$LOGDIR/archive"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff695d2_f5d61948","line":420,"range":{"start_line":417,"start_character":4,"end_line":420,"end_character":48},"updated":"2020-12-14 11:47:19.000000000","message":"Is this still correct? Looks to me like it would also only be needed when installing from source.","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb56fed2d160f87f78c161b0960002ff2ce87c99","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    OVS_BINDIR\u003d${OVS_BINDIR:-/usr/local/bin}"},{"line_number":415,"context_line":"    export PATH\u003d$OVS_BINDIR:$PATH"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/openvswitch"},{"line_number":418,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/openvswitch"},{"line_number":419,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/ovn"},{"line_number":420,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/ovn"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    # Archive log files and create new"},{"line_number":423,"context_line":"    local log_archive_dir\u003d$LOGDIR/archive"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"cc5849b2_830977c5","line":420,"range":{"start_line":417,"start_character":4,"end_line":420,"end_character":48},"in_reply_to":"5ff695d2_f5d61948","updated":"2020-12-17 16:18:29.000000000","message":"Done","commit_id":"2bc7c74599b1301442d8a97a57fc20338a245380"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"aca3ae7928b2cd8fc3f7e092a23bab1be0d769fd","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-bridge\u003d\"br-int\""},{"line_number":626,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-type\u003d\"geneve\""},{"line_number":627,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-ip\u003d\"$HOST_IP\""},{"line_number":628,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:hostname\u003d\"$LOCAL_HOSTNAME\""},{"line_number":629,"context_line":"        # Select this chassis to host gateway routers"},{"line_number":630,"context_line":"        if [[ \"$ENABLE_CHASSIS_AS_GW\" \u003d\u003d \"True\" ]]; then"},{"line_number":631,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"7bfa5f7d_ebca2e61","line":628,"range":{"start_line":628,"start_character":8,"end_line":628,"end_character":91},"updated":"2021-01-08 21:42:15.000000000","message":"hmm.. setting hostname has implications. It means that OVN will require the \nport[\u0027binding:host_id\u0027] attribute to match the $LOCAL_HOSTNAME \nIn my devstack environment, that was not the case and I had to manually set it\nin order to make it work.\nsudo ovs-vsctl set Open_vSwitch . external-ids:hostname\u003d${the_vaule_in_binding_host_id}","commit_id":"e651d9ef8840bb7dd497b557125ce1cd5290993d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0f3d196f683994ecd297a289835c7ca8e9d97457","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-bridge\u003d\"br-int\""},{"line_number":626,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-type\u003d\"geneve\""},{"line_number":627,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-ip\u003d\"$HOST_IP\""},{"line_number":628,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:hostname\u003d\"$LOCAL_HOSTNAME\""},{"line_number":629,"context_line":"        # Select this chassis to host gateway routers"},{"line_number":630,"context_line":"        if [[ \"$ENABLE_CHASSIS_AS_GW\" \u003d\u003d \"True\" ]]; then"},{"line_number":631,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"b423b3bd_436fba07","line":628,"range":{"start_line":628,"start_character":8,"end_line":628,"end_character":91},"in_reply_to":"6edcc77e_b429ef0a","updated":"2021-01-11 10:38:57.000000000","message":"Thanks for reporting Flavio.\n\nI will need to investigate the issue, the hostname was added there to make sure that it would match with the VM\u0027s hostname so it\u0027s strange that it\u0027s differing on some setups. I tested this code locally and it also runs on the gate now for all OVN jobs which seems happy, so something is off.\n\nI will investigate the problem, maybe as Radoslaw suggested, we could get rid of this line ? OVN should figure out the hostname I believe.","commit_id":"e651d9ef8840bb7dd497b557125ce1cd5290993d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b0bc35c0252152b744f12a634b82ceb13d04a9c4","unresolved":true,"context_lines":[{"line_number":625,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-bridge\u003d\"br-int\""},{"line_number":626,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-type\u003d\"geneve\""},{"line_number":627,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-ip\u003d\"$HOST_IP\""},{"line_number":628,"context_line":"        sudo ovs-vsctl --no-wait set open_vswitch . external-ids:hostname\u003d\"$LOCAL_HOSTNAME\""},{"line_number":629,"context_line":"        # Select this chassis to host gateway routers"},{"line_number":630,"context_line":"        if [[ \"$ENABLE_CHASSIS_AS_GW\" \u003d\u003d \"True\" ]]; then"},{"line_number":631,"context_line":"            sudo ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"6edcc77e_b429ef0a","line":628,"range":{"start_line":628,"start_character":8,"end_line":628,"end_character":91},"in_reply_to":"7bfa5f7d_ebca2e61","updated":"2021-01-09 08:59:55.000000000","message":"Please propose a fix. Would we be fine without setting this at all?","commit_id":"e651d9ef8840bb7dd497b557125ce1cd5290993d"}]}