)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9847214f79b760707b6073bfcb1986047f0861e0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure Cinder backup driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new environment variable, CINDER_BACKUP_DRIVER for"},{"line_number":10,"context_line":"configuring cinder backup driver. This gets cinder backup driver"},{"line_number":11,"context_line":"configurable with a similar pattern to cinder backends."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"32167b8e_a2dc9549","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2021-02-11 22:15:44.000000000","message":":nit: Maybe this is too obvious but if I\u0027m understanding this correctly we still need to use the current config : \u0027enable_service c-bak\u0027 and we are extending this old configuration. I think the commit msg might specify this.","commit_id":"d6d6e87d5f9ec582c82e2b7f561d97e4c353f5c6"}],"lib/cinder":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec15165471e1c25cd52b6ef0bf9940a4f72868f0","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Source the backup driver"},{"line_number":128,"context_line":"if is_service_enabled c-bak \u0026\u0026 [[ -n \"$CINDER_BACKUP_DRIVER\" ]]; then"},{"line_number":129,"context_line":"    if [[ -r $CINDER_BACKUPS/$CINDER_BACKUP_DRIVER ]]; then"},{"line_number":130,"context_line":"        source $CINDER_BACKUPS/$CINDER_BACKUP_DRIVER"},{"line_number":131,"context_line":"    fi"},{"line_number":132,"context_line":"fi"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Environment variables to configure the image-volume cache"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"b680b488_9d3ef8da","line":131,"range":{"start_line":129,"start_character":4,"end_line":131,"end_character":6},"updated":"2021-02-20 15:22:48.000000000","message":"I am pretty sure we want to FAIL this if the file is missing.","commit_id":"d6d6e87d5f9ec582c82e2b7f561d97e4c353f5c6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec15165471e1c25cd52b6ef0bf9940a4f72868f0","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        configure_cinder_image_volume_cache"},{"line_number":291,"context_line":"    fi"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    if is_service_enabled c-bak; then"},{"line_number":294,"context_line":"        if type configure_cinder_backup_$CINDER_BACKUP_DRIVER \u003e/dev/null 2\u003e\u00261; then"},{"line_number":295,"context_line":"            configure_cinder_backup_$CINDER_BACKUP_DRIVER"},{"line_number":296,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"06365dc4_df9fbdbd","line":293,"updated":"2021-02-20 15:22:48.000000000","message":"\u0026\u0026 [[ -n \"$CINDER_BACKUP_DRIVER\" ]];","commit_id":"d6d6e87d5f9ec582c82e2b7f561d97e4c353f5c6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ec15165471e1c25cd52b6ef0bf9940a4f72868f0","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    fi"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    if is_service_enabled c-bak; then"},{"line_number":294,"context_line":"        if type configure_cinder_backup_$CINDER_BACKUP_DRIVER \u003e/dev/null 2\u003e\u00261; then"},{"line_number":295,"context_line":"            configure_cinder_backup_$CINDER_BACKUP_DRIVER"},{"line_number":296,"context_line":"        fi"},{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    if is_service_enabled ceilometer; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff6c5535_173922f4","line":296,"range":{"start_line":294,"start_character":8,"end_line":296,"end_character":10},"updated":"2021-02-20 15:22:48.000000000","message":"I am pretty sure we want to FAIL this if the `configure_...` function is not present.","commit_id":"d6d6e87d5f9ec582c82e2b7f561d97e4c353f5c6"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01177e6268376c5f9d2d2b5ed1e5760113668745","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ -n \"$CINDER_BACKUP_DRIVER\" ]]; then"},{"line_number":213,"context_line":"        if type cleanup_cinder_backup_$CINDER_BACKUP_DRIVER \u003e/dev/null 2\u003e\u00261; then"},{"line_number":214,"context_line":"            cleanup_cinder_backup_$CINDER_BACKUP_DRIVER"},{"line_number":215,"context_line":"        fi"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"c8d83670_a8adc223","line":214,"range":{"start_line":214,"start_character":9,"end_line":214,"end_character":55},"updated":"2021-03-31 14:23:50.000000000","message":"none of proposed driver have this cleanup implemented, is this for future drivers or a TODO for existing driver also?","commit_id":"1a9fcc0203161f20ac05c59b8c8a6b1de13167c9"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ec7bb4e797f1b0d355de78464bdbcaf1620e1338","unresolved":true,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    if is_service_enabled c-bak \u0026\u0026 [[ -n \"$CINDER_BACKUP_DRIVER\" ]]; then"},{"line_number":213,"context_line":"        if type cleanup_cinder_backup_$CINDER_BACKUP_DRIVER \u003e/dev/null 2\u003e\u00261; then"},{"line_number":214,"context_line":"            cleanup_cinder_backup_$CINDER_BACKUP_DRIVER"},{"line_number":215,"context_line":"        fi"},{"line_number":216,"context_line":"    fi"},{"line_number":217,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0d4244a6_37bc1d7a","line":214,"range":{"start_line":214,"start_character":9,"end_line":214,"end_character":55},"in_reply_to":"c8d83670_a8adc223","updated":"2021-03-31 14:31:39.000000000","message":"I\u0027ll let the author comment, but I suspect it\u0027s for consistency with the original cinder driver code.","commit_id":"1a9fcc0203161f20ac05c59b8c8a6b1de13167c9"}],"lib/cinder_backends/ceph":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01177e6268376c5f9d2d2b5ed1e5760113668745","unresolved":true,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#   CINDER_ENABLED_BACKENDS+\u003d,ceph:ceph"},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"# Optional parameters:"},{"line_number":11,"context_line":"#   CINDER_BAK_CEPH_POOL\u003d\u003cpool-name\u003e"},{"line_number":12,"context_line":"#   CINDER_BAK_CEPH_USER\u003d\u003cuser\u003e"},{"line_number":13,"context_line":"#   CINDER_BAK_CEPH_POOL_PG\u003d\u003cpg-num\u003e"},{"line_number":14,"context_line":"#   CINDER_BAK_CEPH_POOL_PGP\u003d\u003cpgp-num\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Dependencies:"},{"line_number":17,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"c2849581_3456f2b6","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":38},"updated":"2021-03-31 14:23:50.000000000","message":"these can be removed now.","commit_id":"1a9fcc0203161f20ac05c59b8c8a6b1de13167c9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"01177e6268376c5f9d2d2b5ed1e5760113668745","unresolved":true,"context_lines":[{"line_number":29,"context_line":"# Defaults"},{"line_number":30,"context_line":"# --------"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CINDER_BAK_CEPH_POOL\u003d${CINDER_BAK_CEPH_POOL:-backups}"},{"line_number":33,"context_line":"CINDER_BAK_CEPH_POOL_PG\u003d${CINDER_BAK_CEPH_POOL_PG:-8}"},{"line_number":34,"context_line":"CINDER_BAK_CEPH_POOL_PGP\u003d${CINDER_BAK_CEPH_POOL_PGP:-8}"},{"line_number":35,"context_line":"CINDER_BAK_CEPH_USER\u003d${CINDER_BAK_CEPH_USER:-cinder-bak}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Entry Points"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"d1c4bd6c_caa630d2","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":56},"updated":"2021-03-31 14:23:50.000000000","message":"these can be removed now.","commit_id":"1a9fcc0203161f20ac05c59b8c8a6b1de13167c9"}],"lib/cinder_backups/s3_swift":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"44f9386570198f3b2b9e85ce7a2780fbd89a4a9a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"# Save trace setting"},{"line_number":19,"context_line":"_XTRACE_CINDER_S3_SWIFT\u003d$(set +o | grep xtrace)"},{"line_number":20,"context_line":"set +o xtrace"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function configure_cinder_backup_s3_swift {"},{"line_number":23,"context_line":"    # This configuration requires swift and s3api. If we\u0027re"},{"line_number":24,"context_line":"    # on a subnode we might not know if they are enabled"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ad95a5dd_afa07e91","line":21,"updated":"2021-04-07 14:39:42.000000000","message":"nit: missing line","commit_id":"01a84d2d03cd871fb8734d5fdc9d149b9487e3e4"}],"lib/cinder_backups/swift":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"31aa4ca90f68ddb9f43a34a0b7d41a893589b472","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#!/bin/bash"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# lib/cinder_backups/swift"},{"line_number":6,"context_line":"# Configure the swift backup driver"}],"source_content_type":"text/x-swift","patch_set":3,"id":"c4a7e5b9_c18b74cd","line":3,"updated":"2021-01-22 22:52:45.000000000","message":"Delete this line at next patch set.","commit_id":"cf029944bd387348ebc48ef8ffcdc9c3bb4ca091"}]}