)]}'
{"lib/glance":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"620bd9af1c74480bc61ccb036e339302fc3cb3e7","unresolved":true,"context_lines":[{"line_number":469,"context_line":"# glance_remote_conf() - Return the path to an alternate config file for"},{"line_number":470,"context_line":"#                        the remote glance clone"},{"line_number":471,"context_line":"function glance_remote_conf {"},{"line_number":472,"context_line":"    echo \"$(dirname ${GLANCE_CONF_DIR})/glance-remote/\"$(basename \"$1\")"},{"line_number":473,"context_line":"}"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# start_glance_remote_clone() - Clone the regular glance api worker"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5aad03aa_99d5ba8b","line":472,"range":{"start_line":472,"start_character":40,"end_line":472,"end_character":53},"updated":"2021-03-01 18:01:27.000000000","message":"Any idea why it is not listed here;\nhttps://c2a8c1c0accec3a02a7a-113583a261d5263a5b6ce1f9bce81c2f.ssl.cf5.rackcdn.com/770629/6/check/tempest-integrated-storage-import/0d607ca/controller/logs/etc/index.html","commit_id":"2a1a6668782afca189049d9f20f31f0bb1645837"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7b9a34397132c9b20f559328ffe67c8f9fec8449","unresolved":true,"context_lines":[{"line_number":469,"context_line":"# glance_remote_conf() - Return the path to an alternate config file for"},{"line_number":470,"context_line":"#                        the remote glance clone"},{"line_number":471,"context_line":"function glance_remote_conf {"},{"line_number":472,"context_line":"    echo \"$(dirname ${GLANCE_CONF_DIR})/glance-remote/\"$(basename \"$1\")"},{"line_number":473,"context_line":"}"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# start_glance_remote_clone() - Clone the regular glance api worker"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"4d4bec24_fc3453f1","line":472,"range":{"start_line":472,"start_character":40,"end_line":472,"end_character":53},"in_reply_to":"5aad03aa_99d5ba8b","updated":"2021-03-01 18:10:29.000000000","message":"Yeah, I need to add a thing to the zuul job definition to make sure it gets collected. I think we can do it here in devstack as well, but since this is a very niche config, it might be better to just do it in our job definition.","commit_id":"2a1a6668782afca189049d9f20f31f0bb1645837"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"84d1a50a51c5ae6a6cf14651f8a0b0c039510d7e","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        run_process g-api \"$GLANCE_BIN_DIR/glance-api --config-dir\u003d$GLANCE_CONF_DIR\""},{"line_number":542,"context_line":"    fi"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    if [[ \"$GLANCE_ENABLE_REMOTE_WORKER\" \u003d\u003d True ]]; then"},{"line_number":545,"context_line":"        enable_service g-api-r"},{"line_number":546,"context_line":"        echo \"Starting the g-api-r clone service...\""},{"line_number":547,"context_line":"        start_glance_remote_clone"},{"line_number":548,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"e12c76b9_6ac29f41","line":545,"range":{"start_line":544,"start_character":0,"end_line":545,"end_character":30},"updated":"2021-03-03 22:51:06.000000000","message":"instead if another global variable and enable it, let\u0027s check if g-api-r is enabled directly and job can add g-api-r in devstack services directly. \n\n    if is_service_enabled g-api-r; then\n        echo \"Starting the g-api-r clone service...\"\n        start_glance_remote_clone\n    fi","commit_id":"2a1a6668782afca189049d9f20f31f0bb1645837"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"72b0a5afbdec1a852e9319ef764a7c32535c792c","unresolved":false,"context_lines":[{"line_number":541,"context_line":"        run_process g-api \"$GLANCE_BIN_DIR/glance-api --config-dir\u003d$GLANCE_CONF_DIR\""},{"line_number":542,"context_line":"    fi"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    if [[ \"$GLANCE_ENABLE_REMOTE_WORKER\" \u003d\u003d True ]]; then"},{"line_number":545,"context_line":"        enable_service g-api-r"},{"line_number":546,"context_line":"        echo \"Starting the g-api-r clone service...\""},{"line_number":547,"context_line":"        start_glance_remote_clone"},{"line_number":548,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"b5e25cae_2d940b84","line":545,"range":{"start_line":544,"start_character":0,"end_line":545,"end_character":30},"in_reply_to":"e12c76b9_6ac29f41","updated":"2021-03-03 22:54:39.000000000","message":"Ack","commit_id":"2a1a6668782afca189049d9f20f31f0bb1645837"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"900476cf8e2f51f7a3791962ce8091d2ce82d921","unresolved":true,"context_lines":[{"line_number":505,"context_line":"    # We need to create the systemd service for the clone, but then"},{"line_number":506,"context_line":"    # change it to include an Environment line to point the WSGI app"},{"line_number":507,"context_line":"    # at the alternate config directory."},{"line_number":508,"context_line":"    # NOTE(danms): iniset is broken when the value has an \u0027\u003d\u0027 character"},{"line_number":509,"context_line":"    # in it, so we can\u0027t use that here."},{"line_number":510,"context_line":"    run_process g-api-r \"$(which uwsgi) --procname-prefix glance-api-remote --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\""},{"line_number":511,"context_line":"    sudo sed -ri \"s#^(RestartForce.*)#\\1\\nEnvironment\u003dOS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir#\" \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"c0b887d5_6fb2dae5","line":508,"updated":"2021-03-09 00:45:00.000000000","message":"I don\u0027t think this is true ... although it\u0027s not covered explicitly by the unit tests (updated with [1]).  If there\u0027s a problem I\u0027d prefer to fix it.\n\n[1] https://review.opendev.org/c/openstack/devstack/+/779408","commit_id":"8cddaac11f306af864aede0ef02a5cd713232c6d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b6a92540cbc2f54d01979f81e76e609b06d96126","unresolved":true,"context_lines":[{"line_number":505,"context_line":"    # We need to create the systemd service for the clone, but then"},{"line_number":506,"context_line":"    # change it to include an Environment line to point the WSGI app"},{"line_number":507,"context_line":"    # at the alternate config directory."},{"line_number":508,"context_line":"    # NOTE(danms): iniset is broken when the value has an \u0027\u003d\u0027 character"},{"line_number":509,"context_line":"    # in it, so we can\u0027t use that here."},{"line_number":510,"context_line":"    run_process g-api-r \"$(which uwsgi) --procname-prefix glance-api-remote --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\""},{"line_number":511,"context_line":"    sudo sed -ri \"s#^(RestartForce.*)#\\1\\nEnvironment\u003dOS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir#\" \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7431a096_8a86310e","line":508,"in_reply_to":"80510ce2_725e93c4","updated":"2021-03-09 02:09:00.000000000","message":"I\u0027m trying to iterate on converting back to the helpers for iniset and the unit file writing and I\u0027m not poking what I remember (ISTR it was an awk error that assumed only one equal sign per line or something). Obviously I didn\u0027t just shortcut straight to this _and_ put a note as the easy way out, but karma seems to want to make a liar out of me. So, I dunno what that was, but I\u0027m sure it was something. However, things changed from that original PoC enough that maybe I won\u0027t trip over it.","commit_id":"8cddaac11f306af864aede0ef02a5cd713232c6d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7fdc46c9114e12dbf4dba89c6e962be004fd3006","unresolved":true,"context_lines":[{"line_number":505,"context_line":"    # We need to create the systemd service for the clone, but then"},{"line_number":506,"context_line":"    # change it to include an Environment line to point the WSGI app"},{"line_number":507,"context_line":"    # at the alternate config directory."},{"line_number":508,"context_line":"    # NOTE(danms): iniset is broken when the value has an \u0027\u003d\u0027 character"},{"line_number":509,"context_line":"    # in it, so we can\u0027t use that here."},{"line_number":510,"context_line":"    run_process g-api-r \"$(which uwsgi) --procname-prefix glance-api-remote --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\""},{"line_number":511,"context_line":"    sudo sed -ri \"s#^(RestartForce.*)#\\1\\nEnvironment\u003dOS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir#\" \\"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"80510ce2_725e93c4","line":508,"in_reply_to":"c0b887d5_6fb2dae5","updated":"2021-03-09 01:03:13.000000000","message":"This has been sitting for so long, I forget the details, but I wrestled with using the right tools for the job for a while and decided to just hack this in. Agree it\u0027s a hack, but the iniset stuff didn\u0027t look super serviceable to me. If you fix it, that\u0027s cool with me.","commit_id":"8cddaac11f306af864aede0ef02a5cd713232c6d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"900476cf8e2f51f7a3791962ce8091d2ce82d921","unresolved":true,"context_lines":[{"line_number":509,"context_line":"    # in it, so we can\u0027t use that here."},{"line_number":510,"context_line":"    run_process g-api-r \"$(which uwsgi) --procname-prefix glance-api-remote --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\""},{"line_number":511,"context_line":"    sudo sed -ri \"s#^(RestartForce.*)#\\1\\nEnvironment\u003dOS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir#\" \\"},{"line_number":512,"context_line":"         \"${SYSTEMD_DIR}/devstack@g-api-r.service\""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    # Be gentle, as we can race to kill uwsgi with its own startup, which"},{"line_number":515,"context_line":"    # will cause systemctl to hang for a long time before failing."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"a87142e5_c4689bfe","line":512,"updated":"2021-03-09 00:45:00.000000000","message":"I feel like we have write_user_unit_file which is probably more appropriate here.  It won\u0027t actually start the service which can be done separately, and avoid the unreliability of the stop/start mentioned below.","commit_id":"8cddaac11f306af864aede0ef02a5cd713232c6d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7fdc46c9114e12dbf4dba89c6e962be004fd3006","unresolved":true,"context_lines":[{"line_number":509,"context_line":"    # in it, so we can\u0027t use that here."},{"line_number":510,"context_line":"    run_process g-api-r \"$(which uwsgi) --procname-prefix glance-api-remote --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\""},{"line_number":511,"context_line":"    sudo sed -ri \"s#^(RestartForce.*)#\\1\\nEnvironment\u003dOS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir#\" \\"},{"line_number":512,"context_line":"         \"${SYSTEMD_DIR}/devstack@g-api-r.service\""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"    # Be gentle, as we can race to kill uwsgi with its own startup, which"},{"line_number":515,"context_line":"    # will cause systemctl to hang for a long time before failing."}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"45a39aeb_33e61439","line":512,"in_reply_to":"a87142e5_c4689bfe","updated":"2021-03-09 01:03:13.000000000","message":"Do you mean write_uwsgi_user_unit_file? It doesn\u0027t take extra (although it could be made to obviously) but I was hacking around the iniset problem so it didn\u0027t matter anyway.","commit_id":"8cddaac11f306af864aede0ef02a5cd713232c6d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"472396155b5f37b1ecdfd1597e1ca83e4a8f32e7","unresolved":true,"context_lines":[{"line_number":131,"context_line":"# runs that a clean run would need to clean up"},{"line_number":132,"context_line":"function cleanup_glance {"},{"line_number":133,"context_line":"    # delete image files (glance)"},{"line_number":134,"context_line":"    sudo rm -rf $GLANCE_CACHE_DIR $GLANCE_IMAGE_DIR $(glance_remote_conf \u0027\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # Cleanup multiple stores directories"},{"line_number":137,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"d55067bb_a4e09060","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":76},"updated":"2021-03-09 16:35:51.000000000","message":"I thought this is config dir, not image files dir; I think you wanted to remove subdirs of ${DATA_DIR}/glance-remote","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3311e2f044ff925979b6993cadb740cd50568d17","unresolved":true,"context_lines":[{"line_number":131,"context_line":"# runs that a clean run would need to clean up"},{"line_number":132,"context_line":"function cleanup_glance {"},{"line_number":133,"context_line":"    # delete image files (glance)"},{"line_number":134,"context_line":"    sudo rm -rf $GLANCE_CACHE_DIR $GLANCE_IMAGE_DIR $(glance_remote_conf \u0027\u0027)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    # Cleanup multiple stores directories"},{"line_number":137,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"45687cbe_9fbd9b3f","line":134,"range":{"start_line":134,"start_character":51,"end_line":134,"end_character":76},"in_reply_to":"d55067bb_a4e09060","updated":"2021-03-09 16:40:24.000000000","message":"I actually thought I wanted to do both, but I guess we don\u0027t remove the conf for the base one either.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":468,"context_line":"# glance_remote_conf() - Return the path to an alternate config file for"},{"line_number":469,"context_line":"#                        the remote glance clone"},{"line_number":470,"context_line":"function glance_remote_conf {"},{"line_number":471,"context_line":"    echo \"$(dirname ${GLANCE_CONF_DIR})/glance-remote/\"$(basename \"$1\")"},{"line_number":472,"context_line":"}"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"# start_glance_remote_clone() - Clone the regular glance api worker"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9a34894d_cdc0e0fc","line":471,"range":{"start_line":471,"start_character":9,"end_line":471,"end_character":55},"updated":"2021-03-09 12:09:19.000000000","message":"I don\u0027t understand why only this section is quoted, that doesn\u0027t make sense to me. echo will echo embedded spaces unchanged.\n\nYou may want to use \"${GLANCE_CONF_DIR}\" though in order to avoid issues when that dir name might contain spaces.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":"# start_glance_remote_clone() - Clone the regular glance api worker"},{"line_number":475,"context_line":"function start_glance_remote_clone {"},{"line_number":476,"context_line":"    local glance_remote_conf glance_remote_port"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    glance_remote_conf_dir\u003d$(glance_remote_conf \u0027\u0027)"},{"line_number":479,"context_line":"    glance_remote_port\u003d$(get_random_port)"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"2b229589_0113f1ec","line":476,"range":{"start_line":476,"start_character":10,"end_line":476,"end_character":28},"updated":"2021-03-09 12:09:19.000000000","message":"_dir","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":475,"context_line":"function start_glance_remote_clone {"},{"line_number":476,"context_line":"    local glance_remote_conf glance_remote_port"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    glance_remote_conf_dir\u003d$(glance_remote_conf \u0027\u0027)"},{"line_number":479,"context_line":"    glance_remote_port\u003d$(get_random_port)"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"    # Clone the existing ready-to-go glance-api setup"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"cd844f0a_4568e70c","line":478,"range":{"start_line":478,"start_character":48,"end_line":478,"end_character":50},"updated":"2021-03-09 12:09:19.000000000","message":"Style nit: I\u0027d usually use \"\" here. Also the whole $() might need quoting in case the directory name contains spaces.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":481,"context_line":"    # Clone the existing ready-to-go glance-api setup"},{"line_number":482,"context_line":"    sudo rm -Rf $glance_remote_conf_dir"},{"line_number":483,"context_line":"    sudo cp -r \"$GLANCE_CONF_DIR\" $glance_remote_conf_dir"},{"line_number":484,"context_line":"    sudo chown $STACK_USER -R $glance_remote_conf_dir"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    # Point this worker at different data dirs"},{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"bad387e8_a10e7f34","line":484,"updated":"2021-03-09 12:09:19.000000000","message":"The target should also be quoted in these three commands.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":484,"context_line":"    sudo chown $STACK_USER -R $glance_remote_conf_dir"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"    # Point this worker at different data dirs"},{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"61f3cbc1_62cc2b6a","line":487,"updated":"2021-03-09 12:09:19.000000000","message":"declare as local?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7b492c2a_789b6869","line":490,"range":{"start_line":490,"start_character":32,"end_line":490,"end_character":49},"updated":"2021-03-09 12:09:19.000000000","message":"I don\u0027t see a need to quote this.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"472396155b5f37b1ecdfd1597e1ca83e4a8f32e7","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"90575009_c090bf18","line":490,"range":{"start_line":490,"start_character":32,"end_line":490,"end_character":49},"in_reply_to":"7b492c2a_789b6869","updated":"2021-03-09 16:35:51.000000000","message":"Perhaps because it was meant to be \"$GLANCE_API_CONF\"","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3311e2f044ff925979b6993cadb740cd50568d17","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"c4b5880e_56adee37","line":490,"range":{"start_line":490,"start_character":32,"end_line":490,"end_character":49},"in_reply_to":"90575009_c090bf18","updated":"2021-03-09 16:40:24.000000000","message":"No, it wasn\u0027t. GLANCE_API_CONF is the full path, I just want the short name here.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"680fe07402f2a7939491a9719b25d33f55a272f8","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"6e51836c_d3945b7e","line":490,"range":{"start_line":490,"start_character":32,"end_line":490,"end_character":49},"in_reply_to":"9b4d8e74_a8d42b97","updated":"2021-03-09 16:56:05.000000000","message":"The helper basenames the argument so either will work. I think my mental workflow here made this look a little more clear, but understand that I\u0027m not consistent and that\u0027s probably worse.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2ab8317c1b2a42bf93150ef2e13962e8ecb84975","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    remote_data\u003d\"${DATA_DIR}/glance-remote\""},{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"9b4d8e74_a8d42b97","line":490,"range":{"start_line":490,"start_character":32,"end_line":490,"end_character":49},"in_reply_to":"c4b5880e_56adee37","updated":"2021-03-09 16:47:56.000000000","message":"Then I am confused by L500.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":488,"context_line":"    mkdir -p $remote_data/os_glance_tasks_store \\"},{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"},{"line_number":494,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"506c5eb0_965dc91d","line":491,"range":{"start_line":491,"start_character":36,"end_line":491,"end_character":50},"updated":"2021-03-09 12:09:19.000000000","message":"enclose in \"\"?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":489,"context_line":"          $remote_data/os_glance_staging_store"},{"line_number":490,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_staging_store \\"},{"line_number":491,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_staging_store"},{"line_number":492,"context_line":"    iniset $(glance_remote_conf \u0027glance-api.conf\u0027) os_glance_tasks_store \\"},{"line_number":493,"context_line":"           filesystem_store_datadir ${remote_data}/os_glance_tasks_store"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    # Change our uwsgi to our new port"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"20ffeb70_83eb5d5b","line":492,"range":{"start_line":492,"start_character":32,"end_line":492,"end_character":49},"updated":"2021-03-09 12:09:19.000000000","message":"dito","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    # Change our uwsgi to our new port"},{"line_number":496,"context_line":"    sed -ri \"s/^(http-socket.*):[0-9]+/\\1:$glance_remote_port/\" \\"},{"line_number":497,"context_line":"        $(glance_remote_conf $GLANCE_UWSGI_CONF)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    # Update the self-reference url with our new port"},{"line_number":500,"context_line":"    iniset $(glance_remote_conf $GLANCE_API_CONF) DEFAULT \\"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"934f924b_8b00711e","line":497,"range":{"start_line":497,"start_character":8,"end_line":497,"end_character":48},"updated":"2021-03-09 12:09:19.000000000","message":"Use a local var for this instead of repeating the call multiple times?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"472396155b5f37b1ecdfd1597e1ca83e4a8f32e7","unresolved":true,"context_lines":[{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    # Change our uwsgi to our new port"},{"line_number":496,"context_line":"    sed -ri \"s/^(http-socket.*):[0-9]+/\\1:$glance_remote_port/\" \\"},{"line_number":497,"context_line":"        $(glance_remote_conf $GLANCE_UWSGI_CONF)"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"    # Update the self-reference url with our new port"},{"line_number":500,"context_line":"    iniset $(glance_remote_conf $GLANCE_API_CONF) DEFAULT \\"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7a35e348_66cd64b6","line":497,"range":{"start_line":497,"start_character":8,"end_line":497,"end_character":48},"in_reply_to":"934f924b_8b00711e","updated":"2021-03-09 16:35:51.000000000","message":"But do not mistake this with the one with $GLANCE_API_CONF","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":511,"context_line":"                               --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\" \\"},{"line_number":512,"context_line":"                               \"\" \"$STACK_USER\""},{"line_number":513,"context_line":"    iniset -sudo ${SYSTEMD_DIR}/devstack@g-api-r.service \\"},{"line_number":514,"context_line":"           \"Service\" \"Environment\" \"OS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir\""},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    # Reload and restart with the new config"},{"line_number":517,"context_line":"    $SYSTEMCTL daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"a4cda953_b2af5d57","line":514,"range":{"start_line":514,"start_character":11,"end_line":514,"end_character":34},"updated":"2021-03-09 12:09:19.000000000","message":"No need for quotes here, either?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f624348c6d10260196dc8fe6da26772ea8f44c3e","unresolved":true,"context_lines":[{"line_number":511,"context_line":"                               --ini $(glance_remote_conf $GLANCE_UWSGI_CONF)\" \\"},{"line_number":512,"context_line":"                               \"\" \"$STACK_USER\""},{"line_number":513,"context_line":"    iniset -sudo ${SYSTEMD_DIR}/devstack@g-api-r.service \\"},{"line_number":514,"context_line":"           \"Service\" \"Environment\" \"OS_GLANCE_CONFIG_DIR\u003d$glance_remote_conf_dir\""},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"    # Reload and restart with the new config"},{"line_number":517,"context_line":"    $SYSTEMCTL daemon-reload"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"cf6e9f40_1f2b5f2c","line":514,"range":{"start_line":514,"start_character":11,"end_line":514,"end_character":34},"in_reply_to":"a4cda953_b2af5d57","updated":"2021-03-09 15:45:39.000000000","message":"Was mirroring this style:\n\nhttps://github.com/openstack/devstack/blob/556f84aea90c572873fc9834292635b41e590224/functions-common#L1476-L1487\n\nwhich is what I was re-implementing here with the Environment tweak.\n\nIn my editor it makes things look a lot more uniform, so it seems harmless?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":517,"context_line":"    $SYSTEMCTL daemon-reload"},{"line_number":518,"context_line":"    $SYSTEMCTL restart devstack@g-api-r"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    get_or_create_service glance_remote image_remote \"Alternate glance\""},{"line_number":521,"context_line":"    get_or_create_endpoint image_remote $REGION_NAME \\"},{"line_number":522,"context_line":"                $(awk \u0027-F\u003d \u0027 \u0027/^http-socket/ { print \"http://\"$2 }\u0027 \\"},{"line_number":523,"context_line":"                    $(glance_remote_conf $GLANCE_UWSGI_CONF))"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"d4ead46e_0ef956c6","line":520,"range":{"start_line":520,"start_character":54,"end_line":520,"end_character":70},"updated":"2021-03-09 12:09:19.000000000","message":"Call this \"glance-remote\" to match the devstack function name?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5bd0eeafea3a31b95b6e2f4b342d557bc6076740","unresolved":true,"context_lines":[{"line_number":517,"context_line":"    $SYSTEMCTL daemon-reload"},{"line_number":518,"context_line":"    $SYSTEMCTL restart devstack@g-api-r"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    get_or_create_service glance_remote image_remote \"Alternate glance\""},{"line_number":521,"context_line":"    get_or_create_endpoint image_remote $REGION_NAME \\"},{"line_number":522,"context_line":"                $(awk \u0027-F\u003d \u0027 \u0027/^http-socket/ { print \"http://\"$2 }\u0027 \\"},{"line_number":523,"context_line":"                    $(glance_remote_conf $GLANCE_UWSGI_CONF))"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"8a18a442_5bd421ac","line":520,"range":{"start_line":520,"start_character":54,"end_line":520,"end_character":70},"in_reply_to":"d4ead46e_0ef956c6","updated":"2021-03-09 14:39:31.000000000","message":"It\u0027s called alternate in tempest, which is what I was going for in terms of consistency.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        run_process g-api \"$GLANCE_BIN_DIR/glance-api --config-dir\u003d$GLANCE_CONF_DIR\""},{"line_number":539,"context_line":"    fi"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    if is_service_enabled g-api-r; then"},{"line_number":542,"context_line":"        echo \"Starting the g-api-r clone service...\""},{"line_number":543,"context_line":"        start_glance_remote_clone"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"169e5fe5_ddb04d64","line":541,"range":{"start_line":541,"start_character":26,"end_line":541,"end_character":33},"updated":"2021-03-09 12:09:19.000000000","message":"Use \"g-api-remote\" to be easier understandable?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5bd0eeafea3a31b95b6e2f4b342d557bc6076740","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        run_process g-api \"$GLANCE_BIN_DIR/glance-api --config-dir\u003d$GLANCE_CONF_DIR\""},{"line_number":539,"context_line":"    fi"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    if is_service_enabled g-api-r; then"},{"line_number":542,"context_line":"        echo \"Starting the g-api-r clone service...\""},{"line_number":543,"context_line":"        start_glance_remote_clone"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"f5a397b0_d94bdb12","line":541,"range":{"start_line":541,"start_character":26,"end_line":541,"end_character":33},"in_reply_to":"169e5fe5_ddb04d64","updated":"2021-03-09 14:39:31.000000000","message":"I\u0027ve typed this a couple hundred million times while working on this and would much prefer the abbreviation. Almost nobody will have this enabled, and it seems like it\u0027s in line with us being pretty short in all these names (n-cond, q-agt, etc). If it\u0027s critical I can change it, but I also have to change the patches that depend on this.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"472396155b5f37b1ecdfd1597e1ca83e4a8f32e7","unresolved":true,"context_lines":[{"line_number":538,"context_line":"        run_process g-api \"$GLANCE_BIN_DIR/glance-api --config-dir\u003d$GLANCE_CONF_DIR\""},{"line_number":539,"context_line":"    fi"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"    if is_service_enabled g-api-r; then"},{"line_number":542,"context_line":"        echo \"Starting the g-api-r clone service...\""},{"line_number":543,"context_line":"        start_glance_remote_clone"},{"line_number":544,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5972a37e_7055d6dd","line":541,"range":{"start_line":541,"start_character":26,"end_line":541,"end_character":33},"in_reply_to":"f5a397b0_d94bdb12","updated":"2021-03-09 16:35:51.000000000","message":"I agree with Dan on this.","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"}],"lib/tempest":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d0522385ed02e54afa5e653f1b7a8113f9703931","unresolved":true,"context_lines":[{"line_number":352,"context_line":"    fi"},{"line_number":353,"context_line":"    iniset $TEMPEST_CONFIG image-feature-enabled import_image $GLANCE_USE_IMPORT_WORKFLOW"},{"line_number":354,"context_line":"    iniset $TEMPEST_CONFIG image-feature-enabled os_glance_reserved True"},{"line_number":355,"context_line":"    if [[ \"$GLANCE_ENABLE_REMOTE_WORKER\" \u003d\u003d True ]]; then"},{"line_number":356,"context_line":"        iniset $TEMPEST_CONFIG image-feature-enabled alternate_image_endpoint \\"},{"line_number":357,"context_line":"               \"image_remote\""},{"line_number":358,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"88e3195b_3fa20ce8","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":57},"updated":"2021-03-03 22:59:15.000000000","message":"here also need change\n\n if is_service_enabled g-api-r; then","commit_id":"691a1a201983c787762a7c294cb9eac6a27e1642"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f9abd3c77326888753584efc3f8e150ffcd4876c","unresolved":true,"context_lines":[{"line_number":354,"context_line":"    iniset $TEMPEST_CONFIG image-feature-enabled os_glance_reserved True"},{"line_number":355,"context_line":"    if is_service_enabled g-api-r; then"},{"line_number":356,"context_line":"        iniset $TEMPEST_CONFIG image alternate_image_endpoint \\"},{"line_number":357,"context_line":"               \"image_remote\""},{"line_number":358,"context_line":"    fi"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    # Compute"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"b9112d91_9a52229a","line":357,"range":{"start_line":357,"start_character":15,"end_line":357,"end_character":29},"updated":"2021-03-09 12:09:19.000000000","message":"No need for quotes?","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"472396155b5f37b1ecdfd1597e1ca83e4a8f32e7","unresolved":true,"context_lines":[{"line_number":354,"context_line":"    iniset $TEMPEST_CONFIG image-feature-enabled os_glance_reserved True"},{"line_number":355,"context_line":"    if is_service_enabled g-api-r; then"},{"line_number":356,"context_line":"        iniset $TEMPEST_CONFIG image alternate_image_endpoint \\"},{"line_number":357,"context_line":"               \"image_remote\""},{"line_number":358,"context_line":"    fi"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    # Compute"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"a045455f_bc621d7a","line":357,"range":{"start_line":357,"start_character":15,"end_line":357,"end_character":29},"in_reply_to":"b9112d91_9a52229a","updated":"2021-03-09 16:35:51.000000000","message":"++ but this is nit","commit_id":"802259a49656170108dd79559166ad89c49e2ef7"}]}