)]}'
{"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3737bd2ef709003104918dcf8e78959326059c31","unresolved":true,"context_lines":[{"line_number":412,"context_line":"        install_package $(get_packages ovn)"},{"line_number":413,"context_line":"        if is_fedora; then"},{"line_number":414,"context_line":"            # Erase the pre-set configurations from packages. DevStack"},{"line_number":415,"context_line":"            # will configure OVS and OVN accordingly for its use."},{"line_number":416,"context_line":"            sudo truncate -s 0 /etc/openvswitch/default.conf"},{"line_number":417,"context_line":"            sudo truncate -s 0 /run/openvswitch.useropts"},{"line_number":418,"context_line":"            sudo truncate -s 0 /etc/sysconfig/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ce1d7b4e_e3876dc2","line":415,"updated":"2021-02-24 12:12:58.000000000","message":"Why do you need to do that here immediately instead of waiting until devstack configures those things properly?","commit_id":"4be4275ec36ab842028d937c93c3c8f3910f0c0d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2d2d27b2eef62db2948ecd44ce8d6461601a6450","unresolved":true,"context_lines":[{"line_number":412,"context_line":"        install_package $(get_packages ovn)"},{"line_number":413,"context_line":"        if is_fedora; then"},{"line_number":414,"context_line":"            # Erase the pre-set configurations from packages. DevStack"},{"line_number":415,"context_line":"            # will configure OVS and OVN accordingly for its use."},{"line_number":416,"context_line":"            sudo truncate -s 0 /etc/openvswitch/default.conf"},{"line_number":417,"context_line":"            sudo truncate -s 0 /run/openvswitch.useropts"},{"line_number":418,"context_line":"            sudo truncate -s 0 /etc/sysconfig/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9db447a4_0be29f5c","line":415,"in_reply_to":"ce1d7b4e_e3876dc2","updated":"2021-02-24 13:19:51.000000000","message":"The only reason I added it here is because this code should only run when OVN/OVS is installed from packages so I thought doing it right after it\u0027s installed, in the same conditional.\n\nI will move it to the configure part then.","commit_id":"4be4275ec36ab842028d937c93c3c8f3910f0c0d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3737bd2ef709003104918dcf8e78959326059c31","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # Erase the pre-set configurations from packages. DevStack"},{"line_number":415,"context_line":"            # will configure OVS and OVN accordingly for its use."},{"line_number":416,"context_line":"            sudo truncate -s 0 /etc/openvswitch/default.conf"},{"line_number":417,"context_line":"            sudo truncate -s 0 /run/openvswitch.useropts"},{"line_number":418,"context_line":"            sudo truncate -s 0 /etc/sysconfig/openvswitch"},{"line_number":419,"context_line":"            sudo truncate -s 0 /etc/sysconfig/ovn"},{"line_number":420,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8e3f446b_d1b3402e","line":417,"updated":"2021-02-24 12:12:58.000000000","message":"This is a tmpfs, what will happen when the node gets rebooted? (Not happening in CI, but a likely scenario for some local developer).","commit_id":"4be4275ec36ab842028d937c93c3c8f3910f0c0d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2d2d27b2eef62db2948ecd44ce8d6461601a6450","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # Erase the pre-set configurations from packages. DevStack"},{"line_number":415,"context_line":"            # will configure OVS and OVN accordingly for its use."},{"line_number":416,"context_line":"            sudo truncate -s 0 /etc/openvswitch/default.conf"},{"line_number":417,"context_line":"            sudo truncate -s 0 /run/openvswitch.useropts"},{"line_number":418,"context_line":"            sudo truncate -s 0 /etc/sysconfig/openvswitch"},{"line_number":419,"context_line":"            sudo truncate -s 0 /etc/sysconfig/ovn"},{"line_number":420,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9e21c4d9_4ee5f107","line":417,"in_reply_to":"8e3f446b_d1b3402e","updated":"2021-02-24 13:19:51.000000000","message":"I will test it, but I just checked all the potential places where the configuration could be presented and trucated then. Perhaps we do not need this /run/openvswitch.useropts file, I added to be on the safe-side.\n\nBut I will test it now and see what happens when the node is rebooted","commit_id":"4be4275ec36ab842028d937c93c3c8f3910f0c0d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"424351a1db860634caad5b12fddb04333245cf0f","unresolved":true,"context_lines":[{"line_number":414,"context_line":"            # Erase the pre-set configurations from packages. DevStack"},{"line_number":415,"context_line":"            # will configure OVS and OVN accordingly for its use."},{"line_number":416,"context_line":"            sudo truncate -s 0 /etc/openvswitch/default.conf"},{"line_number":417,"context_line":"            sudo truncate -s 0 /run/openvswitch.useropts"},{"line_number":418,"context_line":"            sudo truncate -s 0 /etc/sysconfig/openvswitch"},{"line_number":419,"context_line":"            sudo truncate -s 0 /etc/sysconfig/ovn"},{"line_number":420,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3525cc0c_56f0d143","line":417,"in_reply_to":"9e21c4d9_4ee5f107","updated":"2021-02-24 13:39:59.000000000","message":"Just tested it, this can be removed. I added because it was part of .service file for ovsdb-server, but it\u0027s not shipped during the installation.\n\nEnvironmentFile\u003d-/run/openvswitch.useropts","commit_id":"4be4275ec36ab842028d937c93c3c8f3910f0c0d"}]}