)]}'
{"lib/swift":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"abf8ca9f3e66cff05fdaa909904ca732c7235c53","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    # rsyncd.conf just prepared for 4 nodes"},{"line_number":302,"context_line":"    if is_ubuntu; then"},{"line_number":303,"context_line":"        sudo sed -i \u0027/^RSYNC_ENABLE\u003dfalse/ { s/false/true/ }\u0027 /etc/default/rsync"},{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2FxfU%3D","line":304,"updated":"2014-02-28 11:42:34.000000000","message":"drop the else","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"abf8ca9f3e66cff05fdaa909904ca732c7235c53","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    if is_ubuntu; then"},{"line_number":303,"context_line":"        sudo sed -i \u0027/^RSYNC_ENABLE\u003dfalse/ { s/false/true/ }\u0027 /etc/default/rsync"},{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"},{"line_number":308,"context_line":"            cat \u003c\u003cEOF | sudo tee /etc/xinetd.d/rsync"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2FxeY%3D","line":305,"updated":"2014-02-28 11:42:34.000000000","message":"bring this up one level, because it\u0027s orthoginal to is_ubuntu, it\u0027s really, if this file exists, then turn on rsync.","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"73348fb8541e43492869af6fcb3472797f0b2777","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"},{"line_number":308,"context_line":"            cat \u003c\u003cEOF | sudo tee /etc/xinetd.d/rsync"},{"line_number":309,"context_line":"service rsync"},{"line_number":310,"context_line":"{"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2Fx1c%3D","line":307,"updated":"2014-02-28 10:40:46.000000000","message":"I don\u0027t understand why we want the else. How did we get in a situation with xinetd \u0026 rsync where there wasn\u0027t a starting template?","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"95c5d976c9a61cca73b92e9830dc36439df99a87","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"},{"line_number":308,"context_line":"            cat \u003c\u003cEOF | sudo tee /etc/xinetd.d/rsync"},{"line_number":309,"context_line":"service rsync"},{"line_number":310,"context_line":"{"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2FxxI%3D","line":307,"in_reply_to":"AAAAVX%2F%2Fx1c%3D","updated":"2014-02-28 10:52:44.000000000","message":"For example on Fedora you have  rsyncd service installed by \u0027rsync\u0027 package, but neither the xinetd or rsync package contains an /etc/xinetd.d/rsync.\n\nJust by editing the original file is safer on distros where this file exists.","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"abf8ca9f3e66cff05fdaa909904ca732c7235c53","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"},{"line_number":308,"context_line":"            cat \u003c\u003cEOF | sudo tee /etc/xinetd.d/rsync"},{"line_number":309,"context_line":"service rsync"},{"line_number":310,"context_line":"{"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2Fxds%3D","line":307,"in_reply_to":"AAAAVX%2F%2Fxk0%3D","updated":"2014-02-28 11:42:34.000000000","message":"Then here, don\u0027t use xinetd.d. Have some if is_fedora (whatever version). \"systemctl enable rsyncd \u0026\u0026 systemctl start rsyncd\"","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"170dd06d1f1828f1bf471d96995320cf6a167606","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    else"},{"line_number":305,"context_line":"        if [ -e /etc/xinetd.d/rsync ]; then"},{"line_number":306,"context_line":"            sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":307,"context_line":"        else"},{"line_number":308,"context_line":"            cat \u003c\u003cEOF | sudo tee /etc/xinetd.d/rsync"},{"line_number":309,"context_line":"service rsync"},{"line_number":310,"context_line":"{"}],"source_content_type":"text/x-swift","patch_set":1,"id":"AAAAVX%2F%2Fxk0%3D","line":307,"in_reply_to":"AAAAVX%2F%2FxxI%3D","updated":"2014-02-28 11:29:18.000000000","message":"On Fedora rsync is a socket activated systemd service and there isn\u0027t xinetd !\nJust do \"systemctl enable rsyncd \u0026\u0026 systemctl start rsyncd\" on Fedora","commit_id":"0130d978de8dd22227e802bdc031422644658729"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"9bdfb205b3963226d8ff2ade407e1b33bae699f4","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    # rsyncd.conf just prepared for 4 nodes"},{"line_number":302,"context_line":"    if is_ubuntu; then"},{"line_number":303,"context_line":"        sudo sed -i \u0027/^RSYNC_ENABLE\u003dfalse/ { s/false/true/ }\u0027 /etc/default/rsync"},{"line_number":304,"context_line":"    elif ! (is_fedora \u0026\u0026 [[ $DISTRO \u003d~ (rhel6) ]]); then"},{"line_number":305,"context_line":"        sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":306,"context_line":"    fi"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-swift","patch_set":2,"id":"AAAAVX%2F%2FxRk%3D","line":304,"updated":"2014-02-28 12:08:14.000000000","message":"wrong condition.","commit_id":"f983800e8dfafd2348adb2ebffaece892f76df11"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f287eb972597bd855f1390d56b1419a29e5f61de","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    # rsyncd.conf just prepared for 4 nodes"},{"line_number":302,"context_line":"    if is_ubuntu; then"},{"line_number":303,"context_line":"        sudo sed -i \u0027/^RSYNC_ENABLE\u003dfalse/ { s/false/true/ }\u0027 /etc/default/rsync"},{"line_number":304,"context_line":"    elif ! (is_fedora \u0026\u0026 ! [[ $DISTRO \u003d~ (rhel6) ]]); then"},{"line_number":305,"context_line":"        sudo sed -i \u0027/disable *\u003d *yes/ { s/yes/no/ }\u0027 /etc/xinetd.d/rsync"},{"line_number":306,"context_line":"    fi"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-swift","patch_set":3,"id":"AAAAVX%2F%2Fvro%3D","line":304,"updated":"2014-02-28 16:02:24.000000000","message":"please just do a detection for existince on /etc/xinetd.d/rsync instead. As suse might have that as well.","commit_id":"bf1fd8aca56f69e60d0e86d26ae79dde73f26ade"}]}