)]}'
{"stack.sh":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42159b793b6a8a1a2984aa1ff7747c796b337ed8","unresolved":true,"context_lines":[{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"async_wait configure_neutron_nova"},{"line_number":1254,"context_line":""},{"line_number":1255,"context_line":"# Launch the nova-api and wait for it to answer before continuing"},{"line_number":1256,"context_line":"if is_service_enabled n-api; then"},{"line_number":1257,"context_line":"    echo_summary \"Starting Nova API\""},{"line_number":1258,"context_line":"    async_runfunc start_nova_api"}],"source_content_type":"text/x-sh","patch_set":5,"id":"517a9c9f_ed896564","line":1255,"updated":"2021-02-10 16:44:06.000000000","message":"nit: Guess the \u0027continuing\u0027 part belong to the async_wait below","commit_id":"22a48edb2d946f1469e2dc3030cbb4026359d870"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42159b793b6a8a1a2984aa1ff7747c796b337ed8","unresolved":true,"context_lines":[{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"if is_service_enabled ovn-controller ovn-controller-vtep; then"},{"line_number":1262,"context_line":"    echo_summary \"Starting OVN services\""},{"line_number":1263,"context_line":"    async_runfunc start_ovn_services"},{"line_number":1264,"context_line":"fi"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"# Start placement before any of the service that are likely to want"}],"source_content_type":"text/x-sh","patch_set":5,"id":"d695dc9e_327ec1ca","line":1263,"updated":"2021-02-10 16:44:06.000000000","message":"I would get Lucas\u0027 opinion on doing this.","commit_id":"22a48edb2d946f1469e2dc3030cbb4026359d870"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4be60e452b307fad2068140973486235d258ab7","unresolved":true,"context_lines":[{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"if is_service_enabled ovn-controller ovn-controller-vtep; then"},{"line_number":1262,"context_line":"    echo_summary \"Starting OVN services\""},{"line_number":1263,"context_line":"    async_runfunc start_ovn_services"},{"line_number":1264,"context_line":"fi"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"# Start placement before any of the service that are likely to want"}],"source_content_type":"text/x-sh","patch_set":5,"id":"4f8a7603_3b1077bc","line":1263,"in_reply_to":"80f43155_76bc9a68","updated":"2021-02-11 10:15:11.000000000","message":"Hi,\n\nThanks Brian and Dan.\n\nDan, I think you are correct here, this needs to be up and running before we attempt to create the initial networks. \n\nThe ML2/OVN driver will wait for the OVN services to start in case Neutron is started first (L1283) but, I believe any request coming at that time will fail as the OVN database connection won\u0027t be initialized.\n\nThe idea of refactoring the code to have a start_neutron_stuff() method which we can run async should work better.","commit_id":"22a48edb2d946f1469e2dc3030cbb4026359d870"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a548fdbcbe1ca3af0241732d03737f210d67b533","unresolved":true,"context_lines":[{"line_number":1260,"context_line":""},{"line_number":1261,"context_line":"if is_service_enabled ovn-controller ovn-controller-vtep; then"},{"line_number":1262,"context_line":"    echo_summary \"Starting OVN services\""},{"line_number":1263,"context_line":"    async_runfunc start_ovn_services"},{"line_number":1264,"context_line":"fi"},{"line_number":1265,"context_line":""},{"line_number":1266,"context_line":"# Start placement before any of the service that are likely to want"}],"source_content_type":"text/x-sh","patch_set":5,"id":"80f43155_76bc9a68","line":1263,"in_reply_to":"d695dc9e_327ec1ca","updated":"2021-02-10 17:07:58.000000000","message":"Yeah, please. I was originally async\u0027ing the neutron startup as well and stopped because we need it to be up before the network creation on L1291 anyway. So it\u0027s quite possible that I should have just removed this async as well.\n\nI think probably what would be good is to move all of this to a start_neutron_stuff() function and just async_runfunc that. I\u0027m not sure that the logic and separation need to be exposed in stack.sh at this layer anyway, and doing so would let those things happen in serial as needed, while we do other things here like starting nova and placement.","commit_id":"22a48edb2d946f1469e2dc3030cbb4026359d870"}]}