)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b16b10adf76de9a5edde727d2dfead24e4c58da","unresolved":true,"context_lines":[{"line_number":11,"context_line":"to create what we need. If we are backing glance with cinder, we"},{"line_number":12,"context_line":"should increase the volumes quota, which this patch does (to 50 from"},{"line_number":13,"context_line":"a default of 10)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2ad1c4d21f996ee1a9ce29ba4f1a4b8f5720f8fb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f7dc024_fd16af38","line":14,"updated":"2021-02-05 14:41:08.000000000","message":"should we also add a Closes-Bug: #1914665 to mention it fixes a gate job?","commit_id":"c27ad3d66363856fb0c161769f48923a304a79b0"}],"lib/cinder":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"55c178ea97d1bab12ea0b00dfe8f7b49c1cfb621","unresolved":true,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"},{"line_number":547,"context_line":"    fi"},{"line_number":548,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"585ab7ed_481e6f0e","line":545,"range":{"start_line":545,"start_character":12,"end_line":545,"end_character":66},"updated":"2021-02-05 14:27:51.000000000","message":"Since service is the default project for glance cinder devstack runs[1], makes sense to increase its quota\n[1] https://opendev.org/openstack/devstack/src/branch/master/lib/glance#L180","commit_id":"c27ad3d66363856fb0c161769f48923a304a79b0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8bee463cc67dc2104898fd1b03d8a80028d0b6f0","unresolved":true,"context_lines":[{"line_number":540,"context_line":"            fi"},{"line_number":541,"context_line":"        done"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"4b2cf7be_6b5af7c6","line":543,"updated":"2021-02-05 15:17:56.000000000","message":"Wouldn\u0027t this rather belong into lib/glance than here?","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"90a44a72660af5de634b55fd6089c889c3474570","unresolved":true,"context_lines":[{"line_number":540,"context_line":"            fi"},{"line_number":541,"context_line":"        done"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"458e49a2_0018f798","line":543,"in_reply_to":"4b2cf7be_6b5af7c6","updated":"2021-02-05 15:30:08.000000000","message":"Well, this needs to happen when the cinder API is up is being poked for runtime config (which is here). The lib/glance module itself doesn\u0027t seem to poke cinder anywhere, and doesn\u0027t really have any equivalent \"do this once all the APIs are up\" function, other than the uploading of the image.\n\nIf you think this is important enough to add a new toplevel function in lib/glance and call that from stack.sh I can surely do that, but it seems like a lot of overhead.\n\nThis function is, in spirit, \"configure the runtime stuff in cinder so other services can use it\" which makes this fit well here.","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8bee463cc67dc2104898fd1b03d8a80028d0b6f0","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        done"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"},{"line_number":547,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"802c8dfa_8e72a2ab","line":544,"updated":"2021-02-05 15:17:56.000000000","message":"IMO this is redundant","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"90a44a72660af5de634b55fd6089c889c3474570","unresolved":true,"context_lines":[{"line_number":541,"context_line":"        done"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"},{"line_number":547,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fe14955b_78cf12cc","line":544,"in_reply_to":"802c8dfa_8e72a2ab","updated":"2021-02-05 15:30:08.000000000","message":"Ack, sorry, I was doing this to make it easy to spot that it was happening from the logs, but doesn\u0027t need to be here.","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8bee463cc67dc2104898fd1b03d8a80028d0b6f0","unresolved":true,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"},{"line_number":547,"context_line":"    fi"},{"line_number":548,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ee22da4c_e3c6d7c4","line":545,"updated":"2021-02-05 15:17:56.000000000","message":"I think you should set the region here like for the other OSC calls above.\nAlso put $SERVICE_PROJECT_NAME into quotes to be on the safe side.","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"90a44a72660af5de634b55fd6089c889c3474570","unresolved":true,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":544,"context_line":"            echo Increasing volumes quota for $SERVICE_PROJECT_NAME to 50"},{"line_number":545,"context_line":"            openstack quota set --volumes 50 $SERVICE_PROJECT_NAME"},{"line_number":546,"context_line":"        fi"},{"line_number":547,"context_line":"    fi"},{"line_number":548,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b4e736ab_fdb7b0df","line":545,"in_reply_to":"ee22da4c_e3c6d7c4","updated":"2021-02-05 15:30:08.000000000","message":"Okay, I can\u0027t say that I understand why they\u0027re doing that, and figured it might have to do with some other multi-region multi-backend support that I don\u0027t understand.\n\nIf you\u0027re saying I just need to add \"--os-region-name\u003d$REGION_NAME\" then I\u0027ll believe you and do it :)","commit_id":"c22ea2aeac1fe6173cb32202a3b2933e3fbf08ee"}]}