)]}'
{"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3fbd3404ec8b7e1f87e941fefa9c40a4f7e8c73","unresolved":true,"context_lines":[{"line_number":624,"context_line":"        (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e $tmp_u_c_m"},{"line_number":625,"context_line":"    else"},{"line_number":626,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":627,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":630,"context_line":"    rm -f $tmp_u_c_m"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"56e8ea24_9db7ef34","line":627,"updated":"2021-02-15 10:38:27.000000000","message":"UPPER_CONSTRAINTS_FILE is deprecated in favor of TOX_CONSTRAINTS_FILE\n\nAlso this looks wrong, wouldn\u0027t you want to set UPPER_CONSTRAINTS_FILE\u003d$tmp_u_c_m instead?","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53be7c9b9a6e7d61cb38b6f25e512940fc26911b","unresolved":true,"context_lines":[{"line_number":624,"context_line":"        (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e $tmp_u_c_m"},{"line_number":625,"context_line":"    else"},{"line_number":626,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":627,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":630,"context_line":"    rm -f $tmp_u_c_m"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"883e9bd5_6a250d41","line":627,"in_reply_to":"56e8ea24_9db7ef34","updated":"2021-02-16 14:59:18.000000000","message":"Tempest still use UPPER_CONSTRAINTS_FILE and switching to new one is challenging as old var is used in many place. let me set both which can help Tempest to move to TOX_CONSTRAINTS_FILE\n- https://github.com/openstack/tempest/blob/d141295f3e1f5b75618e3028f23519ee61749f52/tox.ini#L14\n\nfor 2nd comment, either one work both are same value, I can add UPPER_CONSTRAINTS_FILE\u003d$tmp_u_c_m too for keeping it consistent.","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"567abf505715c902330dd6602ce5c83b3226b4a4","unresolved":true,"context_lines":[{"line_number":624,"context_line":"        (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e $tmp_u_c_m"},{"line_number":625,"context_line":"    else"},{"line_number":626,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":627,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":628,"context_line":"    fi"},{"line_number":629,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":630,"context_line":"    rm -f $tmp_u_c_m"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d86f8091_ae26053e","line":627,"in_reply_to":"883e9bd5_6a250d41","updated":"2021-02-18 16:42:30.000000000","message":"ah we cannot set UPPER_CONSTRAINTS_FILE\u003d$tmp_u_c_m as tmp_u_c_m  is removed at L630 but  UPPER_CONSTRAINTS_FILE is referred later also in run-tempest etc","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3fbd3404ec8b7e1f87e941fefa9c40a4f7e8c73","unresolved":true,"context_lines":[{"line_number":714,"context_line":"    else"},{"line_number":715,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":716,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":717,"context_line":"    fi"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    tox -r --notest -efull"},{"line_number":720,"context_line":"    # TODO: remove the trailing pip constraint when a proper fix"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"01bab830_261b3a76","line":717,"updated":"2021-02-15 10:38:27.000000000","message":"Why does this need to be done twice? Would make sense to put it into a utility function then. Also setting UPPER_CONSTRAINTS_FILE will conflict with what you did above.","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53be7c9b9a6e7d61cb38b6f25e512940fc26911b","unresolved":true,"context_lines":[{"line_number":714,"context_line":"    else"},{"line_number":715,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":716,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":717,"context_line":"    fi"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    tox -r --notest -efull"},{"line_number":720,"context_line":"    # TODO: remove the trailing pip constraint when a proper fix"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"d1532fd5_4d98c325","line":717,"in_reply_to":"01bab830_261b3a76","updated":"2021-02-16 14:59:18.000000000","message":"this is first time tempest virtual env is created so we need to set it here too. As i mentioned above, tempest venv is being recreated many times and tox will recreate it if it constraints mismatch.","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"30a675ea69d577a1daec7a241573b1a509c33b1c","unresolved":true,"context_lines":[{"line_number":626,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":627,"context_line":"        # NOTE: setting both tox env var and once Tempest start using new var"},{"line_number":628,"context_line":"        # TOX_CONSTRAINTS_FILE then we can remove the old one."},{"line_number":629,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":630,"context_line":"        export TOX_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":631,"context_line":"    fi"},{"line_number":632,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":633,"context_line":"    rm -f $tmp_u_c_m"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"eb885dcf_d5314c05","line":630,"range":{"start_line":629,"start_character":0,"end_line":630,"end_character":67},"updated":"2021-02-20 10:44:37.000000000","message":"This leaks too much. Why do we have two ways to control the constraints anyhow? (And I mean via the command below and environment vars, not that we have two env vars).\n\nAlso, it would make more sense to refactor this code as it is used 3 times...","commit_id":"3639f724ade69f0601057b243041c49d17affa2d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ad1e877521f80f17b77405f49657cb0363e8de3","unresolved":true,"context_lines":[{"line_number":626,"context_line":"        cat $TEMPEST_VENV_UPPER_CONSTRAINTS \u003e $tmp_u_c_m"},{"line_number":627,"context_line":"        # NOTE: setting both tox env var and once Tempest start using new var"},{"line_number":628,"context_line":"        # TOX_CONSTRAINTS_FILE then we can remove the old one."},{"line_number":629,"context_line":"        export UPPER_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":630,"context_line":"        export TOX_CONSTRAINTS_FILE\u003d$TEMPEST_VENV_UPPER_CONSTRAINTS"},{"line_number":631,"context_line":"    fi"},{"line_number":632,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":633,"context_line":"    rm -f $tmp_u_c_m"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"564d9b19_753310ba","line":630,"range":{"start_line":629,"start_character":0,"end_line":630,"end_character":67},"in_reply_to":"eb885dcf_d5314c05","updated":"2021-02-20 17:15:39.000000000","message":"we need to set env var also as tempest tox env is recreated many times in devstack and tempest run workflow. after devstack create and install tempest and plugins, run-tempest role run the test in that venv and use those env var as constraints - vhttps://github.com/openstack/tempest/blob/2dd2879a2b315eb497d53d21f4d2b2fdb9c43ad6/roles/run-tempest/tasks/main.yaml#L31\n\nIf both constraints first used by devstack during tempest and tempest plugins and second used by run-tempest differ then tox recreate the venv and it end up removing all the installed tempest plugins. So we have to set constraints as well as tox env var.\n\nLet me add this in single method.","commit_id":"3639f724ade69f0601057b243041c49d17affa2d"}],"stackrc":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a3fbd3404ec8b7e1f87e941fefa9c40a4f7e8c73","unresolved":true,"context_lines":[{"line_number":298,"context_line":"# Tempest test suite"},{"line_number":299,"context_line":"TEMPEST_REPO\u003d${TEMPEST_REPO:-${GIT_BASE}/openstack/tempest.git}"},{"line_number":300,"context_line":"TEMPEST_BRANCH\u003d${TEMPEST_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":301,"context_line":"TEMPEST_VENV_UPPER_CONSTRAINTS\u003d${TEMPEST_VENV_UPPER_CONSTRAINTS:-default}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"##############"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e6a0ab0d_b763ead2","line":301,"updated":"2021-02-15 10:38:27.000000000","message":"Why do you need to set this globally? Wouldn\u0027t setting it within lib/tempest be enough?\n\nAlso, why do you want to use \"default\" as special keyword? I\u0027d much rather keep the default empty and then simply test with -n/-z when needed.","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53be7c9b9a6e7d61cb38b6f25e512940fc26911b","unresolved":true,"context_lines":[{"line_number":298,"context_line":"# Tempest test suite"},{"line_number":299,"context_line":"TEMPEST_REPO\u003d${TEMPEST_REPO:-${GIT_BASE}/openstack/tempest.git}"},{"line_number":300,"context_line":"TEMPEST_BRANCH\u003d${TEMPEST_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":301,"context_line":"TEMPEST_VENV_UPPER_CONSTRAINTS\u003d${TEMPEST_VENV_UPPER_CONSTRAINTS:-default}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"##############"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"520229f4_a5facbbb","line":301,"in_reply_to":"e6a0ab0d_b763ead2","updated":"2021-02-16 14:59:18.000000000","message":"I would like to keep it with other things which is used for Tempest installation like TEMPEST_BRANCH etc. \n\nI can change \u0027default\u0027 to \u0027master\u0027 which will be more aligned as we need to use master constraints by default.","commit_id":"322f9729aa2449cd26843915c49a7c54def24488"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3a1b01a5c825b5894f23397b7a729d893876c95c","unresolved":true,"context_lines":[{"line_number":298,"context_line":"# Tempest test suite"},{"line_number":299,"context_line":"TEMPEST_REPO\u003d${TEMPEST_REPO:-${GIT_BASE}/openstack/tempest.git}"},{"line_number":300,"context_line":"TEMPEST_BRANCH\u003d${TEMPEST_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":301,"context_line":"TEMPEST_VENV_UPPER_CONSTRAINTS\u003d${TEMPEST_VENV_UPPER_CONSTRAINTS:-master}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"##############"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"c00e01e9_2e8c732d","line":301,"updated":"2021-03-08 23:13:23.000000000","message":"It strikes me as a bit weird that sometimes this is a reference to the branch of the requirements project (master) and sometimes a path to a separate file.\n\nHow is TEMPEST_VENV_UPPER_CONSTRAINTS to be set?  This will be a custom requirements file extracted for the used tempest version and kept in the devstack branch?\n\nIf feels like requirements.txt should come from the requirements project on the same branch as TEMPEST_BRANCH?","commit_id":"3bdc8f66ad243f7487ba494e6a71f63c4965413a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f941641b22b3532867510ee3a67fc7ad3605060d","unresolved":true,"context_lines":[{"line_number":298,"context_line":"# Tempest test suite"},{"line_number":299,"context_line":"TEMPEST_REPO\u003d${TEMPEST_REPO:-${GIT_BASE}/openstack/tempest.git}"},{"line_number":300,"context_line":"TEMPEST_BRANCH\u003d${TEMPEST_BRANCH:-$BRANCHLESS_TARGET_BRANCH}"},{"line_number":301,"context_line":"TEMPEST_VENV_UPPER_CONSTRAINTS\u003d${TEMPEST_VENV_UPPER_CONSTRAINTS:-master}"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"##############"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"15284d33_21aa87a4","line":301,"in_reply_to":"c00e01e9_2e8c732d","updated":"2021-03-08 23:19:49.000000000","message":"It depends on what Tempest tag we use for stable testing. Due to the Tempest branchless nature, Tempest master support all supported branch and once stable branch move to Extended Maintenance state then we cut the Tempest tag ans use that for EM stable testing. for example, for stable/stein testing we use Tempest 26.0.0 so for that we need to use stable constraints (stable/stein to stable victoria constraints this is what Tempest 26.0.0 supported).\n\nLike this https://review.opendev.org/c/openstack/devstack/+/775052/6/stackrc#320\n\nOther example where job can define it is stable/train py2.7 jobs - https://review.opendev.org/c/openstack/networking-generic-switch/+/773335/13/zuul.d/networking-generic-switch-jobs.yaml#78\n\nBasically constraints will be master by default and as soon as we start using the old Tempest we keep adding the compatible constraints in TEMPEST_VENV_UPPER_CONSTRAINTS","commit_id":"3bdc8f66ad243f7487ba494e6a71f63c4965413a"}]}