)]}'
{".zuul.yaml":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"3eadc1cb087ec56bcafacf9beea78d033486919e","unresolved":true,"context_lines":[{"line_number":584,"context_line":"    voting: false"},{"line_number":585,"context_line":"    timeout: 9000"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"- job:"},{"line_number":588,"context_line":"    name: devstack-platform-bionic"},{"line_number":589,"context_line":"    parent: tempest-full-py3"},{"line_number":590,"context_line":"    description: Ubuntu Bionic platform test"},{"line_number":591,"context_line":"    nodeset: openstack-single-node-bionic"},{"line_number":592,"context_line":"    voting: false"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"- job:"},{"line_number":595,"context_line":"    name: devstack-async"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"73da003f_d0888e8d","line":592,"range":{"start_line":587,"start_character":0,"end_line":592,"end_character":17},"updated":"2021-03-10 13:22:28.000000000","message":"I think we need to pin this to tgtadm.","commit_id":"e6d697cd6946e5d89b06257383b95d555bda3ee8"}],"lib/cinder":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"93ad9b09ad39f49f6d14ae2d05c752de3476bc07","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"},{"line_number":91,"context_line":"# although the tgt bits are in EPEL and OpenSUSE we don\u0027t want that for CI"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"    if [[ ${CINDER_ISCSI_HELPER} !\u003d \"lioadm\" ]]; then"},{"line_number":95,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d09796bc_0531b7b7","line":92,"updated":"2021-03-09 22:47:32.000000000","message":"But this would break the tgt job we have in cinder-tempest-plugin:\nhttps://opendev.org/openstack/cinder-tempest-plugin/src/branch/master/.zuul.yaml","commit_id":"44ad5fdf2e9448b3864ff6d0fd1b6a1bbc431f75"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"99a700212ac846db1e02c3d849337de37ac21318","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"},{"line_number":91,"context_line":"# although the tgt bits are in EPEL and OpenSUSE we don\u0027t want that for CI"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"    if [[ ${CINDER_ISCSI_HELPER} !\u003d \"lioadm\" ]]; then"},{"line_number":95,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d73a129d_30c65cea","line":92,"in_reply_to":"a13d0b37_53de2611","updated":"2021-03-10 09:37:25.000000000","message":"Ie9ca822f53abf90052ddfae52852b8b78c910ece should handle these tgtadm specific jobs. Let me know if there are anymore!","commit_id":"44ad5fdf2e9448b3864ff6d0fd1b6a1bbc431f75"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c7633bfd9ac759dd6d4ece071fe85cf0c06c3fce","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"},{"line_number":91,"context_line":"# although the tgt bits are in EPEL and OpenSUSE we don\u0027t want that for CI"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"    if [[ ${CINDER_ISCSI_HELPER} !\u003d \"lioadm\" ]]; then"},{"line_number":95,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c08de51b_cab1c075","line":92,"in_reply_to":"a13d0b37_53de2611","updated":"2021-03-10 09:38:57.000000000","message":"The current logic says:\n if this is fedora (and centos/rhel), suse or ubuntu, then a) set the value of CINDER_ISCSI_HELPER to lioadm, and b) errors out if CINDER_ISCSI_HELPER is not lioadm (see line 94).\n\nPlease refactor the condition on line 94 so that it doens\u0027t apply on ubuntu, but it still applies on \"fedora\" and \"suse\", but not ubuntu.","commit_id":"44ad5fdf2e9448b3864ff6d0fd1b6a1bbc431f75"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"8643cd85eb0cfe3b9c0e7581b9220b52a2baf1b6","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"},{"line_number":91,"context_line":"# although the tgt bits are in EPEL and OpenSUSE we don\u0027t want that for CI"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"    if [[ ${CINDER_ISCSI_HELPER} !\u003d \"lioadm\" ]]; then"},{"line_number":95,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3112df4a_edb5499e","line":92,"in_reply_to":"c08de51b_cab1c075","updated":"2021-03-10 10:05:45.000000000","message":"Right apologies I\u0027ve extracted that in the next PS.","commit_id":"44ad5fdf2e9448b3864ff6d0fd1b6a1bbc431f75"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"cd011c1fa090a71a03a9c4a5caa8954e13f93821","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# Centos7 and OpenSUSE switched to using LIO and that\u0027s all that\u0027s supported,"},{"line_number":91,"context_line":"# although the tgt bits are in EPEL and OpenSUSE we don\u0027t want that for CI"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"    if [[ ${CINDER_ISCSI_HELPER} !\u003d \"lioadm\" ]]; then"},{"line_number":95,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a13d0b37_53de2611","line":92,"in_reply_to":"d09796bc_0531b7b7","updated":"2021-03-10 09:31:57.000000000","message":"It wouldn\u0027t break the job but yeah it would switch over to lioadm, I\u0027ll propose a change that this change can depend on ensuring the tgtadm jobs don\u0027t use lioadm.","commit_id":"44ad5fdf2e9448b3864ff6d0fd1b6a1bbc431f75"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9a555d1e27a18917f0ed64d112462f71297b4161","unresolved":true,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# lioadm is the default for EL, SUSE and Ubuntu based deployments, for anything"},{"line_number":91,"context_line":"# else continue to use tgtadm"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"else"},{"line_number":95,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-tgtadm}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9621b01a_b877ee8b","line":92,"updated":"2021-04-23 09:48:42.000000000","message":"I don\u0027t think that there is anything else we support, is there? So this would seem redundant as it is always true.","commit_id":"ec0ea80d194ebd09b9afa2b19d0797722642b11f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"11907b0701df7f05701e6f77d1903ebe1a9bebac","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# lioadm is the default for EL, SUSE and Ubuntu based deployments, for anything"},{"line_number":91,"context_line":"# else continue to use tgtadm"},{"line_number":92,"context_line":"if is_fedora || is_suse || is_ubuntu; then"},{"line_number":93,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-lioadm}"},{"line_number":94,"context_line":"else"},{"line_number":95,"context_line":"    CINDER_ISCSI_HELPER\u003d${CINDER_ISCSI_HELPER:-tgtadm}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"a2bc9bb8_ad46990e","line":92,"in_reply_to":"9621b01a_b877ee8b","updated":"2021-04-23 09:53:37.000000000","message":"ACK that\u0027s fair, I\u0027ll respin now thanks!","commit_id":"ec0ea80d194ebd09b9afa2b19d0797722642b11f"}]}