)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"771eec7b2163c481bef769004c0d78e340b11e9a","unresolved":true,"context_lines":[{"line_number":10,"context_line":"in ovn-uuid file, Devstack will first check if it is already"},{"line_number":11,"context_line":"generated and stored in /etc/openvswitch/system-id.conf file."},{"line_number":12,"context_line":"If it\u0027s not, it will generate it."},{"line_number":13,"context_line":"Finally this OVN_UUID value will now be storer in the"},{"line_number":14,"context_line":"/etc/openvswitch/system-id.conf file so it can be set to same value"},{"line_number":15,"context_line":"after openvswitch will be e.g. restarted."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e74486ae_8fe0fdbc","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":46},"updated":"2021-03-11 12:22:37.000000000","message":"stored","commit_id":"d0a4abc3758cbe2de750865ea63423901bc1883d"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b1aeb55e8987e0f3bf38d11d5464854ac7f1eff6","unresolved":true,"context_lines":[{"line_number":524,"context_line":"    if [ -z \"$OVN_UUID\" ] ; then"},{"line_number":525,"context_line":"        if [ -f ./ovn-uuid ] ; then"},{"line_number":526,"context_line":"            OVN_UUID\u003d$(cat ovn-uuid)"},{"line_number":527,"context_line":"        else"},{"line_number":528,"context_line":"            if [ -f $OVS_SYSCONFDIR/system-id.conf ]; then"},{"line_number":529,"context_line":"                OVN_UUID\u003d$(cat $OVS_SYSCONFDIR/system-id.conf)"},{"line_number":530,"context_line":"            else"},{"line_number":531,"context_line":"                OVN_UUID\u003d$(uuidgen)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"8f3883ae_89bd4f5a","line":528,"range":{"start_line":527,"start_character":8,"end_line":528,"end_character":14},"updated":"2021-03-11 12:20:42.000000000","message":"nit: you can use\n\n elif [ .. ]; then","commit_id":"d0a4abc3758cbe2de750865ea63423901bc1883d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"771eec7b2163c481bef769004c0d78e340b11e9a","unresolved":true,"context_lines":[{"line_number":533,"context_line":"            echo $OVN_UUID \u003e ovn-uuid"},{"line_number":534,"context_line":"        fi"},{"line_number":535,"context_line":"    fi"},{"line_number":536,"context_line":"    echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    # Metadata"},{"line_number":539,"context_line":"    if is_service_enabled q-ovn-metadata-agent \u0026\u0026 is_service_enabled ovn-controller; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b55961df_6a7d460e","line":536,"range":{"start_line":536,"start_character":0,"end_line":536,"end_character":1},"updated":"2021-03-11 12:22:37.000000000","message":"+1, when ovs-ctl is restarted, it will read the system-id from this file (that is the user defined one or a random one). This won\u0027t overwrite what is set in L629","commit_id":"d0a4abc3758cbe2de750865ea63423901bc1883d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b1c50c46f65e9f00f891f705218183b8d4fac4da","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    echo \"Configuring OVN\""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    if [ -z \"$OVN_UUID\" ] ; then"},{"line_number":525,"context_line":"        if [ -f ./ovn-uuid ] ; then"},{"line_number":526,"context_line":"            OVN_UUID\u003d$(cat ovn-uuid)"},{"line_number":527,"context_line":"        elif [ -f $OVS_SYSCONFDIR/system-id.conf ]; then"},{"line_number":528,"context_line":"            OVN_UUID\u003d$(cat $OVS_SYSCONFDIR/system-id.conf)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3d1fc90e_4ec28941","line":525,"updated":"2021-03-12 08:17:02.000000000","message":"Though not introduced with this patch, it seems to be a bug to use a relative path here. The result would change depending on what directory the stack.sh call is being executed from, wouldn\u0027t it?\n\nAlso, is this file still needed with this change? Or couldn\u0027t you simply always use $OVS_SYSCONFDIR/system-id.conf? That would make the logic much easier.","commit_id":"fd0a30d17039ae3967eab639bfd731e245f8007c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e48c209124f1996330ea933d47c1ed38420b1d0","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    echo \"Configuring OVN\""},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"    if [ -z \"$OVN_UUID\" ] ; then"},{"line_number":525,"context_line":"        if [ -f ./ovn-uuid ] ; then"},{"line_number":526,"context_line":"            OVN_UUID\u003d$(cat ovn-uuid)"},{"line_number":527,"context_line":"        elif [ -f $OVS_SYSCONFDIR/system-id.conf ]; then"},{"line_number":528,"context_line":"            OVN_UUID\u003d$(cat $OVS_SYSCONFDIR/system-id.conf)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0c609ddc_364bc4dd","line":525,"in_reply_to":"3d1fc90e_4ec28941","updated":"2021-03-12 09:14:59.000000000","message":"Done","commit_id":"fd0a30d17039ae3967eab639bfd731e245f8007c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b1c50c46f65e9f00f891f705218183b8d4fac4da","unresolved":true,"context_lines":[{"line_number":531,"context_line":"        fi"},{"line_number":532,"context_line":"        echo $OVN_UUID \u003e ovn-uuid"},{"line_number":533,"context_line":"    fi"},{"line_number":534,"context_line":"    echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    # Metadata"},{"line_number":537,"context_line":"    if is_service_enabled q-ovn-metadata-agent \u0026\u0026 is_service_enabled ovn-controller; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"0716281b_4627b095","line":534,"updated":"2021-03-12 08:17:02.000000000","message":"I don\u0027t like rewriting files with identical content on every iteration. Can you adopt the previous logic of only writing things that are new/changed?","commit_id":"fd0a30d17039ae3967eab639bfd731e245f8007c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1e48c209124f1996330ea933d47c1ed38420b1d0","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        fi"},{"line_number":532,"context_line":"        echo $OVN_UUID \u003e ovn-uuid"},{"line_number":533,"context_line":"    fi"},{"line_number":534,"context_line":"    echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"    # Metadata"},{"line_number":537,"context_line":"    if is_service_enabled q-ovn-metadata-agent \u0026\u0026 is_service_enabled ovn-controller; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"4f11de62_963a1c02","line":534,"in_reply_to":"0716281b_4627b095","updated":"2021-03-12 09:14:59.000000000","message":"Done","commit_id":"fd0a30d17039ae3967eab639bfd731e245f8007c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b806060503d2cd86a2c73cb567f1b70632045e34","unresolved":true,"context_lines":[{"line_number":68,"context_line":"# one will be generated.  A randomly generated UUID will be saved in a file"},{"line_number":69,"context_line":"# $OVS_SYSCONFDIR/system-id.conf (typically /etc/openvswitch/system-id.conf)"},{"line_number":70,"context_line":"# so that the same one will be re-used if you re-run DevStack or restart"},{"line_number":71,"context_line":"# Open vSwitch service"},{"line_number":72,"context_line":"OVN_UUID\u003d${OVN_UUID:-}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Whether or not to build the openvswitch kernel module from ovs.  This is required"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ee4c4127_77c1ac24","line":71,"updated":"2021-03-15 09:27:41.000000000","message":"nit: missing stop (dot)","commit_id":"26896d26d19c1b0fe068bd2b18d70c38c521ffc1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fea16f2cfa054f10c43ed23748f56d1846e4ae62","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# one will be generated.  A randomly generated UUID will be saved in a file"},{"line_number":69,"context_line":"# $OVS_SYSCONFDIR/system-id.conf (typically /etc/openvswitch/system-id.conf)"},{"line_number":70,"context_line":"# so that the same one will be re-used if you re-run DevStack or restart"},{"line_number":71,"context_line":"# Open vSwitch service"},{"line_number":72,"context_line":"OVN_UUID\u003d${OVN_UUID:-}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# Whether or not to build the openvswitch kernel module from ovs.  This is required"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"63be635f_b2c2b575","line":71,"in_reply_to":"ee4c4127_77c1ac24","updated":"2021-03-17 09:27:58.000000000","message":"Done","commit_id":"26896d26d19c1b0fe068bd2b18d70c38c521ffc1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b806060503d2cd86a2c73cb567f1b70632045e34","unresolved":true,"context_lines":[{"line_number":531,"context_line":"            echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":532,"context_line":"        fi"},{"line_number":533,"context_line":"    else"},{"line_number":534,"context_line":"        ovs_uuid\u003d$(cat $OVS_SYSCONFDIR/system-id.conf)"},{"line_number":535,"context_line":"        if [ \"$ovs_uuid\" !\u003d $OVN_UUID ]; then"},{"line_number":536,"context_line":"            echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":537,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1b64526b_9c25ab7d","line":534,"range":{"start_line":534,"start_character":8,"end_line":534,"end_character":16},"updated":"2021-03-15 09:27:41.000000000","message":"needs a local declaration before it","commit_id":"26896d26d19c1b0fe068bd2b18d70c38c521ffc1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fea16f2cfa054f10c43ed23748f56d1846e4ae62","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":532,"context_line":"        fi"},{"line_number":533,"context_line":"    else"},{"line_number":534,"context_line":"        ovs_uuid\u003d$(cat $OVS_SYSCONFDIR/system-id.conf)"},{"line_number":535,"context_line":"        if [ \"$ovs_uuid\" !\u003d $OVN_UUID ]; then"},{"line_number":536,"context_line":"            echo $OVN_UUID | sudo tee $OVS_SYSCONFDIR/system-id.conf"},{"line_number":537,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3ca8a5ec_0d2905f3","line":534,"range":{"start_line":534,"start_character":8,"end_line":534,"end_character":16},"in_reply_to":"1b64526b_9c25ab7d","updated":"2021-03-17 09:27:58.000000000","message":"Done","commit_id":"26896d26d19c1b0fe068bd2b18d70c38c521ffc1"}]}