)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c2413179d9d78deb73c52e00e89c267fffac09bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"63999767_0494a9f7","updated":"2021-11-05 10:48:18.000000000","message":"Rebase and amended the comments a bit.","commit_id":"6dc59ec57abce63c17c81401b534256f675c2798"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"68310ece7a2d1262f2a07ebdc3d157b853359c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"57538c76_a586809b","updated":"2021-11-16 16:19:15.000000000","message":"lgtm, thanks","commit_id":"9c81321bfc694bd511dee8dd5d04273e368e5545"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5d3d3dec7b6ce11898ad3ba8b396fe4dbcc619a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"331913a4_32cf3447","updated":"2021-11-17 22:16:36.000000000","message":"looks ok, thanks for the improvement ","commit_id":"9c81321bfc694bd511dee8dd5d04273e368e5545"}],"functions-common":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a761fa502d243debd99da23b611500a8c5001cc6","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    if [ -f \"$SSL_BUNDLE_FILE\" ]; then"},{"line_number":86,"context_line":"        CA_CERT_ARG\u003d\"--os-cacert $SSL_BUNDLE_FILE\""},{"line_number":87,"context_line":"    fi"},{"line_number":88,"context_line":"    # demo_reader -\u003e devstack-reader"},{"line_number":89,"context_line":"    $PYTHON $TOP_DIR/tools/update_clouds_yaml.py \\"},{"line_number":90,"context_line":"        --file $CLOUDS_YAML \\"},{"line_number":91,"context_line":"        --os-cloud devstack-reader \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"43a6114f_ae09c061","line":88,"updated":"2021-03-12 07:53:11.000000000","message":"Nit: I\u0027d prefer to keep the default \"devstack\" cloud first.\n\nIdeally also reorder the other cloud definitions so that we keep all cloud definitions in alphabetic ordering by the cloud names. (That would also swap -admin and -alt in the original code.)","commit_id":"e51ed2fc0b4054ac8df0ad2abc663a9557208daf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a9881e20d817bb4dd06b87dab94879e4b11d856f","unresolved":true,"context_lines":[{"line_number":85,"context_line":"    if [ -f \"$SSL_BUNDLE_FILE\" ]; then"},{"line_number":86,"context_line":"        CA_CERT_ARG\u003d\"--os-cacert $SSL_BUNDLE_FILE\""},{"line_number":87,"context_line":"    fi"},{"line_number":88,"context_line":"    # demo_reader -\u003e devstack-reader"},{"line_number":89,"context_line":"    $PYTHON $TOP_DIR/tools/update_clouds_yaml.py \\"},{"line_number":90,"context_line":"        --file $CLOUDS_YAML \\"},{"line_number":91,"context_line":"        --os-cloud devstack-reader \\"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"66721cff_fdd60c29","line":88,"in_reply_to":"43a6114f_ae09c061","updated":"2021-11-04 21:00:56.000000000","message":"Ok - I tried reorganizing these and I updated the comments since I don\u0027t think the demo -\u003e devstack bit is very clear.","commit_id":"e51ed2fc0b4054ac8df0ad2abc663a9557208daf"}],"lib/keystone":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a761fa502d243debd99da23b611500a8c5001cc6","unresolved":true,"context_lines":[{"line_number":371,"context_line":"    alt_demo_user\u003d$(get_or_create_user \"alt_demo\" \\"},{"line_number":372,"context_line":"        \"$ADMIN_PASSWORD\" \"default\" \"alt_demo@example.com\")"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":375,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":376,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":377,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c6fe5ab6_0a15cf7c","line":374,"updated":"2021-03-12 07:53:11.000000000","message":"IMO it is a bit confusing that this user has both admin and member roles, is this needed? Would it be possible to drop this? Or do the same thing as with the demo project and have this user be member only and add a new alt_demo_admin user instead of _member?","commit_id":"e51ed2fc0b4054ac8df0ad2abc663a9557208daf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e0c3c9eb4bb545dff63dda0a937d353d1523111f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"    alt_demo_user\u003d$(get_or_create_user \"alt_demo\" \\"},{"line_number":372,"context_line":"        \"$ADMIN_PASSWORD\" \"default\" \"alt_demo@example.com\")"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":375,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":376,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":377,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7f36fc0f_0cfe0c99","line":374,"in_reply_to":"8595b038_41ce7c43","updated":"2021-11-04 21:03:01.000000000","message":"Ah - are you referencing this?","commit_id":"e51ed2fc0b4054ac8df0ad2abc663a9557208daf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a9881e20d817bb4dd06b87dab94879e4b11d856f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"    alt_demo_user\u003d$(get_or_create_user \"alt_demo\" \\"},{"line_number":372,"context_line":"        \"$ADMIN_PASSWORD\" \"default\" \"alt_demo@example.com\")"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":375,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":376,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":377,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"8595b038_41ce7c43","line":374,"in_reply_to":"c6fe5ab6_0a15cf7c","updated":"2021-11-04 21:00:56.000000000","message":"AFAICT the alt_demo_user only has the member role and another role on alt_demo project.\n\nAm I misunderstanding something?","commit_id":"e51ed2fc0b4054ac8df0ad2abc663a9557208daf"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4fea1c2229ab491115d3c23a3e176c6a28752b00","unresolved":true,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":365,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":366,"context_line":"    # Also make the admin user admin on project alt_demo"},{"line_number":367,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # Create another user to act as a member on project alt_demo"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4abc9d33_288b796e","line":366,"updated":"2021-11-05 10:52:56.000000000","message":"Hmm, now that I see https://review.opendev.org/c/openstack/devstack/+/780040/2 it seems to have been intended to give the alt_demo user the admin role instead? Not sure where this is actually being used, maybe we need to better document the rationale behind all this?","commit_id":"6dc59ec57abce63c17c81401b534256f675c2798"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7a1a465a2de262374aa8aa598e60156ff6b46bff","unresolved":true,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":365,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":366,"context_line":"    # Also make the admin user admin on project alt_demo"},{"line_number":367,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # Create another user to act as a member on project alt_demo"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"16b2c060_dd1e3c02","line":366,"in_reply_to":"33ca5ce4_dd5f4744","updated":"2021-11-13 20:06:07.000000000","message":"O.k., merged 780040 into this one.","commit_id":"6dc59ec57abce63c17c81401b534256f675c2798"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d3ef96c259b57aa9f738d5ab9757adb16ac962b7","unresolved":true,"context_lines":[{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    async_run ks-alt-member get_or_add_user_project_role $member_role $alt_demo_user $alt_demo_project"},{"line_number":365,"context_line":"    async_run ks-alt-another get_or_add_user_project_role $another_role $alt_demo_user $alt_demo_project"},{"line_number":366,"context_line":"    # Also make the admin user admin on project alt_demo"},{"line_number":367,"context_line":"    async_run ks-alt-admin get_or_add_user_project_role $admin_role $admin_user $alt_demo_project"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # Create another user to act as a member on project alt_demo"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"33ca5ce4_dd5f4744","line":366,"in_reply_to":"4abc9d33_288b796e","updated":"2021-11-05 14:49:55.000000000","message":"Yeah - I\u0027m not sure if it\u0027s needed or not... all this stuff has been around for a long time so I\u0027m not sure I understand the reasoning behind why certain users have a role or not.\n\nFWIW - my goal was to have multiple personas available for people to experiment with. For example, having reader, member, and admin applied to the system and at least two projects. I thought this would help people get familiar with the various personas and how they work, without having to do the same setup each time they deploy devstack.\n\nAdding the \u0027admin\u0027 role to this user on the alt_demo project ensures the alt_demo project has an admin of some kind (e.g., possibly useful for testing tenancy across projects).","commit_id":"6dc59ec57abce63c17c81401b534256f675c2798"}]}