)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8f7eba0d9209ca8205937097cf29e75017f719f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0bcd7647_c733ffd7","updated":"2021-11-08 19:20:53.000000000","message":"\u003e Patch Set 3: Code-Review-1\n\u003e \n\u003e It looks like we still have one thing referencing it?\n\u003e \n\u003e https://opendev.org/openstack/grenade/src/branch/master/projects/30_swift/upgrade.sh#L47\n\nIt appears the command to create tempurls is using the credentials it needs. I\u0027ll propose a follow up.\n\nhttps://opendev.org/openstack/devstack/src/branch/master/lib/swift#L867-L876","commit_id":"d85d0e6b306a509f15b2039a50d1522cab8de3bb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"00696d94f9eeac41128b679a1d22c505f263b0bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"778332f7_27d71714","in_reply_to":"0bcd7647_c733ffd7","updated":"2021-11-09 08:34:44.000000000","message":"It is missing at least the OS_AUTH_URL it seems. Is there any reason not to move that swift account into a cloud definition, too?","commit_id":"d85d0e6b306a509f15b2039a50d1522cab8de3bb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"097aea92f0cc0bef792ae4585f00503aca4af20d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d788d693_fdfa2994","updated":"2021-11-10 13:28:39.000000000","message":"Looks like we have a legitimate failure:\n\n openstack --os-region-name RegionOne --os-auth-url https://173.231.255.75/identity --os-username\u003dswift --os-password\u003dsecretservice --os-user-domain-name\u003dDefault --os-project-name\u003dservice --os-project-domain-name\u003dDefault object store account set --property Temp-URL-Key\u003dsecretkey\nThe request you have made requires authentication. (HTTP 401) (Request-ID: req-d5b9f3a0-5f0a-4664-8a2c-04dd5908938d)","commit_id":"528c0fc5d4f0f70f913a4bbff8a009cef8e2a27a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d4364633f4073879cb84204d70b81034f32b800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f50fbddb_46eff170","updated":"2021-11-16 16:15:16.000000000","message":"lgtm overall. 1 comment on writing cloud.yaml","commit_id":"7423dcc0428c1ead486b86b234c2e6c541001489"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ce2c2e8024b40806cc551409968b6ecdd50b4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4a0a0b2b_931faf6e","updated":"2021-11-16 22:03:29.000000000","message":"recheck","commit_id":"f56f7a557ac4941b5204852f4173db9cf82b4dae"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd75d28ac1feb8f476ed3eda7d88290f3e123367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f0e9e9d3_60889480","updated":"2021-11-17 14:40:27.000000000","message":"recheck","commit_id":"f56f7a557ac4941b5204852f4173db9cf82b4dae"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ec1234380795918be3bed12a6190bd0a760b93f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f88fc802_511a9f29","updated":"2021-11-17 14:42:29.000000000","message":"recheck","commit_id":"f56f7a557ac4941b5204852f4173db9cf82b4dae"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"96aa7419de756c3f3426a950c06b7c7851a088ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bde89469_9ff3d695","updated":"2021-11-17 01:02:11.000000000","message":"thanks, lgtm","commit_id":"f56f7a557ac4941b5204852f4173db9cf82b4dae"}],"functions-common":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"27fd5efae776301c59c356355d8e6af52415d757","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"},{"line_number":139,"context_line":"        --os-username swift \\"},{"line_number":140,"context_line":"        --os-password $SERVICE_PASSWORD \\"},{"line_number":141,"context_line":"\t--os-user-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":142,"context_line":"\t--os-project-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":143,"context_line":"        --os-project-name $SERVICE_PROJECT_NAME"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    cat \u003e\u003e $CLOUDS_YAML \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"d90b9051_5714162d","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":48},"updated":"2021-11-09 16:29:02.000000000","message":"I think we need to get rid of these?","commit_id":"72516e08dd11b4db3cb4f1904ce185eab73c08b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ac816556bb6e4ef93604b5be56b03aade1a6afa6","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"},{"line_number":139,"context_line":"        --os-username swift \\"},{"line_number":140,"context_line":"        --os-password $SERVICE_PASSWORD \\"},{"line_number":141,"context_line":"\t--os-user-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":142,"context_line":"\t--os-project-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":143,"context_line":"        --os-project-name $SERVICE_PROJECT_NAME"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    cat \u003e\u003e $CLOUDS_YAML \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"8cffea90_bee5a300","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":48},"in_reply_to":"ca685ac6_1f5677f9","updated":"2021-11-10 10:07:04.000000000","message":"This will work until you set SERVICE_DOMAIN_NAME to something other than Default. Unless we deprecate that variable - which would likely need some time - I think we need to keep supporting that use case.","commit_id":"72516e08dd11b4db3cb4f1904ce185eab73c08b7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"491e61b02aa804fb842e4d73251a41d4b7b321f0","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        --os-auth-url $KEYSTONE_SERVICE_URI \\"},{"line_number":139,"context_line":"        --os-username swift \\"},{"line_number":140,"context_line":"        --os-password $SERVICE_PASSWORD \\"},{"line_number":141,"context_line":"\t--os-user-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":142,"context_line":"\t--os-project-domain-name $SERVICE_DOMAIN_NAME \\"},{"line_number":143,"context_line":"        --os-project-name $SERVICE_PROJECT_NAME"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    cat \u003e\u003e $CLOUDS_YAML \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ca685ac6_1f5677f9","line":142,"range":{"start_line":141,"start_character":0,"end_line":142,"end_character":48},"in_reply_to":"d90b9051_5714162d","updated":"2021-11-09 20:18:26.000000000","message":"This worked for me locally\n\n  ╭─ubuntu@devstack ~/devstack ‹review/dr_jens_harbott/secure-rbac*›\n  ╰─➤  $ git d\n  diff --git a/functions-common b/functions-common\n  index 741624ff..dd756a8c 100644\n  --- a/functions-common\n  +++ b/functions-common\n  @@ -138,8 +138,6 @@ function write_clouds_yaml {\n           --os-auth-url $KEYSTONE_SERVICE_URI \\\n           --os-username swift \\\n           --os-password $SERVICE_PASSWORD \\\n  -       --os-user-domain-name $SERVICE_DOMAIN_NAME \\\n  -       --os-project-domain-name $SERVICE_DOMAIN_NAME \\\n           --os-project-name $SERVICE_PROJECT_NAME  \n  \n       cat \u003e\u003e $CLOUDS_YAML \u003c\u003cEOF","commit_id":"72516e08dd11b4db3cb4f1904ce185eab73c08b7"}],"stack.sh":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"01640e6f552937938dd7d3d765728e5da1c81a1a","unresolved":true,"context_lines":[{"line_number":1071,"context_line":"    start_tls_proxy http-services \u0027*\u0027 443 $SERVICE_HOST 80"},{"line_number":1072,"context_line":"fi"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"source $TOP_DIR/userrc_early"},{"line_number":1075,"context_line":""},{"line_number":1076,"context_line":"if is_service_enabled keystone; then"},{"line_number":1077,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f0a37f3_5a2a7192","side":"PARENT","line":1074,"updated":"2021-03-13 16:25:02.000000000","message":"As much as I agree with this, I think it needs to be decoupled from the tempest change because this changing requires everything that touches/uses/interacts with devstack be \"ready to roll\", where as the tempest change itself should just already work. I know because I\u0027m mid-stream conveting all of ironic\u0027s devstack plugin openstack command invocations to using os-cloud and the tempest `nova flavor list` is the latest item I hit when I unset the project related variables.","commit_id":"f3e9399d38ebf5dc26d9fdcd80d39179ad3e9baa"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"6c766abecf586fee295e03d6fbd4437ffe98b893","unresolved":true,"context_lines":[{"line_number":1071,"context_line":"    start_tls_proxy http-services \u0027*\u0027 443 $SERVICE_HOST 80"},{"line_number":1072,"context_line":"fi"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"source $TOP_DIR/userrc_early"},{"line_number":1075,"context_line":""},{"line_number":1076,"context_line":"if is_service_enabled keystone; then"},{"line_number":1077,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"f95d1eea_d41ae8a7","side":"PARENT","line":1074,"in_reply_to":"3f0a37f3_5a2a7192","updated":"2021-03-13 16:29:49.000000000","message":"I guess the question really becomes which path do we want to take. Break and everyone have to clean up, or give people a chance to adapt in other areas.","commit_id":"f3e9399d38ebf5dc26d9fdcd80d39179ad3e9baa"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"df5bd3e31434f11605938aaf5df0f8bff316f571","unresolved":true,"context_lines":[{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"# Write a clouds.yaml file and use the devstack-admin cloud"},{"line_number":1055,"context_line":"write_clouds_yaml"},{"line_number":1056,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"if is_service_enabled keystone; then"},{"line_number":1059,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"de763336_ea60a550","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":30},"updated":"2021-07-30 08:46:09.000000000","message":"Can we use devstack-system-admin instead here ?\n\nI\u0027m working on an issue with one of keystone job and it seems system scope token is required to create projects when KEYSTONE_ENFORCE_SCOPE \u003d True.\n\nhttps://bugs.launchpad.net/devstack/+bug/1938120","commit_id":"36ff3beb28d30eb76be61722b3cc6154830ec706"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2e0f9247cf9c2241ae19c71d65421b5b22315b49","unresolved":true,"context_lines":[{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"# Write a clouds.yaml file and use the devstack-admin cloud"},{"line_number":1055,"context_line":"write_clouds_yaml"},{"line_number":1056,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"if is_service_enabled keystone; then"},{"line_number":1059,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1fe4c938_65b7fc81","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":30},"in_reply_to":"2feeb0ec_c818ca61","updated":"2021-08-19 05:07:50.000000000","message":"That\u0027s truly better.\n\nWe should check existing usage of all openstack commands and ensure we use proper credentials, but switching from OS_* to OS_CLOUD here helps such overrides a lot because we can implement these overrides only by --os-colud option.","commit_id":"36ff3beb28d30eb76be61722b3cc6154830ec706"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"26d4a31f0af57b70096db7674a926c6c3522140c","unresolved":true,"context_lines":[{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"# Write a clouds.yaml file and use the devstack-admin cloud"},{"line_number":1055,"context_line":"write_clouds_yaml"},{"line_number":1056,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"if is_service_enabled keystone; then"},{"line_number":1059,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"2feeb0ec_c818ca61","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":30},"in_reply_to":"b4ab783f_f24ac7b2","updated":"2021-08-19 04:59:14.000000000","message":"My idea would be to handle this in the keystone parts, choosing the cloud name as appropriate, just like Slawek does in the above neutron code.\nWe could still look into making the default here overrideable, but likely that\u0027ll only be useful when all projects are ready for system scope.","commit_id":"36ff3beb28d30eb76be61722b3cc6154830ec706"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0b0b3dc5555a98f31775e48f9fb277aee3647a81","unresolved":true,"context_lines":[{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"# Write a clouds.yaml file and use the devstack-admin cloud"},{"line_number":1055,"context_line":"write_clouds_yaml"},{"line_number":1056,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"if is_service_enabled keystone; then"},{"line_number":1059,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"b4ab783f_f24ac7b2","line":1056,"range":{"start_line":1056,"start_character":16,"end_line":1056,"end_character":30},"in_reply_to":"de763336_ea60a550","updated":"2021-08-18 08:42:49.000000000","message":"I think that Jens needs to check it. I just rebased this patch on top of master as I need it for https://review.opendev.org/c/openstack/devstack/+/797450","commit_id":"36ff3beb28d30eb76be61722b3cc6154830ec706"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1d4364633f4073879cb84204d70b81034f32b800","unresolved":true,"context_lines":[{"line_number":1071,"context_line":"write_clouds_yaml"},{"line_number":1072,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"# Write a clouds.yaml file"},{"line_number":1075,"context_line":"write_clouds_yaml"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"if is_service_enabled keystone; then"},{"line_number":1078,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":8,"id":"0933b6a7_c21adc62","line":1075,"range":{"start_line":1074,"start_character":0,"end_line":1075,"end_character":17},"updated":"2021-11-16 16:15:16.000000000","message":"we need to remove this right","commit_id":"7423dcc0428c1ead486b86b234c2e6c541001489"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2459d999af5ecd83d18c5741f9c43f5c94a44244","unresolved":true,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"# Set up password auth credentials now that Keystone is bootstrapped"},{"line_number":1075,"context_line":"export OS_IDENTITY_API_VERSION\u003d3"},{"line_number":1076,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_SERVICE_URI"},{"line_number":1077,"context_line":"export OS_USERNAME\u003dadmin"},{"line_number":1078,"context_line":"export OS_USER_DOMAIN_ID\u003ddefault"},{"line_number":1079,"context_line":"export OS_PASSWORD\u003d$ADMIN_PASSWORD"}],"source_content_type":"text/x-sh","patch_set":9,"id":"73734b79_f58a8a7b","side":"PARENT","line":1076,"updated":"2021-11-18 17:21:38.000000000","message":"Removing this broke the octavia devstack plugin.","commit_id":"55c7830b4bf9d49f8bd0be69f6d2f950a384d707"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9d036a051044712b8b2919b111b646f608783175","unresolved":true,"context_lines":[{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"# Set up password auth credentials now that Keystone is bootstrapped"},{"line_number":1075,"context_line":"export OS_IDENTITY_API_VERSION\u003d3"},{"line_number":1076,"context_line":"export OS_AUTH_URL\u003d$KEYSTONE_SERVICE_URI"},{"line_number":1077,"context_line":"export OS_USERNAME\u003dadmin"},{"line_number":1078,"context_line":"export OS_USER_DOMAIN_ID\u003ddefault"},{"line_number":1079,"context_line":"export OS_PASSWORD\u003d$ADMIN_PASSWORD"}],"source_content_type":"text/x-sh","patch_set":9,"id":"2923b671_8f7faa13","side":"PARENT","line":1076,"in_reply_to":"73734b79_f58a8a7b","updated":"2021-11-18 18:32:03.000000000","message":"Octavia\u0027s devstack plugin likely needs to move to using just OS_CLOUD which provides all of this information via the clouds.yaml file.","commit_id":"55c7830b4bf9d49f8bd0be69f6d2f950a384d707"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"9d036a051044712b8b2919b111b646f608783175","unresolved":true,"context_lines":[{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":"# Write a clouds.yaml file and use the devstack-admin cloud"},{"line_number":1071,"context_line":"write_clouds_yaml"},{"line_number":1072,"context_line":"export OS_CLOUD\u003ddevstack-admin"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"if is_service_enabled keystone; then"},{"line_number":1075,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"9b1c1133_e9f017a3","line":1072,"range":{"start_line":1072,"start_character":0,"end_line":1072,"end_character":30},"updated":"2021-11-18 18:32:03.000000000","message":"Explicitly forcing this instead of relying upon job config *or* a plugin creates inconsistent execution and has broken ironic\u0027s gate. We\u0027re expecting this to be correct, not unilaterally overridden to the project scoped admin account.","commit_id":"f56f7a557ac4941b5204852f4173db9cf82b4dae"}]}