)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a0f0149a2b19a806f18c060d585d2e7837e1bd1","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The commit also removes the IPV6_ROUTER_GW_IP global variable, it was"},{"line_number":16,"context_line":"unused and it created some confusion with the real IP address of the"},{"line_number":17,"context_line":"default router."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I02ca1d94e9f4d5ad4a06182f5ac9a2434941cf08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bbaf8ef7_8e8968a7","line":17,"updated":"2021-03-17 06:36:58.000000000","message":"It is being used in plugins like e.g. ironic, so I don\u0027t think we can just remove it.","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8cc9d5962765bdcbd77204f9ee0d9336c5ba9bb3","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The commit also removes the IPV6_ROUTER_GW_IP global variable, it was"},{"line_number":16,"context_line":"unused and it created some confusion with the real IP address of the"},{"line_number":17,"context_line":"default router."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I02ca1d94e9f4d5ad4a06182f5ac9a2434941cf08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a4b44635_e82e41ae","line":17,"in_reply_to":"bbaf8ef7_8e8968a7","updated":"2021-03-17 08:00:11.000000000","message":"Good catch, I didn\u0027t check the plugins from other repos, I will revert that part, thanks","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a0f0149a2b19a806f18c060d585d2e7837e1bd1","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4ba75239_15471776","line":395,"updated":"2021-03-17 06:36:58.000000000","message":"I\u0027m not sure whether this is the right thing to do in a multinode scenario. The l3 agent will only be enabled on the controller node, but the new condition might also be met on the other nodes?","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3953ff71c35c8bebfc5a76693fe151291f32b592","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"25e7d446_51da387e","line":395,"in_reply_to":"03b39f46_4448b377","updated":"2021-03-19 10:58:21.000000000","message":"That\u0027s a good point regarding not checking if it\u0027s a controller node.\n\nPerhaps we could make this conditional check of q-svc AND Q_AGENT \u003d\u003d OVN ?\n\n # Check if the backend is OVN on a controller node OR if l3-agent is enabled\n if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] \u0026\u0026 is_service_enable q-svc neutron-server || \\\n    is_service_enabled q-l3 neutron-l3; then\n    ...","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"aa59021847eb9361c5390bc4421bd97b6a3d2ad6","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bd6acea6_454a89bd","line":395,"in_reply_to":"25e7d446_51da387e","updated":"2021-03-19 11:01:31.000000000","message":"Also regarding the GW address on multiple host, not sure we have that scenario. What greg is proposing is something that already exists in ML2/OVS, we also need it for OVN so that it works with Octavia.","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3ecbc4b87ebe724fa5588a6d083223602a939cfc","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"03b39f46_4448b377","line":395,"in_reply_to":"284d30f7_bfc111de","updated":"2021-03-17 08:56:33.000000000","message":"For multiple controllers it would be an issue having the same GW address configured on multiple hosts, but I\u0027m not sure whether there actually is such a scenario.","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"8cc9d5962765bdcbd77204f9ee0d9336c5ba9bb3","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"284d30f7_bfc111de","line":395,"in_reply_to":"4ba75239_15471776","updated":"2021-03-17 08:00:11.000000000","message":"This function is called from create_neutron_initial_network, which is only called when q-svc is enabled, so a compute node will not use it.\nIn case of multiple controllers, I think it\u0027s safe to enable the route on each controller that runs q-svc.","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c4ffcf2fd8991c4b578c28f681533feb5fe7beb9","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    fi"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    # This logic is specific to using OVN or the l3-agent for layer 3"},{"line_number":395,"context_line":"    if [[ $Q_AGENT \u003d\u003d \"ovn\" ]] || is_service_enabled q-l3 || is_service_enabled neutron-l3; then"},{"line_number":396,"context_line":"        # if the Linux host considers itself to be a router then it will"},{"line_number":397,"context_line":"        # ignore all router advertisements"},{"line_number":398,"context_line":"        # Ensure IPv6 RAs are accepted on interfaces with a default route."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1ded833f_0771e77f","line":395,"in_reply_to":"bd6acea6_454a89bd","updated":"2021-03-19 13:41:42.000000000","message":"added \"is_service_enabled q-svc\" with the Q_AGENT \u003d\u003d ovn condition","commit_id":"af9c7fd89521ab6c9ed9729053b5ac50c07e7f96"}]}