)]}'
{"id":"openstack%2Fdevstack~78675","triplet_id":"openstack%2Fdevstack~master~I3b881eedc891caa6b2dfd5913e43f3babcfa7d47","project":"openstack/devstack","branch":"master","topic":"ldap-errexit","hashtags":[],"change_id":"I3b881eedc891caa6b2dfd5913e43f3babcfa7d47","subject":"Fix errexit in lib/ldap","status":"MERGED","created":"2014-03-06 17:26:14.000000000","updated":"2014-03-08 12:55:58.000000000","submitted":"2014-03-08 12:55:58.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"93065c76e4b02a903f53735910df66acf28d5298","_number":78675,"virtual_id_number":78675,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-03-08 12:55:58.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"recommended":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-03-06 18:57:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":1,"date":"2014-03-06 19:57:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"date":"2014-03-07 17:59:39.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2014-03-06 17:52:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},{"value":2,"date":"2014-03-08 11:40:27.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"date":"2014-03-07 17:59:39.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},{"value":1,"date":"2014-03-08 11:40:27.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"value":0,"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-06 17:52:25.000000000","updated_by":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"reviewer":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"state":"REVIEWER"},{"updated":"2014-03-06 18:57:31.000000000","updated_by":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"reviewer":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"state":"REVIEWER"},{"updated":"2014-03-06 19:57:38.000000000","updated_by":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"reviewer":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"state":"REVIEWER"},{"updated":"2014-03-08 11:40:27.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-03-08 12:55:58.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"68cb71afef8682f6135cc5daedacfcc45896b527","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-06 17:26:15.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"62f1c7e3a0ab388e0677fca1a4d1c5e411e9f9d7","author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"date":"2014-03-06 17:52:25.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nDean, Thanks for doing this cleanup!!!","accounts_in_message":[],"_revision_number":1},{"id":"e345a18f7f6d853f5e6d350089dff6340ae99a55","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-03-06 18:43:48.000000000","message":"Patch Set 1:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://70dcd673047f0ebed6a7-dda4e480e005aaa13ec303551d2d8155.r49.cf5.rackcdn.com/75/78675/1/results.html\n\nStandard recheck supported; use \"xenserver recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":1},{"id":"8e41734467540c87ca62c482b30b0452fd5cdfbe","author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"date":"2014-03-06 18:57:31.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nWouldn\u0027t be bad to comment why, but OK as is.","accounts_in_message":[],"_revision_number":1},{"id":"155bbc1d60d109cfb7918a482ed679c3bb9d0a27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-06 19:18:16.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/75/78675/1/check/gate-devstack-bash8/577c919 : SUCCESS in 29s\n- check-devstack-dsvm-cells http://logs.openstack.org/75/78675/1/check/check-devstack-dsvm-cells/9bbd9d6 : SUCCESS in 15m 33s\n- check-tempest-dsvm-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-full/b892a22 : FAILURE in 3m 06s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-postgres-full/4ed366e : SUCCESS in 52m 38s\n- check-tempest-dsvm-neutron http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron/b3b57b2 : FAILURE in 4m 49s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron-full/18c8828 : SUCCESS in 1h 00m 07s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/75/78675/1/check/gate-tempest-dsvm-large-ops/ec59bf4 : SUCCESS in 19m 55s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/75/78675/1/check/gate-tempest-dsvm-neutron-large-ops/fc40c3e : FAILURE in 3m 31s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron-heat-slow/894d301 : FAILURE in 24m 21s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-cells-full/e3ca95d : FAILURE in 4m 30s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/75/78675/1/check/check-grenade-dsvm/075cdb7 : SUCCESS in 34m 19s\n- check-swift-dsvm-functional http://logs.openstack.org/75/78675/1/check/check-swift-dsvm-functional/55fb5ab : FAILURE in 5m 00s\n- check-devstack-dsvm-neutron http://logs.openstack.org/75/78675/1/check/check-devstack-dsvm-neutron/038091a : FAILURE in 15m 30s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-ironic-nv/47a3a29 : SUCCESS in 28m 20s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-ironic-postgres-nv/8962fc8 : SUCCESS in 26m 28s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-full-nv/93b9d68 : FAILURE in 3m 29s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-postgres-nv/7919b99 : SUCCESS in 20m 05s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-neutron-nv/479cde0 : SUCCESS in 39m 55s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"884ffdc8760d4275477a7a594ca4b8d107249c81","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2014-03-06 19:57:38.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ded79fd650e9e909f6546944928950127a05ef15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 17:59:39.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"feb2359d0240bda15d0656cd2ab307c14662beb0","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-03-07 17:59:39.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"b9aedc5e90fed55a04e1b172ef780fb3d7791a2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-07 19:06:26.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- check-grenade-dsvm http://logs.openstack.org/75/78675/1/check/check-grenade-dsvm/e53b88c : SUCCESS in 50m 44s\n- check-tempest-dsvm-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-full/9a41ad1 : SUCCESS in 51m 40s\n- check-tempest-dsvm-neutron http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron/51f9c6d : SUCCESS in 38m 07s\n- gate-devstack-bash8 http://logs.openstack.org/75/78675/1/check/gate-devstack-bash8/5f62a96 : SUCCESS in 28s\n- check-devstack-dsvm-cells http://logs.openstack.org/75/78675/1/check/check-devstack-dsvm-cells/f72664a : SUCCESS in 12m 52s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-postgres-full/d0f538d : SUCCESS in 54m 56s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron-full/c75fa36 : SUCCESS in 1h 00m 43s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/75/78675/1/check/gate-tempest-dsvm-large-ops/4e1cdc7 : SUCCESS in 15m 48s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/75/78675/1/check/gate-tempest-dsvm-neutron-large-ops/e6f79f8 : SUCCESS in 15m 40s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-neutron-heat-slow/9945f2b : FAILURE in 22m 38s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-cells-full/031b49d : SUCCESS in 52m 54s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/75/78675/1/check/check-swift-dsvm-functional/71585c5 : SUCCESS in 13m 33s\n- check-devstack-dsvm-neutron http://logs.openstack.org/75/78675/1/check/check-devstack-dsvm-neutron/1ddb48c : FAILURE in 13m 34s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-ironic-nv/4cd5b6d : SUCCESS in 32m 17s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-ironic-postgres-nv/977e2a7 : SUCCESS in 25m 53s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-full-nv/e745827 : SUCCESS in 59m 16s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-postgres-nv/ec63f1c : SUCCESS in 26m 07s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/75/78675/1/check/check-tempest-dsvm-savanna-neutron-nv/8e4161f : SUCCESS in 36m 39s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"87e5ba997822ddd952e6fbb8dd4be705c82dafea","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-03-08 11:40:27.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"c1e0c192abc09c5bc112881a4cdb6d259929724d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-08 11:40:28.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6cf7e79a37d6ec8fa6f07a2450e523bc7e9eb038","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-08 12:55:58.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-grenade-dsvm http://logs.openstack.org/75/78675/1/gate/gate-grenade-dsvm/d470787 : SUCCESS in 28m 05s\n- gate-tempest-dsvm-full http://logs.openstack.org/75/78675/1/gate/gate-tempest-dsvm-full/73ceabc : SUCCESS in 53m 03s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/75/78675/1/gate/gate-tempest-dsvm-neutron/c5f9ad5 : SUCCESS in 40m 56s\n- gate-devstack-bash8 http://logs.openstack.org/75/78675/1/gate/gate-devstack-bash8/a713c70 : SUCCESS in 10s\n- gate-devstack-dsvm-cells http://logs.openstack.org/75/78675/1/gate/gate-devstack-dsvm-cells/dd1aaa7 : SUCCESS in 12m 40s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/75/78675/1/gate/gate-tempest-dsvm-postgres-full/7a0c077 : SUCCESS in 57m 55s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/75/78675/1/gate/gate-tempest-dsvm-large-ops/a46a41a : SUCCESS in 18m 06s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/75/78675/1/gate/gate-tempest-dsvm-neutron-large-ops/354de8d : SUCCESS in 15m 42s\n- gate-swift-dsvm-functional http://logs.openstack.org/75/78675/1/gate/gate-swift-dsvm-functional/7dd915d : SUCCESS in 11m 53s\n","accounts_in_message":[],"_revision_number":1},{"id":"1b1817c85fe87af27361485ed8b762a3b8bef0bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-08 12:55:58.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"b44a8ef14f4e177aef0528db2b7721030f76b290","revisions":{"b44a8ef14f4e177aef0528db2b7721030f76b290":{"kind":"REWORK","_number":1,"created":"2014-03-06 17:26:14.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/75/78675/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/75/78675/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/75/78675/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/75/78675/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/75/78675/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/75/78675/1"}}},"commit":{"parents":[{"commit":"3a07906d9054e282aea2a06098d12f69342056a1","subject":"Merge \"Use cat instead of read\u003cfile\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3a07906d9054e282aea2a06098d12f69342056a1"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-03-06 17:25:04.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-03-06 17:25:08.000000000","tz":-360},"subject":"Fix errexit in lib/ldap","message":"Fix errexit in lib/ldap\n\nclear_ldap_state() deletes an object from the DIT that doesn\u0027t exist\non the first run, this is OK but fails with errexit enabled.\n\nChange-Id: I3b881eedc891caa6b2dfd5913e43f3babcfa7d47\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b44a8ef14f4e177aef0528db2b7721030f76b290"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b44a8ef14f4e177aef0528db2b7721030f76b290"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}