)]}'
{"lib/glance":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a851f22673c37f881982ef78cdb22d6b74ac2050","unresolved":true,"context_lines":[{"line_number":269,"context_line":"    # NOTE(danms): We need to have some of the OS_ things unset in"},{"line_number":270,"context_line":"    # order to use system scope, which is required for creating these"},{"line_number":271,"context_line":"    # limits. This is a hack, but I dunno how else to get osc to use"},{"line_number":272,"context_line":"    # system scope."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"00053ecb_1f7b5210","line":272,"updated":"2021-04-28 18:40:32.000000000","message":"I created a bug to track that effort [0], in case you want to reference it here.\n\n[0] https://bugs.launchpad.net/devstack/+bug/1926332","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a851f22673c37f881982ef78cdb22d6b74ac2050","unresolved":true,"context_lines":[{"line_number":271,"context_line":"    # limits. This is a hack, but I dunno how else to get osc to use"},{"line_number":272,"context_line":"    # system scope."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":276,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":277,"context_line":"                image_size_total; \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"39c14a5d_f23f98ea","line":274,"range":{"start_line":274,"start_character":19,"end_line":274,"end_character":30},"updated":"2021-04-28 18:40:32.000000000","message":"Do you know if this is still required? This should only be used for authentication and shouldn\u0027t have any bearing on authorization. If it does then it\u0027s probably a bug.","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"63b91fbf1c16dc49bcf82b9f57f60bbe72f9e22f","unresolved":true,"context_lines":[{"line_number":271,"context_line":"    # limits. This is a hack, but I dunno how else to get osc to use"},{"line_number":272,"context_line":"    # system scope."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":276,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":277,"context_line":"                image_size_total; \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9f0280ae_30170190","line":274,"range":{"start_line":274,"start_character":19,"end_line":274,"end_character":30},"in_reply_to":"39c14a5d_f23f98ea","updated":"2021-04-28 21:31:30.000000000","message":"I still haven\u0027t tested, I\u0027ll try to do that soon.","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a851f22673c37f881982ef78cdb22d6b74ac2050","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                image_size_total; \\"},{"line_number":278,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":279,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":280,"context_line":"                image_stage_total; \\"},{"line_number":281,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":282,"context_line":"                --service glance --default-limit 100 --region $REGION_NAME \\"},{"line_number":283,"context_line":"                image_count_total\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"166614d8_bbd91786","line":280,"range":{"start_line":280,"start_character":16,"end_line":280,"end_character":33},"updated":"2021-04-28 18:40:32.000000000","message":"What\u0027s a staged image?","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"63b91fbf1c16dc49bcf82b9f57f60bbe72f9e22f","unresolved":true,"context_lines":[{"line_number":277,"context_line":"                image_size_total; \\"},{"line_number":278,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":279,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":280,"context_line":"                image_stage_total; \\"},{"line_number":281,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":282,"context_line":"                --service glance --default-limit 100 --region $REGION_NAME \\"},{"line_number":283,"context_line":"                image_count_total\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"70d40d8b_9cbefac2","line":280,"range":{"start_line":280,"start_character":16,"end_line":280,"end_character":33},"in_reply_to":"166614d8_bbd91786","updated":"2021-04-28 21:31:30.000000000","message":"Glance has two ways to upload an image, the regular way and the import way. Import requires uploading the image to a temporary holding (staging) area, after which the image can be converted before moving to the actual storage location, and potentially be copied to multiple places. This is controlled by the user in a multi-step fashion, and they can leave images in that staging area for a long time. Since it\u0027s shared by all tenants and would generally be local disk space on an API worker, it\u0027s fundamentally different than the regular storage areas, and more constrained.","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b8f9907e9f63cb6b55f4563f38cb703169808b04","unresolved":false,"context_lines":[{"line_number":277,"context_line":"                image_size_total; \\"},{"line_number":278,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":279,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":280,"context_line":"                image_stage_total; \\"},{"line_number":281,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":282,"context_line":"                --service glance --default-limit 100 --region $REGION_NAME \\"},{"line_number":283,"context_line":"                image_count_total\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"4eb7dec3_498936b7","line":280,"range":{"start_line":280,"start_character":16,"end_line":280,"end_character":33},"in_reply_to":"70d40d8b_9cbefac2","updated":"2021-05-10 12:17:34.000000000","message":"Ack","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"30644b3ba8717946e56fc9012bd1c20e3b52a37a","unresolved":true,"context_lines":[{"line_number":280,"context_line":"                image_stage_total; \\"},{"line_number":281,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":282,"context_line":"                --service glance --default-limit 100 --region $REGION_NAME \\"},{"line_number":283,"context_line":"                image_count_total\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    # Tell glance to use these limits"},{"line_number":286,"context_line":"    iniset $GLANCE_API_CONF DEFAULT use_keystone_limits True"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"eb33fa12_c3570bf8","line":283,"updated":"2021-05-10 18:19:06.000000000","message":"I am pretty sure you can avoid the syntactical oddities by using () instead of bash -c","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9ecc5144a3b3540f5d418125229b1c4ac381354f","unresolved":true,"context_lines":[{"line_number":280,"context_line":"                image_stage_total; \\"},{"line_number":281,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":282,"context_line":"                --service glance --default-limit 100 --region $REGION_NAME \\"},{"line_number":283,"context_line":"                image_count_total\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    # Tell glance to use these limits"},{"line_number":286,"context_line":"    iniset $GLANCE_API_CONF DEFAULT use_keystone_limits True"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"32f3da69_04366470","line":283,"in_reply_to":"eb33fa12_c3570bf8","updated":"2021-05-10 19:09:33.000000000","message":"Hmm, I\u0027m pretty sure I tried this at the command line and I ended up unsetting them the parent shell, which I don\u0027t want to do here. But, I\u0027ll give it a try.","commit_id":"f4df0bc87c864ec2333020a652a4732ace752f6c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e2569f06ca54c6fdbd983fdc0ecdddef7ffec2b7","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    # NOTE(danms): We need to have some of the OS_ things unset in"},{"line_number":270,"context_line":"    # order to use system scope, which is required for creating these"},{"line_number":271,"context_line":"    # limits. This is a hack, but I dunno how else to get osc to use"},{"line_number":272,"context_line":"    # system scope."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"a9c84dda_67e98f54","line":272,"range":{"start_line":271,"start_character":14,"end_line":272,"end_character":19},"updated":"2021-07-16 20:20:55.000000000","message":"yeah, we do not have standard way yet but this is something we need migrate devstack to.","commit_id":"4e916aeb060ecf99203f297a0ff726a65d27f50e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6b532b95db4f13a1fda1adeb5bc72c978dd5ddfe","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":276,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":277,"context_line":"                image_size_total; \\"},{"line_number":278,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":279,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9797bccf_f8413036","line":276,"range":{"start_line":276,"start_character":49,"end_line":276,"end_character":53},"updated":"2021-06-14 14:18:50.000000000","message":"Suggestion:\nCan we have all these as global variable, can be provided as a input from local.conf?","commit_id":"4e916aeb060ecf99203f297a0ff726a65d27f50e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"136314e1e54e113c9105a4c25837753556439466","unresolved":true,"context_lines":[{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":275,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":276,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"},{"line_number":277,"context_line":"                image_size_total; \\"},{"line_number":278,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":279,"context_line":"                --service glance --default-limit 1000 --region $REGION_NAME \\"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9881b930_b5d088f7","line":276,"range":{"start_line":276,"start_character":49,"end_line":276,"end_character":53},"in_reply_to":"9797bccf_f8413036","updated":"2021-06-14 14:45:50.000000000","message":"We could, but I don\u0027t think we _need_ it. The other projects all configure some default or -1 (for unlimited) for their quotas. If you\u0027d prefer -1 here that\u0027s fine, but for example, Cinder configures a default static value of 50 for their volumes quota.","commit_id":"4e916aeb060ecf99203f297a0ff726a65d27f50e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6b532b95db4f13a1fda1adeb5bc72c978dd5ddfe","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    iniset $GLANCE_API_CONF oslo_limit auth_type password"},{"line_number":296,"context_line":"    iniset $GLANCE_API_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":297,"context_line":"    iniset $GLANCE_API_CONF oslo_limit system_scope \"\u0027all\u0027\""},{"line_number":298,"context_line":"    iniset $GLANCE_API_CONF oslo_limit endpoint_id \\"},{"line_number":299,"context_line":"           $(openstack endpoint list --service glance -f value -c ID)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    # Allow the glance service user to read quotas"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"55e2e872_156f5708","line":298,"range":{"start_line":298,"start_character":39,"end_line":298,"end_character":50},"updated":"2021-06-14 14:18:50.000000000","message":"Suggestion:\ncan we use service_name instead?\nhttps://docs.openstack.org/oslo.limit/latest/user/usage.html#configuration","commit_id":"4e916aeb060ecf99203f297a0ff726a65d27f50e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"136314e1e54e113c9105a4c25837753556439466","unresolved":true,"context_lines":[{"line_number":295,"context_line":"    iniset $GLANCE_API_CONF oslo_limit auth_type password"},{"line_number":296,"context_line":"    iniset $GLANCE_API_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":297,"context_line":"    iniset $GLANCE_API_CONF oslo_limit system_scope \"\u0027all\u0027\""},{"line_number":298,"context_line":"    iniset $GLANCE_API_CONF oslo_limit endpoint_id \\"},{"line_number":299,"context_line":"           $(openstack endpoint list --service glance -f value -c ID)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    # Allow the glance service user to read quotas"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"2f85d247_f6909f25","line":298,"range":{"start_line":298,"start_character":39,"end_line":298,"end_character":50},"in_reply_to":"55e2e872_156f5708","updated":"2021-06-14 14:45:50.000000000","message":"I think this didn\u0027t work and that it\u0027s one of the things lance and I were struggling with to get that to work. But, there was a lot of back and forth. If it does, let me know and I\u0027ll switch it back (or I\u0027ll test next time I stack).","commit_id":"4e916aeb060ecf99203f297a0ff726a65d27f50e"}]}