)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"eda32974c793fc69005b6ea2954c9b56b22dd4a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"598a1cfc_e51b9c26","updated":"2022-01-27 21:50:11.000000000","message":"recheck","commit_id":"36b9163a47cb96036e9dd79c6dacf1a9d32a9ed8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"20408d963828fb245399a11cc6955bb3bd3d3c71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4fd81f91_6c0c76a1","updated":"2022-03-03 06:53:29.000000000","message":"Found the nova-next job. I\u0027m fine with doing the cleanup things in a follow-up, so as to not block this.","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f5dcb88e9dba292d9611e3005bfa40d44337293","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e66cf6cc_7b220629","updated":"2022-03-03 06:44:26.000000000","message":"Is there a job that will test this scenario?\n\nThe issues below seem to be copied from the lib/glance variant of this, might be good to clean that up in a pre-patch, too.","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"522af1cfd64d80ef562bba9135f91d56de5ede91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f681b908_7febc466","updated":"2022-03-03 17:47:16.000000000","message":"lgtm, working fine in nova-next job\u0027s post hook https://zuul.opendev.org/t/openstack/build/9d5fbad1cd3e4d5d930c291d6a16b657/console","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"48b1c4b42e5eb2498883b18d3459e3a93d5a743e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9b9eddb3_019ac43f","in_reply_to":"4fd81f91_6c0c76a1","updated":"2022-03-04 00:06:35.000000000","message":"Followup change is proposed here: https://review.opendev.org/c/openstack/devstack/+/831877","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"}],"lib/nova":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f5dcb88e9dba292d9611e3005bfa40d44337293","unresolved":true,"context_lines":[{"line_number":732,"context_line":"function configure_nova_unified_limits {"},{"line_number":733,"context_line":"    # Default limits. Mirror the config-based default values."},{"line_number":734,"context_line":"    # Note: disk quota is new in nova as of unified limits."},{"line_number":735,"context_line":"    bash -c \"unset OS_USERNAME OS_TENANT_NAME OS_PROJECT_NAME;"},{"line_number":736,"context_line":"        openstack --os-cloud devstack-system-admin registered limit create \\"},{"line_number":737,"context_line":"                    --service nova --default-limit 10 --region $REGION_NAME \\"},{"line_number":738,"context_line":"                    servers; \\"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"e31c0f6c_791e5d14","line":735,"updated":"2022-03-03 06:44:26.000000000","message":"This wrapper is no longer necessary, we only set OS_CLOUD globally, which is then overridden by you --os-cloud option.","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f5dcb88e9dba292d9611e3005bfa40d44337293","unresolved":true,"context_lines":[{"line_number":776,"context_line":"    iniset $NOVA_CONF oslo_limit username nova"},{"line_number":777,"context_line":"    iniset $NOVA_CONF oslo_limit auth_type password"},{"line_number":778,"context_line":"    iniset $NOVA_CONF oslo_limit auth_url $KEYSTONE_SERVICE_URI"},{"line_number":779,"context_line":"    iniset $NOVA_CONF oslo_limit system_scope \"\u0027all\u0027\""},{"line_number":780,"context_line":"    iniset $NOVA_CONF oslo_limit endpoint_id \\"},{"line_number":781,"context_line":"           $(openstack endpoint list --service nova -f value -c ID)"},{"line_number":782,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"17fd302e_efc7bac9","line":779,"updated":"2022-03-03 06:44:26.000000000","message":"It seems weird that this quoting should be necessary. Seems you just copied it from lib/glance, but I think we should just drop it.","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0f5dcb88e9dba292d9611e3005bfa40d44337293","unresolved":true,"context_lines":[{"line_number":781,"context_line":"           $(openstack endpoint list --service nova -f value -c ID)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    # Allow the nova service user to read quotas"},{"line_number":784,"context_line":"    openstack role add --user nova --user-domain Default --system all \\"},{"line_number":785,"context_line":"              reader"},{"line_number":786,"context_line":"}"},{"line_number":787,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ae17759d_68500f79","line":784,"updated":"2022-03-03 06:44:26.000000000","message":"Also copied, still it doesn\u0027t make sense to use $SERVICE_DOMAIN_NAME above and hardcode \"Default\" here, please make it consistent.","commit_id":"099a048fb933649606e58310e8e705e7c7e29cd7"}]}
