)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2600663eab201ae84dcc480c59a3e30686e6dbc9","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2286f096_dfa5b871","line":11,"updated":"2021-05-13 17:12:15.000000000","message":"Is there a patch showing the failures that I could take a look to help with this ?","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9932cba0c203dd4bb82cf6e5983bad4b9a53ec4c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aab01db1_d1b22327","line":11,"in_reply_to":"2286f096_dfa5b871","updated":"2021-05-13 17:31:59.000000000","message":"If you run fresh devstack (without pre-cloned repo) then you might see the issue, what is whay i understood from clark comment in https://review.opendev.org/c/openstack/devstack/+/791085\n\n-------------------\nClark Boylan\nPatch Set 2: Code-Review+2 Review-Priority+2\n\nthanks Ian. not sure why it did not occur in https://review.opendev.org/c/openstack/devstack/+/735097\n\nI believe the reason it works in normal gating is that we \"preclone\" and configure all of the git repos before devstack runs. This ensures that depends-on works. But a side effect is that you can refer to code that won\u0027t be present if someone has cloned devstack and run stack.sh.\n\n-----------------------","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1a23d2f504e0c7a7573de285fca89b7b02b439f8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da984886_29084297","line":11,"in_reply_to":"7139a8d0_327c07b5","updated":"2021-05-14 08:54:48.000000000","message":"Thanks Ian,\n\nThat clarify things more. I will work on fixes for it and make sure that the ensure-devstack job is happy with the new changes.","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bb30de08cf9583e40a313aecb9ff5692f975c69f","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8947300d_85d8bc75","line":11,"in_reply_to":"86342f10_7e51fe5d","updated":"2021-05-14 13:40:45.000000000","message":"I am with Ian\u0027s idea of \u0027putting ensure-devstack into the devstack gate\u0027\n\n\u003eIf someone wants to propose ensure-devstack cloning from Zuul checkout, we can at least discuss it.\nDo we need to do anything extra than what you already did in below patch? \nhttps://review.opendev.org/c/zuul/zuul-jobs/+/791116/2","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ff5e29bd7871aa1f8148425c45b237c171505eb4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"11ba3387_45cbd233","line":11,"in_reply_to":"8947300d_85d8bc75","updated":"2021-05-16 14:31:24.000000000","message":"Hi,\n\nMy last version of the patch changing the default to ML2/OVN [0] now makes sure that the ensure-devstack is passing [1].\n\nThanks for the help.\n\n[0] https://review.opendev.org/c/openstack/devstack/+/791436\n[1] https://review.opendev.org/c/zuul/zuul-jobs/+/791117","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e244c122f9ecafb68bc94876e7e5c782f4fa82e8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fd6a15a7_1996297c","line":11,"in_reply_to":"aab01db1_d1b22327","updated":"2021-05-14 08:07:06.000000000","message":"Sad to see this reverted.\n\nI will try to figure out what\u0027s needed. Not entirely sure what fresh devstack means as I have deployed it many times on fresh VMs but I will check again.","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0d2991963100dd3efe343d3f61764f6c3309b74a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"86342f10_7e51fe5d","line":11,"in_reply_to":"da984886_29084297","updated":"2021-05-14 10:41:51.000000000","message":"Hi Ian,\n\nThat ensure-devstack job doesn\u0027t seem to pick up changes with Depends-On, is that correct ? How can I test that job using Zuul ?\n\nIf I can\u0027t I will try to test it locally somehow","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2e886b25d469c09ddfc062ed82a89d9c95a340b8","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 5c304d817682d6c807b532b50a2f105479ac3fa2."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Reason for revert: There are more things to fix/move like done in 791085 and 791282 Also let\u0027s change all required default in devstack scripts instead of devstack\u0027s zuul job side. Basically do this change without any change in .zuul.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f59d1b9a4b97ad9fd8131819054dfb616f31fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7139a8d0_327c07b5","line":11,"in_reply_to":"fd6a15a7_1996297c","updated":"2021-05-14 08:41:39.000000000","message":"\u003e I will try to figure out what\u0027s needed. Not entirely sure what fresh devstack means as I have deployed it many times on fresh VMs but I will check again.\n\nMaking sure ensure-devstack works with the proposed change will test basically the end-user case of \"i cloned a fresh tree, have a existing config and i want it to work\"\n\nThat can be exercised against a change with \n\n[1] https://review.opendev.org/c/zuul/zuul-jobs/+/791117\n\nI\u0027m on the fence about putting ensure-devstack into the devstack gate.  The role is explicitly designed to \"use\" devstack, not test it, and there\u0027s been push-back in jobs that use it even collecting devstack logs.  But, OTOH, \"can I use devstack\" is also actually a pretty good test for devstack to do ...\n\nIf someone wants to propose ensure-devstack cloning from Zuul checkout, we can at least discuss it.\n\nBut at a minimum, any revert work should ensure that passes.","commit_id":"ff073a5643f01dda3200d2ce426f23dc24e28b8f"}]}