)]}'
{".zuul.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2e590fe7b5bf501962c9b6f4ef542ca6011d7b3","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        OVN_L3_CREATE_PUBLIC_NETWORK: true"},{"line_number":472,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":473,"context_line":"        ENABLE_CHASSIS_AS_GW: true"},{"line_number":474,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":475,"context_line":"      devstack_local_conf:"},{"line_number":476,"context_line":"        post-config:"},{"line_number":477,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"96ceaec8_20b9f4cf","line":474,"updated":"2021-05-17 10:40:33.000000000","message":"Any reason not to make these four options default, too?","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"876d2590e0324ea2af71fa293f7e584a5df18a65","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        OVN_L3_CREATE_PUBLIC_NETWORK: true"},{"line_number":472,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":473,"context_line":"        ENABLE_CHASSIS_AS_GW: true"},{"line_number":474,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":475,"context_line":"      devstack_local_conf:"},{"line_number":476,"context_line":"        post-config:"},{"line_number":477,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fe1e1c77_14efe5fc","line":474,"in_reply_to":"41277e90_f160ba67","updated":"2021-05-18 08:41:08.000000000","message":"I will take a look at each one of those","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e25c4d1ed2c298022d53f311d22be42a1b1dce31","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        OVN_L3_CREATE_PUBLIC_NETWORK: true"},{"line_number":472,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":473,"context_line":"        ENABLE_CHASSIS_AS_GW: true"},{"line_number":474,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":475,"context_line":"      devstack_local_conf:"},{"line_number":476,"context_line":"        post-config:"},{"line_number":477,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b1985dc3_93c783b0","line":474,"in_reply_to":"96ceaec8_20b9f4cf","updated":"2021-05-17 11:37:32.000000000","message":"+1","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"7b5cb0a872e66bf141e1eef6e70a373feea75d9a","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        OVN_L3_CREATE_PUBLIC_NETWORK: true"},{"line_number":472,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":473,"context_line":"        ENABLE_CHASSIS_AS_GW: true"},{"line_number":474,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":475,"context_line":"      devstack_local_conf:"},{"line_number":476,"context_line":"        post-config:"},{"line_number":477,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"41277e90_f160ba67","line":474,"in_reply_to":"b1985dc3_93c783b0","updated":"2021-05-17 12:20:52.000000000","message":"In case these options are made default, please consider implications outside Zuul CI. In my local lab, the deployment failed and I had to manually set PUBLIC_NETWORK_GATEWAY.","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dc152341957f2942f222f07041a6ead07c812816","unresolved":true,"context_lines":[{"line_number":471,"context_line":"        OVN_L3_CREATE_PUBLIC_NETWORK: true"},{"line_number":472,"context_line":"        OVN_DBS_LOG_LEVEL: dbg"},{"line_number":473,"context_line":"        ENABLE_CHASSIS_AS_GW: true"},{"line_number":474,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":475,"context_line":"      devstack_local_conf:"},{"line_number":476,"context_line":"        post-config:"},{"line_number":477,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4ead6914_43bb409b","line":474,"in_reply_to":"fe1e1c77_14efe5fc","updated":"2021-05-19 11:04:34.000000000","message":"So, I took a look at each of these options\n\n1) Q_USE_PROVIDERNET_FOR_PUBLIC: This one already defaults to True, so it\u0027s safe to just remove it from the zuul file.\n\n2) OVN_DBS_LOG_LEVEL: This one defaults to \"info\" but, given that DevStack is a developers tool and not a production deployment tool (at least that\u0027s how I see it) I don\u0027t think that defaulting to \"dbg\" (a.k.a debug mode) is out of scope. I will make the change.\n\n3) ENABLE_CHASSIS_AS_GW: This option is about letting ML2/OVN where to schedule the gateway router ports. If set to True, means that the node is a candidate for hosting such ports. Most DevStack deployments are single node (all-in-one) so it makes sense to have it to True. For multi-node configuration we would need to set this to False on the compute nodes.\n\n4) OVN_L3_CREATE_PUBLIC_NETWORK: The name of this option is misleading IMHO. This option tells DevStack whether to create an external bridge or not [0]. See, it kinda overlaps with ENABLE_CHASSIS_AS_GW in a way that, if ENABLE_CHASSIS_AS_GW is True, most likely this should also be True. Except for the DVR case where we want to have a external bridge in the compute nodes but we do not want router ports scheduled on to it (we want the router ports on gateway nodes and/or controllers). So I am not convinced I should set it to True here, it seems like an option that could be removed if we have the right checks in [0] (by checking the ENABLE_CHASSIS_AS_GW and a DVR option). Tho it would be a bit out of scope to refactor it as part of this patch and we would need [1] to be merged.\n\nSorry for the long comment, tl;dr I will change all other options but will keep OVN_L3_CREATE_PUBLIC_NETWORK as-is and refactor it as another work.\n\nLet me know if that\u0027s OK for you please.\n\n[0] https://github.com/openstack/devstack/blob/9ee7821e80731dc15f71f4e56233c3295497dd53/lib/neutron-legacy#L478-L486\n\n[1] https://review.opendev.org/#/c/755830","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2e590fe7b5bf501962c9b6f4ef542ca6011d7b3","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"240243f7_e1a7c786","line":488,"updated":"2021-05-17 10:40:33.000000000","message":"I see this as a pretty severe regression in collecting data about devstack runs. Do you have any plans on working on this other than hoping for Ubuntu to fix it? I\u0027m also not convinced that this is actually the same issue, since afaict we do not suspend test instances.","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e25c4d1ed2c298022d53f311d22be42a1b1dce31","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"38377ee8_c5f05eb7","line":488,"in_reply_to":"240243f7_e1a7c786","updated":"2021-05-17 11:37:32.000000000","message":"+1. All devstack-based CI jobs across all OpenStack projects would cease to run dstat which comes very handy when troubleshooting issues. Although, dstat development has been terminated. Is there a replacement tool proposed?","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9813f18fd8afa5db5ffc5b5ef2b2a72749d0a923","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfe60edb_6ef1edcb","line":488,"in_reply_to":"35db1177_af665bb0","updated":"2021-05-17 12:28:11.000000000","message":"Thanks Carlos, Dr. Jens.\n\nUnfortunately dstat is still broken: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_033/791720/1/check/neutron-ovn-tempest-slow/033255f/controller/logs/screen-dstat.txt\n\nThis bug in particular has been open for quite some time [0] but it hasn\u0027t been fixed and probably never will because as Carlos mentioned dstat is no longer maintained.\n\nI am not entirely sure how to proceed here other than disabling this service temporarily until we find an alternative service for collecting these stats.\n\nI took the initiative to look at some alternatives, there\u0027s a direct fork from dstat called \"dool\" [1] but I am not sure it\u0027s being maintained either, the last commit seems quite old even tho there\u0027s nothing in the README indicating that the project is no longer maintained.\n\nAnother alternative I found is a project called \"glances\" [2] this looks promising and seems to be well maintained. I have no experience using it but it\u0027s something I can look at implementing in DevStack.\n\nThat all said, is disabling dstat a blocker here or could we for the sake of this Neutron effort have it temporarily disabled ? \n\n[0] https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619\n[1] https://github.com/scottchiefbaker/dool\n[2] https://github.com/nicolargo/glances","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"39e451c4cdd63282c9d1be3bee36468f464f2906","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"35db1177_af665bb0","line":488,"in_reply_to":"38377ee8_c5f05eb7","updated":"2021-05-17 11:43:17.000000000","message":"FYI, Lucas is testing the re-enablement of dstat in the multinode OVN jobs\nhttps://review.opendev.org/c/openstack/neutron/+/791720","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fb9831f69fb2780b9b57e435fd7c6ef198886fcd","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5c4f704e_afad2643","line":488,"in_reply_to":"94acc3ce_0f298592","updated":"2021-05-17 21:23:25.000000000","message":"Good news! It seems like the pcp-dstat version does work: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_6f2/791720/3/check/neutron-ovn-tempest-slow/6f25761/controller/logs/screen-dstat.txt\n\nThe DevStack patc is https://review.opendev.org/c/openstack/devstack/+/791749. And the test patch is https://review.opendev.org/c/openstack/neutron/+/791720","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"a50d9c625a42ab3bba8e232c9a8f6b6ca1656620","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"d1fa77f8_b442119e","line":488,"in_reply_to":"bfe60edb_6ef1edcb","updated":"2021-05-17 12:41:27.000000000","message":"With my upstream hat on, I\u0027d be hesitant to disabling dstat (and without an alternative to it) to accommodate a change to the default Neutron ML2 backend driver. Most non-Neutron projects do not care for what the network backend is, and their CI jobs would stop running dstat.\n\nControversially, there seems to exist a \"successor\", \"next-generation\" to dstat: pcp-dstat [1][2] (yes, the very same one that led dstat maintainers to archive the project). This tool seems to be somewhat a direct replacement and is packaged in most distributions [3].\n\n[1] https://www.man7.org/linux/man-pages/man1/pcp-dstat.1.html\n[2] https://pcp.io/\n[3] https://pkgs.org/download/dstat","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cfa98a3f5b3f1a498994f4d7f2308dc2a77def32","unresolved":true,"context_lines":[{"line_number":485,"context_line":"        # NOTE(lucasagomes): disable dstat until bug"},{"line_number":486,"context_line":"        # https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619 is"},{"line_number":487,"context_line":"        # fixed. Also see: https://bugs.launchpad.net/neutron/+bug/1898863"},{"line_number":488,"context_line":"        dstat: false"},{"line_number":489,"context_line":"        etcd3: true"},{"line_number":490,"context_line":"        memory_tracker: true"},{"line_number":491,"context_line":"        mysql: true"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"94acc3ce_0f298592","line":488,"in_reply_to":"d1fa77f8_b442119e","updated":"2021-05-17 12:58:29.000000000","message":"Thanks Carlos! I will give that a go: \n\nhttps://review.opendev.org/c/openstack/devstack/+/791749\n\nhttps://review.opendev.org/c/openstack/neutron/+/791720","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9737537f8a8f840716026a17cd67e0f61e75b826","unresolved":true,"context_lines":[{"line_number":468,"context_line":"        SWIFT_HASH: 1234123412341234"},{"line_number":469,"context_line":"        DEBUG_LIBVIRT_COREDUMPS: true"},{"line_number":470,"context_line":"        NOVA_VNC_ENABLED: true"},{"line_number":471,"context_line":"        Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":472,"context_line":"      devstack_local_conf:"},{"line_number":473,"context_line":"        post-config:"},{"line_number":474,"context_line":"          $NEUTRON_CONF:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ddaf3c38_e0a589f7","line":471,"range":{"start_line":471,"start_character":0,"end_line":471,"end_character":42},"updated":"2021-05-20 11:03:43.000000000","message":"My bad this should be OVN_L3_CREATE_PUBLIC_NETWORK: true instead.\n\nThe Q_USE_PROVIDERNET_FOR_PUBLIC is already True by default","commit_id":"4c7335ba3234fa70c45a8bc2f0e0b5febedbdb5b"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2e590fe7b5bf501962c9b6f4ef542ca6011d7b3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":17,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":18,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":19,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":20,"context_line":"if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"77240ea4_f7584291","line":17,"updated":"2021-05-17 10:40:33.000000000","message":"This comment would also need updating","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"876d2590e0324ea2af71fa293f7e584a5df18a65","unresolved":true,"context_lines":[{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Enable this to simply and quickly enable tunneling with ML2."},{"line_number":17,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":18,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":19,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":20,"context_line":"if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9bc82da9_2f4f6652","line":17,"in_reply_to":"77240ea4_f7584291","updated":"2021-05-18 08:41:08.000000000","message":"++","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e2e590fe7b5bf501962c9b6f4ef542ca6011d7b3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":18,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":19,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":20,"context_line":"if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" ]]; then"},{"line_number":21,"context_line":"    Q_TUNNEL_TYPES\u003d$Q_ML2_TENANT_NETWORK_TYPE"},{"line_number":22,"context_line":"elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"},{"line_number":23,"context_line":"    Q_TUNNEL_TYPES\u003dgre"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4b555a82_32b9c3b5","line":20,"updated":"2021-05-17 10:40:33.000000000","message":"Does this also need updating? Should we verify whether the network type matches what OVN can actually support?","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"876d2590e0324ea2af71fa293f7e584a5df18a65","unresolved":true,"context_lines":[{"line_number":17,"context_line":"# Select either \u0027gre\u0027, \u0027vxlan\u0027, or \u0027gre,vxlan\u0027"},{"line_number":18,"context_line":"Q_ML2_TENANT_NETWORK_TYPE\u003d${Q_ML2_TENANT_NETWORK_TYPE:-\"geneve\"}"},{"line_number":19,"context_line":"# This has to be set here since the agent will set this in the config file"},{"line_number":20,"context_line":"if [[ \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"gre\" || \"$Q_ML2_TENANT_NETWORK_TYPE\" \u003d\u003d \"vxlan\" ]]; then"},{"line_number":21,"context_line":"    Q_TUNNEL_TYPES\u003d$Q_ML2_TENANT_NETWORK_TYPE"},{"line_number":22,"context_line":"elif [[ \"$ENABLE_TENANT_TUNNELS\" \u003d\u003d \"True\" ]]; then"},{"line_number":23,"context_line":"    Q_TUNNEL_TYPES\u003dgre"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"f67824be_ee671c0a","line":20,"in_reply_to":"4b555a82_32b9c3b5","updated":"2021-05-18 08:41:08.000000000","message":"Not sure if needed, for not OVN only will support \"geneve\" for it\u0027s tunnel type. There\u0027s work to add support to vxlan in progress in core OVN but I do not think the released versions already does support it. Definitely not the one packaged on Ubuntu.","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f7f65a65be2925cb0b3976a3a52db03c7b2c22b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"_XTRACE_NEUTRON_ML2\u003d$(set +o | grep xtrace)"},{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Default openvswitch L2 agent"},{"line_number":11,"context_line":"Q_AGENT\u003d${Q_AGENT:-ovn}"},{"line_number":12,"context_line":"if [ -f $TOP_DIR/lib/neutron_plugins/${Q_AGENT}_agent ]; then"},{"line_number":13,"context_line":"    source $TOP_DIR/lib/neutron_plugins/${Q_AGENT}_agent"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"b28204ee_8f8db43c","line":10,"updated":"2021-05-21 12:18:57.000000000","message":"Amend this comment, too?","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cd2a8ec4936af10e204419f632816c57b56a6c3e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"_XTRACE_NEUTRON_ML2\u003d$(set +o | grep xtrace)"},{"line_number":8,"context_line":"set +o xtrace"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Default openvswitch L2 agent"},{"line_number":11,"context_line":"Q_AGENT\u003d${Q_AGENT:-ovn}"},{"line_number":12,"context_line":"if [ -f $TOP_DIR/lib/neutron_plugins/${Q_AGENT}_agent ]; then"},{"line_number":13,"context_line":"    source $TOP_DIR/lib/neutron_plugins/${Q_AGENT}_agent"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1679a4e4_13637886","line":10,"in_reply_to":"b28204ee_8f8db43c","updated":"2021-05-21 12:27:00.000000000","message":"Ops, if I need to respin I will change it","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"068ba35540af96af0e37a83d7cc17c74edd57a10","unresolved":true,"context_lines":[{"line_number":389,"context_line":"    sudo ln -s $OVS_RUNDIR $OVN_RUNDIR"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    if [[ \"$OVN_BUILD_FROM_SOURCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":392,"context_line":"        # Load devstack ovs base functions"},{"line_number":393,"context_line":"        source $NEUTRON_DIR/devstack/lib/ovs"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        # If OVS is already installed, remove it, because we\u0027re about to"},{"line_number":396,"context_line":"        # re-install it from source."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"8d0d0eae_1d32c0f2","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":44},"updated":"2021-05-16 23:59:54.000000000","message":"It feels kind of odd to keep this in neutron ... why is installing OVS a thing done here, but the compilation functions for OVS something kept in neutron?","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"99600f23c5a5b0fed456b4e7d9a34b7b953954ab","unresolved":true,"context_lines":[{"line_number":389,"context_line":"    sudo ln -s $OVS_RUNDIR $OVN_RUNDIR"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    if [[ \"$OVN_BUILD_FROM_SOURCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":392,"context_line":"        # Load devstack ovs base functions"},{"line_number":393,"context_line":"        source $NEUTRON_DIR/devstack/lib/ovs"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"        # If OVS is already installed, remove it, because we\u0027re about to"},{"line_number":396,"context_line":"        # re-install it from source."}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0ebb258d_05171448","line":393,"range":{"start_line":392,"start_character":0,"end_line":393,"end_character":44},"in_reply_to":"8d0d0eae_1d32c0f2","updated":"2021-05-17 08:51:24.000000000","message":"This is legacy because this \"ovs\" module always existed in Neutron AFAICT and we just reuse it because OVN depends on OVS (not long ago, both projects were part of the same repository so compiling OVS also compiled OVN).\n\nThat said, I think we could move the module to DevStack itself. I would need to consult with the Neutron folks about it but I don\u0027t see it as a problem.\n\nFor now, what this patch does is to only load it if we are actually telling DevStack to compile OVS/OVN from source. By default (and the reason why ensure-devstack does not fail anymore) we install OVS and OVN from the host OS packages.\n\nShould this be enough for this patch ? I can work on moving this module \"ovs\" module to DevStack on a separated patch.","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8f6ccc72080e1508ec4e66f047e9f5c38f4277a1","unresolved":true,"context_lines":[{"line_number":85,"context_line":"OVN_GENEVE_OVERHEAD\u003d${OVN_GENEVE_OVERHEAD:-38}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The log level of the OVN databases (north and south)"},{"line_number":88,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":91,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ecc3392e_acb90cde","line":88,"updated":"2021-05-20 08:50:50.000000000","message":"nit: I thought I had read it somewhere in this review but maybe it was elsewhere. Anyways... This setting would be best being conditional on DEBUG being True or False but it\u0027s mostly me nit-picking so not a blocker from my side :)","commit_id":"4c7335ba3234fa70c45a8bc2f0e0b5febedbdb5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"53917c2174dfba60a79f087aecac088a351f4365","unresolved":true,"context_lines":[{"line_number":85,"context_line":"OVN_GENEVE_OVERHEAD\u003d${OVN_GENEVE_OVERHEAD:-38}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# The log level of the OVN databases (north and south)"},{"line_number":88,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":91,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"b8edce1a_c08bcff3","line":88,"in_reply_to":"ecc3392e_acb90cde","updated":"2021-05-20 09:28:55.000000000","message":"Yeah, or at least I should also add in the comment what are the supported log levels that you can set here. According to [0] they are: off, emer, err, warn, info or dbg.\n\nIf I re-spin this patch I will add it.\n\n[0] https://man7.org/linux/man-pages/man8/ovs-appctl.8.html (grep for LOGGING COMMANDS)","commit_id":"4c7335ba3234fa70c45a8bc2f0e0b5febedbdb5b"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"8f6ccc72080e1508ec4e66f047e9f5c38f4277a1","unresolved":true,"context_lines":[{"line_number":91,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# If True (default) the node will be considered a gateway node. Set this"},{"line_number":94,"context_line":"# option to False on compute nodes."},{"line_number":95,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"8f1ce6cc_c2e3d6a0","line":94,"updated":"2021-05-20 08:50:50.000000000","message":"Does one necessarily always need to set it to False on compute nodes? What would be the expected setting under DVR scenarios where, per my understanding, computes act as gateways too?\n\nUpdate: reading now your latest comment on the previous patch set, it seems you indicated this setting this to be True on compute nodes for DVR deployments. While it would be best to clarify it in this comment, it\u0027s not a blocker for me either.","commit_id":"4c7335ba3234fa70c45a8bc2f0e0b5febedbdb5b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"53917c2174dfba60a79f087aecac088a351f4365","unresolved":true,"context_lines":[{"line_number":91,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# If True (default) the node will be considered a gateway node. Set this"},{"line_number":94,"context_line":"# option to False on compute nodes."},{"line_number":95,"context_line":"ENABLE_CHASSIS_AS_GW\u003d$(trueorfalse True ENABLE_CHASSIS_AS_GW)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"93345dba_e6c89f05","line":94,"in_reply_to":"8f1ce6cc_c2e3d6a0","updated":"2021-05-20 09:28:55.000000000","message":"Right yeah, maybe the part with \"set this option to False\" can be removed.\n\nWe currently do not support OVN DVR in DevStack :-( I have another patch for it.","commit_id":"4c7335ba3234fa70c45a8bc2f0e0b5febedbdb5b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"58e55538e06f72ba2d813de33b4b80b2ed68c41b","unresolved":true,"context_lines":[{"line_number":88,"context_line":"# Supported log levels are: off, emer, err, warn, info or dbg."},{"line_number":89,"context_line":"# More information about log levels can be found at"},{"line_number":90,"context_line":"# http://www.openvswitch.org/support/dist-docs/ovs-appctl.8.txt"},{"line_number":91,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":94,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"b0c53e31_e7f979af","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"updated":"2021-05-21 15:35:41.000000000","message":"why do we default to dbg?","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6774010b79238f3332d68f39dd81330a03b51abe","unresolved":true,"context_lines":[{"line_number":88,"context_line":"# Supported log levels are: off, emer, err, warn, info or dbg."},{"line_number":89,"context_line":"# More information about log levels can be found at"},{"line_number":90,"context_line":"# http://www.openvswitch.org/support/dist-docs/ovs-appctl.8.txt"},{"line_number":91,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":94,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"28fed350_9f23b0e0","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"in_reply_to":"016a6294_5617d64a","updated":"2021-05-22 14:31:32.000000000","message":"It can be chatty if there\u0027s a lot going on with the database (many transactions). So if you leave it running for longer yeah it may be a problem.\n\nIf Dr.Jens agrees I can move it back to info and set dbg for the gate only, I will ping you on IRC on Monday to discuss it","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"46f9bdc3e715741f184c6f5e3d396b9c18dfd8c0","unresolved":true,"context_lines":[{"line_number":88,"context_line":"# Supported log levels are: off, emer, err, warn, info or dbg."},{"line_number":89,"context_line":"# More information about log levels can be found at"},{"line_number":90,"context_line":"# http://www.openvswitch.org/support/dist-docs/ovs-appctl.8.txt"},{"line_number":91,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":94,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"016a6294_5617d64a","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"in_reply_to":"454d4d6e_8350735d","updated":"2021-05-21 17:04:11.000000000","message":"But that one was for CI only. Is not the dbg level too chatty when left running for longer?","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5f1409ee2d48a41000a5472f97a3695f8c0a32af","unresolved":true,"context_lines":[{"line_number":88,"context_line":"# Supported log levels are: off, emer, err, warn, info or dbg."},{"line_number":89,"context_line":"# More information about log levels can be found at"},{"line_number":90,"context_line":"# http://www.openvswitch.org/support/dist-docs/ovs-appctl.8.txt"},{"line_number":91,"context_line":"OVN_DBS_LOG_LEVEL\u003d${OVN_DBS_LOG_LEVEL:-dbg}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":94,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"454d4d6e_8350735d","line":91,"range":{"start_line":91,"start_character":39,"end_line":91,"end_character":42},"in_reply_to":"b0c53e31_e7f979af","updated":"2021-05-21 16:33:02.000000000","message":"It was asked on a previous review [0] to make the local.conf options that we were passed in the zuul definition default. So I looked at each one of them and made the change where it made sense.\n\nFor this one specifically, since DevStack is a tool for developers defaulting to debug mode sounded reasonable. \n\n[0] https://review.opendev.org/c/openstack/devstack/+/791436/5/.zuul.yaml","commit_id":"734ff8bef9b6201d00cc704c7fad09bb87171633"}],"stackrc":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"e25c4d1ed2c298022d53f311d22be42a1b1dce31","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    ENABLED_SERVICES+\u003d,g-api"},{"line_number":73,"context_line":"    # Cinder"},{"line_number":74,"context_line":"    ENABLED_SERVICES+\u003d,c-sch,c-api,c-vol"},{"line_number":75,"context_line":"    # OVN"},{"line_number":76,"context_line":"    ENABLED_SERVICES+\u003d,ovn-controller,ovn-northd,ovs-vswitchd,ovsdb-server"},{"line_number":77,"context_line":"    # Neutron"},{"line_number":78,"context_line":"    ENABLED_SERVICES+\u003d,q-svc,q-ovn-metadata-agent"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"22e322d8_7165bcfa","line":75,"updated":"2021-05-17 11:37:32.000000000","message":"Thanks for making this change, and not only to the Zuul CI jobs!","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dc152341957f2942f222f07041a6ead07c812816","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    ENABLED_SERVICES+\u003d,g-api"},{"line_number":73,"context_line":"    # Cinder"},{"line_number":74,"context_line":"    ENABLED_SERVICES+\u003d,c-sch,c-api,c-vol"},{"line_number":75,"context_line":"    # OVN"},{"line_number":76,"context_line":"    ENABLED_SERVICES+\u003d,ovn-controller,ovn-northd,ovs-vswitchd,ovsdb-server"},{"line_number":77,"context_line":"    # Neutron"},{"line_number":78,"context_line":"    ENABLED_SERVICES+\u003d,q-svc,q-ovn-metadata-agent"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"28157433_3a9f9d5d","line":75,"in_reply_to":"22e322d8_7165bcfa","updated":"2021-05-19 11:04:34.000000000","message":"You welcome! Thanks for the review","commit_id":"65d805fa186ddf6c64d1bb2c150e6a8f50c0bbf5"}]}