)]}'
{"tests/test_write_devstack_local_conf_role.sh":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7f2ec1ece616e740b91fbf71022f8bed5e500cfe","unresolved":true,"context_lines":[{"line_number":6,"context_line":"source $TOP/functions"},{"line_number":7,"context_line":"source $TOP/tests/unittest.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python3 ./roles/write-devstack-local-conf/library/test.py"}],"source_content_type":"text/x-sh","patch_set":1,"id":"0e67b6a5_da64af65","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"updated":"2021-05-19 12:42:08.000000000","message":"I was looking at tests/test_worlddump.sh, which is the other unit tests that explicitly calls python (and which has been passing), and it uses the PYTHON env var here.  (Not sure where it\u0027s being set, though.)  I wonder if this line should be:\n\n${PYTHON} $TOP/roles/write-devstack-local-conf/library/test.py","commit_id":"e612f5facb28aa4e329480df12104ba70e4ecd31"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fb63c3874ecee6c2b490867f3cf142eff3be174c","unresolved":true,"context_lines":[{"line_number":6,"context_line":"source $TOP/functions"},{"line_number":7,"context_line":"source $TOP/tests/unittest.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python3 ./roles/write-devstack-local-conf/library/test.py"}],"source_content_type":"text/x-sh","patch_set":1,"id":"2c185187_b07b780d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"0e67b6a5_da64af65","updated":"2021-05-19 12:53:05.000000000","message":"seems it\u0027s set here:\nhttps://opendev.org/openstack/devstack/src/commit/9ee7821e80731dc15f71f4e56233c3295497dd53/inc/python#L461\n\nThere is also a tool which sets it itself: \nhttps://opendev.org/openstack/devstack/src/commit/9ee7821e80731dc15f71f4e56233c3295497dd53/tools/memory_tracker.sh#L17\n\nstack.sh also uses \"$PYTHON $TOP_DIR\" logic:\nhttps://opendev.org/openstack/devstack/src/commit/9ee7821e80731dc15f71f4e56233c3295497dd53/stack.sh#L467-L474\n\nso it sounds reasonable to use the PYTHON var here instead","commit_id":"e612f5facb28aa4e329480df12104ba70e4ecd31"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"de8b341ce08b85327b1da4bee474127d5e42a225","unresolved":true,"context_lines":[{"line_number":6,"context_line":"source $TOP/functions"},{"line_number":7,"context_line":"source $TOP/tests/unittest.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python3 ./roles/write-devstack-local-conf/library/test.py"}],"source_content_type":"text/x-sh","patch_set":1,"id":"19f4f222_4c374a73","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":7},"in_reply_to":"2c185187_b07b780d","updated":"2021-05-19 15:01:57.000000000","message":"ah right that is better way. done","commit_id":"e612f5facb28aa4e329480df12104ba70e4ecd31"}],"tests/unittest.sh":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c449c13cb1684f3959d8dd86a85d5c5b76bbfbdd","unresolved":true,"context_lines":[{"line_number":17,"context_line":"PASS\u003d0"},{"line_number":18,"context_line":"FAILED_FUNCS\u003d\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"export PYTHON\u003d$(which python3 2\u003e/dev/null)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# pass a test, printing out MSG"},{"line_number":23,"context_line":"#  usage: passed message"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9f8d8112_3581ba10","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"updated":"2021-05-20 09:30:33.000000000","message":"shouldn\u0027t be \"3\" replace by \"${PYTHON3_VERSION}\" as it\u0027s in inc/python?\nThis will not work in case python3 is an alias:\n```\n$ PYTHON\u003d$(which python3 2\u003e/dev/null)\n$ echo $PYTHON\nalias python3\u003d\u0027\u0027\\\u0027\u0027python3.6\u0027\\\u0027\u0027\u0027\n```","commit_id":"f0736406f5ce055072a62a62fe9fdc7cead49671"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d16d26ce5a2b5871412f1a7ac2763cfbab9cc6e8","unresolved":true,"context_lines":[{"line_number":17,"context_line":"PASS\u003d0"},{"line_number":18,"context_line":"FAILED_FUNCS\u003d\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"export PYTHON\u003d$(which python3 2\u003e/dev/null)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# pass a test, printing out MSG"},{"line_number":23,"context_line":"#  usage: passed message"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bd8bc7e4_fcc91630","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"in_reply_to":"9f8d8112_3581ba10","updated":"2021-05-20 14:12:52.000000000","message":"in that case we need to source stackrc where PYTHON3_VERSION is defined which I thought is unnecessary in unit tests.","commit_id":"f0736406f5ce055072a62a62fe9fdc7cead49671"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2eab554d2d1341a62961ca84d3c94a006a149bd","unresolved":true,"context_lines":[{"line_number":17,"context_line":"PASS\u003d0"},{"line_number":18,"context_line":"FAILED_FUNCS\u003d\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"export PYTHON\u003d$(which python3 2\u003e/dev/null)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# pass a test, printing out MSG"},{"line_number":23,"context_line":"#  usage: passed message"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3e6c8a36_9760a750","line":20,"range":{"start_line":20,"start_character":28,"end_line":20,"end_character":29},"in_reply_to":"bd8bc7e4_fcc91630","updated":"2021-05-20 14:19:28.000000000","message":"that\u0027s correct .. it\u0027s ok as it is, i tested in on an env where python3 is an alias and ./run_tests.sh worked well","commit_id":"f0736406f5ce055072a62a62fe9fdc7cead49671"}]}