)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"18cd3b30324a17624bb82498cf7ba75b754762b5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change add an os-vif lib that declares two new"},{"line_number":10,"context_line":"variables OS_VIF_OVS_INTERFACE and OS_VIF_OVS_ISOLATE_VIF"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The former is introduced to workaround bug #1929466"},{"line_number":13,"context_line":"which cause the nova and neutron agents to periodically"},{"line_number":14,"context_line":"block waithing for ovs to respond."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25db17ff_ddd4dbca","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":51},"updated":"2021-06-17 12:11:10.000000000","message":"nit - bug #1929446","commit_id":"cd59b7a675c5a36fef9d2a924195512fed652415"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3f03e95b1ede53af95c71a4375790d92558b829","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change add an os-vif lib that declares two new"},{"line_number":10,"context_line":"variables OS_VIF_OVS_INTERFACE and OS_VIF_OVS_ISOLATE_VIF"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The former is introduced to workaround bug #1929466"},{"line_number":13,"context_line":"which cause the nova and neutron agents to periodically"},{"line_number":14,"context_line":"block waithing for ovs to respond."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"35653d0e_cdbb4342","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":51},"in_reply_to":"25db17ff_ddd4dbca","updated":"2021-06-17 12:17:12.000000000","message":"yep dumb typo will fix","commit_id":"cd59b7a675c5a36fef9d2a924195512fed652415"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4a5baf4c66898876b4ec4960fcf8ed2e42752f6f","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ml2/ovs vif isolation should always be used to prevent cross tenant"},{"line_number":17,"context_line":"traffic during a live migration.  This makes devstack more closely"},{"line_number":18,"context_line":"mirror reality by enabling it when ml2/ovs is used and disabling it"},{"line_number":19,"context_line":"otherwise."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-Bug: #1734320"},{"line_number":22,"context_line":"Related-Bug: #1929446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c942df57_76804133","line":19,"updated":"2021-06-18 16:37:17.000000000","message":"Is it possible that https://bugs.launchpad.net/neutron/+bug/1844712 is related to this as well? If so maybe we need to send an advisory to operators on how to configure this more appropriately?","commit_id":"5344885a61fe39565692014c15e0b4fb1055c835"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a845b6d06b7b38e8050d437b599f0d3f28731fb3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"ml2/ovs vif isolation should always be used to prevent cross tenant"},{"line_number":17,"context_line":"traffic during a live migration.  This makes devstack more closely"},{"line_number":18,"context_line":"mirror reality by enabling it when ml2/ovs is used and disabling it"},{"line_number":19,"context_line":"otherwise."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-Bug: #1734320"},{"line_number":22,"context_line":"Related-Bug: #1929446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"4c17e8ae_9207ac06","line":19,"in_reply_to":"c942df57_76804133","updated":"2021-06-18 16:41:05.000000000","message":"It\u0027s already related to an older secbug that has not been propagated too well I guess. Hence why I started http://lists.openstack.org/pipermail/openstack-discuss/2021-June/023171.html independently.","commit_id":"5344885a61fe39565692014c15e0b4fb1055c835"}],"lib/os-vif":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"30cb5c18746ff2ffa1d903b71418a22d7e7697ae","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_ml2_ovs {"},{"line_number":9,"context_line":"    if [[ \"${Q_AGENT}\" \u003d\u003d \"openvswitch\" ]]; then"},{"line_number":10,"context_line":"        return \"True\""},{"line_number":11,"context_line":"    fi"},{"line_number":12,"context_line":"    return \"False\""},{"line_number":13,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"763b965c_2b2d5772","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":14},"updated":"2021-06-17 12:21:17.000000000","message":"in bash you echo strign return value \n\nreturn has to be numeric","commit_id":"cd59b7a675c5a36fef9d2a924195512fed652415"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"74ba63ff3aff3948b0385140168fde3977f1aa17","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# support vsctl or native."},{"line_number":4,"context_line":"# until bug #1929446 is resolved we override the os-vif default"},{"line_number":5,"context_line":"# and fall back to the legacy  vsctl driver."},{"line_number":6,"context_line":"OS_VIF_OVS_INTERFACE\u003d${OS_VIF_OVS_INTERFACE:\u003d\"vsctl\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_ml2_ovs {"},{"line_number":9,"context_line":"    if [[ \"${Q_AGENT}\" \u003d\u003d \"openvswitch\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"838458ef_c0c9e4ec","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":10},"updated":"2021-06-17 19:37:54.000000000","message":"OVS_OVSDB, let\u0027s be precise","commit_id":"a709eb7491a097c7adee06160ad20899fbbd1289"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"0489c9d5e501959befb609a61e1f0483be87ff6c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# support vsctl or native."},{"line_number":4,"context_line":"# until bug #1929446 is resolved we override the os-vif default"},{"line_number":5,"context_line":"# and fall back to the legacy  vsctl driver."},{"line_number":6,"context_line":"OS_VIF_OVS_INTERFACE\u003d${OS_VIF_OVS_INTERFACE:\u003d\"vsctl\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_ml2_ovs {"},{"line_number":9,"context_line":"    if [[ \"${Q_AGENT}\" \u003d\u003d \"openvswitch\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5da60c7d_a7632958","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":10},"in_reply_to":"838458ef_c0c9e4ec","updated":"2021-06-18 08:47:09.000000000","message":"Done","commit_id":"a709eb7491a097c7adee06160ad20899fbbd1289"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"86bf73104d5bf15a71753e284ef78178bcaa391c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# support vsctl or native."},{"line_number":4,"context_line":"# until bug #1929446 is resolved we override the os-vif default"},{"line_number":5,"context_line":"# and fall back to the legacy  vsctl driver."},{"line_number":6,"context_line":"OS_VIF_OVSDB_INTERFACE\u003d${OS_VIF_OVSDB_INTERFACE:\u003d\"vsctl\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_ml2_ovs {"},{"line_number":9,"context_line":"    if [[ \"${Q_AGENT}\" \u003d\u003d \"openvswitch\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"09067c2f_132c1d0b","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":12},"updated":"2021-06-18 09:17:35.000000000","message":"I meant OVS_OVSDB (to mimic how the sections and options are called)","commit_id":"4c7afe5c961a75bbb0cdba1e2bc7de5920709182"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fc9fbe0b7d692e74d00f39b900fe592fe6529011","unresolved":true,"context_lines":[{"line_number":3,"context_line":"# support vsctl or native."},{"line_number":4,"context_line":"# until bug #1929446 is resolved we override the os-vif default"},{"line_number":5,"context_line":"# and fall back to the legacy  vsctl driver."},{"line_number":6,"context_line":"OS_VIF_OVSDB_INTERFACE\u003d${OS_VIF_OVSDB_INTERFACE:\u003d\"vsctl\"}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"function is_ml2_ovs {"},{"line_number":9,"context_line":"    if [[ \"${Q_AGENT}\" \u003d\u003d \"openvswitch\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"35dd2c9f_54b83832","line":6,"range":{"start_line":6,"start_character":7,"end_line":6,"end_character":12},"in_reply_to":"09067c2f_132c1d0b","updated":"2021-06-18 13:18:59.000000000","message":"sure i can change that.\n\nalso just in case people have not checked the logs\nwe can see that this is taking effect correctly here\nhttps://zuul.opendev.org/t/openstack/build/218e29232b5e4c47a6af5d091ecf34ec/log/compute1/logs/screen-n-cpu.txt#5-10\n\nthis is deprecated for removal becasue the native backend perform a lost better as the port count increase and in general  but obviously we cant remove the vsctl driver until we fix the bug that can cause the agent to hang on the connect to ovs.\n\nso we should not really worry that this is a deprecated option. i will remove this form devstack if/when we actully drop the vsctl driver and the issue with the native driver is fixed.","commit_id":"4c7afe5c961a75bbb0cdba1e2bc7de5920709182"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7614e99a6c24496dffef82aa74ca9372c8729961","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        iniset ${NOVA_CONF} os_vif_ovs isolate_vif ${OS_VIF_OVS_ISOLATE_VIF}"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"    if [[ -e ${NEUTRON_CONF} ]]; then"},{"line_number":26,"context_line":"        iniset ${NEUTRON_CONF} os_vif_ovs ovsdb_interface ${OS_VIF_OVS_OVSDB_INTERFACE}"},{"line_number":27,"context_line":"        iniset ${NEUTRON_CONF} os_vif_ovs isolate_vif ${OS_VIF_OVS_ISOLATE_VIF}"},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"2b084475_e2dd1fe5","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":57},"updated":"2021-06-22 14:15:43.000000000","message":"We don\u0027t support \"vsctl\" anymore since [1] (Queens).\n\nI know this problem is happening in Nova, but not in Neutron as far as I know.\n\n[1]https://review.opendev.org/c/openstack/neutron/+/503070","commit_id":"5344885a61fe39565692014c15e0b4fb1055c835"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"efb24878a789d72b55ac15eebec1914610a90c75","unresolved":true,"context_lines":[{"line_number":23,"context_line":"        iniset ${NOVA_CONF} os_vif_ovs isolate_vif ${OS_VIF_OVS_ISOLATE_VIF}"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"    if [[ -e ${NEUTRON_CONF} ]]; then"},{"line_number":26,"context_line":"        iniset ${NEUTRON_CONF} os_vif_ovs ovsdb_interface ${OS_VIF_OVS_OVSDB_INTERFACE}"},{"line_number":27,"context_line":"        iniset ${NEUTRON_CONF} os_vif_ovs isolate_vif ${OS_VIF_OVS_ISOLATE_VIF}"},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"08dd362d_602b1cf6","line":26,"range":{"start_line":26,"start_character":42,"end_line":26,"end_character":57},"in_reply_to":"2b084475_e2dd1fe5","updated":"2021-06-22 14:43:15.000000000","message":"Ok, nevermind, this is in the \"os_vif_ovs\" section (I need to read better). This just for the os-vif calls.\n\nOut of scope: maybe Neutron can pass an active IDL connection to os-vif to avoid creating a new one.","commit_id":"5344885a61fe39565692014c15e0b4fb1055c835"}],"stack.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e965e2ffe645483dd1b9e0181642a1b9dffa736c","unresolved":true,"context_lines":[{"line_number":1162,"context_line":"# os-vif"},{"line_number":1163,"context_line":"# ------"},{"line_number":1164,"context_line":"if is_service_enabled nova neutron; then"},{"line_number":1165,"context_line":"    configure_os_vif"},{"line_number":1166,"context_line":"fi"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"# Storage Service"}],"source_content_type":"text/x-sh","patch_set":4,"id":"f4cde1ff_08a55648","line":1165,"range":{"start_line":1165,"start_character":3,"end_line":1165,"end_character":20},"updated":"2021-06-17 12:47:01.000000000","message":"this needs to be after confiure_neutron is called so i had it to early in the last version since the neutron.conf was not present. although i proably should make the updates condtional on if the file exits.\nill do that now","commit_id":"a4d4c59a74d4ce998ee76d7b58b2178ccd5d1e18"}]}