)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"895ae1169100ca085d4a5eb6c75490d5e6d3be4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cee20e1c_6de2e315","updated":"2021-11-16 16:35:53.000000000","message":"lgtm, but let\u0027s wait for the oslo policy patch to merge/release first.\n\n+1 until then otherwise I am +2 on this.","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7991060152d777e285375540fa2f7a5b423f9f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3d6dc4c4_175e8133","updated":"2021-12-21 15:44:59.000000000","message":"thanks, job is working with scope enabled https://zuul.opendev.org/t/openstack/build/37b46c774f874242b2ce7ccff8d9ab97/log/controller/logs/etc/neutron/neutron_conf.txt#1831","commit_id":"24b65adc9cedff9c7a8ab412fb39613ef5d4a627"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"00d2c76ba0acf8ae815e7b98109d6fee66616112","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1410890d_8895cd15","updated":"2021-12-22 19:08:57.000000000","message":"worky - approvy!","commit_id":"24b65adc9cedff9c7a8ab412fb39613ef5d4a627"}],"lib/neutron":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f14969d4c53e621150c06c3ac7fe357823912e31","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# If NEUTRON_ENFORCE_SCOPE \u003d\u003d True, it will set \"enforce_scope\""},{"line_number":41,"context_line":"# and \"enforce_new_defaults\" to True in the Neutron\u0027s config to enforce usage"},{"line_number":42,"context_line":"# of the new RBAC policies and scopes."},{"line_number":43,"context_line":"NEUTRON_ENFORCE_SCOPE\u003d$(trueorfalse False NEUTRON_ENFORCE_SCOPE)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"NEUTRON_DISTRIBUTED_ROUTING\u003d$(trueorfalse False NEUTRON_DISTRIBUTED_ROUTING)"},{"line_number":46,"context_line":"# Distributed Virtual Router (DVR) configuration"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"a87cc694_774bc860","line":43,"updated":"2021-08-05 20:36:33.000000000","message":"Do we have any neutron jobs that run with this turned on or is that coming in a subsequent patch?","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ae921b262bfd1d5febe78d49bf54e0bc4255e7a","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# If NEUTRON_ENFORCE_SCOPE \u003d\u003d True, it will set \"enforce_scope\""},{"line_number":41,"context_line":"# and \"enforce_new_defaults\" to True in the Neutron\u0027s config to enforce usage"},{"line_number":42,"context_line":"# of the new RBAC policies and scopes."},{"line_number":43,"context_line":"NEUTRON_ENFORCE_SCOPE\u003d$(trueorfalse False NEUTRON_ENFORCE_SCOPE)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"NEUTRON_DISTRIBUTED_ROUTING\u003d$(trueorfalse False NEUTRON_DISTRIBUTED_ROUTING)"},{"line_number":46,"context_line":"# Distributed Virtual Router (DVR) configuration"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"68557cc7_b796ad4b","line":43,"in_reply_to":"35c105ea_08abee4f","updated":"2021-08-06 06:31:51.000000000","message":"I have WIP patch https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/796612 which depends on this one and deploys neutron-tempest-plugin-api job with those new defaults. Deployment works fine there but there is a lot of work to do to fix tests there.\nBut I think that is next step really and shouldn\u0027t block this devstack patch.","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d70e6d47890e1c92463fcb21b031ae346a51120","unresolved":true,"context_lines":[{"line_number":40,"context_line":"# If NEUTRON_ENFORCE_SCOPE \u003d\u003d True, it will set \"enforce_scope\""},{"line_number":41,"context_line":"# and \"enforce_new_defaults\" to True in the Neutron\u0027s config to enforce usage"},{"line_number":42,"context_line":"# of the new RBAC policies and scopes."},{"line_number":43,"context_line":"NEUTRON_ENFORCE_SCOPE\u003d$(trueorfalse False NEUTRON_ENFORCE_SCOPE)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"NEUTRON_DISTRIBUTED_ROUTING\u003d$(trueorfalse False NEUTRON_DISTRIBUTED_ROUTING)"},{"line_number":46,"context_line":"# Distributed Virtual Router (DVR) configuration"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"35c105ea_08abee4f","line":43,"in_reply_to":"a87cc694_774bc860","updated":"2021-08-05 22:21:59.000000000","message":"I have patch to add a scope enabled job. added neutron flag also there but test will fail as they need to migrate to scoped token as per new policy.\n\n- https://review.opendev.org/c/openstack/tempest/+/614484","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6746b30cc234b251f01aabfc83826620c3c55002","unresolved":true,"context_lines":[{"line_number":623,"context_line":"function configure_rbac_policies {"},{"line_number":624,"context_line":"    if [ \"$NEUTRON_ENFORCE_SCOPE\" \u003d\u003d \"True\" ]; then"},{"line_number":625,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults True"},{"line_number":626,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope True"},{"line_number":627,"context_line":"    else"},{"line_number":628,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults False"},{"line_number":629,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope False"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"479f28f0_eaca6959","line":626,"range":{"start_line":626,"start_character":55,"end_line":626,"end_character":59},"updated":"2021-08-09 16:06:00.000000000","message":"Last I checked, I wasn\u0027t able to get this to work with Neutron [0].\n\nI think this will set the option, but oslo.policy won\u0027t actually fail if you pass it mismatching scope and credentials.\n\nI suspect that\u0027s because neutron subclasses BaseCheck and the enforcement code isn\u0027t dealing with type checking properly? I think we should try and fix up that behavior either in neutron or oslo.policy before merging this since it could be misleading to readers thinking they\u0027re enforcing scope only to have the behavior not work (or worse, a deployer).\n\n[0] https://bugs.launchpad.net/oslo.policy/+bug/1923503","commit_id":"8e1d8b2630a9588f22f7ad310ce0308a3d000131"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ada0861157ca66116042d44f3857c09187d0bab0","unresolved":true,"context_lines":[{"line_number":623,"context_line":"function configure_rbac_policies {"},{"line_number":624,"context_line":"    if [ \"$NEUTRON_ENFORCE_SCOPE\" \u003d\u003d \"True\" ]; then"},{"line_number":625,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults True"},{"line_number":626,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope True"},{"line_number":627,"context_line":"    else"},{"line_number":628,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults False"},{"line_number":629,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope False"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"90715d36_fda0b6d3","line":626,"range":{"start_line":626,"start_character":41,"end_line":626,"end_character":59},"updated":"2021-08-18 19:18:53.000000000","message":"Should we make this dependent on https://review.opendev.org/c/openstack/oslo.policy/+/804980\n\nOr at least a version of oslo.policy with that fix?","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"895ae1169100ca085d4a5eb6c75490d5e6d3be4b","unresolved":true,"context_lines":[{"line_number":623,"context_line":"function configure_rbac_policies {"},{"line_number":624,"context_line":"    if [ \"$NEUTRON_ENFORCE_SCOPE\" \u003d\u003d \"True\" ]; then"},{"line_number":625,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults True"},{"line_number":626,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope True"},{"line_number":627,"context_line":"    else"},{"line_number":628,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults False"},{"line_number":629,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope False"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"95caea91_aefe0586","line":626,"range":{"start_line":626,"start_character":41,"end_line":626,"end_character":59},"in_reply_to":"90715d36_fda0b6d3","updated":"2021-11-16 16:35:53.000000000","message":"yeah, oslo.policy patch is waiting for neutron patch to merge (https://review.opendev.org/c/openstack/neutron/+/815838) Once that is merged I can push a new release for oslo.policy and then we can merge this patch","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"caebea7fe8b2c48f9496b8ef49dd64c843e9c95d","unresolved":true,"context_lines":[{"line_number":623,"context_line":"function configure_rbac_policies {"},{"line_number":624,"context_line":"    if [ \"$NEUTRON_ENFORCE_SCOPE\" \u003d\u003d \"True\" ]; then"},{"line_number":625,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults True"},{"line_number":626,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope True"},{"line_number":627,"context_line":"    else"},{"line_number":628,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults False"},{"line_number":629,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope False"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"e82cff15_f7e9369b","line":626,"range":{"start_line":626,"start_character":41,"end_line":626,"end_character":59},"in_reply_to":"95caea91_aefe0586","updated":"2021-12-20 13:44:34.000000000","message":"That fix in oslo.policy is already merged and available in 3.10.1. I think we can move on with that patch now, wdyt?","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e7991060152d777e285375540fa2f7a5b423f9f2","unresolved":true,"context_lines":[{"line_number":623,"context_line":"function configure_rbac_policies {"},{"line_number":624,"context_line":"    if [ \"$NEUTRON_ENFORCE_SCOPE\" \u003d\u003d \"True\" ]; then"},{"line_number":625,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults True"},{"line_number":626,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope True"},{"line_number":627,"context_line":"    else"},{"line_number":628,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_new_defaults False"},{"line_number":629,"context_line":"        iniset $NEUTRON_CONF oslo_policy enforce_scope False"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"f316799c_d045f546","line":626,"range":{"start_line":626,"start_character":41,"end_line":626,"end_character":59},"in_reply_to":"e82cff15_f7e9369b","updated":"2021-12-21 15:44:59.000000000","message":"thanks, and u-c also updated with 3.10.1 https://github.com/openstack/requirements/blob/8b5e97b6563f076206b0bfc7276ea9afd179e6b7/upper-constraints.txt#L507","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32b8734347473ff1a1c49fbdf897a029d86d2fe9","unresolved":true,"context_lines":[{"line_number":115,"context_line":"    echo \"$opts\""},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"function _configure_neutron_l3_agent {"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"b227daff_40b38107","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":0},"updated":"2021-07-28 17:57:42.000000000","message":"programming with empty lines?","commit_id":"1f52b9efc102e2b3de7f509117c5f7a8c71677f7"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6ca63d0794645a52038702179f64ec05063cf57","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    echo \"$opts\""},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"function _configure_neutron_l3_agent {"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"2830d8c9_19e68d7d","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":0},"in_reply_to":"b227daff_40b38107","updated":"2021-08-04 13:21:58.000000000","message":"Done","commit_id":"1f52b9efc102e2b3de7f509117c5f7a8c71677f7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e157fd482bf5ed79a2e4ea70a174a73905cdee6c","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    if is_networking_extension_supported \"auto-allocated-topology\"; then"},{"line_number":183,"context_line":"        if [[ \"$USE_SUBNETPOOL\" \u003d\u003d \"True\" ]]; then"},{"line_number":184,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":185,"context_line":"                SUBNETPOOL_V4_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V4 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V4 --pool-prefix $SUBNETPOOL_PREFIX_V4 --share --default -f value -c id)"},{"line_number":186,"context_line":"            fi"},{"line_number":187,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ .*6 ]]; then"},{"line_number":188,"context_line":"                SUBNETPOOL_V6_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V6 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V6 --pool-prefix $SUBNETPOOL_PREFIX_V6 --share --default -f value -c id)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"c5551fea_5e54db2d","line":185,"range":{"start_line":185,"start_character":58,"end_line":185,"end_character":82},"updated":"2021-08-05 20:35:43.000000000","message":"If you do this as a system-admin, it\u0027ll still put the subnet in the right project, which is why the --project bit is necessary?","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3607387e1cae38e2ac45fb40c334412d6132989","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    if is_networking_extension_supported \"auto-allocated-topology\"; then"},{"line_number":183,"context_line":"        if [[ \"$USE_SUBNETPOOL\" \u003d\u003d \"True\" ]]; then"},{"line_number":184,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":185,"context_line":"                SUBNETPOOL_V4_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V4 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V4 --pool-prefix $SUBNETPOOL_PREFIX_V4 --share --default -f value -c id)"},{"line_number":186,"context_line":"            fi"},{"line_number":187,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ .*6 ]]; then"},{"line_number":188,"context_line":"                SUBNETPOOL_V6_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V6 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V6 --pool-prefix $SUBNETPOOL_PREFIX_V6 --share --default -f value -c id)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"e5449fef_1b97114e","line":185,"range":{"start_line":185,"start_character":58,"end_line":185,"end_character":82},"in_reply_to":"c5551fea_5e54db2d","updated":"2021-08-05 22:02:13.000000000","message":"I think so, for neutron it is easy as these API take project id as request param and system admin can create subnet/network etc for specific project.","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ae921b262bfd1d5febe78d49bf54e0bc4255e7a","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    if is_networking_extension_supported \"auto-allocated-topology\"; then"},{"line_number":183,"context_line":"        if [[ \"$USE_SUBNETPOOL\" \u003d\u003d \"True\" ]]; then"},{"line_number":184,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ 4.* ]]; then"},{"line_number":185,"context_line":"                SUBNETPOOL_V4_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V4 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V4 --pool-prefix $SUBNETPOOL_PREFIX_V4 --share --default -f value -c id)"},{"line_number":186,"context_line":"            fi"},{"line_number":187,"context_line":"            if [[ \"$IP_VERSION\" \u003d~ .*6 ]]; then"},{"line_number":188,"context_line":"                SUBNETPOOL_V6_ID\u003d$(openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet pool create $SUBNETPOOL_NAME_V6 --project \"$admin_project_id\" --default-prefix-length $SUBNETPOOL_SIZE_V6 --pool-prefix $SUBNETPOOL_PREFIX_V6 --share --default -f value -c id)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"898d66c0_6adfe753","line":185,"range":{"start_line":185,"start_character":58,"end_line":185,"end_character":82},"in_reply_to":"e5449fef_1b97114e","updated":"2021-08-06 06:31:51.000000000","message":"Exactly. Passing that project id will not hurt even if old rules and scopes are used as in such case it will just be same project_id as in context.\nFor new scopes it is necessary to pass it that way when system_admin user is making request.","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"895ae1169100ca085d4a5eb6c75490d5e6d3be4b","unresolved":true,"context_lines":[{"line_number":170,"context_line":"    project_id\u003d$(openstack project list | grep \" demo \" | get_field 1)"},{"line_number":171,"context_line":"    die_if_not_set $LINENO project_id \"Failure retrieving project_id for demo\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    local admin_project_id"},{"line_number":174,"context_line":"    admin_project_id\u003d$(openstack project list | grep \" admin \" | get_field 1)"},{"line_number":175,"context_line":"    die_if_not_set $LINENO admin_project_id \"Failure retrieving project_id for admin\""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    # Allow drivers that need to create an initial network to do so here"},{"line_number":178,"context_line":"    if type -p neutron_plugin_create_initial_network_profile \u003e /dev/null; then"},{"line_number":179,"context_line":"        neutron_plugin_create_initial_network_profile $PHYSICAL_NETWORK"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"b45dd93a_ac725aaf","line":176,"range":{"start_line":173,"start_character":0,"end_line":176,"end_character":0},"updated":"2021-11-16 16:35:53.000000000","message":"+1, there is no change in situation here. for system user case also network will be created for project admin. later on if needed, we can make it configuration like configure project to create network for.","commit_id":"87a45e66386df94a6acda9c7567070930ade54b5"}],"lib/tempest":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d3607387e1cae38e2ac45fb40c334412d6132989","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    if [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]] \u0026\u0026 is_networking_extension_supported \u0027external-net\u0027; then"},{"line_number":292,"context_line":"        public_network_id\u003d$(openstack --os-cloud devstack-admin network show -f value -c id $PUBLIC_NETWORK_NAME)"},{"line_number":293,"context_line":"        # make sure shared network presence does not confuses the tempest tests"},{"line_number":294,"context_line":"        openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" network create --share shared --project \"$admin_project_id\""},{"line_number":295,"context_line":"        openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet create --description shared-subnet --subnet-range ${TEMPEST_SHARED_POOL:-192.168.233.0/24} --network shared shared-subnet --project \"$admin_project_id\""},{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"4310fd96_9d1ff1a1","line":294,"range":{"start_line":294,"start_character":114,"end_line":294,"end_character":143},"updated":"2021-08-05 22:02:13.000000000","message":"do we need to pass the project id for shared network too? I mean can shared network be created without associating under any specific project ?","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ae921b262bfd1d5febe78d49bf54e0bc4255e7a","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    if [[ \"$NEUTRON_CREATE_INITIAL_NETWORKS\" \u003d\u003d \"True\" ]] \u0026\u0026 is_networking_extension_supported \u0027external-net\u0027; then"},{"line_number":292,"context_line":"        public_network_id\u003d$(openstack --os-cloud devstack-admin network show -f value -c id $PUBLIC_NETWORK_NAME)"},{"line_number":293,"context_line":"        # make sure shared network presence does not confuses the tempest tests"},{"line_number":294,"context_line":"        openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" network create --share shared --project \"$admin_project_id\""},{"line_number":295,"context_line":"        openstack --os-cloud \"$NEUTRON_ADMIN_CLOUD_NAME\" --os-region \"$REGION_NAME\" subnet create --description shared-subnet --subnet-range ${TEMPEST_SHARED_POOL:-192.168.233.0/24} --network shared shared-subnet --project \"$admin_project_id\""},{"line_number":296,"context_line":"    fi"},{"line_number":297,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bb96d575_1bb127d3","line":294,"range":{"start_line":294,"start_character":114,"end_line":294,"end_character":143},"in_reply_to":"4310fd96_9d1ff1a1","updated":"2021-08-06 06:31:51.000000000","message":"We do need it. In Neutron there is no way to create resources like network without owner project.","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4d70e6d47890e1c92463fcb21b031ae346a51120","unresolved":true,"context_lines":[{"line_number":443,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":444,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":445,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_PORT_SECURITY"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    # Scenario"},{"line_number":448,"context_line":"    SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":449,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"98e8c0ee_74a19f8a","line":446,"range":{"start_line":446,"start_character":0,"end_line":446,"end_character":0},"updated":"2021-08-05 22:21:59.000000000","message":"please enable the flag on tempest side also to test with scoep token\n\niniset $TEMPEST_CONFIG enforce_scope neutron \"$NEUTRON_ENFORCE_SCOPE\"\n\nlike done for other services - https://review.opendev.org/c/openstack/devstack/+/779085/1/lib/tempest","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1ae921b262bfd1d5febe78d49bf54e0bc4255e7a","unresolved":false,"context_lines":[{"line_number":443,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6 \"$IPV6_ENABLED\""},{"line_number":444,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled ipv6_subnet_attributes \"$IPV6_SUBNET_ATTRIBUTES_ENABLED\""},{"line_number":445,"context_line":"    iniset $TEMPEST_CONFIG network-feature-enabled port_security $NEUTRON_PORT_SECURITY"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"    # Scenario"},{"line_number":448,"context_line":"    SCENARIO_IMAGE_DIR\u003d${SCENARIO_IMAGE_DIR:-$FILES}"},{"line_number":449,"context_line":"    SCENARIO_IMAGE_FILE\u003d$DEFAULT_IMAGE_FILE_NAME"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"dfdc8baa_c535c432","line":446,"range":{"start_line":446,"start_character":0,"end_line":446,"end_character":0},"in_reply_to":"98e8c0ee_74a19f8a","updated":"2021-08-06 06:31:51.000000000","message":"Done","commit_id":"3b51e4abcf602ab652fde18f9745c7a1c483a3a4"}]}