)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4613beb59b264e5d093a1d5a04f8ef06e4c8fb1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6bfe7e52_df45ddb8","updated":"2021-12-09 08:35:53.000000000","message":"I\u0027m testing it in https://review.opendev.org/c/openstack/devstack/+/799621 with all Neutron jobs","commit_id":"418535883763cb31e54ab3882ee3eacc42afd4f3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7baef9869bc19277ed8a5703e8fd95efcb97f008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2cc5dcc3_f5c7d66f","updated":"2022-01-04 14:13:38.000000000","message":"makes sense, testing patch passes and we have a good number of +1s as well","commit_id":"418535883763cb31e54ab3882ee3eacc42afd4f3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2b86d95a8bc049e2047a11d312d8edc1af87339a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e746c013_d5a253dc","updated":"2022-01-05 19:23:30.000000000","message":"recheck","commit_id":"418535883763cb31e54ab3882ee3eacc42afd4f3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a86eb10c05747c1ed02dceabc99c676ad625723f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a697d37_3fc9e25d","in_reply_to":"6bfe7e52_df45ddb8","updated":"2021-12-20 07:34:41.000000000","message":"Sorry, correct link is https://review.opendev.org/c/openstack/neutron/+/821163","commit_id":"418535883763cb31e54ab3882ee3eacc42afd4f3"}],"lib/neutron_plugins/ovs_base":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28c461b4ea73452a88f069120f5a3df7c2443f3e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"89358613_f2fdd20c","line":63,"updated":"2021-07-06 14:25:42.000000000","message":"Nit: IIUC this comment should be moved together with the line below","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88ec8cb6b96b8627776ce626643325a0c3fe54e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ca7ef898_1b7018ea","line":63,"in_reply_to":"89358613_f2fdd20c","updated":"2021-08-10 20:35:06.000000000","message":"Done","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28c461b4ea73452a88f069120f5a3df7c2443f3e","unresolved":true,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"},{"line_number":67,"context_line":"        load_conntrack_gre_module"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"4c26818e_5109a172","line":64,"updated":"2021-07-06 14:25:42.000000000","message":"This variable is defined locally in lib/neutron_plugins/ovn_agent, not sure whether you can you it here without issues","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88ec8cb6b96b8627776ce626643325a0c3fe54e","unresolved":true,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"},{"line_number":67,"context_line":"        load_conntrack_gre_module"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a4595dca_c641d92a","line":64,"in_reply_to":"4c26818e_5109a172","updated":"2021-08-10 20:35:06.000000000","message":"I moved it\u0027s definition here as this file is sourced in the lib/neutron_plugins/ovn_agent too","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28c461b4ea73452a88f069120f5a3df7c2443f3e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"},{"line_number":67,"context_line":"        load_conntrack_gre_module"},{"line_number":68,"context_line":"        start_new_ovs"},{"line_number":69,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"efbcd7db_a9a654cf","line":66,"range":{"start_line":65,"start_character":8,"end_line":66,"end_character":35},"updated":"2021-07-06 14:25:42.000000000","message":"Similar issue for these functions which come from lib/neutron_plugins/ovs_source. Do these files need to be included here? How best to avoid cyclic dependencies?\nAlso, do we need a job to check that this combination actually works? Is there one in Neutron?","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88ec8cb6b96b8627776ce626643325a0c3fe54e","unresolved":true,"context_lines":[{"line_number":62,"context_line":"function _neutron_ovs_base_install_agent_packages {"},{"line_number":63,"context_line":"    # Install deps"},{"line_number":64,"context_line":"    if [ \"$Q_BUILD_OVS_FROM_GIT\" \u003d\u003d \"True\" ]; then"},{"line_number":65,"context_line":"        remove_ovs_packages"},{"line_number":66,"context_line":"        compile_ovs False /usr /var"},{"line_number":67,"context_line":"        load_conntrack_gre_module"},{"line_number":68,"context_line":"        start_new_ovs"},{"line_number":69,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b9652ce2_baced142","line":66,"range":{"start_line":65,"start_character":8,"end_line":66,"end_character":35},"in_reply_to":"efbcd7db_a9a654cf","updated":"2021-08-10 20:35:06.000000000","message":"I sourced that file here too.\nRegarding job, that\u0027s good question. I think we don\u0027t have such job which would install ML2/OVS and ovs from source. I will do at least DNM patch with such job for now.","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"28c461b4ea73452a88f069120f5a3df7c2443f3e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            restart_service openvswitch"},{"line_number":76,"context_line":"            sudo systemctl enable openvswitch"},{"line_number":77,"context_line":"        elif is_suse; then"},{"line_number":78,"context_line":"            if [[ $DISTRO \u003d\u003d \"sle12\" ]] \u0026\u0026 vercmp \"$os_RELEASE\" \"\u003c\" \"12.2\" ; then"},{"line_number":79,"context_line":"                restart_service openvswitch-switch"},{"line_number":80,"context_line":"            else"},{"line_number":81,"context_line":"                # workaround for https://bugzilla.suse.com/show_bug.cgi?id\u003d1085971"},{"line_number":82,"context_line":"                if [[ $DISTRO \u003d~ \"tumbleweed\" ]]; then"},{"line_number":83,"context_line":"                    sudo sed -i -e \"s,^OVS_USER_ID\u003d.*,OVS_USER_ID\u003d\u0027root:root\u0027,\" /etc/sysconfig/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"63020408_4ba3f4fc","line":80,"range":{"start_line":78,"start_character":12,"end_line":80,"end_character":16},"updated":"2021-07-06 14:25:42.000000000","message":"We only support some suse 15.x now, so just drop this? Might be done in a followup though if you prefer.","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88ec8cb6b96b8627776ce626643325a0c3fe54e","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            restart_service openvswitch"},{"line_number":76,"context_line":"            sudo systemctl enable openvswitch"},{"line_number":77,"context_line":"        elif is_suse; then"},{"line_number":78,"context_line":"            if [[ $DISTRO \u003d\u003d \"sle12\" ]] \u0026\u0026 vercmp \"$os_RELEASE\" \"\u003c\" \"12.2\" ; then"},{"line_number":79,"context_line":"                restart_service openvswitch-switch"},{"line_number":80,"context_line":"            else"},{"line_number":81,"context_line":"                # workaround for https://bugzilla.suse.com/show_bug.cgi?id\u003d1085971"},{"line_number":82,"context_line":"                if [[ $DISTRO \u003d~ \"tumbleweed\" ]]; then"},{"line_number":83,"context_line":"                    sudo sed -i -e \"s,^OVS_USER_ID\u003d.*,OVS_USER_ID\u003d\u0027root:root\u0027,\" /etc/sysconfig/openvswitch"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"41395106_740fb56c","line":80,"range":{"start_line":78,"start_character":12,"end_line":80,"end_character":16},"in_reply_to":"63020408_4ba3f4fc","updated":"2021-08-10 20:35:06.000000000","message":"I would do it in follow up","commit_id":"4e8eb50073b5d61ed0673f6e3fd2608a3e02a786"}],"lib/neutron_plugins/ovs_source":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ee3f44e8e44cd83e695a77c66917c444526611a4","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Defaults"},{"line_number":16,"context_line":"# --------"},{"line_number":17,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d$(trueorfalse False Q_BUILD_OVS_FROM_GIT)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Set variables for building OVS from source"},{"line_number":20,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"f6e4e407_3ac415b0","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":40},"updated":"2021-10-15 16:35:59.000000000","message":"Now the default value is False. This is why in [1] we never install OVN (nor OVS) and system-id does not exist:\n  2021-10-14 12:50:53.016016 | controller | tee: /etc/openvswitch/system-id.conf: No such file or directory\n\n[1]https://github.com/openstack/devstack/blob/82facd6edf7cefac1ab68de4fe9054d7c4cb50db/lib/neutron_plugins/ovn_agent#L344-L346","commit_id":"749ae0f62c58b0beb726809e9fb71a0ac2c3c586"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ace2abfa38f6a9dddff64f3bc6643853eecde684","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Defaults"},{"line_number":16,"context_line":"# --------"},{"line_number":17,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d$(trueorfalse False Q_BUILD_OVS_FROM_GIT)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Set variables for building OVS from source"},{"line_number":20,"context_line":"OVS_REPO\u003d${OVS_REPO:-https://github.com/openvswitch/ovs.git}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1b036c25_bac01f83","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":40},"in_reply_to":"f6e4e407_3ac415b0","updated":"2021-12-08 14:20:59.000000000","message":"Done","commit_id":"749ae0f62c58b0beb726809e9fb71a0ac2c3c586"}]}