)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"465175976f05ca5af83356671917e81735dd5acf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ade Lee \u003calee@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-23 09:55:34 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add option to set chap algoorithms for iscsid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default CHAP algorithm for iscsid is md5, which is disallowed"},{"line_number":10,"context_line":"under fips.  We need an option to set the chap algorighms to something"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c3e0d06a_820dedf4","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":35},"updated":"2021-08-24 17:14:18.000000000","message":"nit: algorithms","commit_id":"8101e4e280b3db2f4c6b52221a9700490dde5d98"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"2c00f55e1ce4ce3dcd01c4b6db765b4088d615bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9eb62282_878effc6","updated":"2021-12-30 07:12:42.000000000","message":"recheck more gate fixed","commit_id":"c3b7051387d4332f956148c5676383499fa31859"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a877b7ced9db0cbacaff9c968ce12dafcd911998","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"636c29c7_e12769c5","updated":"2021-12-29 15:33:55.000000000","message":"recheck paramiko capped","commit_id":"c3b7051387d4332f956148c5676383499fa31859"}],"stack.sh":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f76c232cd5ad9c620b3edcd77bd02fd4bed054f4","unresolved":true,"context_lines":[{"line_number":1027,"context_line":"# Configure iscscid chap algorithms if needed"},{"line_number":1028,"context_line":"# -------------------------------------------"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"if [[ -n $ISCI_CHAP_ALGORITHMS ]]; then"},{"line_number":1031,"context_line":"    if [[ -f /etc/iscsi/iscsid.conf ]]; then"},{"line_number":1032,"context_line":"        iniset -sudo /etc/iscsi/iscsid.conf DEFAULT \"node.session.auth.chap_algs\" $ISCI_CHAP_ALGORITHMS"},{"line_number":1033,"context_line":"        restart_service iscsid"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1345eeb4_100c58b1","line":1030,"range":{"start_line":1030,"start_character":10,"end_line":1030,"end_character":15},"updated":"2021-08-19 02:27:55.000000000","message":"I think this should be ISCSI_ because that\u0027s what people will type from force of habit, and then they\u0027ll wonder why the setting isn\u0027t having any effect.","commit_id":"f0cae07ca06952c01fe85e1f063b73418f2d0c2d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d60006118bfa4c21e3ad6e29b1c21be40b109d51","unresolved":true,"context_lines":[{"line_number":1044,"context_line":"        iniset -sudo /etc/iscsi/iscsid.conf DEFAULT \"node.session.auth.chap_algs\" \"SHA3-256,SHA256\""},{"line_number":1045,"context_line":"        restart_service iscsid"},{"line_number":1046,"context_line":"    fi"},{"line_number":1047,"context_line":"fi"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"# Start Services"},{"line_number":1050,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"b0c12408_6b6a05c7","line":1047,"updated":"2021-11-09 23:53:49.000000000","message":"Is there any reason to not default to sha2/sha3 everywhere? I think as much as possible we should try to avoid adding more options to devstack if we can choose sane defaults that work in as many places as possible.","commit_id":"6c8348645d71e9141f6a04b79c4c74d1f77c2c91"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"dd72c72c2c15f62abcfb9f49d59bee7df0a4aa3a","unresolved":true,"context_lines":[{"line_number":1044,"context_line":"        iniset -sudo /etc/iscsi/iscsid.conf DEFAULT \"node.session.auth.chap_algs\" \"SHA3-256,SHA256\""},{"line_number":1045,"context_line":"        restart_service iscsid"},{"line_number":1046,"context_line":"    fi"},{"line_number":1047,"context_line":"fi"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"# Start Services"},{"line_number":1050,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"80647068_6cde5dfc","line":1047,"in_reply_to":"b0c12408_6b6a05c7","updated":"2021-11-13 14:53:42.000000000","message":"I agree with clark, if this setting works for ubuntu and debian, let\u0027s simply make it unconditional. I also see iscsid only being started in lib/nova, so can we move the setting there? That way we could also avoid the additional restart.","commit_id":"6c8348645d71e9141f6a04b79c4c74d1f77c2c91"}]}