)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f0f6734f25bb429231c4f37356206f72eeedf8fd","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-09 06:00:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7e26fb79_45563b7b","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":41},"updated":"2021-08-10 15:18:38.000000000","message":"cache","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"71d6b6a07012b9d2232b5901b230416dd0cfccf5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-09 06:00:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b22d0f60_707a400e","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":41},"in_reply_to":"7e26fb79_45563b7b","updated":"2021-08-10 16:29:16.000000000","message":"Done","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f0f6734f25bb429231c4f37356206f72eeedf8fd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"11d75c35_939b7210","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":49},"updated":"2021-08-10 15:18:38.000000000","message":"cache","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f0f6734f25bb429231c4f37356206f72eeedf8fd","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2f749b50_2cc8366a","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"updated":"2021-08-10 15:18:38.000000000","message":"remote","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"71d6b6a07012b9d2232b5901b230416dd0cfccf5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"178620b6_b10223cc","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":49},"in_reply_to":"11d75c35_939b7210","updated":"2021-08-10 16:29:16.000000000","message":"Done","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"71d6b6a07012b9d2232b5901b230416dd0cfccf5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d8488b7f_c89580b8","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":21},"in_reply_to":"2f749b50_2cc8366a","updated":"2021-08-10 16:29:16.000000000","message":"Done","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f0f6734f25bb429231c4f37356206f72eeedf8fd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"},{"line_number":13,"context_line":"for image_cache_dir config option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c31996b9_6b3df39b","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":42},"updated":"2021-08-10 15:18:38.000000000","message":"their","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"71d6b6a07012b9d2232b5901b230416dd0cfccf5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Glance remote worker should use own cahce directory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Earlier glance remore worker was using same cahce directory used by"},{"line_number":10,"context_line":"glance worker. Ideally both should use its own cache directory."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes provision for the same by setting different path"},{"line_number":13,"context_line":"for image_cache_dir config option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"872c3119_5af8decf","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":42},"in_reply_to":"c31996b9_6b3df39b","updated":"2021-08-10 16:29:16.000000000","message":"Done","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"}],"lib/glance":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f0f6734f25bb429231c4f37356206f72eeedf8fd","unresolved":true,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # Point this worker to use different cache dir"},{"line_number":556,"context_line":"    iniset $(glance_remote_conf \"$GLANCE_API_CONF\") DEFAULT \\"},{"line_number":557,"context_line":"           image_cache_dir \"${remote_data}/cache\""},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    # Change our uwsgi to our new port"},{"line_number":560,"context_line":"    sed -ri \"s/^(http-socket.*):[0-9]+/\\1:$glance_remote_port/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f93ea42d_3d734872","line":557,"updated":"2021-08-10 15:18:38.000000000","message":"I\u0027m sure this works, but I think I was asked to explicitly create the directories for this (L548 above), so maybe we should do that here as well?","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"71d6b6a07012b9d2232b5901b230416dd0cfccf5","unresolved":false,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # Point this worker to use different cache dir"},{"line_number":556,"context_line":"    iniset $(glance_remote_conf \"$GLANCE_API_CONF\") DEFAULT \\"},{"line_number":557,"context_line":"           image_cache_dir \"${remote_data}/cache\""},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"    # Change our uwsgi to our new port"},{"line_number":560,"context_line":"    sed -ri \"s/^(http-socket.*):[0-9]+/\\1:$glance_remote_port/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a0950473_be0b5940","line":557,"in_reply_to":"f93ea42d_3d734872","updated":"2021-08-10 16:29:16.000000000","message":"Done","commit_id":"901d890aab70268b61702650f76b6f6012a02ccc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1759f510f65505970f378a9972f40482d94ce732","unresolved":true,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # Point this worker to use different cache dir"},{"line_number":556,"context_line":"    mkdir -p \"$remote_data/cache\""},{"line_number":557,"context_line":"    iniset $(glance_remote_conf \"$GLANCE_API_CONF\") DEFAULT \\"},{"line_number":558,"context_line":"           image_cache_dir \"${remote_data}/cache\""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    # Change our uwsgi to our new port"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"85463acf_2aee8400","line":557,"range":{"start_line":557,"start_character":34,"end_line":557,"end_character":49},"updated":"2021-09-13 20:19:28.000000000","message":"along with this, should it be updated in glance-cache_conf too? which points to other cache location - https://zuul.opendev.org/t/openstack/build/b7d4e2caefec4d17bd3a0b44f7977208/log/controller/logs/glance-remote/glance-cache_conf.txt#8","commit_id":"00ac547acacc9fef86f9045a979adf523ab7617b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"25581f3876791d08faa4c080a2e6d037a27cb1f4","unresolved":true,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # Point this worker to use different cache dir"},{"line_number":556,"context_line":"    mkdir -p \"$remote_data/cache\""},{"line_number":557,"context_line":"    iniset $(glance_remote_conf \"$GLANCE_API_CONF\") DEFAULT \\"},{"line_number":558,"context_line":"           image_cache_dir \"${remote_data}/cache\""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    # Change our uwsgi to our new port"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"f95ab444_3087cf20","line":557,"range":{"start_line":557,"start_character":34,"end_line":557,"end_character":49},"in_reply_to":"41bf3dd8_f287fe25","updated":"2021-09-13 21:36:26.000000000","message":"ok, thanks for explaining. agree for wsgi mode in api worker and standalone can be done later if needed.","commit_id":"00ac547acacc9fef86f9045a979adf523ab7617b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1ae8b10b1b476586bc26af19058f6035afbb51e4","unresolved":true,"context_lines":[{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # Point this worker to use different cache dir"},{"line_number":556,"context_line":"    mkdir -p \"$remote_data/cache\""},{"line_number":557,"context_line":"    iniset $(glance_remote_conf \"$GLANCE_API_CONF\") DEFAULT \\"},{"line_number":558,"context_line":"           image_cache_dir \"${remote_data}/cache\""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    # Change our uwsgi to our new port"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"41bf3dd8_f287fe25","line":557,"range":{"start_line":557,"start_character":34,"end_line":557,"end_character":49},"in_reply_to":"85463acf_2aee8400","updated":"2021-09-13 21:00:58.000000000","message":"I believe the other location is only used for the standalone prefetcher, pruner, cleaner binaries. AFAIK, the way this is usually run is with a separate thread in the api worker itself, as I just had to add support for that thread to the wsgi-only mode.","commit_id":"00ac547acacc9fef86f9045a979adf523ab7617b"}]}