)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"72e27be2b14ba4ff290ea42116146ee6928dc169","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rob Crittenden \u003crcritten@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-01 19:54:05 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure Horizon to use SSL-enabled Keystone"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SSL can be enabled in Keystone when devstack is executed."},{"line_number":10,"context_line":"Horizon was not being configured to use the SSL port so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F9qWk%3D","line":7,"updated":"2014-04-03 00:36:59.000000000","message":"s/use/allow","commit_id":"1e5d7414b68e91807407f5e02b4ab4656ae90eda"}],"lib/horizon":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"60f1599dd69006cd76f65743128156c09e8d99b1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        _horizon_config_set $local_settings OPENSTACK_NEUTRON_NETWORK enable_vpn True"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ ($KEYSTONE_SSL_CA) ]]; then"},{"line_number":107,"context_line":"        sed -e \""},{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FSVM%3D","line":106,"updated":"2014-03-18 21:25:28.000000000","message":"i think we probably want $SSL_BUNDLE_CERT which is a file containing all the CA certs being used. This is defined in stack.sh so is there any reason we can\u0027t set this all the time? it will simply be ignored for non-SSL connections.","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"8a20cb58ca8ee37320a5931ea96d40db960928d3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        _horizon_config_set $local_settings OPENSTACK_NEUTRON_NETWORK enable_vpn True"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ ($KEYSTONE_SSL_CA) ]]; then"},{"line_number":107,"context_line":"        sed -e \""},{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FNh8%3D","line":106,"in_reply_to":"AAAAWH%2F%2FSVM%3D","updated":"2014-03-19 12:33:05.000000000","message":"Let me consider that. This is really keyed on whether keystone is using SSL or not. If we end up with the ability to cherry-pick what services are secured with SSL then this could be set without a secured keystone.","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2c7e014be542c8c926630712818c3a8496136329","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ ($KEYSTONE_SSL_CA) ]]; then"},{"line_number":107,"context_line":"        sed -e \""},{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"},{"line_number":110,"context_line":"            s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${KEYSTONE_SSL_CA}\u0027|g;"},{"line_number":111,"context_line":"        \" -i $local_settings"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FSA4%3D","line":108,"updated":"2014-03-18 22:07:24.000000000","message":"can we do stages: \n\n# set openstack host\nsed -i -e \"/^OPENSTACK_HOST/d\"\necho \"\\nOPENSTACK_HOST \u003d ${KEYSTONE_AUTH_URL}\" \u003e\u003e $local_settings\n\n# set keystone url\nsed -i -e \"/^OPENSTACK_KEYSTONE_URL/d\"\necho \"\\nOPENSTACK_KEYSTONE_URL \u003d ${KEYSTONE_AUTH_PROTOCOL}://%s/v2.0 % OPENSTACK_HOST\" \u003e\u003e $local_settings\n\n#set certs\n... same thing\n\n\nthese should not need to be guarded by the if","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"8a20cb58ca8ee37320a5931ea96d40db960928d3","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ ($KEYSTONE_SSL_CA) ]]; then"},{"line_number":107,"context_line":"        sed -e \""},{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"},{"line_number":110,"context_line":"            s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${KEYSTONE_SSL_CA}\u0027|g;"},{"line_number":111,"context_line":"        \" -i $local_settings"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FNjQ%3D","line":108,"in_reply_to":"AAAAWH%2F%2FSA4%3D","updated":"2014-03-19 12:33:05.000000000","message":"That may work. There are place where the existence of the CA certificate have implications which is why I did this.\n\nI\u0027ll test it and find out.","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"47a132c314df14c0a4da47862f1cf02e08c5e931","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ ($KEYSTONE_SSL_CA) ]]; then"},{"line_number":107,"context_line":"        sed -e \""},{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"},{"line_number":110,"context_line":"            s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${KEYSTONE_SSL_CA}\u0027|g;"},{"line_number":111,"context_line":"        \" -i $local_settings"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FR7U%3D","line":108,"in_reply_to":"AAAAWH%2F%2FSA4%3D","updated":"2014-03-18 22:14:14.000000000","message":"replace KEYSTONE_AUTH_* with KEYSTONE_SERVICE_* and add :PORT","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"60f1599dd69006cd76f65743128156c09e8d99b1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"},{"line_number":110,"context_line":"            s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${KEYSTONE_SSL_CA}\u0027|g;"},{"line_number":111,"context_line":"        \" -i $local_settings"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FSUg%3D","line":111,"updated":"2014-03-18 21:25:28.000000000","message":"what\u0027s the reason for not using the _horizon_config_set functions that are available? \n\nIf they are already defined then where and can we fix it there because vars like KEYSTONE_AUTH_PROTOCOL are always going to be correct.","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"8a20cb58ca8ee37320a5931ea96d40db960928d3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_AUTH_HOST}\\\"|g;"},{"line_number":109,"context_line":"            s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_AUTH_PROTOCOL}://%s:5000/v2.0\\\"|g;"},{"line_number":110,"context_line":"            s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${KEYSTONE_SSL_CA}\u0027|g;"},{"line_number":111,"context_line":"        \" -i $local_settings"},{"line_number":112,"context_line":"    fi"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FNjU%3D","line":111,"in_reply_to":"AAAAWH%2F%2FSUg%3D","updated":"2014-03-19 12:33:05.000000000","message":"Because that is for setting values within a section and these values do not live in a section.","commit_id":"5f4b37648a920ebf7c1239f60bd2ec0c707bd4ec"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"62c10e7c4aec244dc45f83aede9f635840fcaeba","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        _horizon_config_set $local_settings OPENSTACK_NEUTRON_NETWORK enable_vpn True"},{"line_number":104,"context_line":"    fi"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    sed -e \"s|OPENSTACK_HOST \u003d \\\"127.0.0.1\\\"|OPENSTACK_HOST \u003d \\\"${KEYSTONE_SERVICE_HOST}\\\"|g;\" -i $local_settings"},{"line_number":107,"context_line":"    sed -e \"s|\\\"http://%s:5000/v2.0\\\"|\\\"${KEYSTONE_SERVICE_PROTOCOL}://%s:5000/v2.0\\\"|g;\" -i $local_settings"},{"line_number":108,"context_line":"    if [ -f $SSL_BUNDLE_FILE ]; then"},{"line_number":109,"context_line":"        sed -e \"s|# OPENSTACK_SSL_CACERT \u003d \u0027/path/to/cacert.pem\u0027|OPENSTACK_SSL_CACERT \u003d \u0027${SSL_BUNDLE_FILE}\u0027|g;\" -i $local_settings"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAWH%2F9qXE%3D","line":106,"updated":"2014-04-03 00:36:19.000000000","message":"This should work but i think it would be more resilient to delete the existing option and then write a new one.\n\n  sed -e \"/^OPENSTACK_HOST/d\" -i $local_settings\n  echo \"\\nOPENSTACK_HOST \u003d ${KEYSTONE_AUTH_URL}\" \u003e\u003e $local_settings\n\nMeans if horizon were to change there default config or someone else is setting it our set will still work. Also IMO much easier to read.\n\n\nSame for the others in this file.","commit_id":"1e5d7414b68e91807407f5e02b4ab4656ae90eda"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a987072ed027ce911717af8e31189639c94eae35","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    echo \"OPENSTACK_KEYSTONE_URL \u003d \u0027${KEYSTONE_SERVICE_PROTOCOL}://%s:${KEYSTONE_SERVICE_PORT}/v2.0\u0027 % OPENSTACK_HOST\" \u003e\u003e $local_settings"},{"line_number":111,"context_line":"    if [ -f $SSL_BUNDLE_FILE ]; then"},{"line_number":112,"context_line":"        sed -e \"/^# OPENSTACK_SSL_CACERT/d\" -i $local_settings"},{"line_number":113,"context_line":"        echo \"OPENSTACK_SSL_CACERT \u003d \u0027${SSL_BUNDLE_FILE}\u0027\" \u003e\u003e $local_settings"},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXX%2F%2F6jQ%3D","line":113,"updated":"2014-04-25 10:24:24.000000000","message":"why is _horizon_config_set not used?","commit_id":"e53959e5809944ece3498a974de24bf8770cacf4"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"ff5895e27c25e3dae3c55d169e3a9f3fec66d654","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    echo \"OPENSTACK_KEYSTONE_URL \u003d \u0027${KEYSTONE_SERVICE_PROTOCOL}://%s:${KEYSTONE_SERVICE_PORT}/v2.0\u0027 % OPENSTACK_HOST\" \u003e\u003e $local_settings"},{"line_number":111,"context_line":"    if [ -f $SSL_BUNDLE_FILE ]; then"},{"line_number":112,"context_line":"        sed -e \"/^# OPENSTACK_SSL_CACERT/d\" -i $local_settings"},{"line_number":113,"context_line":"        echo \"OPENSTACK_SSL_CACERT \u003d \u0027${SSL_BUNDLE_FILE}\u0027\" \u003e\u003e $local_settings"},{"line_number":114,"context_line":"    fi"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # Create an empty directory that apache uses as docroot"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAXX%2F%2F5vY%3D","line":113,"in_reply_to":"AAAAXX%2F%2F6jQ%3D","updated":"2014-04-25 12:27:08.000000000","message":"Because that is for setting values in a section in an ini-style configuration file. $local_settings is a python file.","commit_id":"e53959e5809944ece3498a974de24bf8770cacf4"}]}