)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f0cc2d592f2e50fedfe39819f7683ae36184fa7f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"attached volumes. This change ensures the name is unique by running"},{"line_number":12,"context_line":"iscsi-iname again and overwriting the existing name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We could potentially do this during the image build process itself but"},{"line_number":15,"context_line":"given that devstack systems are not supposed to be multi-purpose this"},{"line_number":16,"context_line":"should be safe to do during the devstack run."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1945983"},{"line_number":19,"context_line":"Change-Id: I9ed26a17858df96c04be9ae52bf2e33e023869a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2054837b_e534b88b","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":45},"updated":"2021-10-06 07:11:29.000000000","message":"nit: we couldn\u0027t as we use the same images and thus they can\u0027t differ","commit_id":"714826d1a27085ba2384ca495c876588d77f0d27"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6df88a28db1ddeb2de16e49a2892205adf02884e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"attached volumes. This change ensures the name is unique by running"},{"line_number":12,"context_line":"iscsi-iname again and overwriting the existing name."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We could potentially do this during the image build process itself but"},{"line_number":15,"context_line":"given that devstack systems are not supposed to be multi-purpose this"},{"line_number":16,"context_line":"should be safe to do during the devstack run."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1945983"},{"line_number":19,"context_line":"Change-Id: I9ed26a17858df96c04be9ae52bf2e33e023869a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e3ec632c_e4ee12b7","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":45},"in_reply_to":"2054837b_e534b88b","updated":"2021-10-06 09:21:44.000000000","message":"True I think I was confusing aspects of the image build with first run scripts. I\u0027ll remove if I need to respin.","commit_id":"714826d1a27085ba2384ca495c876588d77f0d27"}],"lib/nova":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e0402c5c1ae3bb3f5f8047a69975469d29c70223","unresolved":true,"context_lines":[{"line_number":298,"context_line":"            fi"},{"line_number":299,"context_line":"        fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Ensure each compute host uses a unqiue iSCSI initiator"},{"line_number":302,"context_line":"        sudo echo InitiatorName\u003d$(iscsi-iname) \u003e /tmp/initiatorname.iscsi"},{"line_number":303,"context_line":"        sudo mv /tmp/initiatorname.iscsi /etc/iscsi/initiatorname.iscsi"},{"line_number":304,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5bdc8e91_b1662b83","line":301,"range":{"start_line":301,"start_character":42,"end_line":301,"end_character":48},"updated":"2021-10-05 10:33:18.000000000","message":"nit: unique","commit_id":"7d44bf9161f011d1b6f6d0fd9ed639e3d7a4d25b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e0402c5c1ae3bb3f5f8047a69975469d29c70223","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Ensure each compute host uses a unqiue iSCSI initiator"},{"line_number":302,"context_line":"        sudo echo InitiatorName\u003d$(iscsi-iname) \u003e /tmp/initiatorname.iscsi"},{"line_number":303,"context_line":"        sudo mv /tmp/initiatorname.iscsi /etc/iscsi/initiatorname.iscsi"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if [[ ${ISCSID_DEBUG} \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"2c68780c_29fa3c70","line":302,"range":{"start_line":302,"start_character":8,"end_line":302,"end_character":12},"updated":"2021-10-05 10:33:18.000000000","message":"nah, you just sudo the echo command.\n\nIf you want to create a root file, you have to do this :\n\n  echo \"bla\" | sudo tee \u003cfile\u003e","commit_id":"7d44bf9161f011d1b6f6d0fd9ed639e3d7a4d25b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"51a02b0c9912440b7766b7fcf386ebad1094aef0","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Ensure each compute host uses a unique iSCSI initiator"},{"line_number":302,"context_line":"        echo InitiatorName\u003d$(iscsi-iname) | sudo tee /etc/iscsi/initiatorname.iscsi"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        if [[ ${ISCSID_DEBUG} \u003d\u003d \"True\" ]]; then"},{"line_number":305,"context_line":"            # Install an override that starts iscsid with debugging"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5346c437_1065d260","line":302,"range":{"start_line":302,"start_character":44,"end_line":302,"end_character":83},"updated":"2021-10-05 10:51:26.000000000","message":"OK, so you fully recreate the initiatorname file here by giving the iSCSI name (the FQDN and the port). Looks good to me.","commit_id":"714826d1a27085ba2384ca495c876588d77f0d27"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"915e1541b356584ec9fd69c47e679409cdef6211","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Ensure each compute host uses a unique iSCSI initiator"},{"line_number":302,"context_line":"        echo InitiatorName\u003d$(iscsi-iname) | sudo tee /etc/iscsi/initiatorname.iscsi"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        if [[ ${ISCSID_DEBUG} \u003d\u003d \"True\" ]]; then"},{"line_number":305,"context_line":"            # Install an override that starts iscsid with debugging"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"eadb24eb_7f471ec7","line":302,"range":{"start_line":302,"start_character":44,"end_line":302,"end_character":83},"in_reply_to":"5346c437_1065d260","updated":"2021-10-05 16:09:36.000000000","message":"ok so this is using iscsi-iname to generate a unique iSCSI node name\n\nhttps://linux.die.net/man/8/iscsi-iname\n\ndepending on how that is generated internally im not sure that it will be guarneteed to be unique on differnet host so we might want to consider using -p to use the current host name as part of the prefix to force it to be globally unique but for now provided the entropy in the vm is good i think this is an improvment so +1","commit_id":"714826d1a27085ba2384ca495c876588d77f0d27"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ef3a4a2ffca83d012635e445e6195555951457fd","unresolved":true,"context_lines":[{"line_number":299,"context_line":"        fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # Ensure each compute host uses a unique iSCSI initiator"},{"line_number":302,"context_line":"        echo InitiatorName\u003d$(iscsi-iname) | sudo tee /etc/iscsi/initiatorname.iscsi"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        if [[ ${ISCSID_DEBUG} \u003d\u003d \"True\" ]]; then"},{"line_number":305,"context_line":"            # Install an override that starts iscsid with debugging"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"119f167c_75fd7074","line":302,"range":{"start_line":302,"start_character":44,"end_line":302,"end_character":83},"in_reply_to":"eadb24eb_7f471ec7","updated":"2021-10-05 16:11:19.000000000","message":"looking at what the other installers do \n\nhttps://codesearch.opendev.org/?q\u003discsi-iname\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nthis likely is sufficnet\n\nthey all invoke it with out -p","commit_id":"714826d1a27085ba2384ca495c876588d77f0d27"}]}