)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"30f807dc4f1448002d814243be286732293ad94c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21ee378e_41eb0928","updated":"2021-10-20 12:38:19.000000000","message":"Looking good...","commit_id":"344e7998258985faccfc3ceb9006dee945e3f69d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bbe20d4f314b21ca8a89666af4b06d8dc4b7e731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b93200d_c5552b23","updated":"2021-10-18 14:26:14.000000000","message":"recheck openstacksdk-functional-devstack failure unrelated to cinder","commit_id":"344e7998258985faccfc3ceb9006dee945e3f69d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6aef429_fb8a7bab","updated":"2022-02-15 17:29:49.000000000","message":"Thanks for the reviews  :-)","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f8adf92a0e21fa15bf2b5c00bc63607d251d2ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b7c9fa5_7d98f646","updated":"2022-02-01 21:04:31.000000000","message":"This LGTM, and the cinder dependency has merged.  Two nits noted inline.","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b48989c_32d57517","updated":"2022-02-02 05:26:50.000000000","message":"Will there be a CI job that tests this? Or does it need special hardware?","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7e213cf24aa5b3dee31bf7ed60acc7502868937c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6b4fbb3_4db91b4c","updated":"2022-02-15 21:25:40.000000000","message":"This is breaking c9s and openeuler. I\u0027m also wondering whether the nvme-cli would make sense to only be installed when they are actually needed.\n\nAlso still unclear where this would actually be tested.","commit_id":"152e837363fc9ed684777a05cab6c0d1152d9aed"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fb6722079ba398beb33f416d1ac79103a7cf571e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f0e5469_a9c891aa","in_reply_to":"d6b4fbb3_4db91b4c","updated":"2022-04-01 13:54:59.000000000","message":"I\u0027ll change it to only install it when cinder is configured to use it.\n\nBesides helping us with development, we will be creating a CI job to run NVMe-oF jobs with LVM+nvmet, but we cannot do that right now because it is quite broken (both in os-brick and in Cinder).","commit_id":"152e837363fc9ed684777a05cab6c0d1152d9aed"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8f0fdea70d73a4a29f8709616e13232d42510d71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2fb16ba8_29fc6027","updated":"2022-04-22 09:38:56.000000000","message":"So why would you want to add this to devstack when it is still broken?","commit_id":"72a21c5a02ad50db90e8582c9fc6ad7137bfbe88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed211aa37bb530fa8f4b06b9f9b5821b79ea59b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"161f00df_87824b94","in_reply_to":"2fb16ba8_29fc6027","updated":"2022-05-26 15:36:30.000000000","message":"Precisely because it is broken and we have no way of testing it, so anything we merge is mostly untested.\n\nSo in my eyes we either keep merging untested code forever (yuck), or we add support for nvme-of in devstack and then propose a series of patches fixing NVMe-oF in os-brick with the last of the patches leveraging this patch to add an LVM+nvmet CI job.  That way it confirms that the previous patches in the series actually fix things.","commit_id":"72a21c5a02ad50db90e8582c9fc6ad7137bfbe88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"67d79eb1bdfaa327773b1a056d141e44f4aaa0a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1a4ec54e_e0061654","updated":"2022-05-26 15:39:29.000000000","message":"Latest patch is just a rebase on latest master","commit_id":"baa888faec751284c53c7770d4747c88e8693dfd"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"02b761c56e70e6b6cb6a1e90b5da9656128b6f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"aec05d26_4d6562e6","updated":"2022-06-24 17:35:55.000000000","message":"Tested locally, works as advertised.","commit_id":"baa888faec751284c53c7770d4747c88e8693dfd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d15c427d505c0185d3b25f256412996b314d45d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6aead68e_1556e349","updated":"2022-06-07 16:03:21.000000000","message":"This patch is needed to enable us to test the NVMe-oF os-brick connector in the openstack gate without having an NVMe backend available.","commit_id":"baa888faec751284c53c7770d4747c88e8693dfd"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8573ab8f648a41211bb01a4d75d025ca3b989625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c4edb55b_2c36b984","updated":"2022-05-26 19:45:15.000000000","message":"We need to bring this in to move forward with vendor NVMe-oF drivers. The comments have been answered and Zuul passed. Looks good to me. Thanks for the work on this.","commit_id":"baa888faec751284c53c7770d4747c88e8693dfd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"248903d0287e2fac06aefcf11160ea75185a50f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"65de5b78_4962bd59","updated":"2022-05-26 16:14:32.000000000","message":"We need to get this in to progress with vendor NVMe-oF drivers","commit_id":"baa888faec751284c53c7770d4747c88e8693dfd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b2910cc6330bf49e8dfec9bd2097f8f0b2e42b11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f2503a4_d8294ab9","updated":"2022-07-18 18:47:07.000000000","message":"Updated patch with a fix for Ubuntu (Fedora/CentOS was pulling the dependency somewhere else)","commit_id":"78ee24302edba9409c9fbd1d51549ea7c86a04fd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"64100aa7fc65ad1e24a1d51ecb78278d1fafe7ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5c84c5f0_13f5dd0c","updated":"2022-10-25 20:48:53.000000000","message":"Just want to bump this.  It\u0027s needed for Cinder testing.","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"98da0401658353a210c59d090a32b43db8660035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"84d1a4b9_e98e0b96","updated":"2022-09-13 13:02:03.000000000","message":"LGTM","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fc4b28aa9f4c3d4bdf25bb1b53d18d0c4dbbe40c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0a1bd070_ea92321c","updated":"2022-11-08 15:06:23.000000000","message":"Looks like the cinder test failed:\n\nhttps://zuul.opendev.org/t/openstack/build/d163511a390e4333a32da96209cb99c1\n\nNot sure if it\u0027s related or coincidental to this.","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6fe78adcc143809280ac4be96a96a9398ada1c1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c771f85d_56979558","updated":"2022-11-07 19:21:25.000000000","message":"Looks okay to me, for a change we can\u0027t see working.\n\nI put up DNMs against nova and glance to just make sure we\u0027re not introducing a gate break for either of those since they have other job configurations that could run afoul of the trivial refactors here:\n\nhttps://review.opendev.org/c/openstack/glance/+/863926\nhttps://review.opendev.org/c/openstack/nova/+/863925\n\nIf those turn out okay, I\u0027ll be +2.","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e36f51163b6b6c7493758c76b9df2bf4e1e604eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a9e7dfba_ba64396d","updated":"2022-11-08 15:44:24.000000000","message":"Not approving since gate is currently broken, but the patch is fine","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"36a01c91a75ee286ab12ad201e9ae0cff936ad19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f1b105f2_86ffdcf7","updated":"2022-11-07 21:18:30.000000000","message":"Nova and glance appear unharmed by this, so I think this is probably fine. Cinder test job is still pending, but in terms of impact to non-cinder projects I think we\u0027re safe.","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"024e2559afad68367d503f12c05dbecc2b50ef26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87f8e3fb_9a8bf73c","updated":"2022-11-07 19:50:48.000000000","message":"and Brian put this up for cinder:\n\nhttps://review.opendev.org/c/openstack/cinder/+/863927","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"818ea5b4a5b682d87afd0b4f7235e3d56097942e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9c69552f_1f73ee4b","updated":"2022-11-10 08:16:07.000000000","message":"approving since the gate should be ok now","commit_id":"97061c9a1f2a2989e0bacb5f7cc5910c75aaeb44"}],"lib/cinder":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    echo ${!variable_name:-$default_value}"},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CINDER_TARGET_HELPER\u003d${CINDER_TARGET_HELPER:-${CINDER_ISCSI_HELPER:-lioadm}}"},{"line_number":110,"context_line":"CINDER_TARGET_PROTOCOL\u003d$(get_target_value \u0027PROTOCOL\u0027 \u0027nvmet_rdma\u0027 \u0027iscsi\u0027)"},{"line_number":111,"context_line":"CINDER_TARGET_PREFIX\u003d$(get_target_value \u0027PREFIX\u0027 \u0027nvme-subsystem-1\u0027 \u0027iqn.2010-10.org.openstack:\u0027)"},{"line_number":112,"context_line":"CINDER_TARGET_PORT\u003d$(get_target_value \u0027PORT\u0027 4420 3260)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b79ed84b_bcbca04e","line":109,"updated":"2022-02-02 05:26:50.000000000","message":"Can we deprecate the old variable and create a warning if it is still used? I would prefer not to keep this nested construct permanently.","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    echo ${!variable_name:-$default_value}"},{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CINDER_TARGET_HELPER\u003d${CINDER_TARGET_HELPER:-${CINDER_ISCSI_HELPER:-lioadm}}"},{"line_number":110,"context_line":"CINDER_TARGET_PROTOCOL\u003d$(get_target_value \u0027PROTOCOL\u0027 \u0027nvmet_rdma\u0027 \u0027iscsi\u0027)"},{"line_number":111,"context_line":"CINDER_TARGET_PREFIX\u003d$(get_target_value \u0027PREFIX\u0027 \u0027nvme-subsystem-1\u0027 \u0027iqn.2010-10.org.openstack:\u0027)"},{"line_number":112,"context_line":"CINDER_TARGET_PORT\u003d$(get_target_value \u0027PORT\u0027 4420 3260)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9b684948_deefcddb","line":109,"in_reply_to":"b79ed84b_bcbca04e","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":true,"context_lines":[{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CINDER_TARGET_HELPER\u003d${CINDER_TARGET_HELPER:-${CINDER_ISCSI_HELPER:-lioadm}}"},{"line_number":110,"context_line":"CINDER_TARGET_PROTOCOL\u003d$(get_target_value \u0027PROTOCOL\u0027 \u0027nvmet_rdma\u0027 \u0027iscsi\u0027)"},{"line_number":111,"context_line":"CINDER_TARGET_PREFIX\u003d$(get_target_value \u0027PREFIX\u0027 \u0027nvme-subsystem-1\u0027 \u0027iqn.2010-10.org.openstack:\u0027)"},{"line_number":112,"context_line":"CINDER_TARGET_PORT\u003d$(get_target_value \u0027PORT\u0027 4420 3260)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# EL and SUSE should only use lioadm"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"8adc6d14_b8c74faf","line":112,"range":{"start_line":110,"start_character":0,"end_line":112,"end_character":55},"updated":"2022-02-02 05:26:50.000000000","message":"I\u0027d rather propose to just have two versions of these three assinments wrapped in an if/else block, that seem easier to track and debug than using this function call.","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"CINDER_TARGET_HELPER\u003d${CINDER_TARGET_HELPER:-${CINDER_ISCSI_HELPER:-lioadm}}"},{"line_number":110,"context_line":"CINDER_TARGET_PROTOCOL\u003d$(get_target_value \u0027PROTOCOL\u0027 \u0027nvmet_rdma\u0027 \u0027iscsi\u0027)"},{"line_number":111,"context_line":"CINDER_TARGET_PREFIX\u003d$(get_target_value \u0027PREFIX\u0027 \u0027nvme-subsystem-1\u0027 \u0027iqn.2010-10.org.openstack:\u0027)"},{"line_number":112,"context_line":"CINDER_TARGET_PORT\u003d$(get_target_value \u0027PORT\u0027 4420 3260)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"# EL and SUSE should only use lioadm"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d2b8a511_75e5f92e","line":112,"range":{"start_line":110,"start_character":0,"end_line":112,"end_character":55},"in_reply_to":"8adc6d14_b8c74faf","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f8adf92a0e21fa15bf2b5c00bc63607d251d2ea","unresolved":true,"context_lines":[{"line_number":115,"context_line":"# EL and SUSE should only use lioadm"},{"line_number":116,"context_line":"if is_fedora || is_suse; then"},{"line_number":117,"context_line":"    if [[ ${CINDER_TARGET_HELPER} !\u003d \"lioadm\" \u0026\u0026 ${CINDER_TARGET_HELPER} !\u003d \u0027nvmet\u0027 ]]; then"},{"line_number":118,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"fi"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"54bc2a7d_468be48e","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":58},"updated":"2022-02-01 21:04:31.000000000","message":"nit: this message and the comment at line 115 could be updated","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":115,"context_line":"# EL and SUSE should only use lioadm"},{"line_number":116,"context_line":"if is_fedora || is_suse; then"},{"line_number":117,"context_line":"    if [[ ${CINDER_TARGET_HELPER} !\u003d \"lioadm\" \u0026\u0026 ${CINDER_TARGET_HELPER} !\u003d \u0027nvmet\u0027 ]]; then"},{"line_number":118,"context_line":"        die \"lioadm is the only valid Cinder target_helper config on this platform\""},{"line_number":119,"context_line":"    fi"},{"line_number":120,"context_line":"fi"},{"line_number":121,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"48a0b95b_b179b6f6","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":58},"in_reply_to":"54bc2a7d_468be48e","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":true,"context_lines":[{"line_number":238,"context_line":"        fi"},{"line_number":239,"context_line":"    elif [ \"$CINDER_TARGET_HELPER\" \u003d \"lioadm\" ]; then"},{"line_number":240,"context_line":"        sudo cinder-rtstool get-targets | sudo xargs -rn 1 cinder-rtstool delete"},{"line_number":241,"context_line":"    else  # nvmet"},{"line_number":242,"context_line":"        # If we don\u0027t disconnect everything vgremove will block"},{"line_number":243,"context_line":"        sudo nvme disconnect-all"},{"line_number":244,"context_line":"        sudo nvmetcli clear"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"315022f8_d9caed17","line":241,"updated":"2022-02-02 05:26:50.000000000","message":"Can we be sure that there are no other possible options? If yes, there should be an explicit guard against misconfiguration (typos) somewhere. Otherwise better use another elif like you do in the install_cinder function below.","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        fi"},{"line_number":239,"context_line":"    elif [ \"$CINDER_TARGET_HELPER\" \u003d \"lioadm\" ]; then"},{"line_number":240,"context_line":"        sudo cinder-rtstool get-targets | sudo xargs -rn 1 cinder-rtstool delete"},{"line_number":241,"context_line":"    else  # nvmet"},{"line_number":242,"context_line":"        # If we don\u0027t disconnect everything vgremove will block"},{"line_number":243,"context_line":"        sudo nvme disconnect-all"},{"line_number":244,"context_line":"        sudo nvmetcli clear"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a5d771b7_83b5213c","line":241,"in_reply_to":"315022f8_d9caed17","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":true,"context_lines":[{"line_number":508,"context_line":"            sudo modprobe nvme-rdma"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            # Create the Soft-RoCE device over the networking interface"},{"line_number":511,"context_line":"            iface\u003d${HOST_IP_IFACE:-`ip -br -$SERVICE_IP_VERSION a | grep $CINDER_MY_IP | awk \u0027{print $1}\u0027`}"},{"line_number":512,"context_line":"            if ! sudo rdma link | grep $iface ; then"},{"line_number":513,"context_line":"                sudo rdma link add rxe_$iface type rxe netdev $iface"},{"line_number":514,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e8f27b6c_51f2c655","line":511,"updated":"2022-02-02 05:26:50.000000000","message":"Declare this a local variable? Also maybe double-check the result to be non-empty?","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":508,"context_line":"            sudo modprobe nvme-rdma"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"            # Create the Soft-RoCE device over the networking interface"},{"line_number":511,"context_line":"            iface\u003d${HOST_IP_IFACE:-`ip -br -$SERVICE_IP_VERSION a | grep $CINDER_MY_IP | awk \u0027{print $1}\u0027`}"},{"line_number":512,"context_line":"            if ! sudo rdma link | grep $iface ; then"},{"line_number":513,"context_line":"                sudo rdma link add rxe_$iface type rxe netdev $iface"},{"line_number":514,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5a1c9d97_a3c6fc09","line":511,"in_reply_to":"e8f27b6c_51f2c655","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"}],"lib/cinder_backends/lvm":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"369490185a119d58d773d6207a714e8a1a0467a0","unresolved":true,"context_lines":[{"line_number":53,"context_line":"    iniset $CINDER_CONF $be_name target_helper \"$CINDER_TARGET_HELPER\""},{"line_number":54,"context_line":"    iniset $CINDER_CONF $be_name lvm_type \"$CINDER_LVM_TYPE\""},{"line_number":55,"context_line":"    iniset $CINDER_CONF $be_name volume_clear \"$CINDER_VOLUME_CLEAR\""},{"line_number":56,"context_line":"    iniset $CINDER_CONF $be_name target_protocol \"$CINDER_TARGET_PROTOCOL\""},{"line_number":57,"context_line":"    iniset $CINDER_CONF $be_name target_port \"$CINDER_TARGET_PORT\""},{"line_number":58,"context_line":"    iniset $CINDER_CONF $be_name target_prefix \"$CINDER_TARGET_PREFIX\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# init_cinder_backend_lvm - Initialize volume group"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a87ad5ca_500fb475","line":58,"range":{"start_line":56,"start_character":4,"end_line":58,"end_character":70},"updated":"2022-02-02 05:26:50.000000000","message":"leave the target_* options grouped together?","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    iniset $CINDER_CONF $be_name target_helper \"$CINDER_TARGET_HELPER\""},{"line_number":54,"context_line":"    iniset $CINDER_CONF $be_name lvm_type \"$CINDER_LVM_TYPE\""},{"line_number":55,"context_line":"    iniset $CINDER_CONF $be_name volume_clear \"$CINDER_VOLUME_CLEAR\""},{"line_number":56,"context_line":"    iniset $CINDER_CONF $be_name target_protocol \"$CINDER_TARGET_PROTOCOL\""},{"line_number":57,"context_line":"    iniset $CINDER_CONF $be_name target_port \"$CINDER_TARGET_PORT\""},{"line_number":58,"context_line":"    iniset $CINDER_CONF $be_name target_prefix \"$CINDER_TARGET_PREFIX\""},{"line_number":59,"context_line":"}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# init_cinder_backend_lvm - Initialize volume group"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a4adb12b_234ad6a7","line":58,"range":{"start_line":56,"start_character":4,"end_line":58,"end_character":70},"in_reply_to":"a87ad5ca_500fb475","updated":"2022-02-15 17:29:49.000000000","message":"Done","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"}],"lib/lvm":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f8adf92a0e21fa15bf2b5c00bc63607d251d2ea","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    local vg\u003d$1"},{"line_number":125,"context_line":"    local size\u003d$2"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Start the tgtd service on Fedora and SUSE if tgtadm is used"},{"line_number":128,"context_line":"    if  is_fedora || is_suse  \u0026\u0026 [[ \"$CINDER_TARGET_HELPER\" \u003d \"tgtadm\" ]]; then"},{"line_number":129,"context_line":"        start_service tgtd"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Start with a clean volume group"},{"line_number":133,"context_line":"    _create_lvm_volume_group $vg $size"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d0be95a2_eb112ac3","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":6},"updated":"2022-02-01 21:04:31.000000000","message":"nit: compare this to line 116 in lib/cinder ... we don\u0027t allow tgtadm as a target_helper for fedora or suse, so this should be unreachable code","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d593ff8938075f8a5f2d98245b29ab7bfdda935","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    local vg\u003d$1"},{"line_number":125,"context_line":"    local size\u003d$2"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Start the tgtd service on Fedora and SUSE if tgtadm is used"},{"line_number":128,"context_line":"    if  is_fedora || is_suse  \u0026\u0026 [[ \"$CINDER_TARGET_HELPER\" \u003d \"tgtadm\" ]]; then"},{"line_number":129,"context_line":"        start_service tgtd"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Start with a clean volume group"},{"line_number":133,"context_line":"    _create_lvm_volume_group $vg $size"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d0c2a36b_d217841c","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":6},"in_reply_to":"d0be95a2_eb112ac3","updated":"2022-02-15 17:29:49.000000000","message":"I think so, but seems like an unrelated change (cleanup of unreachable code) that I\u0027d rather not group with this feature addition.","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d15c427d505c0185d3b25f256412996b314d45d5","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    local vg\u003d$1"},{"line_number":125,"context_line":"    local size\u003d$2"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # Start the tgtd service on Fedora and SUSE if tgtadm is used"},{"line_number":128,"context_line":"    if  is_fedora || is_suse  \u0026\u0026 [[ \"$CINDER_TARGET_HELPER\" \u003d \"tgtadm\" ]]; then"},{"line_number":129,"context_line":"        start_service tgtd"},{"line_number":130,"context_line":"    fi"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Start with a clean volume group"},{"line_number":133,"context_line":"    _create_lvm_volume_group $vg $size"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"15629be0_5c569fad","line":130,"range":{"start_line":127,"start_character":0,"end_line":130,"end_character":6},"in_reply_to":"d0c2a36b_d217841c","updated":"2022-06-07 16:03:21.000000000","message":"Ack","commit_id":"8456e239742bbf81d878d528f395d51112e835b7"}]}