)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"db274e841d25029d214f0352fa116c87f38e8852","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c48aab41_865c79e2","updated":"2022-02-14 02:01:38.000000000","message":"lgtm","commit_id":"ae40825df618a6b8164be8345f5cc1b11a2dc614"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"726bde97fe8db77355a6ab5a568ece7ddfd891bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f2a244a7_75a5428d","updated":"2022-02-21 12:52:30.000000000","message":"lgtm, needed in the dependent patches ","commit_id":"ae40825df618a6b8164be8345f5cc1b11a2dc614"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"727d0afa9b5ef9a40d7bb3260121cfcc97c6856a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5de50773_e52c4c73","updated":"2022-02-08 14:59:17.000000000","message":"recheck","commit_id":"ae40825df618a6b8164be8345f5cc1b11a2dc614"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"7976429661ccfa81f6a117985e672bbc2d033e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e9fa5033_e2c74bf0","updated":"2022-01-27 14:03:55.000000000","message":"recheck\n\ndevstack-enforce-scope failed with:\n\noscwrap --os-cloud devstack-system-admin --os-region RegionOne subnet pool create shared-default-subnetpool-v4 --project 45e2f8fa050240faa8be2db3ff84aeff --default-prefix-length 26 --pool-prefix 10.1.0.0/20 --share --default -f value -c id\nHttpException: 500: Server Error for url: https://10.210.194.9:9696/v2.0/subnetpools, Request Failed: internal server error while processing your request.\n\noslo_policy.policy.InvalidScope: rule:get_subnetpool requires a scope of [\u0027project\u0027], request was made with system scope.\n\nhttps://b922ff749199e4264dad-738e7a066c935883ae419d9b7cfe468f.ssl.cf5.rackcdn.com/815426/8/check/devstack-enforce-scope/3f7ce9f/controller/logs/screen-q-svc.txt\n\nbut it doesn\u0027t look like it\u0027s anything that this patch touches and patches higher up in the relation chain succeeded.\n","commit_id":"ae40825df618a6b8164be8345f5cc1b11a2dc614"}],"functions-common":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"37f4a1d64833e007d0cd166294fbd265f0c2d24c","unresolved":true,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e7c91d57_5fb9a893","line":794,"updated":"2021-11-03 19:54:55.000000000","message":"We might want to unset this too when we\u0027re done. Otherwise we might run into the same problem where we pollute commands that run after this.\n\nWhat about popping the original values off, if present, running the admin command as system-admin, the resetting the original values?","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5edd5dadac5cbde770d5b2c16231ac88aea4d309","unresolved":true,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5e9f78be_1fedda48","line":794,"in_reply_to":"2ff40648_40f45078","updated":"2021-11-08 17:39:45.000000000","message":"Ok, yeah, that makes sense.","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"676864d96bd246f5e2bcfeba79035ab22eb485c4","unresolved":true,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"670e8032_007828d8","line":794,"in_reply_to":"39b6be72_5a841beb","updated":"2021-11-04 19:42:45.000000000","message":"Ok - that makes sense. In that case, we would no longer be using environment variables at all and we would just invoke the profile via --os-cloud, correct?","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"4c6d190eacceb6208655b98f666d13608f945860","unresolved":false,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3706169d_a3b3c565","line":794,"in_reply_to":"5e9f78be_1fedda48","updated":"2022-01-27 14:04:48.000000000","message":"Done","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"de2525e3f33fe2415f922bb91ff2344a919f469d","unresolved":true,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"2ff40648_40f45078","line":794,"in_reply_to":"670e8032_007828d8","updated":"2021-11-04 19:54:48.000000000","message":"Well I would prefer to still set OS_CLOUD\u003ddevstack-admin by default, or possibly \u003ddevstack-system-admin, in order not having to change every invocation. But with only that single var being set, you can easily override that by either setting a different value or using --os-cloud just for specific calls.","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d1e9c470535391871f3625f301bc73405c16665e","unresolved":true,"context_lines":[{"line_number":791,"context_line":"function as_system_admin {"},{"line_number":792,"context_line":"    # We need to unset this in order for the system profile to work"},{"line_number":793,"context_line":"    OS_USERNAME\u003d OS_TENANT_NAME\u003d OS_PROJECT_NAME\u003d \\"},{"line_number":794,"context_line":"        OS_CLOUD\u003ddevstack-system-admin \"$@\""},{"line_number":795,"context_line":"    return $?"},{"line_number":796,"context_line":"}"},{"line_number":797,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"39b6be72_5a841beb","line":794,"in_reply_to":"e7c91d57_5fb9a893","updated":"2021-11-04 12:25:59.000000000","message":"Well the solution I proposed for this issue is in https://review.opendev.org/c/openstack/devstack/+/780417/4/stack.sh which would only use OS_CLOUD everywhere in devstack and thus make it easy to override credentials. That patch needs a bit more of checking for possible side effects on consumers, though, which I haven\u0027t found the time for so far. If one of you would be interested in taking over, I think that would be a better solution than this workaround here, where I\u0027d not be sure whether even more variables would need to be nulled.","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"}],"stack.sh":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"37f4a1d64833e007d0cd166294fbd265f0c2d24c","unresolved":true,"context_lines":[{"line_number":1091,"context_line":"source $TOP_DIR/userrc_early"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"# Write a clouds.yaml file"},{"line_number":1094,"context_line":"write_clouds_yaml"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"if is_service_enabled keystone; then"},{"line_number":1097,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"41efbf82_3ca59767","line":1094,"updated":"2021-11-03 19:54:55.000000000","message":"I think this bit already merged:\n\nhttps://review.opendev.org/c/openstack/devstack/+/814142/1/stack.sh","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"4c6d190eacceb6208655b98f666d13608f945860","unresolved":false,"context_lines":[{"line_number":1091,"context_line":"source $TOP_DIR/userrc_early"},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"# Write a clouds.yaml file"},{"line_number":1094,"context_line":"write_clouds_yaml"},{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"if is_service_enabled keystone; then"},{"line_number":1097,"context_line":"    echo_summary \"Starting Keystone\""}],"source_content_type":"text/x-sh","patch_set":3,"id":"eeae8e06_7f7286c2","line":1094,"in_reply_to":"41efbf82_3ca59767","updated":"2022-01-27 14:04:48.000000000","message":"Done","commit_id":"c1b46f181b1f2d970bf5a17e2b342e46ac21586d"}]}