)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"32be4420c4db433b7d2168ef3a3463f0e26c47fa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"which we need when interacting with registered limits in keystone."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit removes those unsets since we no longer source those"},{"line_number":14,"context_line":"variables by default. This commit also cleans up some of the redundant"},{"line_number":15,"context_line":"parameters in the registered limit calls, like region."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1af8a168a29e895d57504d41e30efea271ea232d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7828ac16_734627a5","line":15,"range":{"start_line":14,"start_character":22,"end_line":15,"end_character":54},"updated":"2021-11-30 15:02:25.000000000","message":"at the end no parameters were removed","commit_id":"afd0f84eae75fd5a5a7611cb6e8368ef7b845211"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a7801d4307bd17b402658033c211e004e4388153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d17a1220_0c86d263","updated":"2021-11-16 16:27:31.000000000","message":"lgtm, 1 comment on using separate var instead of setting/resetting OS_CLOUD ?","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6e89cf8af71c9bf2099cac97a8519e6b08b3684e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc8fc274_28a405e5","updated":"2021-12-01 10:05:50.000000000","message":"Yeah, that was me mistaking the quota parameter for an auth parameter, not worth respinning","commit_id":"afd0f84eae75fd5a5a7611cb6e8368ef7b845211"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"32be4420c4db433b7d2168ef3a3463f0e26c47fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fa44e676_5b1876b0","updated":"2021-11-30 15:02:25.000000000","message":"makes sense, at the end no parameters were removed as the end of the commit msg suggests, however, that is probably not worth of rerunning the jobs","commit_id":"afd0f84eae75fd5a5a7611cb6e8368ef7b845211"}],"lib/glance":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a7801d4307bd17b402658033c211e004e4388153","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    # Registered limit resources in keystone are system-specific resources."},{"line_number":292,"context_line":"    # Make sure we use a system-scoped token to interact with this API."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ac2ffa2c_19659674","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":41},"updated":"2021-11-16 16:27:31.000000000","message":"I am just thinking to use GLANCE_ADMIN_CLOUD_NAME\u003d\"devstack-system-admin\" like we are doing for other service. \n\noverriding OS_CLOUD can cause issue for async mode when more tasks are async?","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"143e6f754d80f073541b338840aa42fa3c5cf8d9","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    # Registered limit resources in keystone are system-specific resources."},{"line_number":292,"context_line":"    # Make sure we use a system-scoped token to interact with this API."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"f19f1fca_5e53b306","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":41},"in_reply_to":"ac2ffa2c_19659674","updated":"2021-11-17 10:52:52.000000000","message":"The variable should be confined to the currently running process and have no effect on other processes that may already be running in parallel. \n\nThe only other option I see would be to replace this completely with specifying \"--os-cloud devstack-system-admin\" on the command line for the four calls below.","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e4ea759efaab4cbdd31c66ad1868cbd120b79ad7","unresolved":false,"context_lines":[{"line_number":291,"context_line":"    # Registered limit resources in keystone are system-specific resources."},{"line_number":292,"context_line":"    # Make sure we use a system-scoped token to interact with this API."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0c47fd22_acfc6b7a","line":294,"range":{"start_line":294,"start_character":0,"end_line":294,"end_character":41},"in_reply_to":"f19f1fca_5e53b306","updated":"2021-11-22 20:52:55.000000000","message":"I think specifying the --os-cloud argument for each would be nice since it makes things explicit and it\u0027s thread safe.","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"143e6f754d80f073541b338840aa42fa3c5cf8d9","unresolved":true,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":298,"context_line":"        --region $REGION_NAME image_stage_total"},{"line_number":299,"context_line":"    openstack registered limit create --service glance --default-limit 100 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"e6635281_6f5d2b86","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":29},"updated":"2021-11-17 10:52:52.000000000","message":"The region-name is also specified in the cloud config, so this could be dropped.","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"37b9684095cc06b4a92153a928212ce21bb1084f","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":298,"context_line":"        --region $REGION_NAME image_stage_total"},{"line_number":299,"context_line":"    openstack registered limit create --service glance --default-limit 100 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"af813867_4f51a094","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":29},"in_reply_to":"b7c97a69_e38889ce","updated":"2021-11-26 07:25:54.000000000","message":"Seems I was wrong, the \"--region\" parameter here is a dedicated option for the \"registered limit create\" command. Without it, the limit is created for \"region_id: None\" and later image creation is failing because in the default region the limit is still 0.","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e4ea759efaab4cbdd31c66ad1868cbd120b79ad7","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    export OS_CLOUD\u003ddevstack-system-admin"},{"line_number":295,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":296,"context_line":"        --region $REGION_NAME image_size_total"},{"line_number":297,"context_line":"    openstack registered limit create --service glance --default-limit $GLANCE_LIMIT_IMAGE_SIZE_TOTAL \\"},{"line_number":298,"context_line":"        --region $REGION_NAME image_stage_total"},{"line_number":299,"context_line":"    openstack registered limit create --service glance --default-limit 100 \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"b7c97a69_e38889ce","line":296,"range":{"start_line":296,"start_character":8,"end_line":296,"end_character":29},"in_reply_to":"e6635281_6f5d2b86","updated":"2021-11-22 20:52:55.000000000","message":"Done","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"143e6f754d80f073541b338840aa42fa3c5cf8d9","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        --region $REGION_NAME image_count_uploading"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    # Reset the devstack-admin profile."},{"line_number":305,"context_line":"    export OS_CLOUD\u003ddevstack-admin"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Tell glance to use these limits"},{"line_number":308,"context_line":"    iniset $GLANCE_API_CONF DEFAULT use_keystone_limits True"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7cfbff07_2aafe7e6","line":305,"range":{"start_line":305,"start_character":4,"end_line":305,"end_character":10},"updated":"2021-11-17 10:52:52.000000000","message":"The \"export\" is also redundant when the variable has already been exported before (in stack.sh actually).","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e4ea759efaab4cbdd31c66ad1868cbd120b79ad7","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        --region $REGION_NAME image_count_uploading"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    # Reset the devstack-admin profile."},{"line_number":305,"context_line":"    export OS_CLOUD\u003ddevstack-admin"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    # Tell glance to use these limits"},{"line_number":308,"context_line":"    iniset $GLANCE_API_CONF DEFAULT use_keystone_limits True"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"f8b43afc_7bc709b7","line":305,"range":{"start_line":305,"start_character":4,"end_line":305,"end_character":10},"in_reply_to":"7cfbff07_2aafe7e6","updated":"2021-11-22 20:52:55.000000000","message":"Done","commit_id":"e7c9aef5bf82dee5aef7763159227878272bc3fa"}]}