)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d0cc81aa01f3c97b96ae06fd13d79b8e993ce2e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f7f30533_2e6e5a92","updated":"2021-11-08 20:05:51.000000000","message":"i have not tested this locally yet so workflow -1 for now","commit_id":"7fb4e26ce8c13fbe71d8ecb547b188f747a28303"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"373ec85230a9b1ec92893f1d3d95918d6586d5db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3d87b2f_e3c480b8","updated":"2021-11-09 08:53:04.000000000","message":"A few things:\n\n- For our immediate need, the wrapper works\n\n- Upstream libvirt has wired up QEMU\u0027s \u0027tb-size\u0027 (and also began using \u0027-accel\u0027 instead of \u0027-machine accel\u0027 by defaults: \"[PATCH v2 0/4] Introduce TCG domain features\" — https://listman.redhat.com/archives/libvir-list/2021-November/msg00236.html. This will be available from libvirt v.7.10 onwards.\n\n- I\u0027ve got a WIP patch to wire up config class libvirt\u0027s \"tb-cache\" (i.e. QEMU\u0027s \"tb-size\") libvirt: Introduce config classes for QEMU\u0027s \"tb-cache\"https://review.opendev.org/c/openstack/nova/+/816823.  And then introduce a config option that should be conditionalized on MIN_LIBVIRT version v.7.10","commit_id":"66f298bc8234228a2af18e6193ea2fc7c39e2c53"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"0c000ecaa7127fbf9822c3c8b206dc9c92f80386","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"616f0feb_7e1395c2","updated":"2021-11-09 08:57:07.000000000","message":"Note that the \"tb-size\" for `-accel tcg` was introduced in QEMU v.5.0: https://gitlab.com/qemu-project/qemu/-/commit/fe17413247.   (See the text in the \"qemu-depreicated.texi\" file from the commit.)\n\nSo you want to add a version-check for this in the wrapper.","commit_id":"66f298bc8234228a2af18e6193ea2fc7c39e2c53"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ecf13b4cc7d89f2d297fa7b2eb96bd6b212b0583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29b94953_99a9a33a","updated":"2021-11-08 22:23:43.000000000","message":"im still having apparmor issue with this i might have to disable it in libvirt to make this work","commit_id":"66f298bc8234228a2af18e6193ea2fc7c39e2c53"}]}