)]}'
{"lib/ironic":[{"author":{"_account_id":10380,"name":"Josh Gachnang","email":"josh@pcsforeducation.com","username":"JoshNang"},"change_message_id":"0eb2a5bdaa1e030d5bf66e677c83662f75298cd2","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    # Ensure that at least one ListenAddress exists."},{"line_number":413,"context_line":"    if ! sudo grep ListenAddress /etc/ssh/sshd_config | grep -cvq \u0027^#\u0027; then"},{"line_number":414,"context_line":"        # Otherwise we\u0027re dealing with default sshd config. So adding the default one."},{"line_number":415,"context_line":"        echo \"ListenAddress 0.0.0.0\" | sudo tee -a $SSH_CONFIG"},{"line_number":416,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FDPo%3D","line":413,"updated":"2014-03-20 16:46:48.000000000","message":"You should swap /etc/ssh/sshd_config for $SSH_CONFIG","commit_id":"c162cd1134979b47cbab90a67f276e056192d1fa"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"9118cdf866292f8defcd28ca4f1ef17a57904ad5","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"    # Ensure that at least one ListenAddress exists."},{"line_number":413,"context_line":"    if ! sudo grep ListenAddress /etc/ssh/sshd_config | grep -cvq \u0027^#\u0027; then"},{"line_number":414,"context_line":"        # Otherwise we\u0027re dealing with default sshd config. So adding the default one."},{"line_number":415,"context_line":"        echo \"ListenAddress 0.0.0.0\" | sudo tee -a $SSH_CONFIG"},{"line_number":416,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAWH%2F%2FDFA%3D","line":413,"in_reply_to":"AAAAWH%2F%2FDPo%3D","updated":"2014-03-20 17:03:17.000000000","message":"Done","commit_id":"c162cd1134979b47cbab90a67f276e056192d1fa"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"34ec9d5f2dcec114f762b1aa2d98eef8bc1a80ca","unresolved":false,"context_lines":[{"line_number":404,"context_line":"}"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"function configure_ironic_sshd {"},{"line_number":407,"context_line":"    # Ensure sshd server accepts connections from localhost only"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    SSH_CONFIG\u003d/etc/ssh/sshd_config"},{"line_number":410,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAWH%2F%2BdzI%3D","side":"PARENT","line":407,"updated":"2014-03-26 16:04:43.000000000","message":"Is this comment still accurate?","commit_id":"871b1e47092a6463cb39be48c66bfe3e646920c2"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"529df7c36408ec316027ff01d734df510a8fe0de","unresolved":false,"context_lines":[{"line_number":404,"context_line":"}"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"function configure_ironic_sshd {"},{"line_number":407,"context_line":"    # Ensure sshd server accepts connections from localhost only"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    SSH_CONFIG\u003d/etc/ssh/sshd_config"},{"line_number":410,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAWH%2F%2BX1I%3D","side":"PARENT","line":407,"in_reply_to":"AAAAWH%2F%2BdzI%3D","updated":"2014-03-27 09:36:37.000000000","message":"Done","commit_id":"871b1e47092a6463cb39be48c66bfe3e646920c2"},{"author":{"_account_id":7369,"name":"Sergey Skripnick","email":"sskripnick@mirantis.com","username":"redixin"},"change_message_id":"13730080eeee4aa85c68570f66da1a9b0eab82c7","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    # Ensure that at least one ListenAddress exists."},{"line_number":411,"context_line":"    if ! sudo grep ListenAddress $SSH_CONFIG | grep -cvq \u0027^#\u0027; then"},{"line_number":412,"context_line":"        # Otherwise we\u0027re dealing with default sshd config. So adding the default one."},{"line_number":413,"context_line":"        echo \"ListenAddress 0.0.0.0\" | sudo tee -a $SSH_CONFIG"},{"line_number":414,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAWH%2F9l68%3D","line":411,"updated":"2014-04-03 13:59:59.000000000","message":"if sudo grep -q \"^ *ListenAddress\" /tmp/sshd_config; then\n  # there is at least one active ListenAddress\n else\n  # there is no active ListenAddress\n fi\n\nalso usually sshd_config is readable by non-root, so sudo isn\u0027t necessary (not sure about ironic/devstack config)","commit_id":"375ba7f877313e0e416ac145a59a6eb6b018e3af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1b1922fe1cae9f78955b082550595f2cd1b0ef63","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    # Ensure that at least one ListenAddress exists."},{"line_number":411,"context_line":"    if ! sudo grep ListenAddress $SSH_CONFIG | grep -cvq \u0027^#\u0027; then"},{"line_number":412,"context_line":"        # Otherwise we\u0027re dealing with default sshd config. So adding the default one."},{"line_number":413,"context_line":"        echo \"ListenAddress 0.0.0.0\" | sudo tee -a $SSH_CONFIG"},{"line_number":414,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAWH%2F9lHk%3D","line":411,"in_reply_to":"AAAAWH%2F9l68%3D","updated":"2014-04-03 15:06:22.000000000","message":"In Fedora sshd_config is not readable by non-root","commit_id":"375ba7f877313e0e416ac145a59a6eb6b018e3af"},{"author":{"_account_id":8003,"name":"Aleksandr Gordeev","email":"agordeev@mirantis.com","username":"agordeev"},"change_message_id":"279b755d27f995f89d4423721d2b6ac3e1adfd76","unresolved":false,"context_lines":[{"line_number":408,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    # Ensure that at least one ListenAddress exists."},{"line_number":411,"context_line":"    if ! sudo grep ListenAddress $SSH_CONFIG | grep -cvq \u0027^#\u0027; then"},{"line_number":412,"context_line":"        # Otherwise we\u0027re dealing with default sshd config. So adding the default one."},{"line_number":413,"context_line":"        echo \"ListenAddress 0.0.0.0\" | sudo tee -a $SSH_CONFIG"},{"line_number":414,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAAWH%2F9kLI%3D","line":411,"in_reply_to":"AAAAWH%2F9l68%3D","updated":"2014-04-03 16:46:20.000000000","message":"Thank you for tip with grep. But this condition is not needed, b/c requested LIstenAddress will be added for both cases.","commit_id":"375ba7f877313e0e416ac145a59a6eb6b018e3af"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"298ab2a6c50f5dc5f5b636dbdaa8e2d3048997dc","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    SSH_CONFIG\u003d/etc/ssh/sshd_config"},{"line_number":419,"context_line":"    HOST_PORT\u003d$IRONIC_VM_SSH_ADDRESS:$IRONIC_VM_SSH_PORT"},{"line_number":420,"context_line":"    if ! sudo grep ListenAddress $SSH_CONFIG | grep $HOST_PORT; then"},{"line_number":421,"context_line":"        echo \"ListenAddress $HOST_PORT\" | sudo tee -a $SSH_CONFIG"},{"line_number":422,"context_line":"    fi"},{"line_number":423,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAW3%2F%2F4EU%3D","side":"PARENT","line":420,"updated":"2014-04-09 18:41:18.000000000","message":"when $SSH_CONFIG does not have *any* ListenAddres directive... we need to make sure it has at least one before we proceed.\n\nTesting of the original patch which implemented this showed that, within an HPCS Precise instance, without this section sshd would always jump onto the private bridge, and we\u0027d lose access to the host.","commit_id":"995e10cbf70d21cead1e1d31c2eef1a7adede76f"}]}
