)]}'
{"lib/keystone":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fd43f080c971df36a9333a2f04286f3ca22aeadd","unresolved":true,"context_lines":[{"line_number":301,"context_line":"    admin_user\u003d$(openstack user show \"admin\" -f value -c id)"},{"line_number":302,"context_line":"    # These roles are also created during bootstrap but we don\u0027t need their IDs"},{"line_number":303,"context_line":"    local admin_role\u003d\"admin\""},{"line_number":304,"context_line":"    local manager_role"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    openstack role create manager"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    manager_role\u003d$(openstack role show \"manager\" -f value -c id)"},{"line_number":309,"context_line":"    local member_role\u003d\"member\""},{"line_number":310,"context_line":"    local reader_role\u003d\"reader\""},{"line_number":311,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ee56afff_7f88a4ef","line":308,"range":{"start_line":304,"start_character":4,"end_line":308,"end_character":64},"updated":"2021-12-20 14:24:23.000000000","message":"nit:\nyou can move these lines below 310 so that declaration of all roles will be at one place.","commit_id":"386e848f27787911e2f652a93b4d07282da46b0c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"8d99e0e1a7fe5517fa6edc8bfa897dd02933b551","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    admin_user\u003d$(openstack user show \"admin\" -f value -c id)"},{"line_number":302,"context_line":"    # These roles are also created during bootstrap but we don\u0027t need their IDs"},{"line_number":303,"context_line":"    local admin_role\u003d\"admin\""},{"line_number":304,"context_line":"    local manager_role"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    openstack role create manager"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    manager_role\u003d$(openstack role show \"manager\" -f value -c id)"},{"line_number":309,"context_line":"    local member_role\u003d\"member\""},{"line_number":310,"context_line":"    local reader_role\u003d\"reader\""},{"line_number":311,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"c2af9638_a0d9e009","line":308,"range":{"start_line":304,"start_character":4,"end_line":308,"end_character":64},"in_reply_to":"ee56afff_7f88a4ef","updated":"2021-12-21 10:35:06.000000000","message":"Ack","commit_id":"386e848f27787911e2f652a93b4d07282da46b0c"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fd43f080c971df36a9333a2f04286f3ca22aeadd","unresolved":true,"context_lines":[{"line_number":420,"context_line":"    # Set the role hierarchy by implying \u0027manager\u0027 role between \u0027admin\u0027 and \u0027member\u0027"},{"line_number":421,"context_line":"    openstack implied role create $admin_role --implied-role $manager_role"},{"line_number":422,"context_line":"    openstack implied role create $manager_role --implied-role $member_role"},{"line_number":423,"context_line":"    openstack implied role delete $admin_role --implied-role $member_role"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    if is_service_enabled ldap; then"},{"line_number":426,"context_line":"        create_ldap_domain"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7c87ade8_e61346ff","line":423,"range":{"start_line":423,"start_character":4,"end_line":423,"end_character":73},"updated":"2021-12-20 14:24:23.000000000","message":"I think instead of deleting it you should remove the code which is creating this implied role and move the above two lines(421 and 422) where it is creating the exiting implied roles.","commit_id":"386e848f27787911e2f652a93b4d07282da46b0c"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"8d99e0e1a7fe5517fa6edc8bfa897dd02933b551","unresolved":true,"context_lines":[{"line_number":420,"context_line":"    # Set the role hierarchy by implying \u0027manager\u0027 role between \u0027admin\u0027 and \u0027member\u0027"},{"line_number":421,"context_line":"    openstack implied role create $admin_role --implied-role $manager_role"},{"line_number":422,"context_line":"    openstack implied role create $manager_role --implied-role $member_role"},{"line_number":423,"context_line":"    openstack implied role delete $admin_role --implied-role $member_role"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    if is_service_enabled ldap; then"},{"line_number":426,"context_line":"        create_ldap_domain"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"091eb179_1e7e0445","line":423,"range":{"start_line":423,"start_character":4,"end_line":423,"end_character":73},"in_reply_to":"7c87ade8_e61346ff","updated":"2021-12-21 10:35:06.000000000","message":"I might be wrong here but i think the creation of existing implied role happens in the bootstrap_keystone function where in keystone-manage bootstrap command gets called and implied roles gets created for existing roles[1].\n\nIs there any specific place your are pointing out here? \n\n[1]: https://github.com/openstack/keystone/blob/10057702ac361213e74472ec1d0d4e4c4a041f09/keystone/cmd/bootstrap.py#L172","commit_id":"386e848f27787911e2f652a93b4d07282da46b0c"}]}