)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"c6f5cf421d5a3c7716a86f977b6ee631ab6fa21d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a549a84c_6a777d9f","updated":"2021-12-28 07:14:12.000000000","message":"Are you sure that there are no other callers to this than neutron itself?","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1468c8f077c2f42813f08ae4db9ef477db31fd6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"707fad95_8f20601e","updated":"2022-01-12 05:42:49.000000000","message":"O.k., let\u0027s do it this way and hope it doesn\u0027t set too bad a precedent.","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fd6a856c45d5af86f2c69f8c7677c6496612b2ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff302e6d_472a6cd1","updated":"2022-01-07 10:12:28.000000000","message":"Since I didn\u0027t get an answer so far: Changing the signature of a public library function should be done in a backwards compatible way. Best create a new function and keep the old for a while, marking it as deprecated.","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"89447e3d37aad8b4a4af11647d5d4afea094ebfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87ae55d3_f68a4703","updated":"2022-01-13 14:27:59.000000000","message":"lgtm, neutron team agrees with the change, so let\u0027s merge","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91e9a560732037c4d920e7cab87aa8339003850d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87951b07_c455cfe2","in_reply_to":"bdff0f48_0692a421","updated":"2022-01-11 07:35:25.000000000","message":"yes, it\u0027s like Jakub said already. The only known user of that function is Neutron. I can of course propose new function if that\u0027s needed but do we really need to do it in this case? Please let me know what You think about it Jens.","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0bf974a56fba04e44d0a136c7b3aa0e23ba60632","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bdff0f48_0692a421","in_reply_to":"ff302e6d_472a6cd1","updated":"2022-01-07 14:22:31.000000000","message":"There is only Neutron calling it - https://codesearch.openstack.org/?q\u003dcompile_ovn\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nand there is an approved patch to adapt to this change - https://review.opendev.org/c/openstack/neutron/+/822719","commit_id":"588894753971c32f6fff9b2158c3427b012cf9ec"}]}