)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"e766f026703364510f1676139a460d969366ec30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3067eb79_20566671","updated":"2022-01-07 15:10:28.000000000","message":"We are actually testing this patch in the OS migrate upstream CI[1] so it works as expected.\n\n[1]: https://github.com/os-migrate/os-migrate/pull/512/files","commit_id":"84c18d00491123d72abdefdab569ec2b777f813b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"139352386823a6d0a99d449dc0ebb4bff59d9e7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d55a6dab_d8520a63","updated":"2022-01-08 10:56:16.000000000","message":"Are you sure that this is really needed? I would assume that \"disable_service mysql\" in your configuration should do the same thing. If it doesn\u0027t, maybe rather fix that?","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8ddbc6d2a9669a8eed064feee10047faa980120f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76d8c08a_fb54d825","updated":"2022-01-07 20:41:47.000000000","message":"Thanks!","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"52a1306181f6191727b83bb1303a88bc5fd7fe5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3342ad57_0849b1aa","updated":"2022-01-07 20:42:04.000000000","message":"recheck","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"53428dbf12434dc522f979cefd356e32f2bdb186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33738f47_785f3518","in_reply_to":"d55a6dab_d8520a63","updated":"2022-01-10 08:30:30.000000000","message":"Yes, the usage of a mutual exclusive database backend is required, MySQL or Postgres. In our case we always used MySQL, so we can not disable all the configuration steps, we only need to exclude the packages install.","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"53428dbf12434dc522f979cefd356e32f2bdb186","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16ec084b_9a092b7a","updated":"2022-01-10 08:30:30.000000000","message":"Jens and Radoslaw thanks a lot for the feedback.","commit_id":"cc6e20b24d22475720f7b938aa08edf9ee7514fb"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f4bd2adb1ddea1f7e9ced169bc46fbf98fff8fbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f576fc0_05088f01","updated":"2022-01-10 10:19:54.000000000","message":"recheck","commit_id":"cc6e20b24d22475720f7b938aa08edf9ee7514fb"}],"lib/databases/mysql":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"497816f295e4eb0979993edbee795ba9839e00b3","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        chmod 0600 $HOME/.my.cnf"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"    # Install mysql-server"},{"line_number":179,"context_line":"    if [[ \"$INSTALL_DATABASE_SERVER\" \u003d \"True\" ]]; then"},{"line_number":180,"context_line":"        if is_oraclelinux; then"},{"line_number":181,"context_line":"            install_package mysql-community-server"},{"line_number":182,"context_line":"        elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"885ca15d_f02c600f","line":179,"range":{"start_line":179,"start_character":37,"end_line":179,"end_character":39},"updated":"2022-01-07 16:35:48.000000000","message":"\u003d\u003d","commit_id":"2a59a694bdf890e3f8b9c40cf645ef93545506a5"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"8ddbc6d2a9669a8eed064feee10047faa980120f","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        chmod 0600 $HOME/.my.cnf"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"    # Install mysql-server"},{"line_number":179,"context_line":"    if [[ \"$INSTALL_DATABASE_SERVER\" \u003d \"True\" ]]; then"},{"line_number":180,"context_line":"        if is_oraclelinux; then"},{"line_number":181,"context_line":"            install_package mysql-community-server"},{"line_number":182,"context_line":"        elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"cf8b230e_27b02a7d","line":179,"range":{"start_line":179,"start_character":37,"end_line":179,"end_character":39},"in_reply_to":"885ca15d_f02c600f","updated":"2022-01-07 20:41:47.000000000","message":"Done, thanks for the review.","commit_id":"2a59a694bdf890e3f8b9c40cf645ef93545506a5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"139352386823a6d0a99d449dc0ebb4bff59d9e7c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"set +o xtrace"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"MYSQL_DRIVER\u003d${MYSQL_DRIVER:-PyMySQL}"},{"line_number":15,"context_line":"INSTALL_DATABASE_SERVER\u003d$(trueorfalse True INSTALL_DATABASE_SERVER)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"register_database mysql"},{"line_number":18,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9836e31e_383eb9b5","line":15,"updated":"2022-01-08 10:56:16.000000000","message":"Either name the variable INSTALL_MYSQL_SERVER or also disable installing postgres?","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"53428dbf12434dc522f979cefd356e32f2bdb186","unresolved":false,"context_lines":[{"line_number":12,"context_line":"set +o xtrace"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"MYSQL_DRIVER\u003d${MYSQL_DRIVER:-PyMySQL}"},{"line_number":15,"context_line":"INSTALL_DATABASE_SERVER\u003d$(trueorfalse True INSTALL_DATABASE_SERVER)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"register_database mysql"},{"line_number":18,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"c22648c8_7e15adf7","line":15,"in_reply_to":"9836e31e_383eb9b5","updated":"2022-01-10 08:30:30.000000000","message":"You are right, in this case I think the variable should be called INSTALL_DATABASE_SERVER_PACKAGES so independently if you use MySQL or Postgres you can configure them but excluding the package install.","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"139352386823a6d0a99d449dc0ebb4bff59d9e7c","unresolved":true,"context_lines":[{"line_number":150,"context_line":"}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"function install_database_mysql {"},{"line_number":153,"context_line":"    if is_ubuntu; then"},{"line_number":154,"context_line":"        # Seed configuration with mysql password so that apt-get install doesn\u0027t"},{"line_number":155,"context_line":"        # prompt us for a password upon install."},{"line_number":156,"context_line":"        sudo debconf-set-selections \u003c\u003cMYSQL_PRESEED"},{"line_number":157,"context_line":"mysql-server mysql-server/root_password password $DATABASE_PASSWORD"},{"line_number":158,"context_line":"mysql-server mysql-server/root_password_again password $DATABASE_PASSWORD"},{"line_number":159,"context_line":"mysql-server mysql-server/start_on_boot boolean true"},{"line_number":160,"context_line":"MYSQL_PRESEED"},{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # while ``.my.cnf`` is not needed for OpenStack to function, it is useful"},{"line_number":164,"context_line":"    # as it allows you to access the mysql databases via ``mysql nova`` instead"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"803843d8_546cde96","line":161,"range":{"start_line":153,"start_character":0,"end_line":161,"end_character":6},"updated":"2022-01-08 10:56:16.000000000","message":"Do you still need this block to be executed?","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"53428dbf12434dc522f979cefd356e32f2bdb186","unresolved":false,"context_lines":[{"line_number":150,"context_line":"}"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"function install_database_mysql {"},{"line_number":153,"context_line":"    if is_ubuntu; then"},{"line_number":154,"context_line":"        # Seed configuration with mysql password so that apt-get install doesn\u0027t"},{"line_number":155,"context_line":"        # prompt us for a password upon install."},{"line_number":156,"context_line":"        sudo debconf-set-selections \u003c\u003cMYSQL_PRESEED"},{"line_number":157,"context_line":"mysql-server mysql-server/root_password password $DATABASE_PASSWORD"},{"line_number":158,"context_line":"mysql-server mysql-server/root_password_again password $DATABASE_PASSWORD"},{"line_number":159,"context_line":"mysql-server mysql-server/start_on_boot boolean true"},{"line_number":160,"context_line":"MYSQL_PRESEED"},{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # while ``.my.cnf`` is not needed for OpenStack to function, it is useful"},{"line_number":164,"context_line":"    # as it allows you to access the mysql databases via ``mysql nova`` instead"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a2b9dba5_ab090e1a","line":161,"range":{"start_line":153,"start_character":0,"end_line":161,"end_character":6},"in_reply_to":"803843d8_546cde96","updated":"2022-01-10 08:30:30.000000000","message":"Indeed, the MySQL service is already installed in a container but waiting to be configured by the Devstack installer script. We just need a way to control if we need to skip the installing of the database server packages. (adding Postgres now might help others using that backend.)","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"139352386823a6d0a99d449dc0ebb4bff59d9e7c","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        chmod 0600 $HOME/.my.cnf"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"    # Install mysql-server"},{"line_number":179,"context_line":"    if [[ \"$INSTALL_DATABASE_SERVER\" \u003d\u003d \"True\" ]]; then"},{"line_number":180,"context_line":"        if is_oraclelinux; then"},{"line_number":181,"context_line":"            install_package mysql-community-server"},{"line_number":182,"context_line":"        elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"deb60be8_a7f77888","line":179,"updated":"2022-01-08 10:56:16.000000000","message":"Better check for \u003d\u003d False and return, then you can leave the remainder untouched.","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"53428dbf12434dc522f979cefd356e32f2bdb186","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        chmod 0600 $HOME/.my.cnf"},{"line_number":177,"context_line":"    fi"},{"line_number":178,"context_line":"    # Install mysql-server"},{"line_number":179,"context_line":"    if [[ \"$INSTALL_DATABASE_SERVER\" \u003d\u003d \"True\" ]]; then"},{"line_number":180,"context_line":"        if is_oraclelinux; then"},{"line_number":181,"context_line":"            install_package mysql-community-server"},{"line_number":182,"context_line":"        elif is_fedora; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"75fe1291_c59db723","line":179,"in_reply_to":"deb60be8_a7f77888","updated":"2022-01-10 08:30:30.000000000","message":"I thought about this, but my concern is that in the future if you add code below that conditional if you \u0027return\u0027 when skipping the packages install no code bellow that will be ever executed. WDYT?","commit_id":"227e059a43c4142da91e1eeec03dd6f0d7cb5938"}]}