)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"faefff65a600bcced02bb3b2a4e8a2a2eee40d59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d3a09bd6_613a2cc3","updated":"2022-01-31 18:13:46.000000000","message":"Couple of comments inline, nothing to block this patch now, though.\n\nIt would be good to look at which of the different options we have actually get job coverage, though, and possible do some manual testing at least on those that don\u0027t.","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"91cc112df3d69a955a5b39672b17aa112b357f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9eaffa1_d655e141","updated":"2022-02-08 15:39:59.000000000","message":"lgtm. let\u0027s merge it and frickler comment can be worked in followup. ","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"40ebd0f4b9c64e050ec149533a39e6dac412b5ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ffe759e6_dfdf9860","in_reply_to":"c9eaffa1_d655e141","updated":"2022-02-17 11:00:22.000000000","message":"Follow up patch proposed https://review.opendev.org/c/openstack/devstack/+/829675","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"}],"lib/neutron_plugins/services/l3":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"faefff65a600bcced02bb3b2a4e8a2a2eee40d59","unresolved":true,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"# Create private IPv4 subnet"},{"line_number":251,"context_line":"function _neutron_create_private_subnet_v4 {"},{"line_number":252,"context_line":"    local project_id\u003d$1"},{"line_number":253,"context_line":"    if [ -z $SUBNETPOOL_V4_ID ]; then"},{"line_number":254,"context_line":"        fixed_range_v4\u003d$FIXED_RANGE"},{"line_number":255,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"89ddcb15_205f4ca7","line":252,"updated":"2022-01-31 18:13:46.000000000","message":"If you hardcode to demo project, this is no longer useful. Fine to clean up in a follow-up.","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"faefff65a600bcced02bb3b2a4e8a2a2eee40d59","unresolved":true,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"# Configure neutron router for IPv4 public access"},{"line_number":320,"context_line":"function _neutron_configure_router_v4 {"},{"line_number":321,"context_line":"    openstack --os-cloud devstack-admin-demo --os-region \"$REGION_NAME\" router add subnet $ROUTER_ID $SUBNET_ID"},{"line_number":322,"context_line":"    # Create a public subnet on the external network"},{"line_number":323,"context_line":"    local id_and_ext_gw_ip"},{"line_number":324,"context_line":"    id_and_ext_gw_ip\u003d$(_neutron_create_public_subnet_v4 $EXT_NET_ID)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7913c591_7af746bd","line":321,"updated":"2022-01-31 18:13:46.000000000","message":"Doing it this way is fine for consistency, I\u0027m just wondering whether this operation would also be allowed to be done as system-admin?\n\nActually, also the router could either be in the admin or in the demo project according to the choice of Q_L3_ROUTER_PER_TENANT above. So one would need to use the corresponding project here?\n\nAnd finally, does this actually need an admin role? Both adding a subnet and setting a gateway should be normal user operations, maybe we should not use more powerful roles than necessary.","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"faefff65a600bcced02bb3b2a4e8a2a2eee40d59","unresolved":true,"context_lines":[{"line_number":401,"context_line":"        # IPv6 address of the router\u0027s gateway in a bit different way."},{"line_number":402,"context_line":"        # It can be reverted when bug"},{"line_number":403,"context_line":"        # https://bugs.launchpad.net/neutron/+bug/1959332 will be fixed"},{"line_number":404,"context_line":"        IPV6_ROUTER_GW_IP\u003d$(openstack --os-cloud devstack-admin-demo --os-region \"$REGION_NAME\" router show $ROUTER_ID -c external_gateway_info -f json | grep -C 1 $ipv6_pub_subnet_id | grep ip_address | awk \u0027{print $2}\u0027 | tr -d \u0027\"\u0027)"},{"line_number":405,"context_line":"        die_if_not_set $LINENO IPV6_ROUTER_GW_IP \"Failure retrieving IPV6_ROUTER_GW_IP\""},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        if is_neutron_ovs_base_plugin; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5edcaab9_72ea679a","line":404,"updated":"2022-01-31 18:13:46.000000000","message":"Actually I think that this variant might be cleaner than to old one and we should stick to it, maybe just make the json handling a bit cleaner by using \"jq\", I\u0027ll have a go at that.","commit_id":"14a0c09001e8e2304eff4918206163cc7e6db1eb"}]}