)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"61e99d4c9182f9ec85a06cf29e2a4ac126c85223","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be9970df_821c4bce","updated":"2022-02-23 21:37:38.000000000","message":"I7a170262b50a5c80a516095b872d52e1bea5479d already made this work with 6.0, I don\u0027t understand this change either.","commit_id":"4d707b2b1a5e5c6d55eea679859f9947f8c9c627"}],"tools/update_clouds_yaml.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"0412a5db379131b18a8841b226902dd0cb466cd3","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    def _read_clouds(self):"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            with open(self._clouds_path) as clouds_file:"},{"line_number":68,"context_line":"                self._clouds \u003d yaml.safe_load(clouds_file)"},{"line_number":69,"context_line":"        except IOError:"},{"line_number":70,"context_line":"            # The user doesn\u0027t have a clouds.yaml file."},{"line_number":71,"context_line":"            print(\"The user clouds.yaml file didn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfd3b0a0_bd923c87","side":"PARENT","line":68,"updated":"2022-02-23 21:34:42.000000000","message":"This old version of the code appears to by pyyaml 6.0 safe. It has the added benefit of running a safe load which the new code does not. Can you expand a bit on why it is necessary to stop using yaml.safe_load()?","commit_id":"2462893787af2670a9d502dec64f2ed76c0f424c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e65f377cf92f5bb0a65db89e6a9c04a8db5d4d8","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    def _read_clouds(self):"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            with open(self._clouds_path) as clouds_file:"},{"line_number":68,"context_line":"                self._clouds \u003d yaml.safe_load(clouds_file)"},{"line_number":69,"context_line":"        except IOError:"},{"line_number":70,"context_line":"            # The user doesn\u0027t have a clouds.yaml file."},{"line_number":71,"context_line":"            print(\"The user clouds.yaml file didn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"901e05eb_9fa1d4b6","side":"PARENT","line":68,"in_reply_to":"12a07629_4958ac24","updated":"2022-02-23 22:10:55.000000000","message":"Yes I think backporting the existing fix would be preferable.","commit_id":"2462893787af2670a9d502dec64f2ed76c0f424c"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"1df1de60fb23abb4bc4cfcb3f6015ed3a096ef81","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def _read_clouds(self):"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            with open(self._clouds_path) as clouds_file:"},{"line_number":68,"context_line":"                self._clouds \u003d yaml.safe_load(clouds_file)"},{"line_number":69,"context_line":"        except IOError:"},{"line_number":70,"context_line":"            # The user doesn\u0027t have a clouds.yaml file."},{"line_number":71,"context_line":"            print(\"The user clouds.yaml file didn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"92a2d768_aa384020","side":"PARENT","line":68,"in_reply_to":"901e05eb_9fa1d4b6","updated":"2022-02-24 15:18:21.000000000","message":"Done","commit_id":"2462893787af2670a9d502dec64f2ed76c0f424c"},{"author":{"_account_id":30893,"name":"Chris Sibbitt","email":"csibbitt@redhat.com","username":"csibbitt"},"change_message_id":"9dcaab6f014d4c3fad8d7fa5b19f9ad918240ad3","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    def _read_clouds(self):"},{"line_number":66,"context_line":"        try:"},{"line_number":67,"context_line":"            with open(self._clouds_path) as clouds_file:"},{"line_number":68,"context_line":"                self._clouds \u003d yaml.safe_load(clouds_file)"},{"line_number":69,"context_line":"        except IOError:"},{"line_number":70,"context_line":"            # The user doesn\u0027t have a clouds.yaml file."},{"line_number":71,"context_line":"            print(\"The user clouds.yaml file didn\u0027t exist.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"12a07629_4958ac24","side":"PARENT","line":68,"in_reply_to":"cfd3b0a0_bd923c87","updated":"2022-02-23 22:09:55.000000000","message":"Sorry, my patch was meant for wallaby and I oopsed. https://opendev.org/openstack/devstack/src/branch/stable/wallaby/tools/update_clouds_yaml.py#L68). I see the existing code on master is definitely preferred, thanks! \n\nShould I backport the fix on master to Xena and Wallaby? That\u0027s where I encountered the problem.","commit_id":"2462893787af2670a9d502dec64f2ed76c0f424c"}]}
