)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"79f5543be4901873e21a7658c3bcd91bc7fe676d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dd2276d6_cee8f434","updated":"2022-03-10 16:04:44.000000000","message":"good catch!","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cfdebb6012408fedc6001bf137aea7c3fcad6abe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4090fc0e_d4df3334","updated":"2022-03-10 12:16:43.000000000","message":"recheck unrelated volume error","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"42ead98a8a91990fae5b3c5ff27e9eb0f804e24a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93b94b03_98aa7db2","updated":"2022-04-11 13:19:00.000000000","message":"thanks, lgtm ","commit_id":"eca9783a0ad9c7d7e2e8267457be8d4dd8b55502"}],"stack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"11a8d42008460e971642ac630b484dd5826dbd45","unresolved":true,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"8d98efaa_f4e7e710","line":73,"updated":"2022-03-27 07:33:50.000000000","message":"What distro is affected by this? I\u0027m not convinced that this is a good solution, because sometimes pip might install binaries into a different location and this is all about where to find those binaries. Can we instead have a fixup function only for the special case(s) where it is needed?","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1f9b6f6e95d1a1cdfefc40b8e74efb351c8ed1e","unresolved":true,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"80504199_659acd33","line":73,"in_reply_to":"3c571415_76348f6a","updated":"2022-03-28 14:09:17.000000000","message":"I agree, the sbin thing seems to have been added in 2014 for Debian according to the commit message. otoh we don\u0027t have the tools available to check which distro we are running on until much later in this script.\n\nSo I guess I retract my comment and instead maybe keep things simple and just add /usr/local/bin to the list in L70 unconditionally?","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"69c902e0228244e9a996ceb39606b6290c383629","unresolved":true,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"4ceca4dd_ae47e99a","line":73,"in_reply_to":"4ba84afa_5bf7c8e4","updated":"2022-03-29 18:37:16.000000000","message":"+1 on adding the path to the list on line 70","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb5cb5159f913d9cfb1c7aeedaa402de236b197a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"d5ccd898_3c118ea6","line":73,"in_reply_to":"4ceca4dd_ae47e99a","updated":"2022-04-07 12:33:32.000000000","message":"Done","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"64891aa4b00ee1e7cd6c50bfbe0570acdbe0ed47","unresolved":true,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"4ba84afa_5bf7c8e4","line":73,"in_reply_to":"80504199_659acd33","updated":"2022-03-28 14:26:25.000000000","message":"ya i could i was not sure what impact of repeating a folder on the path is.\ni think its fine it will just be checked twice but that is the only reason i did the test.","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3348d51a407cdd86b68073b91ace335d4d6e01bb","unresolved":true,"context_lines":[{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":71,"context_line":"# osc will normally be installed at /usr/local/bin/openstack so ensure"},{"line_number":72,"context_line":"# /usr/local/bin is also in the path"},{"line_number":73,"context_line":"[[ \"$PATH\" \u003d~ \"/usr/local/bin\" ]] || export PATH\u003d\"/usr/local/bin:$PATH\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Keep track of the DevStack directory"},{"line_number":76,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3c571415_76348f6a","line":73,"in_reply_to":"8d98efaa_f4e7e710","updated":"2022-03-28 13:29:41.000000000","message":"well the same logic would apply to the previous line too no?\nwe do not special case the inclusion of sbin\n\nthis was for redhats internal centos 9 stream cloud image.\ni have not figured out why that image does not have /usr/local/bin in its path but that is where pip was installing stuff.\n\n\ni had to also modify the tempest run playook downstream to work around the path issue\n\nanges that run through devstack-tempest are likely to have an impact on\n# the devstack part of the job, so we keep devstack in the main play to\n# avoid zuul retrying on legitimate failures.\n- hosts: all\n  roles:\n    - orchestrate-devstack\n# We run tests only on one node, regardless how many nodes are in the system\n- hosts: tempest\n  environment:\n    # This enviroment variable is used by the optional tempest-gabbi\n    # job provided by the gabbi-tempest plugin. It can be safely ignored\n    # if that plugin is not being used.\n    GABBI_TEMPEST_PATH: \"{{ gabbi_tempest_path | default(\u0027\u0027) }}\"\n    PATH: \"/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin\"\n  roles:\n    - setup-tempest-run-dir\n    - setup-tempest-data-dir\n    - acl-devstack-files\n    - run-tempest\n\ni proably could just set the path in the env when i call orchestrate-devstack i guess. the same way as i do for tempest above and then not need this patch.\nill try that and see if it works.\n\nif we were to move this to a fixup fucntion we should also mvoe the sbin path maniulation to be consitent.","commit_id":"e9e0a3744befc030accdc56c22b6cfd2ff31d706"}]}