)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"10cd52e71384417cd8e2250ca66c6773589b5f93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c4406d10_6d636351","updated":"2022-03-25 13:31:19.000000000","message":"temp -1, need to check if there were any new extensions added during yoga cycle","commit_id":"79d9fbec3a2d14785510f83b83a0dd149bedd376"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"94e4142e68ce05b516b427c927c3d478927f187c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aaf2f373_ebc91557","updated":"2022-03-28 20:47:45.000000000","message":"lgtm, thanks","commit_id":"f169094c21ded2a48197c0273993b4c86e5a4128"}],"lib/tempest":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f66888831eba6bdc6670e2cd32d30fb16c5d195a","unresolved":true,"context_lines":[{"line_number":687,"context_line":"    DEFAULT_NET_EXT+\u003d\",floatingip-pools,rbac-security-groups,subnetpool-prefix-ops,router-admin-state-down-before-update\""},{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile\""},{"line_number":691,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":692,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":693,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fc6578a2_85fc299b","line":690,"range":{"start_line":690,"start_character":61,"end_line":690,"end_character":62},"updated":"2022-03-28 08:33:28.000000000","message":"I found these but I\u0027m not sure they can/should be added for the stable/yoga release:\n\nsubnet-dns-publish-fixed-ip\ntrunk\nvlan-transparent\nsegment\nsecurity-groups-shared-filtering\nsecurity-groups-normalized-cidr\nquota-check-limit\nqos-rule-type-filter\nqos-rules-alias\nqos\nqos-bw-limit-direction\nqos-default\nqos-fip\nqos-gateway-ip\nport-resource-request\nfloating-ip-port-forwarding\nfloating-ip-port-forwarding-description\nfloating-ip-port-forwarding-port-ranges\nlogging\ndns-domain-ports\ndns-integration\ndns-integration-domain-keywords\nexpose-port-forwarding-in-fip","commit_id":"19cef3789483d8410fc4576cdb7c386ef590e29d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"829f13e35d74f5740f2f862cfafb11d2ff68bfd6","unresolved":true,"context_lines":[{"line_number":687,"context_line":"    DEFAULT_NET_EXT+\u003d\",floatingip-pools,rbac-security-groups,subnetpool-prefix-ops,router-admin-state-down-before-update\""},{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile\""},{"line_number":691,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":692,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":693,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6b5ae068_4058f64e","line":690,"range":{"start_line":690,"start_character":61,"end_line":690,"end_character":62},"in_reply_to":"9f0be34e_98dcdcd3","updated":"2022-03-28 15:30:14.000000000","message":"thank you for the feedback! yeah, it may vary, the list contains only the default ones - in case user didn\u0027t set specific extensions - in case a user wants to enable more extensions (or different subset of them) it can be done via NETWORK_API_EXTENSIONS var which will override DEFAULT_NET_EXT one.","commit_id":"19cef3789483d8410fc4576cdb7c386ef590e29d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a3bd47645ec62b170ceec7eebb0e08e27834f50c","unresolved":true,"context_lines":[{"line_number":687,"context_line":"    DEFAULT_NET_EXT+\u003d\",floatingip-pools,rbac-security-groups,subnetpool-prefix-ops,router-admin-state-down-before-update\""},{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile\""},{"line_number":691,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":692,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":693,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f0be34e_98dcdcd3","line":690,"range":{"start_line":690,"start_character":61,"end_line":690,"end_character":62},"in_reply_to":"fc6578a2_85fc299b","updated":"2022-03-28 12:19:18.000000000","message":"Extensions:\n\nsecurity-groups-shared-filtering\nsecurity-groups-normalized-cidr\nquota-check-limit\n\nare supported by ML2 plugin so will be available in any configuration for sure and can be added here as default extensions.\n\nEverything else what You mentioned are extensions which can be enabled by enabling some service plugin (qos, segments, portforwardings, logging, trunk), extension drivers (dns integration) or config option (vlan-transparent). So I wouldn\u0027t add them to the list of default extensions.\n\nAlso that list of default extensions can vary depending on the backend (ML2/OVN or something else) used. So maybe it would be good to prepare list based on the Q_AGENT variable? But that can be done as follow-up patch for sure.","commit_id":"19cef3789483d8410fc4576cdb7c386ef590e29d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3b0f6890850ee723a805c1749297b997ad8504c7","unresolved":true,"context_lines":[{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile,security-groups-shared-filtering\""},{"line_number":691,"context_line":"    DEFAULT_NET_EXT+\u003d\",security-groups-normalized-cidr,quota-check-limit\""},{"line_number":692,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":693,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":694,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dbb982e8_bffa86af","line":691,"updated":"2022-03-29 07:27:18.000000000","message":"If you compare with xena, we had added there\n\nDEFAULT_NET_EXT+\u003d\",multiple-external-gateways,qos-pps-minimum,l3-ext-ndp-proxy,rbac-bgpvpn\"\nDEFAULT_NET_EXT+\u003d\",qos-pps,ecmp_routes,bgp,floating-ip-port-forwarding-port-ranges\"\n\nwhy are these dropped? If they should not be in this list, should they be dropped from xena again, too?","commit_id":"f169094c21ded2a48197c0273993b4c86e5a4128"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"1f077119be36cf16afd7dbc66f73270d10bc4353","unresolved":true,"context_lines":[{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile,security-groups-shared-filtering\""},{"line_number":691,"context_line":"    DEFAULT_NET_EXT+\u003d\",security-groups-normalized-cidr,quota-check-limit\""},{"line_number":692,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":693,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":694,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"e00e1b3f_75ed7f28","line":691,"in_reply_to":"dbb982e8_bffa86af","updated":"2022-03-29 07:56:51.000000000","message":"good point, thanks! I made a mistake when I was copying them , apparently I didn\u0027t copy it from xena branch .. let me fix that in the follow up patchset","commit_id":"f169094c21ded2a48197c0273993b4c86e5a4128"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3e336e30dc2512b36a436ab64ffbdc0943e41785","unresolved":true,"context_lines":[{"line_number":688,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-subnetpool,tag-ports-during-bulk-creation,stateful-security-group,address-group,extraroute-atomic\""},{"line_number":689,"context_line":"    DEFAULT_NET_EXT+\u003d\",port-numa-affinity-policy,rbac-address-scope,security-groups-remote-address-group\""},{"line_number":690,"context_line":"    DEFAULT_NET_EXT+\u003d\",rbac-address-group,port-device-profile,security-groups-shared-filtering\""},{"line_number":691,"context_line":"    DEFAULT_NET_EXT+\u003d\",security-groups-normalized-cidr,quota-check-limit\""},{"line_number":692,"context_line":"    local network_api_extensions\u003d${NETWORK_API_EXTENSIONS:-$DEFAULT_NET_EXT}"},{"line_number":693,"context_line":"    if [[ ! -z \"$DISABLE_NETWORK_API_EXTENSIONS\" ]]; then"},{"line_number":694,"context_line":"        # Enabled extensions are either the ones explicitly specified or those available on the API endpoint"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"2c717206_0cb32570","line":691,"in_reply_to":"e00e1b3f_75ed7f28","updated":"2022-03-29 15:02:09.000000000","message":"thanks for catching that. now it is appending list to what we had in xena. I did not see any extensions is removed in Yoga.","commit_id":"f169094c21ded2a48197c0273993b4c86e5a4128"}]}