)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"678ca43475b37e7f32c88dc2d0749a82315e11c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"242a1136_42056fdb","updated":"2022-04-13 06:48:57.000000000","message":"Per inline notes, I can\u0027t see getting this working","commit_id":"1e00ae35e88904dc62c692b13dce820979598a42"}],"inc/python":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"7d51b8e423a83eff1dd9f0284b1d88ab665d2fb3","unresolved":true,"context_lines":[{"line_number":383,"context_line":"        # source we are about to do."},{"line_number":384,"context_line":"        local name"},{"line_number":385,"context_line":"        name\u003d$(awk \u0027/^name.*\u003d/ {print $3}\u0027 $project_dir/setup.cfg)"},{"line_number":386,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints \\"},{"line_number":387,"context_line":"            $REQUIREMENTS_DIR/upper-constraints.txt -- $name"},{"line_number":388,"context_line":"    fi"},{"line_number":389,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"cb45cd62_b3d0cd0d","side":"PARENT","line":386,"updated":"2022-04-13 01:40:55.000000000","message":"Nit: Extra / here","commit_id":"ce0ff1fd9d32a3cc33d46caacda555c4f6773515"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"359fe1fd6f38fdabb252d6f0098a80a7c403aec9","unresolved":true,"context_lines":[{"line_number":383,"context_line":"        # source we are about to do."},{"line_number":384,"context_line":"        local name"},{"line_number":385,"context_line":"        name\u003d$(awk \u0027/^name.*\u003d/ {print $3}\u0027 $project_dir/setup.cfg)"},{"line_number":386,"context_line":"        $REQUIREMENTS_DIR/.venv/bin/edit-constraints \\"},{"line_number":387,"context_line":"            $REQUIREMENTS_DIR/upper-constraints.txt -- $name"},{"line_number":388,"context_line":"    fi"},{"line_number":389,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f69f6de4_0e1deec1","side":"PARENT","line":386,"in_reply_to":"cb45cd62_b3d0cd0d","updated":"2022-04-13 01:45:33.000000000","message":"ahh yeah, that should go back to $REQUIREMENTS_DIR to be a no-op","commit_id":"ce0ff1fd9d32a3cc33d46caacda555c4f6773515"}],"lib/tempest":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12e338d8c9cbc483a181e0046ce97e3f3194fd3c","unresolved":true,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"# install_tempest() - Collect source and prepare"},{"line_number":710,"context_line":"function install_tempest {"},{"line_number":711,"context_line":"    git_clone_no_chown $TEMPEST_REPO $TEMPEST_DIR $TEMPEST_BRANCH"},{"line_number":712,"context_line":"    pip_install \u0027tox!\u003d2.8.0\u0027"},{"line_number":713,"context_line":"    pushd $TEMPEST_DIR"},{"line_number":714,"context_line":"    # NOTE(gmann): checkout the TEMPEST_BRANCH in case TEMPEST_BRANCH"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"b6434ca1_27ae98f6","line":711,"updated":"2022-04-13 06:48:38.000000000","message":"OK, this doesn\u0027t work because we install tempest globally with pip_install (which uses sudo -- i.e. source dir must be owned by root) but then we\u0027re running tox here as stack -- tox tries to install tempest into the tox venv and now wants it as \"stack\", the user.\n\nI see no way around having to either setup multiple checkouts of the code, or constantly chowning the source tree.  Both are beyond silly for this case, and I really think upstream needs to think a bit more about the implications of the change...","commit_id":"1e00ae35e88904dc62c692b13dce820979598a42"}]}