)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"12092f3ebaab0068e4bf8c772e221a5ecc66a9e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"df9985d2_466b2856","updated":"2022-04-13 15:28:41.000000000","message":"Also note that I think this solution is superior to some other attempts (i.e. https://review.opendev.org/c/openstack/devstack/+/837731) because it keeps things behaving the way they have been for users of devstack (i.e. devs). The alternative to install from sdist breaks editable installs, which I think are a very important part of the workflow for people that use devstack to develop openstack. While I acknowledge that editable installs in generally may have their days numbered, I definitely don\u0027t want us to break that important aspect of devstack just to sidestep this git thing if there are better alternatives (like this patch blessing each of our repos).","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c91a1fba902f28c5b1ab8fc57bfd941e4cdbee6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dffa5410_3f19b062","updated":"2022-04-13 14:33:21.000000000","message":"I think we need to be looking for a quick (interim?) solution to avoid everything being held up while we restructure how we do things in devstack (if that\u0027s even going to happen) and this seems reasonable. Can we roll this in to a stable and move from older to newer to avoid having to make grenade non-voting? Or perhaps the quickest way to at least get devstack jobs working again is to just do the latter.\n","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b83bd3b90cfeaa922a736220ba3a1f2d5f4d786e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"85848d3a_bd6309ac","updated":"2022-04-13 07:36:06.000000000","message":"Need to make grenade jobs non-voting to get it merge.","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4e928f3b03a5acfb0f4e78da10cacc80f302d964","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c88ecfce_c0f71b2c","updated":"2022-04-13 16:35:53.000000000","message":"lgtm, holding +W until greande jobs are green which needs to wait until we backport it in reverse order or make them non voting.","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"39eaa503b5568bb8c2c25bac5bbb0dcfa275cfb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11a8ee3f_1c0b0f6d","updated":"2022-04-13 13:06:25.000000000","message":"recheck","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"}],"functions-common":[{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"c83413e8ffa6d99c20e9a1de5c992af9f6b8da94","unresolved":true,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    # NOTE(ianw) 2022-04-13 : commit [1] has broken many assumptions"},{"line_number":677,"context_line":"    # about how we clone and work with repos.  Mark them safe globally"},{"line_number":678,"context_line":"    # as a work-around."},{"line_number":679,"context_line":"    #"},{"line_number":680,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":681,"context_line":"    sudo git config --global --add safe.directory ${git_dest}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"de8aa672_4ac21062","line":678,"range":{"start_line":678,"start_character":11,"end_line":678,"end_character":22},"updated":"2022-04-13 13:51:13.000000000","message":"Not sure we can call it a \"workaround\". It\u0027s a proper fix, targeting subset of directories.","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"01fdaa464562f401253d07d03c8ae83c732fbca9","unresolved":false,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    # NOTE(ianw) 2022-04-13 : commit [1] has broken many assumptions"},{"line_number":677,"context_line":"    # about how we clone and work with repos.  Mark them safe globally"},{"line_number":678,"context_line":"    # as a work-around."},{"line_number":679,"context_line":"    #"},{"line_number":680,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":681,"context_line":"    sudo git config --global --add safe.directory ${git_dest}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"47254574_2c5532f3","line":678,"range":{"start_line":678,"start_character":11,"end_line":678,"end_character":22},"in_reply_to":"04b6f081_aff3d8ee","updated":"2022-04-13 14:39:13.000000000","message":"right. a \"correct\" solution would be to use virtualenv or something like that, preventing the root thingy. But that\u0027s more for the future. Sooo yeah. \"workaround without a hack\" :).","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c91a1fba902f28c5b1ab8fc57bfd941e4cdbee6a","unresolved":true,"context_lines":[{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    # NOTE(ianw) 2022-04-13 : commit [1] has broken many assumptions"},{"line_number":677,"context_line":"    # about how we clone and work with repos.  Mark them safe globally"},{"line_number":678,"context_line":"    # as a work-around."},{"line_number":679,"context_line":"    #"},{"line_number":680,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":681,"context_line":"    sudo git config --global --add safe.directory ${git_dest}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"04b6f081_aff3d8ee","line":678,"range":{"start_line":678,"start_character":11,"end_line":678,"end_character":22},"in_reply_to":"de8aa672_4ac21062","updated":"2022-04-13 14:33:21.000000000","message":"It\u0027s a workaround in the sense that we\u0027re not (with this patch) completely changing how devstack works to fit git\u0027s new requirements. But agree, it\u0027s better than a hack :)","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4595bef7ba146bf93dbc57635dd59532f04add26","unresolved":true,"context_lines":[{"line_number":678,"context_line":"    # as a work-around."},{"line_number":679,"context_line":"    #"},{"line_number":680,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":681,"context_line":"    sudo git config --global --add safe.directory ${git_dest}"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    # print out the results so we know what change was used in the logs"},{"line_number":684,"context_line":"    cd $git_dest"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9dfea65d_f786b496","line":681,"range":{"start_line":681,"start_character":20,"end_line":681,"end_character":28},"updated":"2022-04-13 16:30:03.000000000","message":"I wonder if --system makes more sense. But currently we\u0027re only experiencing this as root when running the pip installs so sudo + --global should be sufficient.","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"376fa26f0dda1ba280aef7b9102a394bb4632a1a","unresolved":true,"context_lines":[{"line_number":678,"context_line":"    # as a work-around."},{"line_number":679,"context_line":"    #"},{"line_number":680,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":681,"context_line":"    sudo git config --global --add safe.directory ${git_dest}"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    # print out the results so we know what change was used in the logs"},{"line_number":684,"context_line":"    cd $git_dest"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7835c968_383e3b30","line":681,"range":{"start_line":681,"start_character":20,"end_line":681,"end_character":28},"in_reply_to":"9dfea65d_f786b496","updated":"2022-04-13 19:33:12.000000000","message":"Turns out not! On bionic git-config will end up writing to ~stackuser/.gitconfig instead of ~root/.gitconfig unless sudo is run with -H.\n\nHowever, --system is better I think because it\u0027s more discoverable when you\u0027re trying to clean a system. The ~root/.gitconfig is decidedly more hidden, especially on distros where logging in as root is unusual.","commit_id":"676dcaf94487665882be048cfe1f3206d6807e0f"}]}