)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b8663920911e88ff735497e6a90ace992eed29fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9646f105_40e8714e","updated":"2022-05-03 18:29:51.000000000","message":"makes sense, thank you!","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"77c964d163e63942edaa875a77df5e187ad8c6e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80510a0d_f25d91fe","updated":"2022-04-21 12:26:50.000000000","message":"recheck c9stream mirror issue gone","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"38e1325870f97e05d5308580588cd99cc4e441b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ebfa650_137f1ec8","updated":"2022-04-26 06:25:21.000000000","message":"recheck nova-compute not found","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0f646941e28eaf836a3e6f20bf50909b9c74c348","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"647f1686_35ef204d","updated":"2022-04-26 08:24:39.000000000","message":"recheck ovnnb absent","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a2531a1ee950d66229d17e1f14df01288eead728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8f04b7e9_f781f1a1","updated":"2022-04-22 13:09:53.000000000","message":"recheck pypi proxy issue","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"78e127c7248bf97ca33283b5b723fa82ada9b28b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1d4bbe21_6e7b5859","updated":"2022-05-25 06:34:47.000000000","message":"Just fixed a typo","commit_id":"c64ea4f213afebd1602d05cdd4d5bc14eaf5356b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"615fa340a754dd8cbfa2375dfe46d060a0a79fb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a3f01cf_cb165874","updated":"2022-05-31 17:20:53.000000000","message":"recheck tempest timeout slow node","commit_id":"c64ea4f213afebd1602d05cdd4d5bc14eaf5356b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e7217f1e0e43d7cc46cb78dd39c2aedcaf408b89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8310289f_6ba33281","updated":"2022-05-31 14:54:58.000000000","message":"thanks","commit_id":"c64ea4f213afebd1602d05cdd4d5bc14eaf5356b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"836cae2015caf4abffbd7c64b6b0ec8b29198d69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28e2185a_97637b3e","in_reply_to":"1d4bbe21_6e7b5859","updated":"2022-05-25 06:38:30.000000000","message":"Thanks","commit_id":"c64ea4f213afebd1602d05cdd4d5bc14eaf5356b"}],"doc/source/guides/multinode-lab.rst":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9f2087fbcf59602d7cca3149883e895b329753b","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    useradd -s /bin/bash -d /opt/stack -m stack"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Ensure home directory for the `stack` user have permissions set to `755`, RHEL"},{"line_number":79,"context_line":"based distros create it with `700` which will have issues later."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"626a67ca_98302362","line":78,"updated":"2022-05-18 09:20:05.000000000","message":"Use double backticks for all those quoted strings. Also s/have/has/","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed8ef5eea45333dd2ee26bc976336970cc232240","unresolved":true,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    useradd -s /bin/bash -d /opt/stack -m stack"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Ensure home directory for the `stack` user have permissions set to `755`, RHEL"},{"line_number":79,"context_line":"based distros create it with `700` which will have issues later."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9b414409_f078a852","line":78,"in_reply_to":"626a67ca_98302362","updated":"2022-05-18 15:00:33.000000000","message":"Done","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"}],"doc/source/index.rst":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"82fe93149a2904212842b0e4d2f9495373cd258f","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    $ sudo -u stack -i"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Download DevStack"},{"line_number":78,"context_line":"-----------------"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"4af3a260_ceb81613","line":76,"updated":"2022-05-10 18:17:35.000000000","message":"nit: those two lines seems to be not related to this patch IMHO","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed8ef5eea45333dd2ee26bc976336970cc232240","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    $ sudo -u stack -i"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Download DevStack"},{"line_number":78,"context_line":"-----------------"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"9029d41d_9449fe2e","line":76,"in_reply_to":"4af3a260_ceb81613","updated":"2022-05-18 15:00:33.000000000","message":"Done","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"}],"tools/create-stack-user.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e9f2087fbcf59602d7cca3149883e895b329753b","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"if ! getent passwd $STACK_USER \u003e/dev/null; then"},{"line_number":45,"context_line":"    echo \"Creating a user called $STACK_USER\""},{"line_number":46,"context_line":"    useradd -g $STACK_USER -s /bin/bash -d $DEST -m $STACK_USER"},{"line_number":47,"context_line":"    # RHEL based distros create home dir with 700 permissions,"},{"line_number":48,"context_line":"    # But devstack deploy will have issues with it, fix it by"},{"line_number":49,"context_line":"    # setting permission to 755"}],"source_content_type":"text/x-sh","patch_set":1,"id":"2de35c13_04247340","line":46,"updated":"2022-05-18 09:20:05.000000000","message":"Maybe it would be good enough to copy the solution used below and run\n\n( umask 022 \u0026 useradd ... )\n\nOr does RH override that default behavior of useradd simply replicating the current umask?","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed8ef5eea45333dd2ee26bc976336970cc232240","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"if ! getent passwd $STACK_USER \u003e/dev/null; then"},{"line_number":45,"context_line":"    echo \"Creating a user called $STACK_USER\""},{"line_number":46,"context_line":"    useradd -g $STACK_USER -s /bin/bash -d $DEST -m $STACK_USER"},{"line_number":47,"context_line":"    # RHEL based distros create home dir with 700 permissions,"},{"line_number":48,"context_line":"    # But devstack deploy will have issues with it, fix it by"},{"line_number":49,"context_line":"    # setting permission to 755"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5e6967eb_82783cb0","line":46,"in_reply_to":"2de35c13_04247340","updated":"2022-05-18 15:00:33.000000000","message":"No (umask \u0026\u0026 useradd) do not work.\n\nActually i recently found ubuntu 21.04+ also changed[1] to RH behavior. Will also add this info too to the commit message with next update.\n\n[1] https://discourse.ubuntu.com/t/private-home-directories-for-ubuntu-21-04-onwards/19533","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96ca0d2acef6d1e67cc5a188685cd26ad8dbaaa6","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    if [[ $(stat -c \u0027%a\u0027 $DEST) \u003d 700 ]]; then"},{"line_number":51,"context_line":"        echo \"Permissions for $DEST is 700, updating to 755\""},{"line_number":52,"context_line":"        chmod 755 $DEST"},{"line_number":53,"context_line":"    fi"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Giving stack user passwordless sudo privileges\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"10f3a60a_73383e6d","line":53,"updated":"2022-05-03 19:30:56.000000000","message":"This may be pretty surprising to people who are running this on a more general-purpose machine (i.e. a laptop) who don\u0027t expect something so fundamental to have changed.\n\nThat said, devstack installs things running with privileges that are user-writable as a pretty important part of the workflow so it\u0027s probably not critical.\n\nThe important thing that needs to change is just the execute bit so that other things can traverse right? Maybe it would be better to just set ugo+x on ~ to avoid exposing the contents of the home directory without restricting the ability to traverse to specific things?","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2ff3389678a0791f9cd4259cc63be313ae45af95","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    if [[ $(stat -c \u0027%a\u0027 $DEST) \u003d 700 ]]; then"},{"line_number":51,"context_line":"        echo \"Permissions for $DEST is 700, updating to 755\""},{"line_number":52,"context_line":"        chmod 755 $DEST"},{"line_number":53,"context_line":"    fi"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Giving stack user passwordless sudo privileges\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"49f62b7a_51389a7e","line":53,"in_reply_to":"10f3a60a_73383e6d","updated":"2022-05-06 10:02:54.000000000","message":"@Dan you mean people may be using same machine both for devstack and other purpose(and using the same stack user and i\u0027ts home dir), right? and they don\u0027t expect to change permissions on the background like this? just checking if i understood correctly.\n\nWrt executable thing, from what i recall yes it should be enough, i will cross check if need to update here. The reason i pushed 755 change so it have same permissions as before(previous distro releases) and just work.","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"82fe93149a2904212842b0e4d2f9495373cd258f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if [[ $(stat -c \u0027%a\u0027 $DEST) \u003d 700 ]]; then"},{"line_number":51,"context_line":"        echo \"Permissions for $DEST is 700, updating to 755\""},{"line_number":52,"context_line":"        chmod 755 $DEST"},{"line_number":53,"context_line":"    fi"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Giving stack user passwordless sudo privileges\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"5677f23c_2cc2a838","line":53,"in_reply_to":"49f62b7a_51389a7e","updated":"2022-05-10 18:17:35.000000000","message":"Personally I think that this is ok as devstack isn\u0027t something what people usually install on their main machines. I think it\u0027s even written somewhere in devstack docs that it is prettily \"intrusive\" and may make many changes in the environment.","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ed8ef5eea45333dd2ee26bc976336970cc232240","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    if [[ $(stat -c \u0027%a\u0027 $DEST) \u003d 700 ]]; then"},{"line_number":51,"context_line":"        echo \"Permissions for $DEST is 700, updating to 755\""},{"line_number":52,"context_line":"        chmod 755 $DEST"},{"line_number":53,"context_line":"    fi"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"echo \"Giving stack user passwordless sudo privileges\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"ca33f52f_4837a2d0","line":53,"in_reply_to":"5677f23c_2cc2a838","updated":"2022-05-18 15:00:33.000000000","message":"I checked it works fine with just chmod +x, so updated the patch according to it.","commit_id":"3e579b6d6473dab067d56f52169de1a35d623834"}]}