)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"b8e682f6d4324a9fa4b3d0b8ac2e5443120e6cb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a6a0dad_6e11fce1","updated":"2024-08-28 11:47:13.000000000","message":"LGTM\n\nNone of the jobs seems to test it in this patch, pushed test patch[1] to confirm all good\n\n[1] https://review.opendev.org/c/openstack/neutron/+/927381","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"316aeececba673f34cf089b38175172a733d6817","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c65d7b6_5ca9e882","updated":"2024-08-26 19:40:12.000000000","message":"recheck\n\nfor latest results","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ad6adb7088844fda2862cf2ce05a52ce6dda4f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3593adf_ea264921","in_reply_to":"2a6a0dad_6e11fce1","updated":"2024-08-28 12:09:14.000000000","message":"ok now found it tested in https://review.opendev.org/c/openstack/neutron/+/927272 already","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"}],"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1981cdfc512e77111eab5b8826b3441d22379979","unresolved":true,"context_lines":[{"line_number":333,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":334,"context_line":"        ./configure"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    make -j$(($(nproc) + 1))"},{"line_number":337,"context_line":"    popd"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b8e0a097_b4e15d39","line":336,"updated":"2024-08-29 03:54:32.000000000","message":"So we compile a second version of OVS just to build OVN? Wouldn\u0027t it make sense to also install this one, then, and drop compiling the other version? In particular if there are incompatible changes in funtion signatures in OVS, I cannot see how the issue cited above would be fixed by just changing the compile step.","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a760463b3867cee862e35e55578e71205bf8bee5","unresolved":true,"context_lines":[{"line_number":333,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":334,"context_line":"        ./configure"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    make -j$(($(nproc) + 1))"},{"line_number":337,"context_line":"    popd"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"c8e9e301_124c41eb","line":336,"in_reply_to":"b8e0a097_b4e15d39","updated":"2024-08-29 04:00:59.000000000","message":"@frickler we can have different version of ovs installed and we have use cases to test specific ovs versions irrespective of ovn version used.\nThis patch is just to make ovn compile compatible with ovs libraries and using submodule version will help and that\u0027s what ovn tests. [1] also documents this:-\n\nThese OVS sources used as a set of libraries to build OVN binaries, so OVS submodule is only recommended to build OVN and not recommended to be used as a source for OVS build. To actually build/run OVS binaries (ovs-vswitchd, ovsdb-server) use released versions of Open vSwitch or packages provided in your distribution.\n\nhttps://github.com/ovn-org/ovn/blob/3fb397b63663297acbcbf794e1233951222ae5af/Documentation/intro/install/general.rst#bootstrapping","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9646fe90b2630e675fe937f75e3ccf7bb616ae3d","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":334,"context_line":"        ./configure"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    make -j$(($(nproc) + 1))"},{"line_number":337,"context_line":"    popd"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"d7be30ed_0d8c17be","line":336,"in_reply_to":"c8e9e301_124c41eb","updated":"2024-08-29 07:05:40.000000000","message":"Hmm, this sounds like a weird concept of using libraries to me, but whatever.\n\nMaybe longer term someone will want to look into a way of caching these builds somehow so that they don\u0027t need to run for every job, at least for the tagged versions ov OVN+OVS.","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3698c9a527c38c16d14c6a9bf1f8689fb50cbf1c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":334,"context_line":"        ./configure"},{"line_number":335,"context_line":"    fi"},{"line_number":336,"context_line":"    make -j$(($(nproc) + 1))"},{"line_number":337,"context_line":"    popd"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1017c0f1_b42d0c49","line":336,"in_reply_to":"d7be30ed_0d8c17be","updated":"2024-08-29 08:24:06.000000000","message":"It isn\u0027t for every job as most jobs installs it from packages. We have only few jobs which compiles it from source so impact is not that big for sure 😊","commit_id":"7fa24750a676a44ab224206cc13096f904057d44"}]}