)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"002c2c198ea206ad01dadde9c173b71315d2a2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db516bce_269df448","updated":"2022-04-22 15:00:54.000000000","message":"I did test this ... but not with a real $DEST, so my bad...\n","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d03d59e2986fa310beeb838841d446b5fcdf5f36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d7d8c0f0_ee8cfead","updated":"2022-04-22 12:30:01.000000000","message":"IMO we really should drop unstack.sh since it is untested.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5c5bdebc701a6e9fa8a8d7aaec8858c2498ad48d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98a8aba9_3f383196","in_reply_to":"62965e6f_f896971b","updated":"2022-04-22 15:40:03.000000000","message":"\u003e I use unstack all the time. What is the alternative? I always unstack \u0026\u0026 clean. Are you suggesting clean is enough, or that we shouldn\u0027t have either?\n\nThe alternative would be to start with a fresh instance again. The other option would be to build a job that actually tests a full stack/unstack/stack cycle, there was some attempt at that some time ago but I think it has been abandoned.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"55578a450b591c929fcacb4404ab51ccb202ff43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9f1297eb_7b25355e","in_reply_to":"92b3b79f_ac11ebb3","updated":"2022-04-25 13:27:23.000000000","message":"I use a similar approach than Dan to re-stack my env: ./unstack.sh \u0026\u0026 ./clean.sh \u0026\u0026 ./stack.sh . Sure in some case it is easier to recreate the VM from scratch but as Dan I also had devstack on bare metal in the past for SRIOV testing.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"590e82bdd2ddebbba39c015f0b39649360190867","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92b3b79f_ac11ebb3","in_reply_to":"98a8aba9_3f383196","updated":"2022-04-22 16:59:25.000000000","message":"Well, for those of us that run it on bare metal, that\u0027s not really an alternative. At least gibi and myself, but I suspect we\u0027re not the only ones :)\n\nI think it\u0027s okay to say that unstack/clean are not really tested, but if we have to have a job to test them in order to clean them, then fine. But there are other things in the devstack tree that aren\u0027t tested but that we keep for good reason.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"002c2c198ea206ad01dadde9c173b71315d2a2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62965e6f_f896971b","in_reply_to":"d7d8c0f0_ee8cfead","updated":"2022-04-22 15:00:54.000000000","message":"I use unstack all the time. What is the alternative? I always unstack \u0026\u0026 clean. Are you suggesting clean is enough, or that we shouldn\u0027t have either?","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"91c0959ed2ed7b7d9f59e1360d591ffb62544e1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"64b17794_3a49f204","updated":"2022-04-27 11:12:06.000000000","message":"I too noticed this issue locally and was about to push similar patch","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"}],"functions-common":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d03d59e2986fa310beeb838841d446b5fcdf5f36","unresolved":true,"context_lines":[{"line_number":683,"context_line":"    # discoverable anyway."},{"line_number":684,"context_line":"    #"},{"line_number":685,"context_line":"    # [1] https://github.com/git/git/commit/8959555cee7ec045958f9b6dd62e541affb7e7d9"},{"line_number":686,"context_line":"    sudo git config --system --add safe.directory ${git_dest}"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    # print out the results so we know what change was used in the logs"},{"line_number":689,"context_line":"    cd $git_dest"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"f1692263_7ddf769e","line":686,"range":{"start_line":686,"start_character":29,"end_line":686,"end_character":35},"updated":"2022-04-22 12:30:01.000000000","message":"Not directly related, but this \"--add\" should also be removed, since it will add duplicate entries when the stack.sh run is interrupted/failing and restarted. Maybe you can add this to this patch, so we can backport in one piece.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"}],"unstack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d03d59e2986fa310beeb838841d446b5fcdf5f36","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"+directory\u003d${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":1,"id":"33a57a70_f1083f17","line":188,"updated":"2022-04-22 12:30:01.000000000","message":"This also doesn\u0027t work for me:\n\nsed: -e expression #1, char 3: extra characters after command\n\nAlso, the entries I have look like:\n\n    directory \u003d /opt/stack/neutron\n\nMaybe we should rather use the same mechanism we use to create these entries?\n\nsudo git config --system --unset-all safe.directory \"$DEST\"\n\nworks fine in my local testing.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"002c2c198ea206ad01dadde9c173b71315d2a2d1","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"+directory\u003d${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":1,"id":"fafa4165_e6c2fe9b","line":188,"in_reply_to":"33a57a70_f1083f17","updated":"2022-04-22 15:00:54.000000000","message":"\u003e Maybe we should rather use the same mechanism we use to create these entries?\n\u003e \n\u003e sudo git config --system --unset-all safe.directory \"$DEST\"\n\u003e \n\u003e works fine in my local testing.\n\nI tried this locally and it removes *all* of the safe items, even ones not in the $DEST, which I think we should not do, especially against the system list. That might have been on my bionic system when I was validating the backport, but unless you know that I missed that somehow, I don\u0027t think we should use this approach.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5830c6c58e5cf9170eecdf919d6ddf3363609952","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"+directory\u003d${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9048ad18_83d654d1","line":188,"in_reply_to":"38316483_570df833","updated":"2022-04-23 00:10:59.000000000","message":"seems to work on Jammy","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"55578a450b591c929fcacb4404ab51ccb202ff43","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"+directory\u003d${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":1,"id":"46169845_13d674b0","line":188,"in_reply_to":"9048ad18_83d654d1","updated":"2022-04-25 13:27:23.000000000","message":"My bad, I forgot to escape. Fixed.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7b2116fcc92f1c3406a3a1dd2b2c0709f5e4e78f","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"+directory\u003d${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":1,"id":"38316483_570df833","line":188,"in_reply_to":"fafa4165_e6c2fe9b","updated":"2022-04-22 19:39:12.000000000","message":"on old ubuntu/bash this worked: \"\\+directory \u003d ${DEST}+ d\" for me, though i haven\u0027t tested it with focal.","commit_id":"246f3def2cd83cccfb900d60532958af9009e35a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4bce78548fa8889ad18375d2cd61d96c43002066","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"\\+directory \u003d ${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":2,"id":"22a2e7b7_096233c2","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":35},"updated":"2022-04-25 13:43:52.000000000","message":"Do you not need to escape this one too?","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e232a8c48d1bf1267d042fa4efb268c08e8f90d3","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"\\+directory \u003d ${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9c202377_012e7731","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":35},"in_reply_to":"144605df_24381dec","updated":"2022-04-27 15:31:28.000000000","message":"Honestly I don\u0027t know the reason but yes, only the first needs to be escaped.","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"91c0959ed2ed7b7d9f59e1360d591ffb62544e1c","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"\\+directory \u003d ${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":2,"id":"144605df_24381dec","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":35},"in_reply_to":"22a2e7b7_096233c2","updated":"2022-04-27 11:12:06.000000000","message":"Only first one need escape","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a33c7668089d28f859dc8df2de78bb1e152069ab","unresolved":true,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"\\+directory \u003d ${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":2,"id":"d91f060f_8e54e2e1","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":35},"in_reply_to":"9c202377_012e7731","updated":"2022-04-27 15:46:25.000000000","message":"Okay, this is why I use \u0027#\" normally, but if it works...","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"35318486018c690551d0a1499e5d7067a964f32b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Clean any safe.directory items we wrote into the global"},{"line_number":186,"context_line":"# gitconfig. We can identify the relevant ones by checking that they"},{"line_number":187,"context_line":"# point to somewhere in our $DEST directory."},{"line_number":188,"context_line":"sudo sed -i \"\\+directory \u003d ${DEST}+ d\" /etc/gitconfig"}],"source_content_type":"text/x-sh","patch_set":2,"id":"84312c36_a490bbe2","line":188,"range":{"start_line":188,"start_character":34,"end_line":188,"end_character":35},"in_reply_to":"d91f060f_8e54e2e1","updated":"2022-05-18 09:53:04.000000000","message":"This is exactly as documented in the manpage:\n\n       \\cregexpc\n              Match lines matching the regular expression regexp.  The c may be any character.","commit_id":"7191c5e7e7edb1e2f28c0ce71294f61b409cf16b"}]}