)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c112f3bf7e280240edde30db81d52e8f4c1a751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"474d6fba_4b9fbd47","updated":"2022-05-17 13:52:35.000000000","message":"Agree we should do this in some way, and good to do it as late as possible so there\u0027s a better chance we don\u0027t have to wait. We\u0027ve spent a lot of effort trying to make devstack run as quick as possible, so I\u0027d rather try to keep it as tight as possible (i.e. without long explicit waits, especially if waiting won\u0027t help as in the case of using upload).","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d8c49d9b9606b9a51c47ca6e5555f589dc8c2324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"141225e1_3326bf5c","updated":"2022-05-17 13:14:38.000000000","message":"See https://review.opendev.org/c/openstack/glance/+/841805 for evidence that this patch both works and doesn\u0027t cause a regression.","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fb6eedc1865eaa8741f5e2d92ccd79204d086075","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1de87cc0_8d474266","updated":"2022-05-17 14:14:20.000000000","message":"Thanks Brian for working on this, one comment inline.","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ef4d9aa077f2e6ddfe1f0cb717490cfc8a5a76e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d8b4bdab_052934fe","updated":"2022-05-18 03:58:07.000000000","message":"Added a job (that should fail) to trigger the polling to https://review.opendev.org/c/openstack/glance/+/841805\n\n","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"901f3a266824f74e4e7b6b695e62f890cbd654a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"01c50d80_9acff689","updated":"2022-05-18 06:58:24.000000000","message":"Checked the result of DNM patch proposed\n\nglance-multistore-cinder-import https://zuul.opendev.org/t/openstack/build/a8e8a1fd830d402abde0a409605298d1 : SUCCESS in 1h 48m 53s\nglance-multistore-cinder-import-1 https://zuul.opendev.org/t/openstack/build/0c37f826c3414c9995198a711eb374bb : SUCCESS in 1h 25m 52s\nglance-multistore-cinder-import-2 https://zuul.opendev.org/t/openstack/build/b13b1bbaab904440aaa74f8f28df9bda : SUCCESS in 1h 45m 34s\nglance-multistore-cinder-import-3 https://zuul.opendev.org/t/openstack/build/704674d047224763b7c0a1b90f756def : FAILURE in 1h 14m 55s\nglance-multistore-cinder-import-4 https://zuul.opendev.org/t/openstack/build/6dc34ad5b29049bba8992f96317f42bf : FAILURE in 1h 29m 30s\nglance-multistore-cinder-import-negative https://zuul.opendev.org/t/openstack/build/04378578260b4a68ad93c933b6042fbb : FAILURE in 26m 40s\n\nglance-multistore-cinder-import-3 and glance-multistore-cinder-import-4 passed devstack run but failed on certain glance tests (unrelated)\n\n2022-05-18 04:19:56.579436 | controller | ++ lib/tempest:get_active_images:154        :   read -r IMAGE_NAME IMAGE_UUID\n2022-05-18 04:19:56.581725 | controller | ++ lib/tempest:configure_tempest:222        :   ((  1 \u003c 1  ))\n2022-05-18 04:19:56.583910 | controller | ++ lib/tempest:configure_tempest:236        :   case \"${#images[*]}\" in\n2022-05-18 04:19:56.586329 | controller | ++ lib/tempest:configure_tempest:242        :   \u0027[\u0027 -z 73d9a355-d31e-4ca0-bfa3-0fc2b3211e91 \u0027]\u0027\n\nglance-multistore-cinder-import-negative failed as expected\n\n2022-05-18 04:20:15.529977 | controller | ++ lib/tempest:get_active_images:154        :   read -r IMAGE_NAME IMAGE_UUID\n2022-05-18 04:20:15.533082 | controller | ++ lib/tempest:poll_glance_images:173       :   ((  1 \u003e\u003d 2  ))\n2022-05-18 04:20:15.535694 | controller | ++ lib/tempest:poll_glance_images:170       :   ((  poll_count-- \u003e 0  ))\n2022-05-18 04:20:15.537714 | controller | ++ lib/tempest:configure_tempest:229        :   ((  1 \u003c 2  ))\n2022-05-18 04:20:15.541302 | controller | ++ lib/tempest:configure_tempest:230        :   echo \u0027Only found 1 image(s), was looking for 2\u0027\n2022-05-18 04:20:15.541325 | controller | Only found 1 image(s), was looking for 2\n2022-05-18 04:20:15.544199 | controller | ++ lib/tempest:configure_tempest:231        :   exit 1\n\nLGTM.","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4678dfde797aae4dce9d1cccc32ec0574f4924e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3ad3bb6_e9ab7964","updated":"2022-05-17 22:09:48.000000000","message":"Seems okay to me (pending a successful run).","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8512ef0beea3396e88f886b88545e39fda1a950d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d616d2b3_0e53cc34","updated":"2022-05-18 12:22:09.000000000","message":"Thanks for the reviews.  New patch set up in a minute.","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a9073e5fe3b7004c0f2b8a2c109d78847d103cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"692ddf3e_56764248","updated":"2022-05-18 02:26:46.000000000","message":"lgtm.","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"33b17aea263ecd878c250bc4df7a9838518b25e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e522598_b3bf22ff","updated":"2022-05-18 13:54:38.000000000","message":"Warning shows up on the negative test run:\nhttps://zuul.opendev.org/t/openstack/build/68ad5e7f743c40dc8ed78a0c75829904/log/job-output.txt?severity\u003d0#23351","commit_id":"111a38b4d6e6f61c21570e0adba58f6c59c52900"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a961ce8fe58a1987faf5d0bf07b6c89b2601d876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c66e3337_6e3fbd56","updated":"2022-05-18 12:32:27.000000000","message":"thx","commit_id":"111a38b4d6e6f61c21570e0adba58f6c59c52900"}],"lib/tempest":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c112f3bf7e280240edde30db81d52e8f4c1a751","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            # import has completed and there may be no active images yet."},{"line_number":204,"context_line":"            # So in that case, we wait a moment and try again."},{"line_number":205,"context_line":"            if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":206,"context_line":"                sleep $TEMPEST_GLANCE_IMPORT_WAIT_TIME"},{"line_number":207,"context_line":"                get_active_images images image_uuid image_uuid_alt"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6997ac32_3c50e3b2","line":206,"updated":"2022-05-17 13:52:35.000000000","message":"I would prefer we poll every second or so, with a total limit timeout so that we will notice as soon as it\u0027s available. I\u0027m guessing 12 is the number you picked because it seems long enough for some failure you\u0027re seeing, but if someone is using a real distro image it could be longer.\n\nSo, any reason not to poll every second (or two) for, say, a minute, before giving up?\n\nAlso, this will wait for 12 seconds for no reason if we\u0027re not using import. Can we set/honor the default only if import is enabled? GLANCE_USE_IMPORT_WORKFLOW tells us if it\u0027s enabled or not.","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fb6eedc1865eaa8741f5e2d92ccd79204d086075","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            # import has completed and there may be no active images yet."},{"line_number":204,"context_line":"            # So in that case, we wait a moment and try again."},{"line_number":205,"context_line":"            if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":206,"context_line":"                sleep $TEMPEST_GLANCE_IMPORT_WAIT_TIME"},{"line_number":207,"context_line":"                get_active_images images image_uuid image_uuid_alt"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf98e4dd_d7d1ff52","line":206,"in_reply_to":"6997ac32_3c50e3b2","updated":"2022-05-17 14:14:20.000000000","message":"I think the if statement above will only trigger this wait when import is enabled\n\nif [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then\n\nAlso i like the idea of polling every x seconds, not sure about the reason for 12 though.","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"880e4cba5f82c47950ebf00ba18a85d2639b61e0","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            # import has completed and there may be no active images yet."},{"line_number":204,"context_line":"            # So in that case, we wait a moment and try again."},{"line_number":205,"context_line":"            if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":206,"context_line":"                sleep $TEMPEST_GLANCE_IMPORT_WAIT_TIME"},{"line_number":207,"context_line":"                get_active_images images image_uuid image_uuid_alt"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"dc4330f9_73f29a85","line":206,"in_reply_to":"6dc1995a_96fa4861","updated":"2022-05-17 21:33:32.000000000","message":"No reason not to poll, I thought I\u0027d keep it simple for the first draft to see if this kind of change was acceptable at all, and also because I figured in the grand scheme of things, what\u0027s 12 seconds relative to total stack time ... but if everyone took that attitude, it would take devstack a week to setup.\n\nAnd yeah, the 12 seconds was because the example I saw needed a 4 sec delay, and I figured 3x that should be adequate on a slow system.","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b83da02af365a872cc969374d73d153c5df90eb1","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            # import has completed and there may be no active images yet."},{"line_number":204,"context_line":"            # So in that case, we wait a moment and try again."},{"line_number":205,"context_line":"            if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":206,"context_line":"                sleep $TEMPEST_GLANCE_IMPORT_WAIT_TIME"},{"line_number":207,"context_line":"                get_active_images images image_uuid image_uuid_alt"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"6dc1995a_96fa4861","line":206,"in_reply_to":"bf98e4dd_d7d1ff52","updated":"2022-05-17 14:18:07.000000000","message":"LOL, sorry, yes. Something something, had not had coffee yet at 6:42am :P","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8512ef0beea3396e88f886b88545e39fda1a950d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            # import has completed and there may be no active images yet."},{"line_number":204,"context_line":"            # So in that case, we wait a moment and try again."},{"line_number":205,"context_line":"            if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":206,"context_line":"                sleep $TEMPEST_GLANCE_IMPORT_WAIT_TIME"},{"line_number":207,"context_line":"                get_active_images images image_uuid image_uuid_alt"},{"line_number":208,"context_line":"            fi"},{"line_number":209,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"132a362e_597c3b8b","line":206,"in_reply_to":"dc4330f9_73f29a85","updated":"2022-05-18 12:22:09.000000000","message":"Done","commit_id":"e9f1b5c125c812b95c7869962ed0f37512f7fb4b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e62307f7f2b43b6ef4b482a7a28f82e23e1b13","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    poll_count\u003d$TEMPEST_GLANCE_IMPORT_POLL_LIMIT"},{"line_number":170,"context_line":"    while (( poll_count-- \u003e 0 )) ; do"},{"line_number":171,"context_line":"        sleep $TEMPEST_GLANCE_IMPORT_POLL_INTERVAL"},{"line_number":172,"context_line":"        get_active_images image_array image_id image_id_alt"},{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"59f9e57e_eb146d3b","line":171,"updated":"2022-05-18 09:06:12.000000000","message":"Since you discussed unnecessary delays, maybe move the sleep to the end of the loop so you don\u0027t sleep at all when the imports went fast?","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a961ce8fe58a1987faf5d0bf07b6c89b2601d876","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    poll_count\u003d$TEMPEST_GLANCE_IMPORT_POLL_LIMIT"},{"line_number":170,"context_line":"    while (( poll_count-- \u003e 0 )) ; do"},{"line_number":171,"context_line":"        sleep $TEMPEST_GLANCE_IMPORT_POLL_INTERVAL"},{"line_number":172,"context_line":"        get_active_images image_array image_id image_id_alt"},{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"525619d4_aa011330","line":171,"in_reply_to":"545ed8c3_7ab42194","updated":"2022-05-18 12:32:27.000000000","message":"Ah, with that call before I think indeed the current solution is o.k.\n\nI was also thinking about the final sleep when I wrote this comment, but considered it acceptable vs. the additional code to skip it in that case.","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8512ef0beea3396e88f886b88545e39fda1a950d","unresolved":true,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    poll_count\u003d$TEMPEST_GLANCE_IMPORT_POLL_LIMIT"},{"line_number":170,"context_line":"    while (( poll_count-- \u003e 0 )) ; do"},{"line_number":171,"context_line":"        sleep $TEMPEST_GLANCE_IMPORT_POLL_INTERVAL"},{"line_number":172,"context_line":"        get_active_images image_array image_id image_id_alt"},{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"545ed8c3_7ab42194","line":171,"in_reply_to":"59f9e57e_eb146d3b","updated":"2022-05-18 12:22:09.000000000","message":"My theory is that since we already made a non-polling call at line 220 before starting this function, the function call + sleep time might be enough for us to catch the active images the first time through.  The other thing was that somehow it bothered me to have the sleep at the bottom of the loop, where we\u0027d be sleeping after the final call that didn\u0027t find anything.  (Not sure how convincing that is.)","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f8e62307f7f2b43b6ef4b482a7a28f82e23e1b13","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"},{"line_number":175,"context_line":"        fi"},{"line_number":176,"context_line":"    done"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"# configure_tempest() - Set config files, create data dirs, etc"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9d5afab5_ac283495","line":176,"updated":"2022-05-18 09:06:12.000000000","message":"Add least add a warning when the limit is exceeded instead of relying on the tempest setup to fail later?","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8512ef0beea3396e88f886b88545e39fda1a950d","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"},{"line_number":175,"context_line":"        fi"},{"line_number":176,"context_line":"    done"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"# configure_tempest() - Set config files, create data dirs, etc"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"a9642ad3_fbf7fe70","line":176,"in_reply_to":"9d5afab5_ac283495","updated":"2022-05-18 12:22:09.000000000","message":"That\u0027s a good idea, I\u0027ll add it.","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a961ce8fe58a1987faf5d0bf07b6c89b2601d876","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        if (( ${#image_array[*]} \u003e\u003d $TEMPEST_GLANCE_IMAGE_COUNT )) ; then"},{"line_number":174,"context_line":"            return"},{"line_number":175,"context_line":"        fi"},{"line_number":176,"context_line":"    done"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"# configure_tempest() - Set config files, create data dirs, etc"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"b9d98f32_1d665094","line":176,"in_reply_to":"a9642ad3_fbf7fe70","updated":"2022-05-18 12:32:27.000000000","message":"Done","commit_id":"8a7384bd1aa5767d092f31f20cd55b6875ec1080"}]}