)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9f624be3f087a151e1d10859e0810dfc577678d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"350955ae_7303f9a5","updated":"2022-06-07 16:47:48.000000000","message":"As Dan mentioned in IRC, waiting for +A to have more eyes in this approach. ","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41876bba1a1ed7d1dc22902613bcfba0d569d422","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8248bd57_54c71a82","updated":"2022-06-07 15:28:08.000000000","message":"I\u0027m fine with this, but I don\u0027t know the implications of having setuptools in u-c and what having that differ might affect.\n\nDebugging this a little yesterday, pip seems to be installing deps inside the tox vnenv to /usr/local instead of $venv/local. I\u0027m not sure why the interaction of pip and setuptools would be causing that, so I\u0027m kinda worried it will pop up again somewhere. However, the immediate problem is definitely just part of our synthetic testing setup, so maybe not a huge deal.\n\nAnyway, I\u0027ll +2 and look for someone else to +W. I assume this is worth getting wide(r) agreement on...","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"75d966425bab06406a6f14bff2503317aba7c896","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0ecfb62_a308ea04","updated":"2022-06-07 14:21:06.000000000","message":"Looking at https://review.opendev.org/c/openstack/devstack/+/797069/4/tools/fixup_stuff.sh and https://review.opendev.org/c/openstack/devstack/+/779943 maybe we want to fix this globally.","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f3ce047e59cdce76b1ce101d2a9075602370e82e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6030d537_9ecdc23c","updated":"2022-06-07 18:49:53.000000000","message":"Sounds like we\u0027re in agreement that this is good to go. Adding Martin and Matthew on this to see if they have any opinion, but I\u0027m guessing we\u0027re good. If we do this, probably makes sense to follow up with removing setuptools from g-r.","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"307a13c425cc777f2f6b0e7ab7be47207e746502","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d2af2021_3d435768","updated":"2022-06-07 16:47:19.000000000","message":"lgtm. I remember setuptools from u-c was not a best choice always and we always kept it as workaround or so.  ","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"faf533c7959acf768a8115ea220067a09c198d1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9d791d05_31240a3b","updated":"2022-06-08 11:23:14.000000000","message":"makes sense to me","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"882c710b3fdf4473420690f4273c36bebf79b12f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51bad518_56a47b1f","updated":"2022-06-07 14:06:00.000000000","message":"recheck unrelated c9s instability","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"}],"tools/install_pip.sh":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"41876bba1a1ed7d1dc22902613bcfba0d569d422","unresolved":true,"context_lines":[{"line_number":141,"context_line":"elif is_ubuntu; then"},{"line_number":142,"context_line":"    # pip on Ubuntu 20.04 is new enough, too"},{"line_number":143,"context_line":"    # drop setuptools from u-c"},{"line_number":144,"context_line":"    sed -i -e \u0027/setuptools/d\u0027 $REQUIREMENTS_DIR/upper-constraints.txt"},{"line_number":145,"context_line":"else"},{"line_number":146,"context_line":"    install_get_pip"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"606da877_be343ad5","line":144,"updated":"2022-06-07 15:28:08.000000000","message":"And python3-setuptools is required by python3-pip, so we should always have it if we have pip from the distro.","commit_id":"e6e7100e853f2ba06bf2157fd87ae948faba1d1f"}]}
